61215 2011-05-20 14:00:24 -0700 Default min DOM Timer interval is not set soon enough for first page to pick it up in WK2 2011-05-20 14:40:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mdelaney7 mdelaney7 jberlin sfalken oldest_to_newest 407312 0 mdelaney7 2011-05-20 14:00:24 -0700 The min DOM timer interval is set just after the first page is created. When pages are created, they use the currently set timer interval. Thus, we should be setting the min DOM timer interval sooner - ideally, just before page creation. As a follow up, this DOM timer setting code could be cleaned up better very soon since it appears that all (or at least most) of the ports are now agreeing upon default values. I've filed this bug for that followup cleanup: https://bugs.webkit.org/show_bug.cgi?id=61214 407314 1 94267 mdelaney7 2011-05-20 14:02:26 -0700 Created attachment 94267 Patch 407315 2 94267 darin 2011-05-20 14:04:44 -0700 Comment on attachment 94267 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94267&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:210 > + Settings::setDefaultMinDOMTimerInterval(0.004); Moving this early seems good, but it’s a bit strange to tuck this in between setting up the page clients and calling new Page, since the pageClients structure is really just an argument to the Page constructor. I suggest calling this even before the definition of the pageClients local variable, right after the assert. 407316 3 94268 mdelaney7 2011-05-20 14:07:25 -0700 Created attachment 94268 Patch 407331 4 mdelaney7 2011-05-20 14:40:42 -0700 Committed r86985: <http://trac.webkit.org/changeset/86985> 94267 2011-05-20 14:02:26 -0700 2011-05-20 14:07:22 -0700 Patch bug-61215-20110520140224.patch text/plain 1565 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2OTc5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjAgIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEZWZhdWx0IG1pbiBET00gVGltZXIgaW50ZXJ2YWwgaXMg bm90IHNldCBzb29uIGVub3VnaCBmb3IgZmlyc3QgcGFnZSB0byBwaWNrIGl0IHVwIGluIFdLMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyMTUgCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6IFNpbXBseSBtb3Zpbmcg dGhlIERPTSBtaW4gdGltZXIgaW50ZXJ2YWwgc2V0dGluZyB0byBiZWZvcmUgdGhlIGZpcnN0IHBh Z2UgY3JlYXRpb24uCisKIDIwMTEtMDUtMjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDg2 ODgxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMDcsNiArMjA3LDcgQEAgV2ViUGFnZTo6V2ViUGFnZSh1aW50NjRf dCBwYWdlSUQsIGNvbnN0IAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgcGFnZUNsaWVudHMu aW5zcGVjdG9yQ2xpZW50ID0gbmV3IFdlYkluc3BlY3RvckNsaWVudCh0aGlzKTsKICNlbmRpZgor ICAgIFNldHRpbmdzOjpzZXREZWZhdWx0TWluRE9NVGltZXJJbnRlcnZhbCgwLjAwNCk7CiAgICAg bV9wYWdlID0gYWRvcHRQdHIobmV3IFBhZ2UocGFnZUNsaWVudHMpKTsKIAogICAgIC8vIFF0IGRv ZXMgbm90IHlldCBjYWxsIHNldElzSW5XaW5kb3cuIFVudGlsIGl0IGRvZXMsIGp1c3QgbGVhdmUK QEAgLTIyMyw3ICsyMjQsNiBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwgY29u c3QgCiAgICAgbV9wYWdlLT5zZXRHcm91cE5hbWUobV9wYWdlR3JvdXAtPmlkZW50aWZpZXIoKSk7 CiAKICAgICBwbGF0Zm9ybUluaXRpYWxpemUoKTsKLSAgICBTZXR0aW5nczo6c2V0RGVmYXVsdE1p bkRPTVRpbWVySW50ZXJ2YWwoMC4wMDQpOwogCiAgICAgbV9kcmF3aW5nQXJlYSA9IERyYXdpbmdB cmVhOjpjcmVhdGUodGhpcywgcGFyYW1ldGVycyk7CiAgICAgbV9tYWluRnJhbWUgPSBXZWJGcmFt ZTo6Y3JlYXRlTWFpbkZyYW1lKHRoaXMpOwo= 94268 2011-05-20 14:07:25 -0700 2011-05-20 14:36:34 -0700 Patch bug-61215-20110520140722.patch text/plain 1640 mdelaney7 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2OTc5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjAgIE1hdHRoZXcg RGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEZWZhdWx0IG1pbiBET00gVGltZXIgaW50ZXJ2YWwgaXMg bm90IHNldCBzb29uIGVub3VnaCBmb3IgZmlyc3QgcGFnZSB0byBwaWNrIGl0IHVwIGluIFdLMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyMTUgCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6IFNpbXBseSBtb3Zpbmcg dGhlIERPTSBtaW4gdGltZXIgaW50ZXJ2YWwgc2V0dGluZyB0byBiZWZvcmUgdGhlIGZpcnN0IHBh Z2UgY3JlYXRpb24uCisKIDIwMTEtMDUtMjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDg2 ODgxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xOTQsNiArMTk0LDkgQEAgV2ViUGFnZTo6V2ViUGFnZSh1aW50NjRf dCBwYWdlSUQsIGNvbnN0IAogI2VuZGlmCiB7CiAgICAgQVNTRVJUKG1fcGFnZUlEKTsKKyAgICAv LyBGSVhNRTogVGhpcyBpcyBhIG5vbi1pZGVhbCBsb2NhdGlvbiBmb3IgdGhpcyBTZXR0aW5nIGFu ZAorICAgIC8vIDRtcyBzaG91bGQgYmUgYWRvcHRlZCBwcm9qZWN0LXdpZGUgbm93LCBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyMTQKKyAgICBTZXR0aW5nczo6c2V0 RGVmYXVsdE1pbkRPTVRpbWVySW50ZXJ2YWwoMC4wMDQpOwogCiAgICAgUGFnZTo6UGFnZUNsaWVu dHMgcGFnZUNsaWVudHM7CiAgICAgcGFnZUNsaWVudHMuY2hyb21lQ2xpZW50ID0gbmV3IFdlYkNo cm9tZUNsaWVudCh0aGlzKTsKQEAgLTIyMyw3ICsyMjYsNiBAQCBXZWJQYWdlOjpXZWJQYWdlKHVp bnQ2NF90IHBhZ2VJRCwgY29uc3QgCiAgICAgbV9wYWdlLT5zZXRHcm91cE5hbWUobV9wYWdlR3Jv dXAtPmlkZW50aWZpZXIoKSk7CiAKICAgICBwbGF0Zm9ybUluaXRpYWxpemUoKTsKLSAgICBTZXR0 aW5nczo6c2V0RGVmYXVsdE1pbkRPTVRpbWVySW50ZXJ2YWwoMC4wMDQpOwogCiAgICAgbV9kcmF3 aW5nQXJlYSA9IERyYXdpbmdBcmVhOjpjcmVhdGUodGhpcywgcGFyYW1ldGVycyk7CiAgICAgbV9t YWluRnJhbWUgPSBXZWJGcmFtZTo6Y3JlYXRlTWFpbkZyYW1lKHRoaXMpOwo=