61203 2011-05-20 11:27:03 -0700 Horrendous bug in callOnMainThreadAndWait 2011-06-18 11:55:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ademar ap darin levin oldest_to_newest 407224 0 beidson 2011-05-20 11:27:03 -0700 Horrendous bug in callOnMainThreadAndWait When the main thread is done with the invocation and decides to signal the waiting thread, it doesn't reacquire the mutex first. Ouch! In radar as <rdar://problem/9472883> 407226 1 94247 beidson 2011-05-20 11:30:14 -0700 Created attachment 94247 Patch v1 - Acquire the mutex before signaling 407242 2 beidson 2011-05-20 11:46:28 -0700 Landed in r86972 407970 3 ademar 2011-05-23 07:47:31 -0700 Revision r86972 cherry-picked into qtwebkit-2.2 with commit 1aba524 <http://gitorious.org/webkit/qtwebkit/commit/1aba524> 94247 2011-05-20 11:30:14 -0700 2011-05-20 11:42:54 -0700 Patch v1 - Acquire the mutex before signaling patch.txt text/plain 1492 beidson SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODY5NjkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDUtMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85 NDcyODgzPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMjAz CisgICAgICAgIEhvcnJlbmRvdXMgYnVnIGluIGNhbGxPbk1haW5UaHJlYWRBbmRXYWl0CisKKyAg ICAgICAgKiB3dGYvTWFpblRocmVhZC5jcHA6CisgICAgICAgIChXVEY6OmRpc3BhdGNoRnVuY3Rp b25zRnJvbU1haW5UaHJlYWQpOiBCZWZvcmUgc2lnbmFsaW5nIHRoZSBiYWNrZ3JvdW5kIHRocmVh ZCB3aXRoIHRoZQorICAgICAgICAgIHN5bmNGbGFnIGNvbmRpdGlvbiwgcmVhY3F1aXJlIHRoZSBt dXRleCBmaXJzdC4KKwogMjAxMS0wNS0yMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL01haW5UaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvTWFpblRocmVhZC5jcHAJKHJldmlzaW9uIDg2OTU1KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9NYWluVGhyZWFkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUzLDgg KzE1MywxMCBAQCB2b2lkIGRpc3BhdGNoRnVuY3Rpb25zRnJvbU1haW5UaHJlYWQoKQogICAgICAg ICB9CiAKICAgICAgICAgaW52b2NhdGlvbi5mdW5jdGlvbihpbnZvY2F0aW9uLmNvbnRleHQpOwot ICAgICAgICBpZiAoaW52b2NhdGlvbi5zeW5jRmxhZykKKyAgICAgICAgaWYgKGludm9jYXRpb24u c3luY0ZsYWcpIHsKKyAgICAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtYWluVGhyZWFkRnVu Y3Rpb25RdWV1ZU11dGV4KCkpOwogICAgICAgICAgICAgaW52b2NhdGlvbi5zeW5jRmxhZy0+c2ln bmFsKCk7CisgICAgICAgIH0KIAogICAgICAgICAvLyBJZiB3ZSBhcmUgcnVubmluZyBhY2N1bXVs YXRlZCBmdW5jdGlvbnMgZm9yIHRvbyBsb25nIHNvIFVJIG1heSBiZWNvbWUgdW5yZXNwb25zaXZl LCB3ZSBuZWVkIHRvCiAgICAgICAgIC8vIHlpZWxkIHNvIHRoZSB1c2VyIGlucHV0IGNhbiBiZSBw cm9jZXNzZWQuIE90aGVyd2lzZSB1c2VyIG1heSBub3QgYmUgYWJsZSB0byBldmVuIGNsb3NlIHRo ZSB3aW5kb3cuCg==