61187 2011-05-20 06:33:41 -0700 [Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build 2011-06-21 09:00:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 pvarga webkit-unassigned abecsi hausmann jedrzej.nowacki webkit.review.bot oldest_to_newest 407039 0 pvarga 2011-05-20 06:33:41 -0700 This functionality has been disabled in QtWebkit-V8 build because qtscript-staging's shipped version of V8's API doesn't provide the Context::AllowCodeGenerationFromStrings() method yet. It is in V8 since http://code.google.com/p/v8/source/detail?r=7753 This functionality will be enabled at the next update of the qtscript-staging's V8 fork. 424456 1 97989 pvarga 2011-06-21 07:58:54 -0700 Created attachment 97989 proposed patch The QtScript's V8 is up-to-date now. We can enable this functionality. 424462 2 97989 kling 2011-06-21 08:18:12 -0700 Comment on attachment 97989 proposed patch rs=me 424484 3 97989 webkit.review.bot 2011-06-21 09:00:18 -0700 Comment on attachment 97989 proposed patch Clearing flags on attachment: 97989 Committed r89359: <http://trac.webkit.org/changeset/89359> 424485 4 webkit.review.bot 2011-06-21 09:00:23 -0700 All reviewed patches have been landed. Closing bug. 97989 2011-06-21 07:58:54 -0700 2011-06-21 09:00:18 -0700 proposed patch 0001-reenable-disableEval.patch text/plain 1928 pvarga RnJvbSBhODM4NTIwMzkxYTI0ZjBiYzhlM2I0ODk3ODljYmY1ZGI1NzYzM2I2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogVHVlLCAyMSBKdW4gMjAxMSAxNjo1NjowMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHJl ZW5hYmxlIGRpc2FibGVFdmFsCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIHwgICAgNiAtLS0tLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjZjMDY4 Yi4uMjNiZjI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA2LTIxICBQZXRl ciBWYXJnYSAgPHB2YXJnYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bVjhdIEVuYWJsZSBTY3JpcHRDb250cm9sbGVyOjpk aXNhYmxlRXZhbCBmdW5jdGlvbmFsaXR5IGluIFF0V2Via2l0LVY4IGJ1aWxkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTE4NworCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmRpc2FibGVFdmFs KToKKwogMjAxMS0wNi0yMSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAppbmRleCAyNjUyYTJjLi5jN2ZlYmZi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNw cApAQCAtMjYyLDExICsyNjIsNiBAQCBib29sIFNjcmlwdENvbnRyb2xsZXI6OmhhdmVJbnRlcnBy ZXRlcigpIGNvbnN0CiAKIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6ZGlzYWJsZUV2YWwoKQogewot I2lmICFQTEFURk9STShRVCkKLS8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjAzODQKLS8vICAgICAgICBUaGlzIGZ1bmN0aW9uYWxpdHkgaXMgZGlzYWJs ZWQgaW4gUXRXZWJraXQgVjggYnVpbGQgYmVjYXVzZSBpdCBpc24ndAotLy8gICAgICAgIHN1cHBv cnRlZCBieSB0aGUgcXRzY3JpcHQtc3RhZ2luZydzIHNoaXBwZWQgdmVyc2lvbiBvZiBWOCB5ZXQu Ci0KICAgICBtX3Byb3h5LT53aW5kb3dTaGVsbCgpLT5pbml0Q29udGV4dElmTmVlZGVkKCk7CiAK ICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CkBAIC0yNzUsNyArMjcwLDYgQEAgdm9p ZCBTY3JpcHRDb250cm9sbGVyOjpkaXNhYmxlRXZhbCgpCiAgICAgICAgIHJldHVybjsKIAogICAg IHY4Q29udGV4dC0+QWxsb3dDb2RlR2VuZXJhdGlvbkZyb21TdHJpbmdzKGZhbHNlKTsKLSNlbmRp ZgogfQogCiBQYXNzU2NyaXB0SW5zdGFuY2UgU2NyaXB0Q29udHJvbGxlcjo6Y3JlYXRlU2NyaXB0 SW5zdGFuY2VGb3JXaWRnZXQoV2lkZ2V0KiB3aWRnZXQpCi0tIAoxLjcuNS4zCgo=