61185 2011-05-20 05:34:19 -0700 Web Inspector: [Chromium] Searching in a bottom-up view of a large CPU profile overloads system and finally stops execution of any Inspector code 2011-05-20 06:51:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://v8.googlecode.com/svn/data/benchmarks/current/run.html P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 407008 0 mnaganov 2011-05-20 05:34:19 -0700 From http://code.google.com/p/chromium/issues/detail?id=28864 What steps will reproduce the problem? 1. Gather a CPU profile from V8 benchmarks site. 2. Try to search in bottom-up view. Search hogs all time of a CPU core and finally stops with no results. DevTools stops working after that. Analysis shows that this is due to V8's heap got exhausted by trying to build a bottom-up tree from a top down. This problem originates from the fact that in WebKit Inspector the bottom up tree is built dynamically from the top down tree. Thus, to perform a search in a bottom up tree, it first needs to be fully built, which can grow up V8's heap to its limit. JSC doesn't impose heap size limit, so searching in the same tree in WebKit just eats up a enormous amount of memory, but finishes happily. It seems that an approach to maintaining calls tree needs to be reworked in WebKit Inspector. 407021 1 94204 mnaganov 2011-05-20 06:10:13 -0700 Created attachment 94204 patch 407051 2 94204 yurys 2011-05-20 06:39:47 -0700 Comment on attachment 94204 patch View in context: https://bugs.webkit.org/attachment.cgi?id=94204&action=review > Source/WebCore/bindings/js/ScriptProfile.cpp:71 > + // FIXME: implement building bottom-up profiles in C++ code, Please file a bug against JSC and put its number next to the FIXME. 407054 3 mnaganov 2011-05-20 06:47:39 -0700 Manually committed: http://trac.webkit.org/changeset/86947 2011-05-20 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM, instead of building it on Inspector's side. https://bugs.webkit.org/show_bug.cgi?id=61185 * bindings/js/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead): * bindings/js/ScriptProfile.h: * bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::bottomUpHead): (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead): * bindings/v8/ScriptProfile.h: * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile): * inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree): 407058 4 mnaganov 2011-05-20 06:51:39 -0700 (In reply to comment #2) > (From update of attachment 94204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94204&action=review > > > Source/WebCore/bindings/js/ScriptProfile.cpp:71 > > + // FIXME: implement building bottom-up profiles in C++ code, > > Please file a bug against JSC and put its number next to the FIXME. Oh, sorry, I've already had an issue created: https://bugs.webkit.org/show_bug.cgi?id=61184 But I forgot to put it into fixme. 94204 2011-05-20 06:10:13 -0700 2011-05-20 06:39:47 -0700 patch patch-61185 text/plain 6255 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZDZkMTg2Li40NDVjMDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDUtMjAgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIFVzZSBib3R0b20tdXAgQ1BVIHByb2ZpbGUgdHJlZSBidWlsdCBp biBWTSwKKyAgICAgICAgaW5zdGVhZCBvZiBidWlsZGluZyBpdCBvbiBJbnNwZWN0b3IncyBzaWRl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjExODUK KworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2NyaXB0UHJvZmlsZTo6Ym90dG9tVXBIZWFkKToKKyAgICAgICAgKFdlYkNvcmU6OlNj cmlwdFByb2ZpbGU6OmJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yQm90dG9tVXBIZWFkKToKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRQcm9maWxlLmg6CisgICAgICAgICogYmluZGluZ3Mvdjgv U2NyaXB0UHJvZmlsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRQcm9maWxlOjpib3R0 b21VcEhlYWQpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0UHJvZmlsZTo6YnVpbGRJbnNwZWN0 b3JPYmplY3RGb3JCb3R0b21VcEhlYWQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdFBy b2ZpbGUuaDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JQcm9maWxlckFnZW50OjpnZXRQcm9maWxlKToK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVWaWV3LmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3LnByb3RvdHlwZS5nZXQgYm90dG9tVXBQcm9maWxl RGF0YUdyaWRUcmVlKToKKwogMjAxMS0wNS0yMCAgUGlyb3NrYSBBbmRyw6FzICA8UGlyb3NrYS5B bmRyYXNAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFpp bW1lcm1hbm4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRQ cm9maWxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuY3Bw CmluZGV4IDg0NDUxZmIuLjZhMzQ5NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdFByb2ZpbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1NjcmlwdFByb2ZpbGUuY3BwCkBAIC02Niw2ICs2NiwxMyBAQCBTY3JpcHRQcm9maWxlTm9kZSog U2NyaXB0UHJvZmlsZTo6aGVhZCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fcHJvZmlsZS0+aGVhZCgp OwogfQogCitQYXNzUmVmUHRyPFNjcmlwdFByb2ZpbGVOb2RlPiBTY3JpcHRQcm9maWxlOjpib3R0 b21VcEhlYWQoKSBjb25zdAoreworICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQgYnVpbGRpbmcgYm90 dG9tLXVwIHByb2ZpbGVzIGluIEMrKyBjb2RlLAorICAgIC8vIGJ1dCBjb25zaWRlciBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ2MDQKKyAgICByZXR1cm4gMDsKK30K KwogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiBzdGF0aWMgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmpl Y3Q+IGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yKGNvbnN0IEpTQzo6UHJvZmlsZU5vZGUqIG5vZGUp CiB7CkBAIC05NSw2ICsxMDIsMTEgQEAgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IFNjcmlw dFByb2ZpbGU6OmJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9ySGVhZCgpIGNvbnN0CiB7CiAgICAgcmV0 dXJuIGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yKG1fcHJvZmlsZS0+aGVhZCgpKTsKIH0KKworUGFz c1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IFNjcmlwdFByb2ZpbGU6OmJ1aWxkSW5zcGVjdG9yT2Jq ZWN0Rm9yQm90dG9tVXBIZWFkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gMDsKK30KICNlbmRpZgog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRQcm9maWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3Jp cHRQcm9maWxlLmgKaW5kZXggMGIzOGVkYy4uZDcyNWFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvU2NyaXB0UHJvZmlsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdFByb2ZpbGUuaApAQCAtNTAsOSArNTAsMTEgQEAgcHVibGljOgogICAg IFN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAgIHVuc2lnbmVkIGludCB1aWQoKSBjb25zdDsKICAg ICBTY3JpcHRQcm9maWxlTm9kZSogaGVhZCgpIGNvbnN0OworICAgIFBhc3NSZWZQdHI8U2NyaXB0 UHJvZmlsZU5vZGU+IGJvdHRvbVVwSGVhZCgpIGNvbnN0OwogCiAjaWYgRU5BQkxFKElOU1BFQ1RP UikKICAgICBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gYnVpbGRJbnNwZWN0b3JPYmplY3RG b3JIZWFkKCkgY29uc3Q7CisgICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGJ1aWxkSW5z cGVjdG9yT2JqZWN0Rm9yQm90dG9tVXBIZWFkKCkgY29uc3Q7CiAjZW5kaWYKIAogcHJpdmF0ZToK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAKaW5kZXggMmM5 ZjBmNS4uODY2Y2JhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2Ny aXB0UHJvZmlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJv ZmlsZS5jcHAKQEAgLTYwLDYgKzYwLDExIEBAIFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZU5vZGU+ IFNjcmlwdFByb2ZpbGU6OmhlYWQoKSBjb25zdAogICAgIHJldHVybiBTY3JpcHRQcm9maWxlTm9k ZTo6Y3JlYXRlKG1fcHJvZmlsZS0+R2V0VG9wRG93blJvb3QoKSk7CiB9CiAKK1Bhc3NSZWZQdHI8 U2NyaXB0UHJvZmlsZU5vZGU+IFNjcmlwdFByb2ZpbGU6OmJvdHRvbVVwSGVhZCgpIGNvbnN0Cit7 CisgICAgcmV0dXJuIFNjcmlwdFByb2ZpbGVOb2RlOjpjcmVhdGUobV9wcm9maWxlLT5HZXRCb3R0 b21VcFJvb3QoKSk7Cit9CisKIHN0YXRpYyBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gYnVp bGRJbnNwZWN0b3JPYmplY3RGb3IoY29uc3Qgdjg6OkNwdVByb2ZpbGVOb2RlKiBub2RlKQogewog ICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKQEAgLTg4LDQgKzkzLDkgQEAgUGFzc1Jl ZlB0cjxJbnNwZWN0b3JPYmplY3Q+IFNjcmlwdFByb2ZpbGU6OmJ1aWxkSW5zcGVjdG9yT2JqZWN0 Rm9ySGVhZCgpIGNvbnN0CiAgICAgcmV0dXJuIGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yKG1fcHJv ZmlsZS0+R2V0VG9wRG93blJvb3QoKSk7CiB9CiAKK1Bhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0 PiBTY3JpcHRQcm9maWxlOjpidWlsZEluc3BlY3Rvck9iamVjdEZvckJvdHRvbVVwSGVhZCgpIGNv bnN0Cit7CisgICAgcmV0dXJuIGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yKG1fcHJvZmlsZS0+R2V0 Qm90dG9tVXBSb290KCkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmggYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmgKaW5kZXggZDgxOTZhNC4uYWVkNDViNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaApAQCAtNTMsOCAr NTMsMTAgQEAgcHVibGljOgogICAgIFN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAgIHVuc2lnbmVk IGludCB1aWQoKSBjb25zdDsKICAgICBQYXNzUmVmUHRyPFNjcmlwdFByb2ZpbGVOb2RlPiBoZWFk KCkgY29uc3Q7CisgICAgUGFzc1JlZlB0cjxTY3JpcHRQcm9maWxlTm9kZT4gYm90dG9tVXBIZWFk KCkgY29uc3Q7CiAKICAgICBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gYnVpbGRJbnNwZWN0 b3JPYmplY3RGb3JIZWFkKCkgY29uc3Q7CisgICAgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+ IGJ1aWxkSW5zcGVjdG9yT2JqZWN0Rm9yQm90dG9tVXBIZWFkKCkgY29uc3Q7CiAKIHByaXZhdGU6 CiAgICAgU2NyaXB0UHJvZmlsZShjb25zdCB2ODo6Q3B1UHJvZmlsZSogcHJvZmlsZSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcApp bmRleCA4ZTY1NGEzLi4zMjkzYjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwCkBAIC0yMTIsNiArMjEyLDggQEAgdm9pZCBJ bnNwZWN0b3JQcm9maWxlckFnZW50OjpnZXRQcm9maWxlKEVycm9yU3RyaW5nKiwgY29uc3QgU3Ry aW5nJiB0eXBlLCB1bnNpZ24KICAgICAgICAgaWYgKGl0ICE9IG1fcHJvZmlsZXMuZW5kKCkpIHsK ICAgICAgICAgICAgICpwcm9maWxlT2JqZWN0ID0gY3JlYXRlUHJvZmlsZUhlYWRlcigqaXQtPnNl Y29uZCk7CiAgICAgICAgICAgICAoKnByb2ZpbGVPYmplY3QpLT5zZXRPYmplY3QoImhlYWQiLCBp dC0+c2Vjb25kLT5idWlsZEluc3BlY3Rvck9iamVjdEZvckhlYWQoKSk7CisgICAgICAgICAgICBp ZiAoaXQtPnNlY29uZC0+Ym90dG9tVXBIZWFkKCkpCisgICAgICAgICAgICAgICAgKCpwcm9maWxl T2JqZWN0KS0+c2V0T2JqZWN0KCJib3R0b21VcEhlYWQiLCBpdC0+c2Vjb25kLT5idWlsZEluc3Bl Y3Rvck9iamVjdEZvckJvdHRvbVVwSGVhZCgpKTsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAo dHlwZSA9PSBIZWFwUHJvZmlsZVR5cGUpIHsKICAgICAgICAgSGVhcFNuYXBzaG90c01hcDo6aXRl cmF0b3IgaXQgPSBtX3NuYXBzaG90cy5maW5kKHVpZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlVmlldy5qcwppbmRleCBhOGM1ZmY0Li5lZjNlMmI2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVW aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZVZp ZXcuanMKQEAgLTExNyw4ICsxMTcsMTIgQEAgV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3LnBy b3RvdHlwZSA9IHsKIAogICAgIGdldCBib3R0b21VcFByb2ZpbGVEYXRhR3JpZFRyZWUoKQogICAg IHsKLSAgICAgICAgaWYgKCF0aGlzLl9ib3R0b21VcFByb2ZpbGVEYXRhR3JpZFRyZWUpCi0gICAg ICAgICAgICB0aGlzLl9ib3R0b21VcFByb2ZpbGVEYXRhR3JpZFRyZWUgPSBuZXcgV2ViSW5zcGVj dG9yLkJvdHRvbVVwUHJvZmlsZURhdGFHcmlkVHJlZSh0aGlzLCB0aGlzLnByb2ZpbGUuaGVhZCk7 CisgICAgICAgIGlmICghdGhpcy5fYm90dG9tVXBQcm9maWxlRGF0YUdyaWRUcmVlKSB7CisgICAg ICAgICAgICBpZiAodGhpcy5wcm9maWxlLmJvdHRvbVVwSGVhZCkKKyAgICAgICAgICAgICAgICB0 aGlzLl9ib3R0b21VcFByb2ZpbGVEYXRhR3JpZFRyZWUgPSBuZXcgV2ViSW5zcGVjdG9yLlRvcERv d25Qcm9maWxlRGF0YUdyaWRUcmVlKHRoaXMsIHRoaXMucHJvZmlsZS5ib3R0b21VcEhlYWQpOwor ICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHRoaXMuX2JvdHRvbVVwUHJvZmlsZURh dGFHcmlkVHJlZSA9IG5ldyBXZWJJbnNwZWN0b3IuQm90dG9tVXBQcm9maWxlRGF0YUdyaWRUcmVl KHRoaXMsIHRoaXMucHJvZmlsZS5oZWFkKTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm4gdGhp cy5fYm90dG9tVXBQcm9maWxlRGF0YUdyaWRUcmVlOwogICAgIH0sCiAK