6118 2005-12-17 03:21:58 -0800 Investigate not using the frameset charset as a default for frames 2005-12-23 00:30:26 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED http://images.google.com/imgres?imgurl=http://www.galicianos.com/media/luar%2520na%2520lubre-cabo%2520do%2520mundo.jpg&imgrefurl=http://www.galicianos.com/folk.html&h=260&w=260&sz=23&tbnid=e-QF8j69jqcJ:&tbnh=107&tbnw=107&hl=en&start=9&prev=/images%3Fq%3DLuar%2BNa%2BLubre%2BCabo%2BDo%2BMundo%2B%26hl%3Den%26lr%3D%26c2coff%3D1%26sa%3DG P2 Normal --- 1 ap ap oldest_to_newest 26069 0 ap 2005-12-17 03:21:58 -0800 This site reports UTF-8 for the main document, but uses Latin1 in all the frames without specifying it. Safari defaults to UTF-8, Firefox doesn't. For me, this makes little difference (I have windows-1251 set as a default in both browsers), but for people with Latin-1 default in Firefox, the page looks OK. 26177 1 ap 2005-12-19 05:29:36 -0800 Using the parent frame encoding as a default is intentional, see rdar://3100151 (subframes without explicit charset settings should inherit from parent, not use default). I cannot see the bug contents, thus have no idea about the reason, and I'm going to propose a patch that reverts this change :) 26178 2 5150 ap 2005-12-19 05:42:32 -0800 Created attachment 5150 proposed patch 26179 3 5150 ap 2005-12-19 05:46:11 -0800 Comment on attachment 5150 proposed patch Do not use the parent frame encoding as a default for sub-frames (revert rdar://3100151). Fixes displaying of Google Images search results. 26183 4 darin 2005-12-19 08:53:43 -0800 Here's the original bug report: Text from reporter: "When subframes don't have the charset, it should inherit the setting from the parent page. The HTML spec doesn't say anything about this implicit inheritance, but other browsers including IE, Mozilla, and OmniWeb do it. "* STEPS TO REPRODUCE: "0) Change your text encoding setting to 'Western (ISO Latin 1)' in Pref panel's Display pane. "1) Go to http://www.2ch.net/2ch.html "RESULT: the left side frame is garbled." Then later: "Correction. "It's only Mozilla that behaves this way. IE and OmniWeb don't propagate the setting." So we need to test this Japanese site with the patched behavior. If Mozilla does continue to work with this site, then we have to figure out why. 26185 5 ap 2005-12-19 09:14:03 -0800 Currently, this site provides a correct charset in HTTP headers, so it should work with any browser (tested WebKit with and without this patch, Firefox 1.5 and Opera 8.5). Assuming the analysis in rdar://3100151 was correct, I suppose that Mozilla/Firefox have been brought in line with IE since then, so reverting its fix should be a right and safe thing to do. 26186 6 darin 2005-12-19 09:42:09 -0800 Later a comment from the International "bug review" group at Apple: "This is a common situation in, eg, Japanese web pages. It would seem that propagating to at least unlabeled frames would be the right thing to do." 26203 7 darin 2005-12-19 12:50:09 -0800 OK, here's our theory. At the time this bug was written, Mozilla did propagate the encoding to subframes. Since then, it was fixed to behave the same way other browsers do. And the http://www.2ch.net/2ch.html website was fixed too. So now WebKit is left as the odd one out, with a rule that Mozilla once had in the past but no longer has. So we think we should take this patch. 26204 8 5150 darin 2005-12-19 12:50:54 -0800 Comment on attachment 5150 proposed patch Test should probably use "about:blank" instead of "about:", but "about:" will work. r=me 5150 2005-12-19 05:42:32 -0800 2005-12-19 12:50:54 -0800 proposed patch NoParentFrameEncodingPatch.txt text/plain 5238 ap SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvZnJhbWUtZGVmYXVsdC1lbmMtZXhwZWN0 ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpkaWZmIC1OcHUgTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGlu Zy9mcmFtZS1kZWZhdWx0LWVuYy1leHBlY3RlZC5jaGVja3N1bQotLS0gTGF5b3V0VGVzdHMvZmFz dC9lbmNvZGluZy9mcmFtZS1kZWZhdWx0LWVuYy1leHBlY3RlZC5jaGVja3N1bQkxIEphbiAxOTcw IDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2ZyYW1lLWRlZmF1 bHQtZW5jLWV4cGVjdGVkLmNoZWNrc3VtCTE5IERlYyAyMDA1IDEzOjQwOjA4IC0wMDAwCkBAIC0w LDAgKzEgQEAKK2VhMzBiN2IyYjk0ZTVmZmIyYzRiZDRlYTYxYzc1YmVhClwgTm8gbmV3bGluZSBh dCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9mcmFtZS1kZWZh dWx0LWVuYy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpkaWZmIC1OcHUgTGF5b3V0VGVzdHMvZmFz dC9lbmNvZGluZy9mcmFtZS1kZWZhdWx0LWVuYy1leHBlY3RlZC50eHQKLS0tIExheW91dFRlc3Rz L2Zhc3QvZW5jb2RpbmcvZnJhbWUtZGVmYXVsdC1lbmMtZXhwZWN0ZWQudHh0CTEgSmFuIDE5NzAg MDA6MDA6MDAgLTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvZnJhbWUtZGVmYXVs dC1lbmMtZXhwZWN0ZWQudHh0CTE5IERlYyAyMDA1IDEzOjM5OjU0IC0wMDAwCkBAIC0wLDAgKzEs MjMgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJDYW52YXMgYXQgKDAs MCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxv Y2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckZyYW1lU2V0IHtGUkFN RVNFVH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgICBSZW5kZXJGcmFtZSB7RlJBTUV9IGF0 ICgwLDApIHNpemUgODAweDAKKyAgICAgICAgbGF5ZXIgYXQgKDAsMCkgc2l6ZSA3OTh4MAorICAg ICAgICAgIFJlbmRlckNhbnZhcyBhdCAoMCwwKSBzaXplIDc5OHgtNAorICAgICAgICBsYXllciBh dCAoMCwwKSBzaXplIDc5OHgwCisgICAgICAgICAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDAp IHNpemUgNzk4eDAKKyAgICAgICAgICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICgwLDApIHNpemUg Nzk4eDAKKyAgICAgIFJlbmRlckZyYW1lIHtGUkFNRX0gYXQgKDAsNCkgc2l6ZSA4MDB4NTk2Cisg ICAgICAgIGxheWVyIGF0ICgwLDApIHNpemUgNzk4eDU5MgorICAgICAgICAgIFJlbmRlckNhbnZh cyBhdCAoMCwwKSBzaXplIDc5OHg1OTIKKyAgICAgICAgbGF5ZXIgYXQgKDAsMCkgc2l6ZSA3OTh4 NTkyCisgICAgICAgICAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgNzk4eDU5Mgor ICAgICAgICAgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODJ4NTY4CisgICAg ICAgICAgICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgwLDApIHNpemUgNzgyeDE4Cisg ICAgICAgICAgICAgICAgUmVuZGVyVGV4dCB7VEVYVH0gYXQgKDAsMCkgc2l6ZSA3NngxOAorICAg ICAgICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNzY6ICJJU08tODg1OS0xIgor ICAgICAgICAgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMzQpIHNpemUgNzgyeDE4CisgICAg ICAgICAgICAgICAgUmVuZGVyVGV4dCB7VEVYVH0gYXQgKDAsMCkgc2l6ZSA1MTV4MTgKKyAgICAg ICAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDUxNTogIlRoZSBhYm92ZSBsaW5l IHNob3VsZCBiZSB5b3VyIGJyb3dzZXIncyBkZWZhdWx0IGVuY29kaW5nLCBhbmQgbm90IHgtbWFj LWN5cmlsbGljLiIKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvZnJhbWUtZGVmYXVs dC1lbmMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5n L2ZyYW1lLWRlZmF1bHQtZW5jLmh0bWwKLS0tIExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvZnJh bWUtZGVmYXVsdC1lbmMuaHRtbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2VuY29kaW5nL2ZyYW1lLWRlZmF1bHQtZW5jLmh0bWwJMTkgRGVjIDIwMDUgMTM6 MzQ6NTQgLTAwMDAKQEAgLTAsMCArMSwxMCBAQAorPGh0bWw+Cis8aGVhZD4KKzxtZXRhIGh0dHAt ZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXgtbWFjLWN5 cmlsbGljIj4KKzx0aXRsZT5GcmFtZXMgYW5kIGVuY29kaW5nczwvdGl0bGU+Cis8L2hlYWQ+Cis8 ZnJhbWVzZXQgcm93cz0iMCwqIj4KKwk8ZnJhbWUgc3JjPSJhYm91dDoiIHNjcm9sbGluZz1ubyBt YXJnaW53aWR0aD0wIG1hcmdpbmhlaWdodD0wPgorCTxmcmFtZSBzcmM9InJlc291cmNlcy9mcmFt ZS1kZWZhdWx0LWVuYy1mcmFtZS5odG1sIj4KKzwvZnJhbWVzZXQ+Cis8L2h0bWw+CkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2VuY29kaW5nL3Jlc291cmNlcy9mcmFtZS1kZWZhdWx0 LWVuYy1mcmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91dFRlc3RzL2Zhc3QvZW5j b2RpbmcvZW5jb2RpbmcvcmVzb3VyY2VzL2ZyYW1lLWRlZmF1bHQtZW5jLWZyYW1lLmh0bWwKLS0t IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvZW5jb2RpbmcvcmVzb3VyY2VzL2ZyYW1lLWRlZmF1 bHQtZW5jLWZyYW1lLmh0bWwJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAorKysgTGF5b3V0VGVz dHMvZmFzdC9lbmNvZGluZy9lbmNvZGluZy9yZXNvdXJjZXMvZnJhbWUtZGVmYXVsdC1lbmMtZnJh bWUuaHRtbAkxOSBEZWMgMjAwNSAxMzozOTo0NCAtMDAwMApAQCAtMCwwICsxLDI0IEBACis8aHRt bD4KKzxoZWFkPgorPHRpdGxlPkZyYW1lPC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlw dD4KKy8vIE90aGVyd2lzZSwgRHVtcFJlbmRlclRyZWUgcHJpbnRzIGVtcHR5IG91dHB1dCwgZm9y IHdoYXRldmVyIHJlYXNvbi4KKy8vICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor Ly8gICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK2NocyA9IGRvY3Vt ZW50LmlucHV0RW5jb2Rpbmc7CitpZiAoIWNocykKKwljaHMgPSBkb2N1bWVudC5jaGFyc2V0Owor aWYgKCFjaHMpCisJY2hzID0gZG9jdW1lbnQuY2hhcmFjdGVyU2V0OworCitkb2N1bWVudC53cml0 ZShjaHMpOworPC9zY3JpcHQ+CisKKzxwPlRoZSBhYm92ZSBsaW5lIHNob3VsZCBiZSB5b3VyIGJy b3dzZXIncyBkZWZhdWx0IGVuY29kaW5nLCBhbmQgbm90IHgtbWFjLWN5cmlsbGljLjwvcD4KKzwh LS0gSXQncyB1bmxpa2VseSB0aGF0IGFueW9uZSBoYXMgeC1tYWMtY3lyaWxsaWMgYXMgZGVmYXVs dCAtLT4KKworPGJvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL2todG1sL2todG1sX3BhcnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL2todG1sX3Bh cnQuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM2OQpkaWZmIC1wIC11IC1yMS4zNjkgV2Vi Q29yZS9raHRtbC9raHRtbF9wYXJ0LmNwcAotLS0gV2ViQ29yZS9raHRtbC9raHRtbF9wYXJ0LmNw cAkxNiBEZWMgMjAwNSAyMTozMDozNSAtMDAwMAkxLjM2OQorKysgV2ViQ29yZS9raHRtbC9raHRt bF9wYXJ0LmNwcAkxOSBEZWMgMjAwNSAxMzo0ODoxMSAtMDAwMApAQCAtNyw2ICs3LDcgQEAKICAq ICAgICAgICAgICAgICAgICAgICAgMjAwMCBTdGVmYW4gU2NoaW1hbnNraSA8MVN0ZWluQGdteC5k ZT4KICAqICAgICAgICAgICAgICAgICAgICAgMjAwMSBHZW9yZ2UgU3RhaWtvcyA8c3RhaWtvc0Br ZGUub3JnPgogICogQ29weXJpZ2h0IChDKSAyMDA0IEFwcGxlIENvbXB1dGVyLCBJbmMuCisgKiBD b3B5cmlnaHQgKEMpIDIwMDUgQWxleGV5IFByb3NrdXJ5YWtvdiA8YXBAbnlwb3AuY29tPgogICoK ICAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5 IEdlbmVyYWwgUHVibGljCkBAIC05NDYsMTIgKzk0Nyw5IEBAIHZvaWQgS0hUTUxQYXJ0Ojp3cml0 ZSggY29uc3QgY2hhciAqc3RyLCAKICAgICAgICAgaWYgKCFkLT5tX2VuY29kaW5nLmlzTnVsbCgp KQogICAgICAgICAgICAgZC0+bV9kZWNvZGVyLT5zZXRFbmNvZGluZyhkLT5tX2VuY29kaW5nLmxh dGluMSgpLAogICAgICAgICAgICAgICAgIGQtPm1faGF2ZUVuY29kaW5nID8gRGVjb2Rlcjo6VXNl ckNob3NlbkVuY29kaW5nIDogRGVjb2Rlcjo6RW5jb2RpbmdGcm9tSFRUUEhlYWRlcik7Ci0gICAg ICAgIGVsc2UgewotICAgICAgICAgICAgLy8gSW5oZXJpdCB0aGUgZGVmYXVsdCBlbmNvZGluZyBm cm9tIHRoZSBwYXJlbnQgZnJhbWUgaWYgdGhlcmUgaXMgb25lLgotICAgICAgICAgICAgY29uc3Qg Y2hhciAqZGVmYXVsdEVuY29kaW5nID0gKHBhcmVudFBhcnQoKSAmJiBwYXJlbnRQYXJ0KCktPmQt Pm1fZGVjb2RlcikKLSAgICAgICAgICAgICAgICA/IHBhcmVudFBhcnQoKS0+ZC0+bV9kZWNvZGVy LT5lbmNvZGluZygpIDogc2V0dGluZ3MoKS0+ZW5jb2RpbmcoKS5sYXRpbjEoKTsKLSAgICAgICAg ICAgIGQtPm1fZGVjb2Rlci0+c2V0RW5jb2RpbmcoZGVmYXVsdEVuY29kaW5nLCBEZWNvZGVyOjpE ZWZhdWx0RW5jb2RpbmcpOwotICAgICAgICB9CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGQt Pm1fZGVjb2Rlci0+c2V0RW5jb2Rpbmcoc2V0dGluZ3MoKS0+ZW5jb2RpbmcoKS5sYXRpbjEoKSwg RGVjb2Rlcjo6RGVmYXVsdEVuY29kaW5nKTsKKwogICAgICAgICBpZiAoZC0+bV9kb2MpCiAgICAg ICAgICAgICBkLT5tX2RvYy0+c2V0RGVjb2RlcihkLT5tX2RlY29kZXIpOwogICAgIH0K