61177 2011-05-20 01:49:03 -0700 Web Inspector: [Chromium] Show URL of DOMWindow in heap profiles 2011-05-27 13:05:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 406949 0 mnaganov 2011-05-20 01:49:03 -0700 When there are multiple DOMWindow objects, it's hard to tell which one corresponds to page, etc. We need to show an URL next to an object for identification. 411605 1 95205 mnaganov 2011-05-27 12:28:40 -0700 Created attachment 95205 patch We need very little from the UI. The main change is in the VM. 411630 2 mnaganov 2011-05-27 13:05:39 -0700 Manually committed http://trac.webkit.org/changeset/87538 2011-05-27 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles. https://bugs.webkit.org/show_bug.cgi?id=61177 * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className): 95205 2011-05-27 12:28:40 -0700 2011-05-27 12:42:12 -0700 patch patch-61177 text/plain 1503 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMDM2NTVjLi4xNTljYjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDUtMjcgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIEFkZCBzdXBwb3J0IGZvciBzaG93aW5nIFVSTCBvZiBET01XaW5k b3cgaW4gaGVhcCBwcm9maWxlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYxMTc3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBT bmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3ROb2RlLnByb3Rv dHlwZS5nZXQgY2xhc3NOYW1lKToKKwogMjAxMS0wNS0yNyAgTmlrb2xhcyBaaW1tZXJtYW5uICA8 bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVpcy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90 LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMK aW5kZXggOTVmNDRlZi4uNjc2Mzg3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKQEAgLTQ5Miw4ICs0OTIsMTAgQEAgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUucHJvdG90eXBlID0gewogICAgICAgICBzd2l0Y2ggKHRo aXMudHlwZSkgewogICAgICAgICBjYXNlICJoaWRkZW4iOgogICAgICAgICAgICAgcmV0dXJuIFdl Ykluc3BlY3Rvci5VSVN0cmluZygiKHN5c3RlbSkiKTsKLSAgICAgICAgY2FzZSAib2JqZWN0IjoK LSAgICAgICAgICAgIHJldHVybiB0aGlzLm5hbWU7CisgICAgICAgIGNhc2UgIm9iamVjdCI6IHsK KyAgICAgICAgICAgIHZhciBjb21tZW50UG9zID0gdGhpcy5uYW1lLmluZGV4T2YoIi8iKTsKKyAg ICAgICAgICAgIHJldHVybiBjb21tZW50UG9zICE9PSAtMSA/IHRoaXMubmFtZS5zdWJzdHJpbmco MCwgY29tbWVudFBvcykudHJpbVJpZ2h0KCkgOiB0aGlzLm5hbWU7CisgICAgICAgIH0KICAgICAg ICAgY2FzZSAibmF0aXZlIjogewogICAgICAgICAgICAgdmFyIGVudGl0aWVzQ291bnRQb3MgPSB0 aGlzLm5hbWUuaW5kZXhPZigiLyIpOwogICAgICAgICAgICAgcmV0dXJuIGVudGl0aWVzQ291bnRQ b3MgIT09IC0xID8gdGhpcy5uYW1lLnN1YnN0cmluZygwLCBlbnRpdGllc0NvdW50UG9zKS50cmlt UmlnaHQoKSA6IHRoaXMubmFtZTsK