61170 2011-05-20 00:07:58 -0700 Zombies should "live" forever 2011-05-20 12:06:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned commit-queue oliver oldest_to_newest 406912 0 zherczeg 2011-05-20 00:07:58 -0700 Some improvements to keep zombies alive. 406914 1 94180 zherczeg 2011-05-20 00:16:12 -0700 Created attachment 94180 patch 407125 2 94180 oliver 2011-05-20 08:50:58 -0700 Comment on attachment 94180 patch View in context: https://bugs.webkit.org/attachment.cgi?id=94180&action=review > Source/JavaScriptCore/JavaScriptCore.pro:-67 > - assembler/MacroAssemblerSH4.h \ > assembler/MacroAssemblerSH4.cpp \ > - assembler/SH4Assembler.h \ Why remove these? Or at least why remove them in this patch? > Source/JavaScriptCore/runtime/JSCell.h:362 > - return isCell() && asCell() > (JSCell*)0x1ffffffffL && asCell()->isZombie(); > + return isCell() && asCell()->isZombie(); whoops, i shouldn't have left this in, my bad. > Source/JavaScriptCore/runtime/WriteBarrier.h:132 > - ASSERT(!m_cell || !isZombie(m_cell)); > + ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell)); What are you testing here? 407166 3 zherczeg 2011-05-20 10:03:41 -0700 > > Source/JavaScriptCore/JavaScriptCore.pro:-67 > > - assembler/MacroAssemblerSH4.h \ > > assembler/MacroAssemblerSH4.cpp \ > > - assembler/SH4Assembler.h \ > > Why remove these? Or at least why remove them in this patch? True, it is unrelated. That list should contain only .cpp files. It is just a typo. > > Source/JavaScriptCore/runtime/WriteBarrier.h:132 > > - ASSERT(!m_cell || !isZombie(m_cell)); > > + ASSERT(!m_cell || value == reinterpret_cast<T*>(1) || !isZombie(m_cell)); > > What are you testing here? CodeBlock.h : setSeen(): cachedPrototypeStructure.setWithoutWriteBarrier((Structure*)1); 407258 4 94180 commit-queue 2011-05-20 12:06:39 -0700 Comment on attachment 94180 patch Clearing flags on attachment: 94180 Committed r86974: <http://trac.webkit.org/changeset/86974> 407259 5 commit-queue 2011-05-20 12:06:44 -0700 All reviewed patches have been landed. Closing bug. 94180 2011-05-20 00:16:12 -0700 2011-05-20 12:06:39 -0700 patch 0001-zombies.patch text/plain 5850 zherczeg RnJvbSBmNzQ2MDkxYjEyNDIwMTFhZDAxN2Y1MzJkOTBiZWI3MGExMzk5NTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDIwIE1heSAyMDExIDAwOjA0OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gem9tYmllcwoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICB8ICAgMjMgKysrKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS5wcm8gICAgIHwgICAgMyArLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtlZEJsb2NrLmNwcCAgIHwgICAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmggICAgIHwgICAgMiArKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkU3BhY2UuY3BwICAgfCAgICAzICsrKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmggICAgICAgfCAgICA0ICsrLS0KIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmggICAgIHwgICAgNiArKysrKysKIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dyaXRlQmFycmllci5oIHwgICAgMiArLQogOCBmaWxl cyBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCmluZGV4IGE2ZmY0OWYuLjU3NjBlMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI2IEBACisyMDExLTA1LTIwICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVn QGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBab21iaWVzIHNob3VsZCAibGl2ZSIgZm9yZXZlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjExNzAKKworICAgICAgICBSZXVzaW5n IHpvbWJpZSBjZWxscyBjb3VsZCBzdGlsbCBoaWRlIGdhcmJhZ2UKKyAgICAgICAgY29sbGVjdGVk IGNlbGwgcmVsYXRlZCBidWdzLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJvOgorICAg ICAgICAqIGhlYXAvTWFya2VkQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpNYXJrZWRCbG9jazo6 Y2xlYXJNYXJrcyk6CisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5oOgorICAgICAgICAqIGhl YXAvTWFya2VkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpNYXJrZWRTcGFjZTo6ZGVzdHJveSk6 CisgICAgICAgICogcnVudGltZS9KU0NlbGwuaDoKKyAgICAgICAgKEpTQzo6SlNDZWxsOjpKU1Zh bHVlOjppc1pvbWJpZSk6CisgICAgICAgICogcnVudGltZS9KU1pvbWJpZS5oOgorICAgICAgICAo SlNDOjpKU1pvbWJpZTo6fkpTWm9tYmllKToKKyAgICAgICAgKiBydW50aW1lL1dyaXRlQmFycmll ci5oOgorICAgICAgICAoSlNDOjpXcml0ZUJhcnJpZXJCYXNlOjpzZXRXaXRob3V0V3JpdGVCYXJy aWVyKToKKwogMjAxMS0wNS0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg2NjUzLgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8KaW5kZXggM2UwY2FmOC4uNzNlOWQ4YyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybworKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCkBAIC02Miw5ICs2Miw3 IEBAIFNPVVJDRVMgKz0gXAogICAgIGFzc2VtYmxlci9BUk1Bc3NlbWJsZXIuY3BwIFwKICAgICBh c3NlbWJsZXIvQVJNdjdBc3NlbWJsZXIuY3BwIFwKICAgICBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uY3BwIFwKLSAgICBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaCBcCiAgICAgYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmNwcCBcCi0gICAgYXNzZW1ibGVyL1NINEFzc2VtYmxl ci5oIFwKICAgICBieXRlY29kZS9Db2RlQmxvY2suY3BwIFwKICAgICBieXRlY29kZS9KdW1wVGFi bGUuY3BwIFwKICAgICBieXRlY29kZS9PcGNvZGUuY3BwIFwKQEAgLTE2Nyw2ICsxNjUsNyBAQCBT T1VSQ0VTICs9IFwKICAgICBydW50aW1lL0pTVmFsdWUuY3BwIFwKICAgICBydW50aW1lL0pTVmFy aWFibGVPYmplY3QuY3BwIFwKICAgICBydW50aW1lL0pTV3JhcHBlck9iamVjdC5jcHAgXAorICAg IHJ1bnRpbWUvSlNab21iaWUuY3BwIFwKICAgICBydW50aW1lL0xpdGVyYWxQYXJzZXIuY3BwIFwK ICAgICBydW50aW1lL0xvb2t1cC5jcHAgXAogICAgIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHAgXApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3BwCmluZGV4IGYxZjYzMGMu LmFhOTNiMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJs b2NrLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAK QEAgLTg2LDQgKzg2LDE5IEBAIHZvaWQgTWFya2VkQmxvY2s6OnN3ZWVwKCkKICAgICB9CiB9CiAK KyNpZiBFTkFCTEUoSlNDX1pPTUJJRVMpCit2b2lkIE1hcmtlZEJsb2NrOjpjbGVhck1hcmtzKCkK K3sKKyAgICAvKiBLZWVwIG91ciBwcmVjaW91cyB6b21iaWVzISAqLworICAgIGZvciAoc2l6ZV90 IGkgPSBmaXJzdEF0b20oKTsgaSA8IG1fZW5kQXRvbTsgaSArPSBtX2F0b21zUGVyQ2VsbCkgewor ICAgICAgICBpZiAobV9tYXJrcy5nZXQoaSkpCisgICAgICAgICAgICBjb250aW51ZTsKKworICAg ICAgICBKU0NlbGwqIGNlbGwgPSByZWludGVycHJldF9jYXN0PEpTQ2VsbCo+KCZhdG9tcygpW2ld KTsKKyAgICAgICAgaWYgKCFjZWxsLT5pc1pvbWJpZSgpKQorICAgICAgICAgICAgbV9tYXJrcy5j bGVhcihpKTsKKyAgICB9Cit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suaAppbmRleCBjNTY3NTAyLi4xZmY1ZjI5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgKQEAgLTE1NCwxMCArMTU0 LDEyIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gbV9tYXJrcy5pc0VtcHR5KCk7 CiAgICAgfQogCisjaWYgIUVOQUJMRShKU0NfWk9NQklFUykKICAgICBpbmxpbmUgdm9pZCBNYXJr ZWRCbG9jazo6Y2xlYXJNYXJrcygpCiAgICAgewogICAgICAgICBtX21hcmtzLmNsZWFyQWxsKCk7 CiAgICAgfQorI2VuZGlmCiAgICAgCiAgICAgaW5saW5lIHNpemVfdCBNYXJrZWRCbG9jazo6bWFy a0NvdW50KCkKICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9N YXJrZWRTcGFjZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRTcGFjZS5j cHAKaW5kZXggNzdmNmU1Mi4uOGRlMmQ5YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvTWFya2VkU3BhY2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hcmtlZFNwYWNlLmNwcApAQCAtNDYsOSArNDYsMTIgQEAgTWFya2VkU3BhY2U6Ok1hcmtlZFNw YWNlKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSkKIAogdm9pZCBNYXJrZWRTcGFjZTo6ZGVzdHJv eSgpCiB7CisgICAgLyogS2VlcCBvdXIgcHJlY2lvdXMgem9tYmllcyEgKi8KKyNpZiAhRU5BQkxF KEpTQ19aT01CSUVTKQogICAgIGNsZWFyTWFya3MoKTsKICAgICBzaHJpbmsoKTsKICAgICBBU1NF UlQoIXNpemUoKSk7CisjZW5kaWYKIH0KIAogTWFya2VkQmxvY2sqIE1hcmtlZFNwYWNlOjphbGxv Y2F0ZUJsb2NrKFNpemVDbGFzcyYgc2l6ZUNsYXNzKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NlbGwuaAppbmRleCA3ZDJjNWRmLi45NTk1ZmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0NlbGwuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0NlbGwuaApAQCAtMzU1LDExICszNTUsMTEgQEAgbmFtZXNwYWNlIEpTQyB7CiAg ICAgewogICAgICAgICByZXR1cm4gTWFya2VkU3BhY2U6OmhlYXAoYyk7CiAgICAgfQotICAgIAor CiAjaWYgRU5BQkxFKEpTQ19aT01CSUVTKQogICAgIGlubGluZSBib29sIEpTVmFsdWU6OmlzWm9t YmllKCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiBpc0NlbGwoKSAmJiBhc0NlbGwoKSA+ IChKU0NlbGwqKTB4MWZmZmZmZmZmTCAmJiBhc0NlbGwoKS0+aXNab21iaWUoKTsKKyAgICAgICAg cmV0dXJuIGlzQ2VsbCgpICYmIGFzQ2VsbCgpLT5pc1pvbWJpZSgpOwogICAgIH0KICNlbmRpZgog CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1pvbWJpZS5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNab21iaWUuaAppbmRleCA3OTUwMzZlLi5k ODNjYWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1pvbWJp ZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTWm9tYmllLmgKQEAgLTQx LDYgKzQxLDEyIEBAIHB1YmxpYzoKICAgICAgICAgQVNTRVJUKGluaGVyaXRzKCZzX2luZm8pKTsK ICAgICB9CiAKKyAgICB+SlNab21iaWUoKQorICAgIHsKKyAgICAgICAgLyogWm9tYmllIGNlbGxz IHNob3VsZCBuZXZlciBiZWVuIHJldXNlZC4gKi8KKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVE KCk7CisgICAgfQorCiAgICAgdmlydHVhbCBib29sIGlzWm9tYmllKCkgY29uc3QgeyByZXR1cm4g dHJ1ZTsgfQogCiAgICAgdmlydHVhbCBib29sIGlzR2V0dGVyU2V0dGVyKCkgY29uc3QgeyBBU1NF UlRfTk9UX1JFQUNIRUQoKTsgcmV0dXJuIGZhbHNlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Xcml0ZUJhcnJpZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1dyaXRlQmFycmllci5oCmluZGV4IDg5OTg5NDcuLmE5ZTkzODQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dyaXRlQmFycmllci5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dyaXRlQmFycmllci5oCkBAIC0xMjksNyArMTI5 LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgdGhpcy0+bV9jZWxsID0gcmVpbnRlcnByZXRf Y2FzdDxKU0NlbGwqPih2YWx1ZSk7CiAjaWYgRU5BQkxFKEpTQ19aT01CSUVTKQotICAgICAgICBB U1NFUlQoIW1fY2VsbCB8fCAhaXNab21iaWUobV9jZWxsKSk7CisgICAgICAgIEFTU0VSVCghbV9j ZWxsIHx8IHZhbHVlID09IHJlaW50ZXJwcmV0X2Nhc3Q8VCo+KDEpIHx8ICFpc1pvbWJpZShtX2Nl bGwpKTsKICNlbmRpZgogICAgIH0KIAotLSAKMS43LjIuMwoK