61164 2011-05-19 19:03:23 -0700 [chromium] Fix division by zero in TilingData for boundary case texture sizes 2011-05-23 13:40:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne commit-queue enne jamesr scheib oldest_to_newest 406823 0 enne 2011-05-19 19:03:23 -0700 [chromium] Fix division by zero in TilingData for boundary case texture sizes 406824 1 94157 enne 2011-05-19 19:05:17 -0700 Created attachment 94157 Patch 406825 2 enne 2011-05-19 19:09:39 -0700 This fixes this crasher: http://crash/reportdetail?reportid=139f0688bc41a480 The new test cases repro the division by zero without the corresponding code fix. 406834 3 94157 jamesr 2011-05-19 19:17:22 -0700 Comment on attachment 94157 Patch Do you know how to repro this with a web page? 406842 4 enne 2011-05-19 19:41:20 -0700 (In reply to comment #3) > (From update of attachment 94157 [details]) > Do you know how to repro this with a web page? I suspect that any composited 2xY layer would cause this issue, where Y <= 512. ContentLayerChromium would set the tile size to be 2x2 because it's small and would ask for border texels in the tiler because it's on a transformed layer. TilingData's computeNumTiles properly handles this case and avoids the division by zero, but tileXIndexFromSrcCoord does not. 406899 5 94157 scheib 2011-05-19 23:21:50 -0700 Comment on attachment 94157 Patch LGTM 408223 6 94157 commit-queue 2011-05-23 13:40:35 -0700 Comment on attachment 94157 Patch Clearing flags on attachment: 94157 Committed r87094: <http://trac.webkit.org/changeset/87094> 408224 7 commit-queue 2011-05-23 13:40:40 -0700 All reviewed patches have been landed. Closing bug. 94157 2011-05-19 19:05:17 -0700 2011-05-23 13:40:35 -0700 Patch bug-61164-20110519190516.patch text/plain 6400 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODY5MDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MDM0YTc0YjU0N2M0YmM1 MDcxYTJlMzg2ODU0NDJiYTQyM2VhMWM4Li5jMjBmMmE5Y2NhYTMzOWI4ZWY0OWYwZDM0ODg0ZDlj MTM0NGY3ZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTkgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBkaXZpc2lvbiBieSB6ZXJvIGlu IFRpbGluZ0RhdGEgZm9yIGJvdW5kYXJ5IGNhc2UgdGV4dHVyZSBzaXplcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjExNjQKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRp bGluZ0RhdGE6OnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQpOgorICAgICAgICAoV2ViQ29yZTo6VGls aW5nRGF0YTo6dGlsZVlJbmRleEZyb21TcmNDb29yZCk6CisKIDIwMTEtMDUtMTggIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJv Ymluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L1RpbGluZ0RhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1Rp bGluZ0RhdGEuY3BwCmluZGV4IDI0MTVlZTQ2ZDdkZGZlYWNmNDdlOWFkYWJlY2RlMDM2OTY2NDU5 NzYuLmFhNWFmOTU4YzNmNTk4NjBhZDAxMTdlZTgzMTk1NTg5MmJkNTcwNDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAKQEAg LTc1LDEyICs3NSwyMCBAQCB2b2lkIFRpbGluZ0RhdGE6OnNldE1heFRleHR1cmVTaXplKGludCBt YXhUZXh0dXJlU2l6ZSkKIAogaW50IFRpbGluZ0RhdGE6OnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQo aW50IHNyY1BvcykgY29uc3QKIHsKKyAgICBpZiAobnVtVGlsZXNYKCkgPD0gMSkKKyAgICAgICAg cmV0dXJuIDA7CisKKyAgICBBU1NFUlQobV9tYXhUZXh0dXJlU2l6ZSAtIDIgKiBtX2JvcmRlclRl eGVscyk7CiAgICAgaW50IHggPSAoc3JjUG9zIC0gbV9ib3JkZXJUZXhlbHMpIC8gKG1fbWF4VGV4 dHVyZVNpemUgLSAyICogbV9ib3JkZXJUZXhlbHMpOwogICAgIHJldHVybiBtaW4obWF4KHgsIDAp LCBudW1UaWxlc1goKSAtIDEpOwogfQogCiBpbnQgVGlsaW5nRGF0YTo6dGlsZVlJbmRleEZyb21T cmNDb29yZChpbnQgc3JjUG9zKSBjb25zdAogeworICAgIGlmIChudW1UaWxlc1koKSA8PSAxKQor ICAgICAgICByZXR1cm4gMDsKKworICAgIEFTU0VSVChtX21heFRleHR1cmVTaXplIC0gMiAqIG1f Ym9yZGVyVGV4ZWxzKTsKICAgICBpbnQgeSA9IChzcmNQb3MgLSBtX2JvcmRlclRleGVscykgLyAo bV9tYXhUZXh0dXJlU2l6ZSAtIDIgKiBtX2JvcmRlclRleGVscyk7CiAgICAgcmV0dXJuIG1pbiht YXgoeSwgMCksIG51bVRpbGVzWSgpIC0gMSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmlu ZGV4IDRhMjliZTJiZGQxNTRjYmYxYTA0OWI0N2JlOGMxNTg3MDRiYWI2N2QuLjk1Y2JjYTNlM2Ji N2FiOTlkYTQyMzY3MDc2NWMyZWQ5OTJlNGM3YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMTkgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29v Z2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbY2hyb21pdW1dIEZpeCBkaXZpc2lvbiBieSB6ZXJvIGluIFRpbGluZ0RhdGEgZm9yIGJvdW5k YXJ5IGNhc2UgdGV4dHVyZSBzaXplcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjExNjQKKworICAgICAgICBBZGQgYWRkaXRpb25hbCB0ZXN0cyBmb3Ig c21hbGwgbWF4IHRleHR1cmUgc2l6ZXMuCisKKyAgICAgICAgKiB0ZXN0cy9UaWxpbmdEYXRhVGVz dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpURVNUKToKKwogMjAxMS0wNS0xOSAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjg2ODY5LCByODY4NzMsIHI4Njg3NSwgYW5kIHI4Njg3Ny4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKaW5kZXggNzU3M2Rj N2Y3MmZhZjgxZTIxNTM0MzM0OTIyZjUyMTJlZDUwMjE5OC4uNzYyZWRhOTM5OTE1MGViZTRjOTcx OTQ2YTc0ZTU3YzM5YTNiNWRkNSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9UaWxpbmdEYXRhVGVzdC5jcHAKQEAgLTE3Nyw2ICsxNzcsMzAgQEAgVEVTVChUaWxpbmdEYXRh VGVzdCwgdGlsZVhJbmRleEZyb21TcmNDb29yZCkKICAgICBFWFBFQ1RfRVEoNywgVGlsaW5nRGF0 YSgzLCAxMCwgMTAsIHRydWUpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoOSkpOwogICAgIEVYUEVD VF9FUSg3LCBUaWxpbmdEYXRhKDMsIDEwLCAxMCwgdHJ1ZSkudGlsZVhJbmRleEZyb21TcmNDb29y ZCgxMCkpOwogICAgIEVYUEVDVF9FUSg3LCBUaWxpbmdEYXRhKDMsIDEwLCAxMCwgdHJ1ZSkudGls ZVhJbmRleEZyb21TcmNDb29yZCgxMSkpOworCisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEo MSwgMSwgMSwgZmFsc2UpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMCkpOworICAgIEVYUEVDVF9F USgwLCBUaWxpbmdEYXRhKDIsIDIsIDIsIGZhbHNlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDAp KTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgyLCAyLCAyLCBmYWxzZSkudGlsZVhJbmRl eEZyb21TcmNDb29yZCgxKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMywgMywgMywg ZmFsc2UpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxp bmdEYXRhKDMsIDMsIDMsIGZhbHNlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDEpKTsKKyAgICBF WFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCAzLCAzLCBmYWxzZSkudGlsZVhJbmRleEZyb21TcmND b29yZCgyKSk7CisKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCA0LCAzLCBmYWxzZSku dGlsZVhJbmRleEZyb21TcmNDb29yZCgwKSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEo MywgNCwgMywgZmFsc2UpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMSkpOworICAgIEVYUEVDVF9F USgwLCBUaWxpbmdEYXRhKDMsIDQsIDMsIGZhbHNlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDIp KTsKKyAgICBFWFBFQ1RfRVEoMSwgVGlsaW5nRGF0YSgzLCA0LCAzLCBmYWxzZSkudGlsZVhJbmRl eEZyb21TcmNDb29yZCgzKSk7CisKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgxLCAxLCAx LCB0cnVlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDApKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGls aW5nRGF0YSgyLCAyLCAyLCB0cnVlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDApKTsKKyAgICBF WFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgyLCAyLCAyLCB0cnVlKS50aWxlWEluZGV4RnJvbVNyY0Nv b3JkKDEpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCAzLCAzLCB0cnVlKS50aWxl WEluZGV4RnJvbVNyY0Nvb3JkKDApKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCAz LCAzLCB0cnVlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDEpKTsKKyAgICBFWFBFQ1RfRVEoMCwg VGlsaW5nRGF0YSgzLCAzLCAzLCB0cnVlKS50aWxlWEluZGV4RnJvbVNyY0Nvb3JkKDIpKTsKKwor ICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDMsIDQsIDMsIHRydWUpLnRpbGVYSW5kZXhGcm9t U3JjQ29vcmQoMCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDMsIDQsIDMsIHRydWUp LnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMSkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRh KDMsIDQsIDMsIHRydWUpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMikpOworICAgIEVYUEVDVF9F USgxLCBUaWxpbmdEYXRhKDMsIDQsIDMsIHRydWUpLnRpbGVYSW5kZXhGcm9tU3JjQ29vcmQoMykp OwogfQogVEVTVChUaWxpbmdEYXRhVGVzdCwgdGlsZVlJbmRleEZyb21TcmNDb29yZCkKIHsKQEAg LTIwNSw2ICsyMjksMzAgQEAgVEVTVChUaWxpbmdEYXRhVGVzdCwgdGlsZVlJbmRleEZyb21TcmND b29yZCkKICAgICBFWFBFQ1RfRVEoNywgVGlsaW5nRGF0YSgzLCAxMCwgMTAsIHRydWUpLnRpbGVZ SW5kZXhGcm9tU3JjQ29vcmQoOSkpOwogICAgIEVYUEVDVF9FUSg3LCBUaWxpbmdEYXRhKDMsIDEw LCAxMCwgdHJ1ZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgxMCkpOwogICAgIEVYUEVDVF9FUSg3 LCBUaWxpbmdEYXRhKDMsIDEwLCAxMCwgdHJ1ZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgxMSkp OworCisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMSwgMSwgMSwgZmFsc2UpLnRpbGVZSW5k ZXhGcm9tU3JjQ29vcmQoMCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDIsIDIsIDIs IGZhbHNlKS50aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDApKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGls aW5nRGF0YSgyLCAyLCAyLCBmYWxzZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgxKSk7CisgICAg RVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMywgMywgMywgZmFsc2UpLnRpbGVZSW5kZXhGcm9tU3Jj Q29vcmQoMCkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDMsIDMsIDMsIGZhbHNlKS50 aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDEpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgz LCAzLCAzLCBmYWxzZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgyKSk7CisKKyAgICBFWFBFQ1Rf RVEoMCwgVGlsaW5nRGF0YSgzLCAzLCA0LCBmYWxzZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgw KSk7CisgICAgRVhQRUNUX0VRKDAsIFRpbGluZ0RhdGEoMywgMywgNCwgZmFsc2UpLnRpbGVZSW5k ZXhGcm9tU3JjQ29vcmQoMSkpOworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdEYXRhKDMsIDMsIDQs IGZhbHNlKS50aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDIpKTsKKyAgICBFWFBFQ1RfRVEoMSwgVGls aW5nRGF0YSgzLCAzLCA0LCBmYWxzZSkudGlsZVlJbmRleEZyb21TcmNDb29yZCgzKSk7CisKKyAg ICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgxLCAxLCAxLCB0cnVlKS50aWxlWUluZGV4RnJvbVNy Y0Nvb3JkKDApKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgyLCAyLCAyLCB0cnVlKS50 aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDApKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgy LCAyLCAyLCB0cnVlKS50aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDEpKTsKKyAgICBFWFBFQ1RfRVEo MCwgVGlsaW5nRGF0YSgzLCAzLCAzLCB0cnVlKS50aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDApKTsK KyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCAzLCAzLCB0cnVlKS50aWxlWUluZGV4RnJv bVNyY0Nvb3JkKDEpKTsKKyAgICBFWFBFQ1RfRVEoMCwgVGlsaW5nRGF0YSgzLCAzLCAzLCB0cnVl KS50aWxlWUluZGV4RnJvbVNyY0Nvb3JkKDIpKTsKKworICAgIEVYUEVDVF9FUSgwLCBUaWxpbmdE YXRhKDMsIDMsIDQsIHRydWUpLnRpbGVZSW5kZXhGcm9tU3JjQ29vcmQoMCkpOworICAgIEVYUEVD VF9FUSgwLCBUaWxpbmdEYXRhKDMsIDMsIDQsIHRydWUpLnRpbGVZSW5kZXhGcm9tU3JjQ29vcmQo MSkpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDMsIDMsIDQsIHRydWUpLnRpbGVZSW5k ZXhGcm9tU3JjQ29vcmQoMikpOworICAgIEVYUEVDVF9FUSgxLCBUaWxpbmdEYXRhKDMsIDMsIDQs IHRydWUpLnRpbGVZSW5kZXhGcm9tU3JjQ29vcmQoMykpOwogfQogCiBURVNUKFRpbGluZ0RhdGFU ZXN0LCB0aWxlU2l6ZVgpCg==