61163 2011-05-19 18:30:55 -0700 Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position 2015-12-04 03:33:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 honten webkit-unassigned commit-queue florian_schwab honten tkent oldest_to_newest 406801 0 honten 2011-05-19 18:30:55 -0700 Number input should handle cursor position intelligently when it formats the value. 406807 1 94156 honten 2011-05-19 18:34:34 -0700 Created attachment 94156 Patch 406808 2 94156 honten 2011-05-19 18:35:32 -0700 Comment on attachment 94156 Patch Please review. 406885 3 94156 tkent 2011-05-19 22:26:33 -0700 Comment on attachment 94156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94156&action=review > Source/WebCore/ChangeLog:5 > + Number input should handle cursor position intelligently when it formats the value. The summary is not concrete. It should be something like "Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position" 406893 4 94177 honten 2011-05-19 22:48:37 -0700 Created attachment 94177 Change summary webkit-patch script doesn't work well suddenly in my environment... So manually I made the patch. I just change the summary. Please review and commit. Thanks, 406903 5 94177 commit-queue 2011-05-19 23:37:14 -0700 Comment on attachment 94177 Change summary Clearing flags on attachment: 94177 Committed r86926: <http://trac.webkit.org/changeset/86926> 406904 6 commit-queue 2011-05-19 23:37:19 -0700 All reviewed patches have been landed. Closing bug. 94156 2011-05-19 18:34:34 -0700 2011-05-19 22:48:37 -0700 Patch bug-61163-20110519183433.patch text/plain 2637 honten U3VidmVyc2lvbiBSZXZpc2lvbjogODY3MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMjdmZDNiN2VlNWRkMzI5 NTQzODA1NjAwZDlkZDM0Y2ZlZTg0MjFjLi4wNmJiMmRiODYwMjkwZDQ4YzIxNjNhYTU4NjllM2Q2 ZWZhYWM0ZjI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMTkgIE5hb2tp IFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTnVtYmVyIGlucHV0IHNob3VsZCBoYW5kbGUgY3Vy c29yIHBvc2l0aW9uIGludGVsbGlnZW50bHkgd2hlbiBpdCBmb3JtYXRzIHRoZSB2YWx1ZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMTYzCisKKyAg ICAgICAgTWFudWFsIHRlc3QgaW5wdXQtbnVtYmVyLWxvY2FsaXphdGlvbi5odG1sLgorICAgICAg ICBCZWNhdXNlIHdlIGNhbid0IGFzc3VtZSBhbnkgbnVtYmVyIGZvcm1hdHMgaW4gdmFyaW91cyBX ZWJLaXQgcG9ydHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2V0VmFsdWUpOiBUaGUgY3Vyc29yIG11 c3QgYmUgdGhlIGxhc3QgcG9zaXRpb24gb2YgdmlzaWJsZVZhbHVlKCksIG5vdCBtX3ZhbHVlLgor ICAgICAgICAqIG1hbnVhbC10ZXN0cy9pbnB1dC1udW1iZXItbG9jYWxpemF0aW9uLmh0bWw6IEFk ZGVkIG1hbnVhbCB0ZXN0IHRvIGNoZWNrIHRoZSBjdXJzb3IgY29ycmVjdGx5IG1vdmVkIHRvIHRo ZSBsYXN0IHBvaXNpdGlvbiBvZiB0aGUgaW5wdXQuCisKIDIwMTEtMDUtMTcgIEplcmVteSBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCA0ZWYxNTZh MjMyN2JiM2ZlMmE4OWI0ZDU0MjBjMjgyOTRjN2U0YjQ5Li42OGRmNzQ5NTVlYjQyOWIwMTdmOTA2 MzQ1Nzg1YjZhZWZiOWFmYTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKQEAgLTkzOCw3ICs5MzgsNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVl KGNvbnN0IFN0cmluZyYgdmFsdWUsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQogICAgIHNldE5lZWRz VmFsaWRpdHlDaGVjaygpOwogCiAgICAgaWYgKGlzVGV4dEZpZWxkKCkpIHsKLSAgICAgICAgdW5z aWduZWQgbWF4ID0gbV92YWx1ZS5sZW5ndGgoKTsKKyAgICAgICAgdW5zaWduZWQgbWF4ID0gdmlz aWJsZVZhbHVlKCkubGVuZ3RoKCk7CiAgICAgICAgIGlmIChkb2N1bWVudCgpLT5mb2N1c2VkTm9k ZSgpID09IHRoaXMpCiAgICAgICAgICAgICBXZWJDb3JlOjpzZXRTZWxlY3Rpb25SYW5nZSh0aGlz LCBtYXgsIG1heCk7CiAgICAgICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21h bnVhbC10ZXN0cy9pbnB1dC1udW1iZXItbG9jYWxpemF0aW9uLmh0bWwgYi9Tb3VyY2UvV2ViQ29y ZS9tYW51YWwtdGVzdHMvaW5wdXQtbnVtYmVyLWxvY2FsaXphdGlvbi5odG1sCmluZGV4IDI5NDAy MmFjNzZiZTQzZTUwZjhkMGYxYTk0MzY3ZTdmNGRlMzAxZTAuLmM1NjA4OTRkZGIwNWMxM2I2NTU5 MjMwN2U5MzM3ZmQxOWJmNDU1NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10 ZXN0cy9pbnB1dC1udW1iZXItbG9jYWxpemF0aW9uLmh0bWwKKysrIGIvU291cmNlL1dlYkNvcmUv bWFudWFsLXRlc3RzL2lucHV0LW51bWJlci1sb2NhbGl6YXRpb24uaHRtbApAQCAtMjEsNiArMjEs MTEgQEAgWW91J2xsIHNlZSBhbiBlcXVpdmFsZW50IG51bWJlciBpbiB0aGUgc3RhbmRhcmQgZm9y bWF0IG9uIHRoZSBib3R0b20gb2YgdGhlIHRleHQKIDxkaXY+PGlucHV0IHR5cGU9bnVtYmVyIGlk PXRhcmdldCBzdGVwPWFueSBvbmlucHV0PSJoYW5kbGVJbnB1dCgpIj48L2Rpdj4KIDxkaXY+U3Rh bmRhcmQgZm9ybWF0OiA8b3V0cHV0IGlkPW91dHB1dD48L291dHB1dD48L2Rpdj4KIAorPHA+SW5w dXQgdGVzdDogVHlwZSB0aGUgbnVtYmVyIHRleHQgIjEyMzQiIGludG8gdGhlIHRoZSBmb2xsb3dp biBudW1iZXIgZmllbGQuCitUaGUgbnVtYmVyIHN0cmluZyB3aWxsIGJlICIxLDIzNCIgYW5kIHRo ZSBjdXJzb3IgcG9zaXRpb24gbXVzdCBiZSB0aGUgbGFzdCBwb3NpdGlvbi4KKzwvcD4KKzxkaXY+ PGlucHV0IHR5cGU9Im51bWJlciIgb25rZXl1cD0idGhpcy52YWx1ZT10aGlzLnZhbHVlIiAvPjwv ZGl2PgorCiA8c2NyaXB0PgogZnVuY3Rpb24gaGFuZGxlSW5wdXQoKSB7CiAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdvdXRwdXQnKS52YWx1ZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0 YXJnZXQnKS52YWx1ZTsK 94177 2011-05-19 22:48:37 -0700 2011-05-19 23:37:14 -0700 Change summary upload.patch text/plain 2417 honten ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMjdmZDNiLi5jNzNkMTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDUtMTkgIE5hb2tpIFRha2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgcHJv YmxlbSB0aGF0IHVwZGF0aW5nIEhUTUxJbnB1dEVsZW1lbnQ6OnZhbHVlIHNldHMgdGhlIGN1cnNv ciB0byBhIHdyb25nIHBvc2l0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjExNjMKKworICAgICAgICBNYW51YWwgdGVzdCBpbnB1dC1udW1iZXIt bG9jYWxpemF0aW9uLmh0bWwuCisgICAgICAgIEJlY2F1c2Ugd2UgY2FuJ3QgYXNzdW1lIGFueSBu dW1iZXIgZm9ybWF0cyBpbiB2YXJpb3VzIFdlYktpdCBwb3J0cy4KKworICAgICAgICAqIGh0bWwv SFRNTElucHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50 OjpzZXRWYWx1ZSk6IFRoZSBjdXJzb3IgbXVzdCBiZSB0aGUgbGFzdCBwb3NpdGlvbiBvZiB2aXNp YmxlVmFsdWUoKSwgbm90IG1fdmFsdWUuCisgICAgICAgICogbWFudWFsLXRlc3RzL2lucHV0LW51 bWJlci1sb2NhbGl6YXRpb24uaHRtbDogQWRkZWQgbWFudWFsIHRlc3QgdG8gY2hlY2sgdGhlIGN1 cnNvciBjb3JyZWN0bHkgbW92ZWQgdG8gdGhlIGxhc3QgcG9pc2l0aW9uIG9mIHRoZSBpbnB1dC4K KwogMjAxMS0wNS0xNyAgSmVyZW15IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCmluZGV4IDRlZjE1NmEuLjY4ZGY3NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtOTM4LDcgKzkzOCw3IEBAIHZvaWQgSFRNTElucHV0 RWxlbWVudDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiB2YWx1ZSwgYm9vbCBzZW5kQ2hhbmdlRXZl bnQpCiAgICAgc2V0TmVlZHNWYWxpZGl0eUNoZWNrKCk7CiAKICAgICBpZiAoaXNUZXh0RmllbGQo KSkgewotICAgICAgICB1bnNpZ25lZCBtYXggPSBtX3ZhbHVlLmxlbmd0aCgpOworICAgICAgICB1 bnNpZ25lZCBtYXggPSB2aXNpYmxlVmFsdWUoKS5sZW5ndGgoKTsKICAgICAgICAgaWYgKGRvY3Vt ZW50KCktPmZvY3VzZWROb2RlKCkgPT0gdGhpcykKICAgICAgICAgICAgIFdlYkNvcmU6OnNldFNl bGVjdGlvblJhbmdlKHRoaXMsIG1heCwgbWF4KTsKICAgICAgICAgZWxzZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2lucHV0LW51bWJlci1sb2NhbGl6YXRpb24uaHRt bCBiL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnB1dC1udW1iZXItbG9jYWxpemF0aW9u Lmh0bWwKaW5kZXggMjk0MDIyYS4uYzU2MDg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bWFudWFsLXRlc3RzL2lucHV0LW51bWJlci1sb2NhbGl6YXRpb24uaHRtbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9tYW51YWwtdGVzdHMvaW5wdXQtbnVtYmVyLWxvY2FsaXphdGlvbi5odG1sCkBAIC0y MSw2ICsyMSwxMSBAQCBZb3UnbGwgc2VlIGFuIGVxdWl2YWxlbnQgbnVtYmVyIGluIHRoZSBzdGFu ZGFyZCBmb3JtYXQgb24gdGhlIGJvdHRvbSBvZiB0aGUgdGV4dAogPGRpdj48aW5wdXQgdHlwZT1u dW1iZXIgaWQ9dGFyZ2V0IHN0ZXA9YW55IG9uaW5wdXQ9ImhhbmRsZUlucHV0KCkiPjwvZGl2Pgog PGRpdj5TdGFuZGFyZCBmb3JtYXQ6IDxvdXRwdXQgaWQ9b3V0cHV0Pjwvb3V0cHV0PjwvZGl2Pgog Cis8cD5JbnB1dCB0ZXN0OiBUeXBlIHRoZSBudW1iZXIgdGV4dCAiMTIzNCIgaW50byB0aGUgdGhl IGZvbGxvd2luIG51bWJlciBmaWVsZC4KK1RoZSBudW1iZXIgc3RyaW5nIHdpbGwgYmUgIjEsMjM0 IiBhbmQgdGhlIGN1cnNvciBwb3NpdGlvbiBtdXN0IGJlIHRoZSBsYXN0IHBvc2l0aW9uLgorPC9w PgorPGRpdj48aW5wdXQgdHlwZT0ibnVtYmVyIiBvbmtleXVwPSJ0aGlzLnZhbHVlPXRoaXMudmFs dWUiIC8+PC9kaXY+CisKIDxzY3JpcHQ+CiBmdW5jdGlvbiBoYW5kbGVJbnB1dCgpIHsKICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ291dHB1dCcpLnZhbHVlID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3RhcmdldCcpLnZhbHVlOwo=