61158 2011-05-19 17:55:48 -0700 [chromium] remove <(library) variable 2011-05-20 10:21:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evan evan webkit.review.bot oldest_to_newest 406783 0 evan 2011-05-19 17:55:48 -0700 [chromium] remove <(library) variable 406830 1 94159 evan 2011-05-19 19:10:37 -0700 Created attachment 94159 Patch 406832 2 webkit.review.bot 2011-05-19 19:13:02 -0700 Attachment 94159 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 407117 3 94159 tony 2011-05-20 08:41:32 -0700 Comment on attachment 94159 Patch OK, please fix the style error before landing. 407173 4 evan 2011-05-20 10:21:02 -0700 Committed r86965: <http://trac.webkit.org/changeset/86965> 94159 2011-05-19 19:10:37 -0700 2011-05-20 08:41:31 -0700 Patch bug-61158-20110519191133.patch text/plain 7590 evan U3VidmVyc2lvbiBSZXZpc2lvbjogODY4ODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUw MmJmMmY0N2ExNTU5YTFlY2ZhNDc4Yjc1Y2M4ZTMzYTM0YWU2YmEuLjViNzYyNGRhZWVmYjQyYjE5 MDBkZGJhYjM3ZTQxNmM5YjJiM2NmN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDExLTA1LTE5ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1 bV0gcmVtb3ZlIDwobGlicmFyeSkgdmFyaWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMTU4CisKKwlUaGlzIHdhcyBmb3IgYSBidWlsZCBleHBl cmltZW50OyB3ZSBjYW4ganVzdCB1c2UgdGhlIGNvcnJlY3QgdmFsdWUgbm93LgorCisgICAgICAg ICogSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDoKKwogMjAxMS0wNS0xOSAg T2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdl b2ZmcmV5IEdhcmVuLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAppbmRleCAyNzU5NmZjZWZmNGRkZmJk MDA2N2QxNDUyNGNkYjQ2MzBlNWE5Yzg0Li4zMWU4N2MzODFiMWQ0Mjc5MDY2MWM2ZDc3OTBlYzRh NjZiYmYyNjljIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cApAQCAtOTMsNyArOTMsNyBAQAogICAg IH0sCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ3d0ZicsCi0gICAgICAndHlwZSc6ICc8 KGxpYnJhcnkpJywKKyAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKICAgICAgICdtc3Zz X2d1aWQnOiAnQUE4QTVBODUtNTkyQi00MzU3LUJDNjAtRTBFOTFFMDI2QUY2JywKICAgICAgICdk ZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3dGZfY29uZmlnJywKQEAgLTE5MCw3ICsxOTAsNyBA QAogICAgIH0sCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ3lhcnInLAotICAgICAgJ3R5 cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCiAgICAg ICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd3RmJywKICAgICAgIF0sCmRpZmYgLS1naXQg YS9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VM b2cKaW5kZXggODdlNWNmODljMjhhN2NmYTJiMWUzYTkwMDg0OTU5ZjlhMjc0NjAyNS4uZDYzYTYy OGVkNTY2NzRhZTZkMGY5NzNiZjQyMmYxMTFhNmM1OWYwOSAxMDA2NDQKLS0tIGEvU291cmNlL1Ro aXJkUGFydHkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDExLTA1LTE5ICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gcmVtb3ZlIDwobGlicmFyeSkgdmFyaWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMTU4CisKKyAgICAgICAgVGhpcyB3YXMgZm9yIGEg YnVpbGQgZXhwZXJpbWVudDsgd2UgY2FuIGp1c3QgdXNlIHRoZSBjb3JyZWN0IHZhbHVlIG5vdy4K KworICAgICAgICAqIGdsdS9nbHUuZ3lwOgorICAgICAgICAqIGd5cC90ZXN0L2xpYnJhcnkvc3Jj L2xpYnJhcnkuZ3lwOgorCiAyMDExLTA1LTEyICBKZWZmIE1pbGxlciAgPGplZmZtQGFwcGxlLmNv bT4KIAogICAgICAgICBJZ25vcmUgVmlzdWFsIFN0dWRpbyAqLnVzZXIgZmlsZXMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9nbHUvZ2x1Lmd5cCBiL1NvdXJjZS9UaGlyZFBhcnR5L2ds dS9nbHUuZ3lwCmluZGV4IGM5ZGRiNzdmYmQ2Yjc4ZmVmNTg5NThlMzRhN2M2YmY4ZWQ4NTdkOWMu LjUxY2JjODQwZWM2NTI5ZGZjYjczZGU2OGYzYzE3NmZiZmU4ZDQzMGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9UaGlyZFBhcnR5L2dsdS9nbHUuZ3lwCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2dsdS9n bHUuZ3lwCkBAIC0xLDcgKzEsNyBAQAogewogICAndGFyZ2V0cyc6IFt7CiAgICAgJ3RhcmdldF9u YW1lJzogJ2xpYnRlc3MnLAotICAgICd0eXBlJzogJzwobGlicmFyeSknLAorICAgICd0eXBlJzog J3N0YXRpY19saWJyYXJ5JywKICAgICAnaW5jbHVkZV9kaXJzJzogWwogICAgICAgJy4uLy4uJywK ICAgICBdLApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvZ3lwL3Rlc3QvbGlicmFyeS9z cmMvbGlicmFyeS5neXAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9neXAvdGVzdC9saWJyYXJ5L3NyYy9s aWJyYXJ5Lmd5cAppbmRleCBiYzM1NTE2NDI2MDM3M2E4OThkOGNjOGFkYWU3YTJiMDI5MzU2OTY3 Li41MWY1OWJjNDUzZTU3OTc1OGMxNDJlNjUzODU3NGQwNzA4ZjI3MTM5IDEwMDY0NAotLS0gYS9T b3VyY2UvVGhpcmRQYXJ0eS9neXAvdGVzdC9saWJyYXJ5L3NyYy9saWJyYXJ5Lmd5cAorKysgYi9T b3VyY2UvVGhpcmRQYXJ0eS9neXAvdGVzdC9saWJyYXJ5L3NyYy9saWJyYXJ5Lmd5cApAQCAtMjAs NyArMjAsNyBAQAogICAgIH0sCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ2xpYjEnLAot ICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFy eScsCiAgICAgICAnc291cmNlcyc6IFsKICAgICAgICAgJ2xpYjEuYycsCiAgICAgICBdLApAQCAt MzQsNyArMzQsNyBAQAogICAgIH0sCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ2xpYjIn LAotICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0aWNfbGli cmFyeScsCiAgICAgICAnc291cmNlcyc6IFsKICAgICAgICAgJ2xpYjIuYycsCiAgICAgICBdLApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDZkYmY5ZGNlNGVkZDIyZGU1MDBkODY2MGYwN2ZiNWJkM2RlNzJhOWIuLjg4 ODFjY2MyMjkyNTA2NjAwMDVkOWViZDQ0NTllYjExNmZkZjQ2YjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMS0wNS0xOSAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21p dW1dIHJlbW92ZSA8KGxpYnJhcnkpIHZhcmlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTE1OAorCisgICAgICAgIFRoaXMgd2FzIGZvciBhIGJ1 aWxkIGV4cGVyaW1lbnQ7IHdlIGNhbiBqdXN0IHVzZSB0aGUgY29ycmVjdCB2YWx1ZSBub3cuCisK KyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMS0wNS0xOSAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjg2ODY5LCByODY4NzMsIHI4Njg3NSwgYW5kIHI4Njg3Ny4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggMmUwYjUxZDZkNDIzODAzZThkZWQx MmYxZTQwZDc5NzdmNDdjOTViOS4uZjViZWU1Y2ZlMzIyYjgxYTdhOWY0MGYzYjA5NjNlNDE5ZjZh MzQ1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAK KysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTg2MSw3ICs4 NjEsNyBAQAogICAgIH0sCiAgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ3dlYmNvcmVfYmlu ZGluZ3MnLAotICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0 aWNfbGlicmFyeScsCiAgICAgICAnaGFyZF9kZXBlbmRlbmN5JzogMSwKICAgICAgICdkZXBlbmRl bmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX2JpbmRpbmdzX3NvdXJjZXMnLApAQCAtMTIwNiw3 ICsxMjA2LDcgQEAKICAgICB9LAogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3Jl X2h0bWwnLAotICAgICAgJ3R5cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0 aWNfbGlicmFyeScsCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9w cmVyZXF1aXNpdGVzJywKICAgICAgIF0sCkBAIC0xMjI0LDcgKzEyMjQsNyBAQAogICAgIH0sCiAg ICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ3dlYmNvcmVfc3ZnJywKLSAgICAgICd0eXBlJzog JzwobGlicmFyeSknLAorICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAogICAgICAgJ2Rl cGVuZGVuY2llcyc6IFsKICAgICAgICAgJ3dlYmNvcmVfcHJlcmVxdWlzaXRlcycsCiAgICAgICBd LApAQCAtMTI0OCw3ICsxMjQ4LDcgQEAKICAgICB9LAogICAgIHsKICAgICAgICd0YXJnZXRfbmFt ZSc6ICd3ZWJjb3JlX3BsYXRmb3JtJywKLSAgICAgICd0eXBlJzogJzwobGlicmFyeSknLAorICAg ICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAg ICAgICAgJ3dlYmNvcmVfcHJlcmVxdWlzaXRlcycsCiAgICAgICBdLApAQCAtMTQzNSw3ICsxNDM1 LDcgQEAKICAgICB9LAogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX3JlbmRl cmluZycsCi0gICAgICAndHlwZSc6ICc8KGxpYnJhcnkpJywKKyAgICAgICd0eXBlJzogJ3N0YXRp Y19saWJyYXJ5JywKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX3By ZXJlcXVpc2l0ZXMnLAogICAgICAgXSwKQEAgLTE0OTMsNyArMTQ5Myw3IEBACiAgICAgfSwKICAg ICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9yZW1haW5pbmcnLAotICAgICAgJ3R5 cGUnOiAnPChsaWJyYXJ5KScsCisgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCiAgICAg ICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9wcmVyZXF1aXNpdGVzJywKICAg ICAgIF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDRhMjliZTJiZGQxNTRjYmYxYTA0 OWI0N2JlOGMxNTg3MDRiYWI2N2QuLmYzNDYyNTU2OGE5OGRhZGIzNzU0NzcwMTI4OGVkNjI2Zjcw YTIwNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEt MDUtMTkgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSByZW1vdmUgPChsaWJy YXJ5KSB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjExNTgKKworICAgICAgICBUaGlzIHdhcyBmb3IgYSBidWlsZCBleHBlcmltZW50OyB3 ZSBjYW4ganVzdCB1c2UgdGhlIGNvcnJlY3QgdmFsdWUgbm93LgorCisgICAgICAgICogV2ViS2l0 Lmd5cDoKKwogMjAxMS0wNS0xOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg2ODY5LCByODY4NzMs IHI4Njg3NSwgYW5kIHI4Njg3Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v V2ViS2l0Lmd5cCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCA4MWVj OWE0OTExOGI0ZDRmM2RjNzhlOTBkNzA4NWE3MjdmNWRhOTNkLi43MjNlNzFhNTg5ZTBlYzZkODlj ZDlkMTJiZjcxZDY1NGMxNTg3NjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L1dlYktpdC5neXAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCkBAIC00 MywxMSArNDMsOSBAQAogICAgICAgICAgICAgICAgICMgV2Via2l0IGlzIGJlaW5nIGJ1aWx0IG91 dHNpZGUgb2YgdGhlIGZ1bGwgY2hyb21pdW0gcHJvamVjdC4KICAgICAgICAgICAgICAgICAjIGUu Zy4gdmlhIGJ1aWxkLXdlYmtpdCAtLWNocm9taXVtCiAgICAgICAgICAgICAgICAgJ2Nocm9taXVt X3NyY19kaXInOiAnLi4vLi4vV2ViS2l0L2Nocm9taXVtJywKLSAgICAgICAgICAgICAgICAnd2Vi a2l0X3RhcmdldF90eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKICAgICAgICAgICAgIH0sewogICAg ICAgICAgICAgICAgICMgV2ViS2l0IGlzIGNoZWNrZWQgb3V0IGluIHNyYy9jaHJvbWl1bS90aGly ZF9wYXJ0eS9XZWJLaXQKICAgICAgICAgICAgICAgICAnY2hyb21pdW1fc3JjX2Rpcic6ICcuLi8u Li8uLi8uLi8uLicsCi0gICAgICAgICAgICAgICAgJ3dlYmtpdF90YXJnZXRfdHlwZSc6ICc8KGxp YnJhcnkpJywKICAgICAgICAgICAgIH1dLAogICAgICAgICBdLAogICAgICAgICAnYWhlbV9wYXRo JzogJy4uLy4uLy4uL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2ZvbnRzL0FIRU1fX19fLlRURics CkBAIC02Niw2ICs2NCw3IEBACiAgICAgJ3RhcmdldHMnOiBbCiAgICAgICAgIHsKICAgICAgICAg ICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJraXQnLAorICAgICAgICAgICAgJ3R5cGUnOiAnc3RhdGlj X2xpYnJhcnknLAogICAgICAgICAgICAgJ21zdnNfZ3VpZCc6ICc1RUNFQzlFNS04RjIzLTQ3QjYt OTNFMC1DM0IzMjhCM0JFNjUnLAogICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAg ICAgICAgICAgICAnLi4vLi4vV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDp3ZWJjb3Jl JywKQEAgLTY1MCw4ICs2NDksNiBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIF0KICAg ICAgICAgICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgICAgICAgICBdLAotICAgICAg ICAgICAgICAgIH0sIHsKLSAgICAgICAgICAgICAgICAgICAgJ3R5cGUnOiAnPCh3ZWJraXRfdGFy Z2V0X3R5cGUpJwogICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgICAgIFsnT1M9PSJs aW51eCIgb3IgT1M9PSJmcmVlYnNkIicsIHsKICAgICAgICAgICAgICAgICAgICAgJ2RlcGVuZGVu Y2llcyc6IFsK