61156 2011-05-19 17:17:24 -0700 Change RenderLineBoxList::hitTest to use IntPoint 2023-09-05 07:07:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 60318 1 eae eae abarth ap commit-queue eric mitz simon.fraser webkit-bug-importer oldest_to_newest 406765 0 eae 2011-05-19 17:17:24 -0700 Change RenderBlock::hitTestContents to use IntPoint instead of a int x, int y 406766 1 eae 2011-05-19 17:18:25 -0700 Err, Change RenderLineBoxList::hitTest to use IntPoint instead of int x, int y. 406773 2 94151 eae 2011-05-19 17:36:10 -0700 Created attachment 94151 Patch 407532 3 94151 eric 2011-05-21 06:51:20 -0700 Comment on attachment 94151 Patch Oj 407538 4 94151 commit-queue 2011-05-21 08:30:14 -0700 Comment on attachment 94151 Patch Clearing flags on attachment: 94151 Committed r87019: <http://trac.webkit.org/changeset/87019> 407539 5 commit-queue 2011-05-21 08:30:19 -0700 All reviewed patches have been landed. Closing bug. 407545 6 commit-queue 2011-05-21 08:59:08 -0700 The commit-queue encountered the following flaky tests while processing attachment 94151: http/tests/websocket/tests/bad-handshake-crash.html bug 54370 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 1975533 7 webkit-bug-importer 2023-09-05 07:07:38 -0700 <rdar://problem/114980025> 94151 2011-05-19 17:36:10 -0700 2011-05-21 08:30:14 -0700 Patch bug-61156-20110519173609.patch text/plain 5952 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2OTA3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMTkgIEVtaWwgQSBF a2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoYW5nZSBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdCB0byB1 c2UgSW50UG9pbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxMTU2CisKKyAgICAgICAgQ2hhbmdlIHRoZSBSZW5kZXJMaW5lQm94TGlzdCBoaXQgdGVz dGluZyB0byB1c2UgSW50UG9pbnQgYW5kIGNsZWFuIHVwIHRoZSByZWN0IGNhbGN1bGF0aW9uLgor CisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmhpdFRl c3RDb250ZW50cyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6Om5vZGVBdFBvaW50KToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGlu ZUJveExpc3Q6OmhpdFRlc3QpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlz dC5oOgorCiAyMDExLTA1LTE4ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gODY3ODcpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDM1LDcg KzQwMzUsNyBAQCBib29sIFJlbmRlckJsb2NrOjpoaXRUZXN0Q29udGVudHMoY29uc3QgCiB7CiAg ICAgaWYgKGNoaWxkcmVuSW5saW5lKCkgJiYgIWlzVGFibGUoKSkgewogICAgICAgICAvLyBXZSBo YXZlIHRvIGhpdC10ZXN0IG91ciBsaW5lIGJveGVzLgotICAgICAgICBpZiAobV9saW5lQm94ZXMu aGl0VGVzdCh0aGlzLCByZXF1ZXN0LCByZXN1bHQsIHgsIHksIHR4LCB0eSwgaGl0VGVzdEFjdGlv bikpCisgICAgICAgIGlmIChtX2xpbmVCb3hlcy5oaXRUZXN0KHRoaXMsIHJlcXVlc3QsIHJlc3Vs dCwgSW50UG9pbnQoeCwgeSksIHR4LCB0eSwgaGl0VGVzdEFjdGlvbikpCiAgICAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9IGVsc2UgewogICAgICAgICAvLyBIaXQgdGVzdCBvdXIgY2hpbGRy ZW4uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAkocmV2 aXNpb24gODY3ODcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzE0LDcgKzcxNCw3IEBAIGNvbnN0IGNoYXIqIFJlbmRlcklu bGluZTo6cmVuZGVyTmFtZSgpIGMKIGJvb2wgUmVuZGVySW5saW5lOjpub2RlQXRQb2ludChjb25z dCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBJbnRQb2ludCYgcG9pbnRJbkNvbnRhaW5l ciwgaW50IHR4LCBpbnQgdHksIEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikKIHsKLSAgICBy ZXR1cm4gbV9saW5lQm94ZXMuaGl0VGVzdCh0aGlzLCByZXF1ZXN0LCByZXN1bHQsIHBvaW50SW5D b250YWluZXIueCgpLCBwb2ludEluQ29udGFpbmVyLnkoKSwgdHgsIHR5LCBoaXRUZXN0QWN0aW9u KTsKKyAgICByZXR1cm4gbV9saW5lQm94ZXMuaGl0VGVzdCh0aGlzLCByZXF1ZXN0LCByZXN1bHQs IHBvaW50SW5Db250YWluZXIsIHR4LCB0eSwgaGl0VGVzdEFjdGlvbik7CiB9CiAKIFZpc2libGVQ b3NpdGlvbiBSZW5kZXJJbmxpbmU6OnBvc2l0aW9uRm9yUG9pbnQoY29uc3QgSW50UG9pbnQmIHBv aW50KQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpbmVCb3hMaXN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExp c3QuY3BwCShyZXZpc2lvbiA4Njc4NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMaW5lQm94TGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3NCw3ICsyNzQsNyBAQCB2b2lk IFJlbmRlckxpbmVCb3hMaXN0OjpwYWludChSZW5kZXJCb3hNCiB9CiAKIAotYm9vbCBSZW5kZXJM aW5lQm94TGlzdDo6aGl0VGVzdChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVuZGVyZXIsIGNvbnN0 IEhpdFRlc3RSZXF1ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIGludCB4LCBp bnQgeSwgaW50IHR4LCBpbnQgdHksIEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikgY29uc3QK K2Jvb2wgUmVuZGVyTGluZUJveExpc3Q6OmhpdFRlc3QoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJl bmRlcmVyLCBjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYgcmVz dWx0LCBjb25zdCBJbnRQb2ludCYgcG9pbnRJbkNvbnRhaW5lciwgaW50IHR4LCBpbnQgdHksIEhp dFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikgY29uc3QKIHsKICAgICBpZiAoaGl0VGVzdEFjdGlv biAhPSBIaXRUZXN0Rm9yZWdyb3VuZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMjg1LDEz ICsyODUsMTAgQEAgYm9vbCBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdChSZW5kZXJCbwogICAg IGlmICghZmlyc3RMaW5lQm94KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGJvb2wg aXNIb3Jpem9udGFsID0gZmlyc3RMaW5lQm94KCktPmlzSG9yaXpvbnRhbCgpOwotICAgIAotICAg IGludCBsb2dpY2FsUG9pbnRTdGFydCA9IGlzSG9yaXpvbnRhbCA/IHkgLSByZXN1bHQudG9wUGFk ZGluZygpIDogeCAtIHJlc3VsdC5sZWZ0UGFkZGluZygpOwotICAgIGludCBsb2dpY2FsUG9pbnRF bmQgPSAoaXNIb3Jpem9udGFsID8geSArIHJlc3VsdC5ib3R0b21QYWRkaW5nKCkgOiB4ICsgcmVz dWx0LnJpZ2h0UGFkZGluZygpKSArIDE7Ci0gICAgSW50UmVjdCByZWN0KGlzSG9yaXpvbnRhbCA/ IHggOiBsb2dpY2FsUG9pbnRTdGFydCwgaXNIb3Jpem9udGFsID8gbG9naWNhbFBvaW50U3RhcnQg OiB5LAotICAgICAgICAgICAgICAgICBpc0hvcml6b250YWwgPyAxIDogbG9naWNhbFBvaW50RW5k IC0gbG9naWNhbFBvaW50U3RhcnQsCi0gICAgICAgICAgICAgICAgIGlzSG9yaXpvbnRhbCA/IGxv Z2ljYWxQb2ludEVuZCAtIGxvZ2ljYWxQb2ludFN0YXJ0IDogMSk7ICAgIAorICAgIEludFJlY3Qg cmVjdCA9IGZpcnN0TGluZUJveCgpLT5pc0hvcml6b250YWwoKSA/CisgICAgICAgIEludFJlY3Qo cG9pbnRJbkNvbnRhaW5lci54KCksIHBvaW50SW5Db250YWluZXIueSgpIC0gcmVzdWx0LnRvcFBh ZGRpbmcoKSwgMSwgcmVzdWx0LnRvcFBhZGRpbmcoKSArIHJlc3VsdC5ib3R0b21QYWRkaW5nKCkg KyAxKSA6CisgICAgICAgIEludFJlY3QocG9pbnRJbkNvbnRhaW5lci54KCkgLSByZXN1bHQubGVm dFBhZGRpbmcoKSwgcG9pbnRJbkNvbnRhaW5lci55KCksIHJlc3VsdC5yaWdodFBhZGRpbmcoKSAr IHJlc3VsdC5sZWZ0UGFkZGluZygpICsgMSwgMSk7CisKICAgICBpZiAoIWFueUxpbmVJbnRlcnNl Y3RzUmVjdChyZW5kZXJlciwgcmVjdCwgdHgsIHR5KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CkBAIC0zMDEsOSArMjk4LDkgQEAgYm9vbCBSZW5kZXJMaW5lQm94TGlzdDo6aGl0VGVzdChSZW5k ZXJCbwogICAgIGZvciAoSW5saW5lRmxvd0JveCogY3VyciA9IGxhc3RMaW5lQm94KCk7IGN1cnI7 IGN1cnIgPSBjdXJyLT5wcmV2TGluZUJveCgpKSB7CiAgICAgICAgIFJvb3RJbmxpbmVCb3gqIHJv b3QgPSBjdXJyLT5yb290KCk7CiAgICAgICAgIGlmIChyYW5nZUludGVyc2VjdHNSZWN0KHJlbmRl cmVyLCBjdXJyLT5sb2dpY2FsVG9wVmlzdWFsT3ZlcmZsb3cocm9vdC0+bGluZVRvcCgpKSwgY3Vy ci0+bG9naWNhbEJvdHRvbVZpc3VhbE92ZXJmbG93KHJvb3QtPmxpbmVCb3R0b20oKSksIHJlY3Qs IHR4LCB0eSkpIHsKLSAgICAgICAgICAgIGJvb2wgaW5zaWRlID0gY3Vyci0+bm9kZUF0UG9pbnQo cmVxdWVzdCwgcmVzdWx0LCBJbnRQb2ludCh4LCB5KSwgdHgsIHR5LCByb290LT5saW5lVG9wKCks IHJvb3QtPmxpbmVCb3R0b20oKSk7CisgICAgICAgICAgICBib29sIGluc2lkZSA9IGN1cnItPm5v ZGVBdFBvaW50KHJlcXVlc3QsIHJlc3VsdCwgcG9pbnRJbkNvbnRhaW5lciwgdHgsIHR5LCByb290 LT5saW5lVG9wKCksIHJvb3QtPmxpbmVCb3R0b20oKSk7CiAgICAgICAgICAgICBpZiAoaW5zaWRl KSB7Ci0gICAgICAgICAgICAgICAgcmVuZGVyZXItPnVwZGF0ZUhpdFRlc3RSZXN1bHQocmVzdWx0 LCBJbnRQb2ludCh4IC0gdHgsIHkgLSB0eSkpOworICAgICAgICAgICAgICAgIHJlbmRlcmVyLT51 cGRhdGVIaXRUZXN0UmVzdWx0KHJlc3VsdCwgcG9pbnRJbkNvbnRhaW5lciAtIEludFNpemUodHgs IHR5KSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlz dC5oCShyZXZpc2lvbiA4Njc4NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM aW5lQm94TGlzdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCw3IEBAIHB1YmxpYzoKICAg ICB2b2lkIGRpcnR5TGluZXNGcm9tQ2hhbmdlZENoaWxkKFJlbmRlck9iamVjdCogcGFyZW50LCBS ZW5kZXJPYmplY3QqIGNoaWxkKTsKIAogICAgIHZvaWQgcGFpbnQoUmVuZGVyQm94TW9kZWxPYmpl Y3QqLCBQYWludEluZm8mLCBpbnQgeCwgaW50IHkpIGNvbnN0OwotICAgIGJvb2wgaGl0VGVzdChS ZW5kZXJCb3hNb2RlbE9iamVjdCosIGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJlc3Vs dCYsIGludCB4LCBpbnQgeSwgaW50IHR4LCBpbnQgdHksIEhpdFRlc3RBY3Rpb24pIGNvbnN0Owor ICAgIGJvb2wgaGl0VGVzdChSZW5kZXJCb3hNb2RlbE9iamVjdCosIGNvbnN0IEhpdFRlc3RSZXF1 ZXN0JiwgSGl0VGVzdFJlc3VsdCYsIGNvbnN0IEludFBvaW50JiBwb2ludEluQ29udGFpbmVyLCBp bnQgdHgsIGludCB0eSwgSGl0VGVzdEFjdGlvbikgY29uc3Q7CiAgICAgCiBwcml2YXRlOgogICAg IGJvb2wgYW55TGluZUludGVyc2VjdHNSZWN0KFJlbmRlckJveE1vZGVsT2JqZWN0KiwgY29uc3Qg SW50UmVjdCYsIGludCB0eCwgaW50IHR5LCBib29sIHVzZVByaW50UmVjdCA9IGZhbHNlLCBpbnQg b3V0bGluZVNpemUgPSAwKSBjb25zdDsK