61153 2011-05-19 16:10:08 -0700 WebView loses firstResponder status when entering full-screen mode. 2011-05-20 18:41:46 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes sam oldest_to_newest 406716 0 aestes 2011-05-19 16:10:08 -0700 Space button does not play/pause video on apple.com when in full-screen mode. 406729 1 aestes 2011-05-19 16:25:14 -0700 <rdar://problem/9400346> 406736 2 94145 aestes 2011-05-19 16:35:16 -0700 Created attachment 94145 Patch 406838 3 94145 darin 2011-05-19 19:23:03 -0700 Comment on attachment 94145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review > Source/WebKit/mac/Misc/WebNSWindowExtras.m:55 > + if ([responder respondsToSelector:@selector(isDescendantOf:)] > + && [(id)responder isDescendantOf:view]) Should keep this expression all on one line to avoid awkward placement of the (id). I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector. I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that. 407355 4 aestes 2011-05-20 15:22:05 -0700 (In reply to comment #3) > (From update of attachment 94145 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review > > > Source/WebKit/mac/Misc/WebNSWindowExtras.m:55 > > + if ([responder respondsToSelector:@selector(isDescendantOf:)] > > + && [(id)responder isDescendantOf:view]) > > Should keep this expression all on one line to avoid awkward placement of the (id). > > I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector. > > I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that. Thanks Darin. I'll ping Sam for suggestions. 407373 5 aestes 2011-05-20 15:51:21 -0700 Committed r86995: <http://trac.webkit.org/changeset/86995> 407459 6 aestes 2011-05-20 18:41:46 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 94145 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=94145&action=review > > > > > Source/WebKit/mac/Misc/WebNSWindowExtras.m:55 > > > + if ([responder respondsToSelector:@selector(isDescendantOf:)] > > > + && [(id)responder isDescendantOf:view]) > > > > Should keep this expression all on one line to avoid awkward placement of the (id). > > > > I suggest checking isKindOfClass:[NSView class] instead of specifically checking for this selector. > > > > I don’t think it’s really so convenient to have this as an NSWindow method. I would suggest just making a helper function that does this. But I guess you made it a method so you could share with WebKit2. I am not really sure that’s the best practice way to make code you can share with WebKit1 and WebKit2. Might be worth asking Sam about that. > > Thanks Darin. I'll ping Sam for suggestions. Sam suggested I add the helper function to WebCore. I'll do that in a follow-up patch. 94145 2011-05-19 16:35:16 -0700 2011-05-19 19:23:03 -0700 Patch bug-61153-20110519163515.patch text/plain 13582 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogODY3ODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYTljYzZhODRjNTgxMTYz MzY5ODljOTc0ZDk1ODg1YjdjZGViZDI2Li42MTk4YzViNmZkNTkzMGVhYzYyYzIwMTAzYjNiYmQx NjA3NmUwZDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTkgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYlZpZXcgbG9zZXMgZmlyc3RSZXNwb25kZXIgc3RhdHVzIHdo ZW4gZW50ZXJpbmcgZnVsbC1zY3JlZW4gbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMTUzCisKKyAgICAgICAgTm8gdGVzdCBwb3NzaWJsZSB2 aWEgRFJULiBBZGQgYSBtYW51YWwgdGVzdCBpbnN0ZWFkLgorCisgICAgICAgICogbWFudWFsLXRl c3RzL2Z1bGwtc2NyZWVuLWtleXByZXNzLmh0bWw6IEFkZGVkLgorCiAyMDExLTA1LTE4ICBBYmhp c2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QmV0aCBEYWtpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9mdWxs LXNjcmVlbi1rZXlwcmVzcy5odG1sIGIvU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2Z1bGwt c2NyZWVuLWtleXByZXNzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzE2MzA2ZGUzYWEzYmY2N2NmNWQ4OGUy MzU3ZTU3NDkzOGFmMWU1OQotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hbnVh bC10ZXN0cy9mdWxsLXNjcmVlbi1rZXlwcmVzcy5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9D VFlQRSBodG1sPgorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBlbnRlckZ1bGxTY3JlZW4oKSB7Cisg ICAgICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImZ1bGxzY3JlZW4i KTsKKyAgICAgICAgZWxlbWVudC5pbm5lclRleHQgPSAiUHJlc3MgdGhlIHNwYWNlIGJhci4iOwor ICAgICAgICAKKyAgICAgICAgdmFyIGNvbnNvbGVEaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiY29uc29sZSIpOworICAgICAgICBjb25zb2xlRGl2LmlubmVySFRNTCA9ICI8c3BhbiBzdHls ZT0nY29sb3I6cmVkJz5GQUlMPC9zcGFuPiI7CisgICAgICAgIAorICAgICAgICBkb2N1bWVudC5h ZGRFdmVudExpc3RlbmVyKCJrZXlkb3duIiwgZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgICAg IGNvbnNvbGVEaXYuaW5uZXJIVE1MID0gIjxzcGFuIHN0eWxlPSdjb2xvcjpncmVlbic+UEFTUzwv c3Bhbj4iOworICAgICAgICAgICAgZG9jdW1lbnQud2Via2l0Q2FuY2VsRnVsbFNjcmVlbigpOwor ICAgICAgICB9LCB0cnVlKTsKKyAgICAgICAgCisgICAgICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0 ZW5lcigid2Via2l0ZnVsbHNjcmVlbmNoYW5nZSIsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAg ICAgICBpZiAoIWRvY3VtZW50LndlYmtpdElzRnVsbFNjcmVlbikKKyAgICAgICAgICAgICAgICBl bGVtZW50LmlubmVyVGV4dCA9ICIiOworICAgICAgICB9LCBmYWxzZSk7CisgICAgICAgIAorICAg ICAgICBlbGVtZW50LndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKCk7CisgICAgfQorPC9zY3JpcHQ+ Cis8cD5UaGlzIHRlc3QgY2hlY2tzIHRoYXQga2V5Ym9hcmQgZXZlbnRzIGFyZSByZWNlaXZlZCBi eSBhbiBlbGVtZW50IGluIGZ1bGwgc2NyZWVuIG1vZGUuIFRvIHJ1biB0aGUgdGVzdCwgcHJlc3Mg dGhlICdFbnRlciBGdWxsIFNjcmVlbicgYnV0dG9uIHRoZW4gcHJlc3MgdGhlIHNwYWNlIGJhci4g VGhlIHRlc3QgcGFzc2VzIGlmIHRoZSBlbGVtZW50IGV4aXN0cyBmdWxsIHNjcmVlbiBhbmQgeW91 IHNlZSB0aGUgd29yZCAnUEFTUycgYmVsb3cuPC9wPgorPGJ1dHRvbiBvbmNsaWNrPSJlbnRlckZ1 bGxTY3JlZW4oKSI+RW50ZXIgRnVsbCBTY3JlZW48L2J1dHRvbj4KKzxkaXYgaWQ9ImZ1bGxzY3Jl ZW4iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwppbmRleCA3ODQ4OWI2MWUyMjA5MTJlZTQ3NjIzNzJmZDZiMzA2MTM0ZmU2 OWEzLi43NGUzMTM2MWNhNzFhOWJkYWEzOTYzMjQxMmU3MDQwNWQzOGY3ZDllIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDExLTA1LTE5ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJW aWV3IGxvc2VzIGZpcnN0UmVzcG9uZGVyIHN0YXR1cyB3aGVuIGVudGVyaW5nIGZ1bGwtc2NyZWVu IG1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MTE1MworCisgICAgICAgICogV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6IEV4cG9y dCBXZWJOU1dpbmRvd0V4dHJhcy5oIGFzIGEKKyAgICAgICAgcHJpdmF0ZSBoZWFkZXIgc28gdGhh dCBXZWJLaXQyIGNhbiBpbmNsdWRlIGl0LgorCiAyMDExLTA1LTE2ICBEYW4gQmVybnN0ZWluICA8 bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgTm8gbmVlZCB0byBjb21waWxlIC5qcyBmaWxlcywg dGhhdCBpcyB3aGF0IHRoZSBKSVQgaXMgZm9yLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9X ZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggNjg4OTM4YWEyYWJiYjkwMzA3NzBhZGRjNTY5 NzE1MTNiOTVhZmY2ZS4uYWQwNjBlY2QxYzFhZjMzMDFkNzAzYWVhNWU3NmE5N2ZmNzgwNDdlYSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv agorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBA IC0xNzAsNyArMTcwLDcgQEAKIAkJOTM5ODEwMjIwODI0QkYwMTAwOERGMDM4IC8qIFdlYk5TSW1h Z2VFeHRyYXMuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IDgzOTg4NDdBMDM0MjZGQjAwMEJDNUY1RSAvKiBXZWJOU0ltYWdlRXh0cmFzLmggKi87IH07CiAJ CTkzOTgxMDIzMDgyNEJGMDEwMDhERjAzOCAvKiBXZWJOU1Bhc3RlYm9hcmRFeHRyYXMuaCBpbiBI ZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEVEMkIyNDc0MDMzQTJE QTgwMEMxQTUyNiAvKiBXZWJOU1Bhc3RlYm9hcmRFeHRyYXMuaCAqLzsgc2V0dGluZ3MgPSB7QVRU UklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OwogCQk5Mzk4MTAyNDA4MjRCRjAxMDA4REYwMzgg LyogV2ViTlNWaWV3RXh0cmFzLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSBGNTA4OTQ2OTAyQjcxRDU5MDE4QTlDRDQgLyogV2ViTlNWaWV3RXh0cmFzLmgg Ki87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwgKTsgfTsgfTsKLQkJOTM5ODEw MjUwODI0QkYwMTAwOERGMDM4IC8qIFdlYk5TV2luZG93RXh0cmFzLmggaW4gSGVhZGVycyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA5MzQ1RERBRTAzNjVGQjI3MDA4NjM1Q0Ug LyogV2ViTlNXaW5kb3dFeHRyYXMuaCAqLzsgfTsKKwkJOTM5ODEwMjUwODI0QkYwMTAwOERGMDM4 IC8qIFdlYk5TV2luZG93RXh0cmFzLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZp bGU7IGZpbGVSZWYgPSA5MzQ1RERBRTAzNjVGQjI3MDA4NjM1Q0UgLyogV2ViTlNXaW5kb3dFeHRy YXMuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OwogCQk5 Mzk4MTAyNzA4MjRCRjAxMDA4REYwMzggLyogV2ViU3RyaW5nVHJ1bmNhdG9yLmggaW4gSGVhZGVy cyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBGNTk2NjhDODAyQUQyOTIzMDE4 NjM1Q0EgLyogV2ViU3RyaW5nVHJ1bmNhdG9yLmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMg PSAoUHJpdmF0ZSwgKTsgfTsgfTsKIAkJOTM5ODEwMjkwODI0QkYwMTAwOERGMDM4IC8qIFdlYkF1 dGhlbnRpY2F0aW9uUGFuZWwuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsg ZmlsZVJlZiA9IEY4Q0ExNUI1MDI5QTM5RDkwMTAwMDEyMiAvKiBXZWJBdXRoZW50aWNhdGlvblBh bmVsLmggKi87IH07CiAJCTkzOTgxMDJBMDgyNEJGMDEwMDhERjAzOCAvKiBXZWJQYW5lbEF1dGhl bnRpY2F0aW9uSGFuZGxlci5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBm aWxlUmVmID0gOTMxNTRFRjEwM0E0MTI3MDAwODYzNUNFIC8qIFdlYlBhbmVsQXV0aGVudGljYXRp b25IYW5kbGVyLmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwgKTsgfTsg fTsKQEAgLTE0NjgsNiArMTQ2OCw3IEBACiAJCQkJNTFDQkZDQUQwRDEwRTZDNTAwMkRCRjUxIC8q IFdlYkNhY2hlZEZyYW1lUGxhdGZvcm1EYXRhLmggaW4gSGVhZGVycyAqLywKIAkJCQkxNEQ4MjUy RjBBRjk1NTA5MDAwNEYwNTcgLyogV2ViQ2hyb21lQ2xpZW50LmggaW4gSGVhZGVycyAqLywKIAkJ CQk5Mzk4MTA0OTA4MjRCRjAxMDA4REYwMzggLyogV2ViQ2xpcFZpZXcuaCBpbiBIZWFkZXJzICov LAorCQkJCTkzOTgxMDI1MDgyNEJGMDEwMDhERjAzOCAvKiBXZWJOU1dpbmRvd0V4dHJhcy5oIGlu IEhlYWRlcnMgKi8sCiAJCQkJMDY1QUQ1QTMwQjBDMzJDNzAwNUEyQjFEIC8qIFdlYkNvbnRleHRN ZW51Q2xpZW50LmggaW4gSGVhZGVycyAqLywKIAkJCQk5Mzk4MTAxNjA4MjRCRjAxMDA4REYwMzgg LyogV2ViQ29yZVN0YXRpc3RpY3MuaCBpbiBIZWFkZXJzICovLAogCQkJCTUxQUVERUYxMENFQ0Y0 NTcwMDg1NDMyOCAvKiBXZWJEYXRhYmFzZU1hbmFnZXJJbnRlcm5hbC5oIGluIEhlYWRlcnMgKi8s CkBAIC0xNTgxLDcgKzE1ODIsNiBAQAogCQkJCTY1RTBGODg0MDg1MDA5MTcwMDdFNUNCOSAvKiBX ZWJOU1VSTFJlcXVlc3RFeHRyYXMuaCBpbiBIZWFkZXJzICovLAogCQkJCTY1RTBGOUU2MDg1MDBG MjMwMDdFNUNCOSAvKiBXZWJOU1VzZXJEZWZhdWx0c0V4dHJhcy5oIGluIEhlYWRlcnMgKi8sCiAJ CQkJOTM5ODEwMjQwODI0QkYwMTAwOERGMDM4IC8qIFdlYk5TVmlld0V4dHJhcy5oIGluIEhlYWRl cnMgKi8sCi0JCQkJOTM5ODEwMjUwODI0QkYwMTAwOERGMDM4IC8qIFdlYk5TV2luZG93RXh0cmFz LmggaW4gSGVhZGVycyAqLywKIAkJCQk5Mzk4MTAyQTA4MjRCRjAxMDA4REYwMzggLyogV2ViUGFu ZWxBdXRoZW50aWNhdGlvbkhhbmRsZXIuaCBpbiBIZWFkZXJzICovLAogCQkJCTM3QjZGQjRFMTA2 MzUzMEMwMDBGREIzQiAvKiBXZWJQREZEb2N1bWVudEV4dHJhcy5oIGluIEhlYWRlcnMgKi8sCiAJ CQkJOTM5ODEwQTUwODI0QkYwMTAwOERGMDM4IC8qIFdlYlBERlJlcHJlc2VudGF0aW9uLmggaW4g SGVhZGVycyAqLywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCA0OTcxZTFlOTAyZTMyMWU4ZWIwZWQ0OGYw ZjI2ZWI4OGJhZWUwODJmLi40ZWQ1OWEzN2FlZDA1OGExZWM5YmJlM2RmMWNjNmIxYTBkZmI4Y2Q5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDUtMTkgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYlZpZXcgbG9zZXMgZmlyc3RSZXNwb25kZXIgc3RhdHVzIHdoZW4g ZW50ZXJpbmcgZnVsbC1zY3JlZW4gbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYxMTUzCisKKyAgICAgICAgKiBNaXNjL1dlYk5TV2luZG93RXh0 cmFzLmg6CisgICAgICAgICogTWlzYy9XZWJOU1dpbmRvd0V4dHJhcy5tOgorICAgICAgICAoLVtO U1dpbmRvdyBtYWtlUmVzcG9uZGVyOmZpcnN0UmVzcG9uZGVySWZEZXNjZW5kYW50T2ZWaWV3Ol0p OiBBZGQgYQorICAgICAgICBjb252ZW5pZW5jZSBtZXRob2QgdG8gTlNXaW5kb3cgdGhhdCBtYWtl cyB0aGUgZ2l2ZW4gTlNSZXNwb25kZXIgZmlyc3QKKyAgICAgICAgcmVzcG9uZGVyIG9ubHkgaWYg aXQgaXMgYSBkZXNjZW5kYW50IG9mIHRoZSBnaXZlbiB2aWV3LgorICAgICAgICAqIFdlYlZpZXcv V2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dlYkZ1bGxTY3JlZW5Db250 cm9sbGVyIHdpbmRvd0RpZEVudGVyRnVsbHNjcmVlbjpdKTogSWYgdGhlIFdlYlZpZXcKKyAgICAg ICAgd2FzIGEgZGVzY2VuZGFudCBvZiB0aGUgYnJvd3NlciB3aW5kb3cncyBmaXJzdCByZXNwb25k ZXIgd2hlbiBlbnRlcmluZworICAgICAgICBmdWxsLXNjcmVlbiBtb2RlLCBzZXQgdGhlIGZ1bGwt c2NyZWVuIHdpbmRvdydzIGZpcnN0IHJlc3BvbmRlciB0byB0aGF0CisgICAgICAgIHNhbWUgTlNS ZXNwb25kZXIuCisgICAgICAgICgtW1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyIGV4aXRGdWxsc2Ny ZWVuXSk6IERvIHRoZSByZXZlcnNlIG9mIHdoYXQgaXMKKyAgICAgICAgZG9uZSBpbiB3aW5kb3dE aWRFbnRlckZ1bGxzY3JlZW46LgorCiAyMDExLTA1LTE2ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNXaW5kb3dFeHRyYXMuaCBiL1NvdXJjZS9X ZWJLaXQvbWFjL01pc2MvV2ViTlNXaW5kb3dFeHRyYXMuaAppbmRleCAwYWViZDRmOTIxYTM4NTBh OWY3MzA2OTgwYjE2OTJkYjZiZjE5YWE4Li5lNmUxYjAxNDY3MzlkMDM0ZmM4ZGJjYTcyMWU3N2Ey Yzg1YzYzNmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TV2luZG93 RXh0cmFzLmgKKysrIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJOU1dpbmRvd0V4dHJhcy5o CkBAIC0zMCw1ICszMCw2IEBACiAKIEBpbnRlcmZhY2UgTlNXaW5kb3cgKFdlYkV4dHJhcykKIC8v IGNlbnRlcnMgInZpc3VhbGx5IiwgcHV0dGluZyAxLzMgb2YgdGhlIHJlbWFpbmluZyBzcGFjZSBh Ym92ZSwgYW5kIDIvMyBiZWxvdwotLSAodm9pZCljZW50ZXJPdmVyTWFpbldpbmRvdzsgCistICh2 b2lkKWNlbnRlck92ZXJNYWluV2luZG93OworLSAodm9pZCltYWtlUmVzcG9uZGVyOihOU1Jlc3Bv bmRlciAqKXJlc3BvbmRlciBmaXJzdFJlc3BvbmRlcklmRGVzY2VuZGFudE9mVmlldzooTlNWaWV3 ICopdmlldzsKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNX aW5kb3dFeHRyYXMubSBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNXaW5kb3dFeHRyYXMu bQppbmRleCBlZjI3YjEzYTdhZGY1MDY3OTQxMDI5ZjMyOWQ2NjE5MWY1OTBlOWI3Li44ZjkzMzZj MGYzNGU5MGQ0M2VmNDk4OGZhMzAzNTNlMjEwYTg3MWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L21hYy9NaXNjL1dlYk5TV2luZG93RXh0cmFzLm0KKysrIGIvU291cmNlL1dlYktpdC9tYWMv TWlzYy9XZWJOU1dpbmRvd0V4dHJhcy5tCkBAIC00OSw0ICs0OSwxMSBAQCAtICh2b2lkKWNlbnRl ck92ZXJNYWluV2luZG93CiAgICAgW3NlbGYgc2V0RnJhbWVPcmlnaW46b3JpZ2luXTsKIH0KIAor LSAodm9pZCltYWtlUmVzcG9uZGVyOihOU1Jlc3BvbmRlciAqKXJlc3BvbmRlciBmaXJzdFJlc3Bv bmRlcklmRGVzY2VuZGFudE9mVmlldzooTlNWaWV3ICopdmlldworeworICAgIGlmIChbcmVzcG9u ZGVyIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoaXNEZXNjZW5kYW50T2Y6KV0KKyAgICAg ICAgJiYgWyhpZClyZXNwb25kZXIgaXNEZXNjZW5kYW50T2Y6dmlld10pCisgICAgICAgIFtzZWxm IG1ha2VGaXJzdFJlc3BvbmRlcjpyZXNwb25kZXJdOworfQorCiBAZW5kCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tIGIvU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGdWxsU2NyZWVuQ29udHJvbGxlci5tbQppbmRleCBk YTcwMDlhNWRkYTUzODM3ODIwNzlkNDAxOWVhZTdmN2E5N2FlZmJkLi4xMjM1MGIzZTE1ODhhOWZl YzRlMzAxYjZlN2NlZDI4NzZhM2U0NjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkZ1bGxTY3JlZW5Db250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIubW0KQEAgLTI3LDYgKzI3LDcgQEAKIAog I2ltcG9ydCAiV2ViRnVsbFNjcmVlbkNvbnRyb2xsZXIuaCIKIAorI2ltcG9ydCAiV2ViTlNXaW5k b3dFeHRyYXMuaCIKICNpbXBvcnQgIldlYlByZWZlcmVuY2VzUHJpdmF0ZS5oIgogI2ltcG9ydCAi V2ViV2luZG93QW5pbWF0aW9uLmgiCiAjaW1wb3J0ICJXZWJWaWV3SW50ZXJuYWwuaCIKQEAgLTI3 Myw2ICsyNzQsNyBAQCBwcml2YXRlOgogCiAgICAgICAgIFdlYlZpZXcgKndlYlZpZXcgPSBbc2Vs ZiB3ZWJWaWV3XTsKICAgICAgICAgTlNXaW5kb3cgKndlYldpbmRvdyA9IFt3ZWJWaWV3IHdpbmRv d107CisgICAgICAgIE5TUmVzcG9uZGVyICp3ZWJXaW5kb3dGaXJzdFJlc3BvbmRlciA9IFt3ZWJX aW5kb3cgZmlyc3RSZXNwb25kZXJdOwogCiAgICAgICAgIC8vIERvIG5vdCBzd2FwIHRoZSBwbGFj ZWhvbGRlciBpbnRvIHBsYWNlIGlmIGFscmVhZHkgaXMgaW4gYSB3aW5kb3csCiAgICAgICAgIC8v IGFzc3VtaW5nIHRoZSBwbGFjZWhvbGRlcidzIHdpbmRvdyB3aWxsIGFsd2F5cyBiZSB0aGUgd2Vi VmlldydzIApAQCAtMjg0LDYgKzI4Niw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBbW3dlYlZp ZXcgc3VwZXJ2aWV3XSByZXBsYWNlU3Vidmlldzp3ZWJWaWV3IHdpdGg6X3BsYWNlaG9sZGVyVmll d107CiAgICAgICAgICAgICAKICAgICAgICAgICAgIFtbW3NlbGYgd2luZG93XSBjb250ZW50Vmll d10gYWRkU3Vidmlldzp3ZWJWaWV3XTsKKyAgICAgICAgICAgIFtbc2VsZiB3aW5kb3ddIG1ha2VS ZXNwb25kZXI6d2ViV2luZG93Rmlyc3RSZXNwb25kZXIgZmlyc3RSZXNwb25kZXJJZkRlc2NlbmRh bnRPZlZpZXc6d2ViVmlld107CiAgICAgICAgICAgICBbd2ViVmlldyBzZXRBdXRvcmVzaXppbmdN YXNrOk5TVmlld1dpZHRoU2l6YWJsZXxOU1ZpZXdIZWlnaHRTaXphYmxlXTsKICAgICAgICAgICAg IFt3ZWJWaWV3IHNldEZyYW1lOlsoTlNWaWV3ICopW1tzZWxmIHdpbmRvd10gY29udGVudFZpZXdd IGJvdW5kc11dOwogICAgICAgICB9CkBAIC01MjMsMTAgKzUyNiwxMiBAQCBwcml2YXRlOgogICAg IGlmIChfcGxhY2Vob2xkZXJWaWV3ICYmIFtfcGxhY2Vob2xkZXJWaWV3IHdpbmRvd10pIHsKICAg ICAgICAgLy8gTW92ZSB0aGUgd2ViVmlldyBiYWNrIHRvIGl0cyBvd24gbmF0aXZlIHdpbmRvdzoK ICAgICAgICAgV2ViVmlldyogd2ViVmlldyA9IFtzZWxmIHdlYlZpZXddOworICAgICAgICBOU1Jl c3BvbmRlciAqZnVsbFNjcmVlbldpbmRvd0ZpcnN0UmVzcG9uZGVyID0gW1tzZWxmIHdpbmRvd10g Zmlyc3RSZXNwb25kZXJdOwogICAgICAgICBbd2ViVmlldyBzZXRGcmFtZTpbX3BsYWNlaG9sZGVy VmlldyBmcmFtZV1dOwogICAgICAgICBbd2ViVmlldyBzZXRBdXRvcmVzaXppbmdNYXNrOltfcGxh Y2Vob2xkZXJWaWV3IGF1dG9yZXNpemluZ01hc2tdXTsKICAgICAgICAgW3dlYlZpZXcgcmVtb3Zl RnJvbVN1cGVydmlld107CiAgICAgICAgIFtbX3BsYWNlaG9sZGVyVmlldyBzdXBlcnZpZXddIHJl cGxhY2VTdWJ2aWV3Ol9wbGFjZWhvbGRlclZpZXcgd2l0aDp3ZWJWaWV3XTsKKyAgICAgICAgW1t3 ZWJWaWV3IHdpbmRvd10gbWFrZVJlc3BvbmRlcjpmdWxsU2NyZWVuV2luZG93Rmlyc3RSZXNwb25k ZXIgZmlyc3RSZXNwb25kZXJJZkRlc2NlbmRhbnRPZlZpZXc6d2ViVmlld107CiAgICAgICAgIAog ICAgICAgICBOU1dpbmRvdyAqd2ViV2luZG93ID0gW1tzZWxmIHdlYlZpZXddIHdpbmRvd107CiAj aWYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdfT05f U05PV19MRU9QQVJEKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDM4Mzg1ZDhhZWNmNDhmMTZjY2Q4MzdhMGE1MWE2 NjMzZjIwYTJlNDYuLjlkZWJhNjQ2YjQxZjIwMGQzZmJmMzkyNDVkMmRlM2NmZGYzYmZkNDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wNS0xOSAgQW5keSBFc3RlcyAgPGFlc3Rl c0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViVmlldyBsb3NlcyBmaXJzdFJlc3BvbmRlciBzdGF0dXMgd2hlbiBlbnRlcmluZyBm dWxsLXNjcmVlbiBtb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjExNTMKKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2lu ZG93Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ciBmaW5pc2hlZEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbjpdKTogSWYKKyAgICAgICAgdGhlIFdl YlZpZXcgd2FzIGEgZGVzY2VuZGFudCBvZiB0aGUgYnJvd3NlciB3aW5kb3cncyBmaXJzdCByZXNw b25kZXIKKyAgICAgICAgd2hlbiBlbnRlcmluZyBmdWxsLXNjcmVlbiBtb2RlLCBzZXQgdGhlIGZ1 bGwtc2NyZWVuIHdpbmRvdydzIGZpcnN0CisgICAgICAgIHJlc3BvbmRlciB0byB0aGF0IHNhbWUg TlNSZXNwb25kZXIuCisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgYmVn YW5FeGl0RnVsbFNjcmVlbkFuaW1hdGlvbl0pOiBEbyB0aGUKKyAgICAgICAgcmV2ZXJzZSBvZiB3 aGF0IGlzIGRvbmUgaW4gZmluaXNoZWRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb246LgorCiAyMDEx LTA1LTE4ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KaW5kZXggYjE1YWJhY2IwM2Yx YzdlZGIzYTU4ZDBiYjdkMGE2MDFiMzY1NmFmMi4uODE5MDNjYmJjNTNhZThlZDdkMzU0MmU3NDU2 MWIyMmE2ZjRjNzk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9X S0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtMzksNiArMzksNyBA QAogI2ltcG9ydCA8UXVhcnR6Q29yZS9RdWFydHpDb3JlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0Zs b2F0UmVjdC5oPgogI2ltcG9ydCA8V2ViQ29yZS9JbnRSZWN0Lmg+CisjaW1wb3J0IDxXZWJLaXQv V2ViTlNXaW5kb3dFeHRyYXMuaD4KICNpbXBvcnQgPFdlYktpdFN5c3RlbUludGVyZmFjZS5oPgog CiBzdGF0aWMgY29uc3QgTlNUaW1lSW50ZXJ2YWwgdGlja2xlVGltZXJJbnRlcnZhbCA9IDEuMDsK QEAgLTI0OCwxMiArMjQ5LDE2IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgICAgICAv LyBTd2FwIHRoZSB3ZWJWaWV3IHBsYWNlaG9sZGVyIGludG8gcGxhY2UuCiAgICAgICAgIGlmICgh X3dlYlZpZXdQbGFjZWhvbGRlcikKICAgICAgICAgICAgIF93ZWJWaWV3UGxhY2Vob2xkZXIuYWRv cHROUyhbW05TVmlldyBhbGxvY10gaW5pdF0pOworCisgICAgICAgIE5TUmVzcG9uZGVyICp3ZWJX aW5kb3dGaXJzdFJlc3BvbmRlciA9IFtbX3dlYlZpZXcgd2luZG93XSBmaXJzdFJlc3BvbmRlcl07 CisKICAgICAgICAgW3NlbGYgX3N3YXBWaWV3Ol93ZWJWaWV3IHdpdGg6X3dlYlZpZXdQbGFjZWhv bGRlci5nZXQoKV07CiAgICAgICAgIAogICAgICAgICAvLyBUaGVuIGluc2VydCB0aGUgV2ViVmll dyBpbnRvIHRoZSBmdWxsIHNjcmVlbiB3aW5kb3cKICAgICAgICAgTlNWaWV3KiBjb250ZW50Vmll dyA9IFtbc2VsZiBfZnVsbFNjcmVlbldpbmRvd10gY29udGVudFZpZXddOwogICAgICAgICBbY29u dGVudFZpZXcgYWRkU3Vidmlldzpfd2ViVmlldyBwb3NpdGlvbmVkOk5TV2luZG93QmVsb3cgcmVs YXRpdmVUbzpfbGF5ZXJIb3N0aW5nVmlldy5nZXQoKV07CiAgICAgICAgIFtfd2ViVmlldyBzZXRG cmFtZTpbY29udGVudFZpZXcgYm91bmRzXV07CisgICAgICAgIFtbc2VsZiB3aW5kb3ddIG1ha2VS ZXNwb25kZXI6d2ViV2luZG93Rmlyc3RSZXNwb25kZXIgZmlyc3RSZXNwb25kZXJJZkRlc2NlbmRh bnRPZlZpZXc6X3dlYlZpZXddOwogCiAgICAgICAgIFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsKICAg ICAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFjdGlvbnM6WUVTXTsKQEAgLTMwNSw3ICsz MTAsOSBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICAKICAgICAvLyBTd2FwIHRoZSB3 ZWJWaWV3IGJhY2sgaW50byBpdHMgb3JpZ2luYWwgcG9zaXRpb246CiAgICAgaWYgKFtfd2ViVmll dyB3aW5kb3ddID09IFtzZWxmIHdpbmRvd10pIHsKKyAgICAgICAgTlNSZXNwb25kZXIgKmZ1bGxT Y3JlZW5XaW5kb3dGaXJzdFJlc3BvbmRlciA9IFtbc2VsZiBfZnVsbFNjcmVlbldpbmRvd10gZmly c3RSZXNwb25kZXJdOwogICAgICAgICBbc2VsZiBfc3dhcFZpZXc6X3dlYlZpZXdQbGFjZWhvbGRl ci5nZXQoKSB3aXRoOl93ZWJWaWV3XTsKKyAgICAgICAgW1tfd2ViVmlldyB3aW5kb3ddIG1ha2VS ZXNwb25kZXI6ZnVsbFNjcmVlbldpbmRvd0ZpcnN0UmVzcG9uZGVyIGZpcnN0UmVzcG9uZGVySWZE ZXNjZW5kYW50T2ZWaWV3Ol93ZWJWaWV3XTsKICAgICAgICAgTlNXaW5kb3cqIHdlYldpbmRvdyA9 IFtfd2ViVmlldyB3aW5kb3ddOwogI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX0xFT1BBUkQpICYm ICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKICAgICAgICAgLy8gSW4gTGlvbiwg TlNXaW5kb3cgd2lsbCBhbmltYXRlIGludG8gYW5kIG91dCBvZiBvcmRlck91dCBvcGVyYXRpb25z LiBTdXBwcmVzcyB0aGF0Cg==