61132 2011-05-19 10:48:07 -0700 fix render overflow computation for input type=range 2011-05-24 14:01:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59644 1 tony tony ademar hyatt jamesr mitz oldest_to_newest 406517 0 tony 2011-05-19 10:48:07 -0700 fix render overflow computation for input type=range 406520 1 94089 tony 2011-05-19 10:51:56 -0700 Created attachment 94089 Patch 406528 2 94092 tony 2011-05-19 11:11:20 -0700 Created attachment 94092 Patch 406529 3 tony 2011-05-19 11:11:55 -0700 (In reply to comment #2) > Created an attachment (id=94092) [details] > Patch I moved the call to m_overflow.clear() to be outside the thumb check. It's possible for the thumb to be remove and the overflow not cleared. 406619 4 94092 jamesr 2011-05-19 13:44:20 -0700 Comment on attachment 94092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94092&action=review Test is (theoretically at least) flaky > LayoutTests/fast/forms/slider-hit-testing.html:1 > +<head> <!DOCTYPE html> plz unless this test needs quirks mode > LayoutTests/fast/forms/slider-hit-testing.html:11 > +window.setTimeout(function() { > + document.getElementById("slider").style.width = "100%"; > + changeAndCheckRangeValue(); > +}, 0); the setTimeout is a bit odd - does the test not work if you run this code in an onload handler? technically speaking, this setTimeout _could_ execute immediately after parsing the end of the <script> and before the <input> is parsed, although in practice we'll nearly always parse through the end of this document before running timeouts. > LayoutTests/fast/forms/slider-hit-testing.html:20 > + var x = slider.offsetLeft + (slider.clientWidth * .75); > + var y = slider.offsetTop + (slider.clientHeight / 2); could you add some comments indicating what you are trying to click on here and what should be happening? 406629 5 94112 tony 2011-05-19 14:07:17 -0700 Created attachment 94112 Patch 406631 6 94092 tony 2011-05-19 14:08:23 -0700 Comment on attachment 94092 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94092&action=review >> LayoutTests/fast/forms/slider-hit-testing.html:1 >> +<head> > > <!DOCTYPE html> plz unless this test needs quirks mode Done. >> LayoutTests/fast/forms/slider-hit-testing.html:11 >> +}, 0); > > the setTimeout is a bit odd - does the test not work if you run this code in an onload handler? technically speaking, this setTimeout _could_ execute immediately after parsing the end of the <script> and before the <input> is parsed, although in practice we'll nearly always parse through the end of this document before running timeouts. I didn't work in the onload handler, but I added a call to document.body.offsetLeft to force a layout. This allowed me to remove the waitUntilDone/notifyDone calls. >> LayoutTests/fast/forms/slider-hit-testing.html:20 >> + var y = slider.offsetTop + (slider.clientHeight / 2); > > could you add some comments indicating what you are trying to click on here and what should be happening? Done. 408580 7 94112 jamesr 2011-05-23 19:24:58 -0700 Comment on attachment 94112 Patch Looks good! 408983 8 tony 2011-05-24 10:44:04 -0700 Committed r87168: <http://trac.webkit.org/changeset/87168> 409189 9 ademar 2011-05-24 14:01:49 -0700 Revision r87168 cherry-picked into qtwebkit-2.2 with commit 49b8a1e <http://gitorious.org/webkit/qtwebkit/commit/49b8a1e> 94089 2011-05-19 10:51:56 -0700 2011-05-19 11:11:16 -0700 Patch bug-61132-20110519105120.patch text/plain 4028 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODY4NDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMGRiYTY5ODQzZmY2NTA3ZDkwNzhj MDRiZjgyNGNhY2M5NTA4Y2VkLi4wNjVjNzdmMGM5ZWZmZGQ0NmEyMjFmNzZmMWI3M2IwYWJkZWJm ZjdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTkgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmaXggcmVuZGVyIG92ZXJmbG93IGNvbXB1dGF0aW9uIGZvciBpbnB1dCB0eXBlPXJh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTEz MgorCisgICAgICAgICogZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sOiBB ZGRlZC4KKwogMjAxMS0wNS0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gU2tpcCBmYWlsaW5nIHRlc3RzIGFmdGVyIHI4NjgzNC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43NzIzNzlhNTYyNGI5MjBjODgyNjRlNzI3MDY5ODFiYjI3MzZkMWFk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRl c3RpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorQ2xpY2tpbmcgb24gdGhlIHJpZ2h0 IHNpZGUgb2Ygc2xpZGVyIHNob3VsZCBjYXVzZSB0aGUgdGh1bWIgdG8gbW92ZS4KKworCitQQVNT RUQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5n Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmQ2YWFhY2VhZjRiYjc0YjliYzQ0YjNhZDU5MTgwNTc2YWNmOGU4ODYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5o dG1sCkBAIC0wLDAgKzEsMzYgQEAKKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25l KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCit3aW5kb3cu c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNsaWRl ciIpLnN0eWxlLndpZHRoID0gIjEwMCUiOworICBjaGFuZ2VBbmRDaGVja1JhbmdlVmFsdWUoKTsK K30sIDApOworCitmdW5jdGlvbiBjaGFuZ2VBbmRDaGVja1JhbmdlVmFsdWUoKQoreworICAgIGlm ICghd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICByZXR1cm47CisKKyAgICB2 YXIgc2xpZGVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNsaWRlciIpOworICAgIHZhciB4 ID0gc2xpZGVyLm9mZnNldExlZnQgKyAoc2xpZGVyLmNsaWVudFdpZHRoICogLjc1KTsKKyAgICB2 YXIgeSA9IHNsaWRlci5vZmZzZXRUb3AgKyAoc2xpZGVyLmNsaWVudEhlaWdodCAvIDIpOworICAg IGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93 bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKworICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJyZXN1bHRzIikuaW5uZXJUZXh0ID0gKHNsaWRlci52YWx1ZSA9PSAzKSA/ICJQQVNT RUQiIDogIkZBSUxFRCI7CisKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHk+Cis8cD5DbGlja2luZyBvbiB0aGUgcmln aHQgc2lkZSBvZiBzbGlkZXIgc2hvdWxkIGNhdXNlIHRoZSB0aHVtYiB0byBtb3ZlLjwvcD4KKzxp bnB1dCBpZD0ic2xpZGVyIiB0eXBlPSJyYW5nZSIgc3R5bGU9ImhlaWdodDogMTBweDsgbWFyZ2lu OiAwIiBtaW49IjEiIG1heD0iMyI+Cis8ZGl2IGlkPSJyZXN1bHRzIj48L2Rpdj4KKzwvYm9keT4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMTM3YWUwMjI1YTVhZjRjYWJhODVlYjQwM2NmYTg2M2I1YTE5NDAzLi4z NmI3Njk5M2VlMjdjODFlM2E2MWJkNThhMWViMDdiOGQwZWRjYjRkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMTEtMDUtMTkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaXggcmVu ZGVyIG92ZXJmbG93IGNvbXB1dGF0aW9uIGZvciBpbnB1dCB0eXBlPXJhbmdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTEzMgorCisgICAgICAgIFRl c3Q6IGZhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLmh0bWwKKworICAgICAgICBXZSBuZWVk IHRvIGNsZWFyIG1fb3ZlcmZsb3cgb3RoZXJ3aXNlIHdlIHVzZSB0aGUgZmlyc3QKKyAgICAgICAg c2l6ZSBvZiB0aGUgc2xpZGVyIGZvciBoaXQgdGVzdGluZyAoaS5lLiwgY2hhbmdlcyB0byB0aGUg c2l6ZQorICAgICAgICBjYXVzZSBwcm9ibGVtcykuICBUaGlzIG9ubHkgc2hvd3MgdXAgaWYgdGhl IHRodW1iIGlzbid0IGNvbnRhaW5lZAorICAgICAgICBpbiB0aGUgYm91bmRzIG9mIHRoZSBzbGlk ZXIuICBNYWtpbmcgdGhlIHJhbmdlIGhhdmUgYSBzbWFsbGVyIGhlaWdodAorICAgICAgICB0aGFu IHRoZSB0aHVtYiBzaG93cyB0aGUgYnVnLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNs aWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTbGlkZXI6OmxheW91dCk6IENsZWFy IHRoZSBvdmVyZmxvdyBkdXJpbmcgbGF5b3V0CisgICAgICAgICAgICBzbyB3ZSByZS1jb21wdXRl IHRoZSBvdmVyZmxvdyBiYXNlZCBvbiB0aGUgY3VycmVudCBzaXplIG9mIHRoZQorICAgICAgICAg ICAgc2xpZGVyLgorCiAyMDExLTA1LTE5ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNsaWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNwcAppbmRleCAwN2QzMjVlZDE3ZjA4MTI4ZGFkYWIz YzM5OGIwOWQ1ODgzZmI2MzEyLi4zOTRhYTNkM2M4OTBhOGI4MzE3NDFlZjAwYTQxNGE0MDFmOWMz NWQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNwcApAQCAtMTY5 LDYgKzE2OSw3IEBAIHZvaWQgUmVuZGVyU2xpZGVyOjpsYXlvdXQoKQogICAgICAgICAgICAgdGh1 bWItPnJlcGFpbnREdXJpbmdMYXlvdXRJZk1vdmVkKG9sZFRodW1iUmVjdCk7CiAKICAgICAgICAg c3RhdGVQdXNoZXIucG9wKCk7CisgICAgICAgIG1fb3ZlcmZsb3cuY2xlYXIoKTsKICAgICAgICAg YWRkT3ZlcmZsb3dGcm9tQ2hpbGQodGh1bWIpOwogICAgIH0KIAo= 94092 2011-05-19 11:11:20 -0700 2011-05-19 14:08:23 -0700 Patch bug-61132-20110519111045.patch text/plain 4051 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODY4NDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMGRiYTY5ODQzZmY2NTA3ZDkwNzhj MDRiZjgyNGNhY2M5NTA4Y2VkLi4wNjVjNzdmMGM5ZWZmZGQ0NmEyMjFmNzZmMWI3M2IwYWJkZWJm ZjdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTkgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmaXggcmVuZGVyIG92ZXJmbG93IGNvbXB1dGF0aW9uIGZvciBpbnB1dCB0eXBlPXJh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTEz MgorCisgICAgICAgICogZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sOiBB ZGRlZC4KKwogMjAxMS0wNS0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gU2tpcCBmYWlsaW5nIHRlc3RzIGFmdGVyIHI4NjgzNC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43NzIzNzlhNTYyNGI5MjBjODgyNjRlNzI3MDY5ODFiYjI3MzZkMWFk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRl c3RpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorQ2xpY2tpbmcgb24gdGhlIHJpZ2h0 IHNpZGUgb2Ygc2xpZGVyIHNob3VsZCBjYXVzZSB0aGUgdGh1bWIgdG8gbW92ZS4KKworCitQQVNT RUQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5n Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmQ2YWFhY2VhZjRiYjc0YjliYzQ0YjNhZDU5MTgwNTc2YWNmOGU4ODYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5o dG1sCkBAIC0wLDAgKzEsMzYgQEAKKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25l KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCit3aW5kb3cu c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNsaWRl ciIpLnN0eWxlLndpZHRoID0gIjEwMCUiOworICBjaGFuZ2VBbmRDaGVja1JhbmdlVmFsdWUoKTsK K30sIDApOworCitmdW5jdGlvbiBjaGFuZ2VBbmRDaGVja1JhbmdlVmFsdWUoKQoreworICAgIGlm ICghd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICByZXR1cm47CisKKyAgICB2 YXIgc2xpZGVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNsaWRlciIpOworICAgIHZhciB4 ID0gc2xpZGVyLm9mZnNldExlZnQgKyAoc2xpZGVyLmNsaWVudFdpZHRoICogLjc1KTsKKyAgICB2 YXIgeSA9IHNsaWRlci5vZmZzZXRUb3AgKyAoc2xpZGVyLmNsaWVudEhlaWdodCAvIDIpOworICAg IGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93 bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKworICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJyZXN1bHRzIikuaW5uZXJUZXh0ID0gKHNsaWRlci52YWx1ZSA9PSAzKSA/ICJQQVNT RUQiIDogIkZBSUxFRCI7CisKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHk+Cis8cD5DbGlja2luZyBvbiB0aGUgcmln aHQgc2lkZSBvZiBzbGlkZXIgc2hvdWxkIGNhdXNlIHRoZSB0aHVtYiB0byBtb3ZlLjwvcD4KKzxp bnB1dCBpZD0ic2xpZGVyIiB0eXBlPSJyYW5nZSIgc3R5bGU9ImhlaWdodDogMTBweDsgbWFyZ2lu OiAwIiBtaW49IjEiIG1heD0iMyI+Cis8ZGl2IGlkPSJyZXN1bHRzIj48L2Rpdj4KKzwvYm9keT4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMTM3YWUwMjI1YTVhZjRjYWJhODVlYjQwM2NmYTg2M2I1YTE5NDAzLi4z NmI3Njk5M2VlMjdjODFlM2E2MWJkNThhMWViMDdiOGQwZWRjYjRkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjMgQEAKKzIwMTEtMDUtMTkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaXggcmVu ZGVyIG92ZXJmbG93IGNvbXB1dGF0aW9uIGZvciBpbnB1dCB0eXBlPXJhbmdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTEzMgorCisgICAgICAgIFRl c3Q6IGZhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLmh0bWwKKworICAgICAgICBXZSBuZWVk IHRvIGNsZWFyIG1fb3ZlcmZsb3cgb3RoZXJ3aXNlIHdlIHVzZSB0aGUgZmlyc3QKKyAgICAgICAg c2l6ZSBvZiB0aGUgc2xpZGVyIGZvciBoaXQgdGVzdGluZyAoaS5lLiwgY2hhbmdlcyB0byB0aGUg c2l6ZQorICAgICAgICBjYXVzZSBwcm9ibGVtcykuICBUaGlzIG9ubHkgc2hvd3MgdXAgaWYgdGhl IHRodW1iIGlzbid0IGNvbnRhaW5lZAorICAgICAgICBpbiB0aGUgYm91bmRzIG9mIHRoZSBzbGlk ZXIuICBNYWtpbmcgdGhlIHJhbmdlIGhhdmUgYSBzbWFsbGVyIGhlaWdodAorICAgICAgICB0aGFu IHRoZSB0aHVtYiBzaG93cyB0aGUgYnVnLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclNs aWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTbGlkZXI6OmxheW91dCk6IENsZWFy IHRoZSBvdmVyZmxvdyBkdXJpbmcgbGF5b3V0CisgICAgICAgICAgICBzbyB3ZSByZS1jb21wdXRl IHRoZSBvdmVyZmxvdyBiYXNlZCBvbiB0aGUgY3VycmVudCBzaXplIG9mIHRoZQorICAgICAgICAg ICAgc2xpZGVyLgorCiAyMDExLTA1LTE5ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAZ29vZ2xl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNsaWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNwcAppbmRleCAwN2QzMjVlZDE3ZjA4MTI4ZGFkYWIz YzM5OGIwOWQ1ODgzZmI2MzEyLi41NDQ5YzQxMmJmMjQ5YzY3MDAwOTk0MzYwMzMwZGFiZjdlNjE4 NmQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNwcApAQCAtMTUz LDYgKzE1Myw4IEBAIHZvaWQgUmVuZGVyU2xpZGVyOjpsYXlvdXQoKQogICAgIGNvbXB1dGVMb2dp Y2FsSGVpZ2h0KCk7CiAgICAgdXBkYXRlTGF5ZXJUcmFuc2Zvcm0oKTsKIAorICAgIG1fb3ZlcmZs b3cuY2xlYXIoKTsKKwogICAgIGlmICh0aHVtYikgewogICAgICAgICBpZiAob2xkU2l6ZSAhPSBz aXplKCkpCiAgICAgICAgICAgICB0aHVtYi0+c2V0Q2hpbGROZWVkc0xheW91dCh0cnVlLCBmYWxz ZSk7Cg== 94112 2011-05-19 14:07:17 -0700 2011-05-23 19:24:58 -0700 Patch bug-61132-20110519140641.patch text/plain 4185 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODY4NDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkMGRiYTY5ODQzZmY2NTA3ZDkwNzhj MDRiZjgyNGNhY2M5NTA4Y2VkLi4wNjVjNzdmMGM5ZWZmZGQ0NmEyMjFmNzZmMWI3M2IwYWJkZWJm ZjdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTkgIFRvbnkgQ2hhbmcgIDx0b255 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmaXggcmVuZGVyIG92ZXJmbG93IGNvbXB1dGF0aW9uIGZvciBpbnB1dCB0eXBlPXJh bmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTEz MgorCisgICAgICAgICogZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sOiBB ZGRlZC4KKwogMjAxMS0wNS0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gU2tpcCBmYWlsaW5nIHRlc3RzIGFmdGVyIHI4NjgzNC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5nLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi43NzIzNzlhNTYyNGI5MjBjODgyNjRlNzI3MDY5ODFiYjI3MzZkMWFk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRl c3RpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorQ2xpY2tpbmcgb24gdGhlIHJpZ2h0 IHNpZGUgb2Ygc2xpZGVyIHNob3VsZCBjYXVzZSB0aGUgdGh1bWIgdG8gbW92ZS4KKworCitQQVNT RUQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2xpZGVyLWhpdC10ZXN0aW5n Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjVmNjEwNGMzZGFkYWQ0YTJhMDg5MTllYjdlZWRiNmE1MWMzMjc0MGYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NsaWRlci1oaXQtdGVzdGluZy5o dG1sCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxw PkNsaWNraW5nIG9uIHRoZSByaWdodCBzaWRlIG9mIHNsaWRlciBzaG91bGQgY2F1c2UgdGhlIHRo dW1iIHRvIG1vdmUuPC9wPgorPGlucHV0IGlkPSJzbGlkZXIiIHR5cGU9InJhbmdlIiBzdHlsZT0i aGVpZ2h0OiAxMHB4OyBtYXJnaW46IDAiIG1pbj0iMSIgbWF4PSIzIj4KKzxkaXYgaWQ9InJlc3Vs dHMiPjwvZGl2PgorPHNjcmlwdD4KKy8vIEZvcmNlIGEgbGF5b3V0IHNvIHRoZSBzbGlkZXIgc3Rh cnRzIHdpdGggdGhlIGRlZmF1bHQgd2lkdGguCitkb2N1bWVudC5ib2R5Lm9mZnNldExlZnQ7CisK K2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK3dpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2xpZGVyIikuc3R5bGUud2lkdGggPSAiMTAwJSI7 CisgICAgY2hhbmdlQW5kQ2hlY2tSYW5nZVZhbHVlKCk7Cit9OworCitmdW5jdGlvbiBjaGFuZ2VB bmRDaGVja1JhbmdlVmFsdWUoKQoreworICAgIGlmICghd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKQorICAgICAgICByZXR1cm47CisKKyAgICAvLyBDbGljayBvbiB0aGUgcmlnaHQgc2lkZSBv ZiB0aGUgc2xpZGVyLiAgVGhpcyBzaG91bGQgY2F1c2UgdGhlIHRodW1iCisgICAgLy8gdG8gbW92 ZSB0byB0aGUgcmlnaHQgc2lkZS4KKyAgICB2YXIgc2xpZGVyID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInNsaWRlciIpOworICAgIHZhciB4ID0gc2xpZGVyLm9mZnNldExlZnQgKyAoc2xpZGVy LmNsaWVudFdpZHRoICogLjc1KTsKKyAgICB2YXIgeSA9IHNsaWRlci5vZmZzZXRUb3AgKyAoc2xp ZGVyLmNsaWVudEhlaWdodCAvIDIpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkp OworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAo KTsKKworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHRzIikuaW5uZXJUZXh0ID0g KHNsaWRlci52YWx1ZSA9PSAzKSA/ICJQQVNTRUQiIDogIkZBSUxFRCI7Cit9CisKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQxMzdhZTAyMjVhNWFmNGNhYmE4NWVi NDAzY2ZhODYzYjVhMTk0MDMuLjM2Yjc2OTkzZWUyN2M4MWUzYTYxYmQ1OGExZWIwN2I4ZDBlZGNi NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMS0wNS0xOSAgVG9ueSBDaGFuZyAg PHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGZpeCByZW5kZXIgb3ZlcmZsb3cgY29tcHV0YXRpb24gZm9yIGlucHV0IHR5 cGU9cmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYxMTMyCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9zbGlkZXItaGl0LXRlc3RpbmcuaHRt bAorCisgICAgICAgIFdlIG5lZWQgdG8gY2xlYXIgbV9vdmVyZmxvdyBvdGhlcndpc2Ugd2UgdXNl IHRoZSBmaXJzdAorICAgICAgICBzaXplIG9mIHRoZSBzbGlkZXIgZm9yIGhpdCB0ZXN0aW5nIChp LmUuLCBjaGFuZ2VzIHRvIHRoZSBzaXplCisgICAgICAgIGNhdXNlIHByb2JsZW1zKS4gIFRoaXMg b25seSBzaG93cyB1cCBpZiB0aGUgdGh1bWIgaXNuJ3QgY29udGFpbmVkCisgICAgICAgIGluIHRo ZSBib3VuZHMgb2YgdGhlIHNsaWRlci4gIE1ha2luZyB0aGUgcmFuZ2UgaGF2ZSBhIHNtYWxsZXIg aGVpZ2h0CisgICAgICAgIHRoYW4gdGhlIHRodW1iIHNob3dzIHRoZSBidWcuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNs aWRlcjo6bGF5b3V0KTogQ2xlYXIgdGhlIG92ZXJmbG93IGR1cmluZyBsYXlvdXQKKyAgICAgICAg ICAgIHNvIHdlIHJlLWNvbXB1dGUgdGhlIG92ZXJmbG93IGJhc2VkIG9uIHRoZSBjdXJyZW50IHNp emUgb2YgdGhlCisgICAgICAgICAgICBzbGlkZXIuCisKIDIwMTEtMDUtMTkgIEFuZHJleSBBZGFp a2luICA8YWFuZHJleUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZl bGRtYW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyU2xpZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTbGlkZXIuY3BwCmluZGV4IDA3 ZDMyNWVkMTdmMDgxMjhkYWRhYjNjMzk4YjA5ZDU4ODNmYjYzMTIuLjU0NDljNDEyYmYyNDljNjcw MDA5OTQzNjAzMzBkYWJmN2U2MTg2ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJTbGlkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTbGlkZXIuY3BwCkBAIC0xNTMsNiArMTUzLDggQEAgdm9pZCBSZW5kZXJTbGlkZXI6OmxheW91 dCgpCiAgICAgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoKTsKICAgICB1cGRhdGVMYXllclRyYW5zZm9y bSgpOwogCisgICAgbV9vdmVyZmxvdy5jbGVhcigpOworCiAgICAgaWYgKHRodW1iKSB7CiAgICAg ICAgIGlmIChvbGRTaXplICE9IHNpemUoKSkKICAgICAgICAgICAgIHRodW1iLT5zZXRDaGlsZE5l ZWRzTGF5b3V0KHRydWUsIGZhbHNlKTsK