61128 2011-05-19 08:36:38 -0700 Fix GraphicsContext3DQt.cpp compile error 2011-05-19 13:40:53 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 rectalogic webkit-unassigned ademar commit-queue oldest_to_newest 406415 0 rectalogic 2011-05-19 08:36:38 -0700 GraphicsContext3DQt.cpp is failing to compile: ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In constructor 'WebCore::GraphicsContext3D::GraphicsContext3D(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, bool)': ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:692: error: no match for 'operator=' in '((WebCore::GraphicsContext3D*)this)->WebCore::GraphicsContext3D::m_internal = 0' ../../../Source/JavaScriptCore/wtf/OwnPtr.h:131: note: candidates are: WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::PassOwnPtr<T>&) [with T = WebCore::GraphicsContext3DInternal] ../../../Source/JavaScriptCore/wtf/OwnPtr.h:72: note: WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(std::nullptr_t) [with T = WebCore::GraphicsContext3DInternal] ../../../Source/JavaScriptCore/wtf/OwnPtr.h:83: note: WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::GraphicsContext3DInternal] Will attach a patch. 406416 1 94072 rectalogic 2011-05-19 08:39:55 -0700 Created attachment 94072 Fix compilation 406451 2 94072 darin 2011-05-19 09:31:58 -0700 Comment on attachment 94072 Fix compilation OK. We slightly prefer "= nullptr" to clear(), but the fix is fine either way. 406545 3 94072 commit-queue 2011-05-19 11:39:25 -0700 Comment on attachment 94072 Fix compilation Clearing flags on attachment: 94072 Committed r86861: <http://trac.webkit.org/changeset/86861> 406546 4 commit-queue 2011-05-19 11:39:29 -0700 All reviewed patches have been landed. Closing bug. 406617 5 ademar 2011-05-19 13:40:53 -0700 Revision r86861 cherry-picked into qtwebkit-2.2 with commit 863c88a <http://gitorious.org/webkit/qtwebkit/commit/863c88a> 94072 2011-05-19 08:39:55 -0700 2011-05-19 11:39:25 -0700 Fix compilation buildfix.diff text/plain 1248 rectalogic SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2ODQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTkgIEFuZHJldyBX YXNvbiAgPHJlY3RhbG9naWNAcmVjdGFsb2dpYy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IEdyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGNv bXBpbGUgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxMTI4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRl eHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpHcmFwaGlj c0NvbnRleHQzRCk6CisgICAgICAgICBjbGVhcigpIG1faW50ZXJuYWwgT3duUHRyLgorCiAyMDEx LTA1LTE5ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAJKHJl dmlzaW9uIDg2ODQzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NDb250ZXh0M0RRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OSw3ICs2ODksNyBAQCBH cmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3JhCiAgICAgOiBtX2lzUmVzb3Vy Y2VTYWZlKGZhbHNlKSwgbV9pbnRlcm5hbChhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250ZXh0M0RJ bnRlcm5hbChhdHRycywgaG9zdFdpbmRvdykpKQogewogICAgIGlmICghbV9pbnRlcm5hbC0+aXNW YWxpZCgpKQotICAgICAgICBtX2ludGVybmFsID0gMDsKKyAgICAgICAgbV9pbnRlcm5hbC5jbGVh cigpOwogfQogCiBHcmFwaGljc0NvbnRleHQzRDo6fkdyYXBoaWNzQ29udGV4dDNEKCkK