6112 2005-12-16 04:59:20 -0800 REGRESSION: navigator.plugins empty 2005-12-18 08:19:12 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 VERIFIED FIXED file:///Applications/Safari.app/Contents/Resources/English.lproj/Plug-ins.html P1 Major --- 1 mitz ggaren eric oldest_to_newest 26046 0 mitz 2005-12-16 04:59:20 -0800 navigator.plugins returns an empty PluginArray. At the same time, the following error is printed: ERROR: config number not implemented (.../WebCore/kwq/KWQKConfigBase.mm:123 readNumEntry) One way to reproduce is to choose Help > Installed Plug-ins in Safari. This is a very fresh regression. 26047 1 mitz 2005-12-16 05:12:59 -0800 The regression is due to this change in kjs_navigator.cpp r1.41: - KConfig c(KGlobal::dirs()->saveLocation("data","nsplugins")+"/pluginsinfo"); + KConfig c(""); 26048 2 mitz 2005-12-16 05:14:47 -0800 I should add that the simplest fix is to pass "pluginsinfo" to the constructor. 26057 3 5115 ggaren 2005-12-16 09:43:22 -0800 Created attachment 5115 Fix Mitz is right. Eric thought the old code passed a single string to a constructor that returned NULL, so he replaced that string with "". In fact, the old code passed one string to a constructor that returned NULL, and then concatenated "pluginsinfo" to that string. So "pluginsinfo" is what we want. 26058 4 ggaren 2005-12-16 09:46:07 -0800 I'm going to add "Plug-ins.html" to our layout test suite when I land this. 26059 5 5116 ggaren 2005-12-16 10:00:22 -0800 Created attachment 5116 Fix Previous patch had extra junk in it. 26060 6 5116 eric 2005-12-16 10:03:33 -0800 Comment on attachment 5116 Fix Agreed. Mitz and I were discussting making this an enum, etc. but that can be done later (in my next cleanup patch!). Thanks for fixing this. r=me 26061 7 eric 2005-12-16 10:05:29 -0800 Oh, as a side-note. Plugins.html (your test) should check that navigator.plugins has above a certain number of plugins, or perhaps one or two which we ship by default. Unfortunately it can't just dump all the plugins as those will be different between machines. Thanks again. 26107 8 mitz 2005-12-18 08:19:12 -0800 Thanks, Geoffrey! 5115 2005-12-16 09:43:22 -0800 2005-12-16 10:00:43 -0800 Fix ro.txt text/plain 4479 ggaren SW5kZXg6IGtodG1sL2VjbWEva2pzX25hdmlnYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUva2h0bWwvZWNtYS9ranNfbmF2aWdhdG9yLmNwcCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS40MgpkaWZmIC1wIC11IC1yMS40MiBraHRtbC9lY21hL2tqc19uYXZpZ2F0 b3IuY3BwCi0tLSBraHRtbC9lY21hL2tqc19uYXZpZ2F0b3IuY3BwCTE2IERlYyAyMDA1IDAwOjA4 OjMxIC0wMDAwCTEuNDIKKysrIGtodG1sL2VjbWEva2pzX25hdmlnYXRvci5jcHAJMTYgRGVjIDIw MDUgMTc6NDE6NTggLTAwMDAKQEAgLTIzOCw3ICsyMzgsNyBAQCBQbHVnaW5CYXNlOjpQbHVnaW5C YXNlKEV4ZWNTdGF0ZSAqZXhlYykKICAgICAgICAgbWltZXMtPnNldEF1dG9EZWxldGUoIHRydWUg KTsKIAogICAgICAgICAvLyByZWFkIGNvbmZpZ3VyYXRpb24KLSAgICAgICAgS0NvbmZpZyBjKCIi KTsKKyAgICAgICAgS0NvbmZpZyBjKCJwbHVnaW5zaW5mbyIpOwogICAgICAgICB1bnNpZ25lZCBu dW0gPSAodW5zaWduZWQgaW50KWMucmVhZE51bUVudHJ5KCJudW1iZXIiKTsKICAgICAgICAgZm9y ICggdW5zaWduZWQgbj0wOyBuPG51bTsgbisrICkgewogCkluZGV4OiBrd3EvS1dRS0hUTUxQYXJ0 QnJvd3NlckV4dGVuc2lvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29y ZS9rd3EvS1dRS0hUTUxQYXJ0QnJvd3NlckV4dGVuc2lvbi5tbSx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS41MQpkaWZmIC1wIC11IC1yMS41MSBrd3EvS1dRS0hUTUxQYXJ0QnJvd3NlckV4dGVuc2lv bi5tbQotLS0ga3dxL0tXUUtIVE1MUGFydEJyb3dzZXJFeHRlbnNpb24ubW0JMyBPY3QgMjAwNSAy MToxMzowNSAtMDAwMAkxLjUxCisrKyBrd3EvS1dRS0hUTUxQYXJ0QnJvd3NlckV4dGVuc2lvbi5t bQkxNiBEZWMgMjAwNSAxNzo0MTo1OCAtMDAwMApAQCAtNzEsMjggKzcxLDI4IEBAIHZvaWQgS0hU TUxQYXJ0QnJvd3NlckV4dGVuc2lvbjo6Y3JlYXRlTmUKIHsgCiAgICAgS1dRX0JMT0NLX0VYQ0VQ VElPTlM7CiAKLSAgICBOU1N0cmluZyAqZnJhbWVOYW1lID0gdXJsQXJncy5mcmFtZU5hbWUubGVu Z3RoKCkgPT0gMCA/IG5pbCA6IHVybEFyZ3MuZnJhbWVOYW1lLmdldE5TU3RyaW5nKCk7Ci0gICAg Ci0gICAgV2ViQ29yZUJyaWRnZSAqYnJpZGdlOwotCi0gICAgTlNTdHJpbmcgKnJlZmVycmVyOwot ICAgIFFTdHJpbmcgYXJnc1JlZmVycmVyID0gdXJsQXJncy5tZXRhRGF0YSgpWyJyZWZlcnJlciJd OwotICAgIGlmIChhcmdzUmVmZXJyZXIubGVuZ3RoKCkgPiAwKSB7Ci0gICAgICAgIHJlZmVycmVy ID0gYXJnc1JlZmVycmVyLmdldE5TU3RyaW5nKCk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgcmVm ZXJyZXIgPSBbX3BhcnQtPmJyaWRnZSgpIHJlZmVycmVyXTsKLSAgICB9Ci0KICAgICBBU1NFUlQo IXdpbkFyZ3MuZGlhbG9nIHx8IHVybEFyZ3MuZnJhbWVOYW1lLmlzRW1wdHkoKSk7CiAKKyAgICBR U3RyaW5nIGFyZ3NSZWZlcnJlciA9IHVybEFyZ3MubWV0YURhdGEoKVsicmVmZXJyZXIiXTsKKyAg ICBOU1N0cmluZyAqcmVmZXJyZXIgPSBhcmdzUmVmZXJyZXIubGVuZ3RoKCkgPiAwID8gYXJnc1Jl ZmVycmVyLmdldE5TU3RyaW5nKCkgOiBbX3BhcnQtPmJyaWRnZSgpIHJlZmVycmVyXTsKKyAgICBO U1N0cmluZyAqZnJhbWVOYW1lID0gdXJsQXJncy5mcmFtZU5hbWUubGVuZ3RoKCkgPiAwID8gdXJs QXJncy5mcmFtZU5hbWUuZ2V0TlNTdHJpbmcoKSA6IG5pbDsKKyAgICAKICAgICBpZiAocGFydFJl c3VsdCkKIAkqcGFydFJlc3VsdCA9IE5VTEw7CiAKKyAgICBXZWJDb3JlQnJpZGdlICpicmlkZ2U7 CiAgICAgaWYgKGZyYW1lTmFtZSAhPSBuaWwpIHsKIAlicmlkZ2UgPSBbX3BhcnQtPmJyaWRnZSgp IGZpbmRGcmFtZU5hbWVkOmZyYW1lTmFtZV07CiAJaWYgKGJyaWRnZSAhPSBuaWwpIHsKIAkgICAg aWYgKCF1cmwuaXNFbXB0eSgpKSB7Ci0JCVticmlkZ2UgbG9hZFVSTDp1cmwuZ2V0TlNVUkwoKSBy ZWZlcnJlcjpyZWZlcnJlciByZWxvYWQ6dXJsQXJncy5yZWxvYWQgdXNlckdlc3R1cmU6dHJ1ZSB0 YXJnZXQ6bmlsIHRyaWdnZXJpbmdFdmVudDpuaWwgZm9ybTpuaWwgZm9ybVZhbHVlczpuaWxdOwor CQlbYnJpZGdlIGxvYWRVUkw6dXJsLmdldE5TVVJMKCkgCisJCSAgICAgICByZWZlcnJlcjpyZWZl cnJlciAKKwkJCSByZWxvYWQ6dXJsQXJncy5yZWxvYWQgCisJCSAgICB1c2VyR2VzdHVyZTp0cnVl IAorCQkJIHRhcmdldDpuaWwgCisJCXRyaWdnZXJpbmdFdmVudDpuaWwgCisJCQkgICBmb3JtOm5p bCAKKwkJICAgICBmb3JtVmFsdWVzOm5pbF07CiAJICAgIH0KIAkgICAgW2JyaWRnZSBmb2N1c1dp bmRvd107CiAJICAgIGlmIChwYXJ0UmVzdWx0KSB7CkBAIC0xMjUsMzMgKzEyNSwzMSBAQCB2b2lk IEtIVE1MUGFydEJyb3dzZXJFeHRlbnNpb246OmNyZWF0ZU5lCiAJW2JyaWRnZSBzZXRXaW5kb3dJ c1Jlc2l6YWJsZTpOT107CiAgICAgfQogICAgIAotICAgIGlmICh3aW5BcmdzLnhTZXQgfHwgd2lu QXJncy55U2V0IHx8IHdpbkFyZ3Mud2lkdGhTZXQgfHwgd2luQXJncy5oZWlnaHRTZXQpIHsKLQlO U1JlY3QgZnJhbWUgPSBbYnJpZGdlIHdpbmRvd0ZyYW1lXTsKLQlOU1JlY3QgY29udGVudFJlY3Qg PSBbYnJpZGdlIHdpbmRvd0NvbnRlbnRSZWN0XTsKLQkKLQlpZiAod2luQXJncy54U2V0KSB7Ci0J ICAgIGZyYW1lLm9yaWdpbi54ID0gd2luQXJncy54OwotCX0KLQkKLQlpZiAod2luQXJncy55U2V0 KSB7Ci0JICAgIGZsb2F0IGhlaWdodEZvckZsaXAgPSBOU01heFkoW1tbTlNTY3JlZW4gc2NyZWVu c10gb2JqZWN0QXRJbmRleDowXSBmcmFtZV0pOwotCSAgICBmcmFtZS5vcmlnaW4ueSA9IGhlaWdo dEZvckZsaXAgLSAod2luQXJncy55ICsgZnJhbWUuc2l6ZS5oZWlnaHQpOwotCX0KLQkKLQlpZiAo d2luQXJncy53aWR0aFNldCkgewotCSAgICBmcmFtZS5zaXplLndpZHRoICs9IHdpbkFyZ3Mud2lk dGggLSBjb250ZW50UmVjdC5zaXplLndpZHRoOwotCX0KLQkKLQlpZiAod2luQXJncy5oZWlnaHRT ZXQpIHsKLQkgICAgZmxvYXQgaGVpZ2h0RGVsdGEgPSB3aW5BcmdzLmhlaWdodCAtIGNvbnRlbnRS ZWN0LnNpemUuaGVpZ2h0OwotCSAgICBmcmFtZS5zaXplLmhlaWdodCArPSBoZWlnaHREZWx0YTsK LQkgICAgZnJhbWUub3JpZ2luLnkgLT0gaGVpZ2h0RGVsdGE7Ci0JfQotCQotCVticmlkZ2Ugc2V0 V2luZG93RnJhbWU6ZnJhbWVdOworICAgIE5TUmVjdCB3aW5kb3dGcmFtZSA9IFticmlkZ2Ugd2lu ZG93RnJhbWVdOworCisgICAgTlNTaXplIHNjYWxlZFNpemUgPSBbW2JyaWRnZSBwYXJ0XS0+d2lk Z2V0KCktPmdldFZpZXcoKSBjb252ZXJ0U2l6ZTpOU01ha2VTaXplKDEsIDEpIHRvVmlldzpuaWxd OworICAgIGZsb2F0IHNjYWxlWCA9IHNjYWxlZFNpemUud2lkdGg7CisgICAgZmxvYXQgc2NhbGVZ ID0gc2NhbGVkU2l6ZS5oZWlnaHQ7CisKKyAgICBOU1BvaW50IG9yaWdpbiA9IHdpbmRvd0ZyYW1l Lm9yaWdpbjsKKyAgICBpZiAod2luQXJncy54U2V0KQorCW9yaWdpbi54ID0gd2luQXJncy54ICog c2NhbGVYOworICAgIGlmICh3aW5BcmdzLnlTZXQpIHsKKwlmbG9hdCBzY3JlZW5Ub3AgPSBOU01h eFkoW1tbTlNTY3JlZW4gc2NyZWVuc10gb2JqZWN0QXRJbmRleDowXSBmcmFtZV0pOworCW9yaWdp bi55ID0gc2NyZWVuVG9wIC0gKHdpbkFyZ3MueSAqIHNjYWxlWSkgLSB3aW5kb3dGcmFtZS5zaXpl LmhlaWdodDsKKyAgICB9CisKKyAgICBOU1NpemUgc2l6ZSA9IHdpbmRvd0ZyYW1lLnNpemU7Cisg ICAgaWYgKHdpbkFyZ3Mud2lkdGhTZXQpCisJc2l6ZS53aWR0aCA9IHdpbkFyZ3Mud2lkdGggKiBz Y2FsZVg7CisgICAgaWYgKHdpbkFyZ3MuaGVpZ2h0U2V0KSB7CisJZmxvYXQgaGVpZ2h0RGVsdGEg PSBzaXplLmhlaWdodCAtICh3aW5BcmdzLmhlaWdodCAqc2NhbGVZKTsKKwlzaXplLmhlaWdodCAr PSBoZWlnaHREZWx0YTsKKwlvcmlnaW4ueSAtPSBoZWlnaHREZWx0YTsKICAgICB9CiAgICAgCi0g ICAgW2JyaWRnZSBzaG93V2luZG93XTsKKyAgICBOU1JlY3QgcmVjdCA9IE5TTWFrZVJlY3Qob3Jp Z2luLngsIG9yaWdpbi55LCBzaXplLndpZHRoLCBzaXplLmhlaWdodCk7CisgICAgW2JyaWRnZSBz ZXRXaW5kb3dGcmFtZTpyZWN0XTsKIAogICAgIGlmIChbYnJpZGdlIHBhcnRdKSB7CiAJW2JyaWRn ZSBwYXJ0XS0+c2V0TmFtZSh1cmxBcmdzLmZyYW1lTmFtZSk7CkBAIC0xNjEsNiArMTU5LDggQEAg dm9pZCBLSFRNTFBhcnRCcm93c2VyRXh0ZW5zaW9uOjpjcmVhdGVOZQogCSpwYXJ0UmVzdWx0ID0g W2JyaWRnZSBwYXJ0XTsKICAgICB9CiAKKyAgICBbYnJpZGdlIHNob3dXaW5kb3ddOworICAgIAog ICAgIEtXUV9VTkJMT0NLX0VYQ0VQVElPTlM7CiB9CiAK 5116 2005-12-16 10:00:22 -0800 2005-12-16 10:03:33 -0800 Fix patch-pluginsinfo.txt text/plain 661 ggaren SW5kZXg6IGtodG1sL2VjbWEva2pzX25hdmlnYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUva2h0bWwvZWNtYS9ranNfbmF2aWdhdG9yLmNwcCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS40MgpkaWZmIC1wIC11IC1yMS40MiBraHRtbC9lY21hL2tqc19uYXZpZ2F0 b3IuY3BwCi0tLSBraHRtbC9lY21hL2tqc19uYXZpZ2F0b3IuY3BwCTE2IERlYyAyMDA1IDAwOjA4 OjMxIC0wMDAwCTEuNDIKKysrIGtodG1sL2VjbWEva2pzX25hdmlnYXRvci5jcHAJMTYgRGVjIDIw MDUgMTg6MDA6NTcgLTAwMDAKQEAgLTIzOCw3ICsyMzgsNyBAQCBQbHVnaW5CYXNlOjpQbHVnaW5C YXNlKEV4ZWNTdGF0ZSAqZXhlYykKICAgICAgICAgbWltZXMtPnNldEF1dG9EZWxldGUoIHRydWUg KTsKIAogICAgICAgICAvLyByZWFkIGNvbmZpZ3VyYXRpb24KLSAgICAgICAgS0NvbmZpZyBjKCIi KTsKKyAgICAgICAgS0NvbmZpZyBjKCJwbHVnaW5zaW5mbyIpOwogICAgICAgICB1bnNpZ25lZCBu dW0gPSAodW5zaWduZWQgaW50KWMucmVhZE51bUVudHJ5KCJudW1iZXIiKTsKICAgICAgICAgZm9y ICggdW5zaWduZWQgbj0wOyBuPG51bTsgbisrICkgewogCg==