61083 2011-05-18 11:38:18 -0700 Regression(r85355): Crash with two table captions when child visible and enclosing layer invisible 2011-05-19 13:35:25 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 inferno inferno ademar bdakin hyatt jamesr mitz oldest_to_newest 405895 0 inferno 2011-05-18 11:38:18 -0700 Testcase:: <html> <body> <div style="visibility: collapse;"> <table> <caption>Test passes if it does not crash.</caption> <caption> <span style="visibility: visible;"></span> </caption> </table> </div> <script> if (window.layoutTestController) layoutTestController.dumpAsText(); </script> </body> </html> Fixing it. RenderObjectChildList::removeChildNode crashes on a null pointer in if (owner->style()->visibility() != VISIBLE && oldChild->style()->visibility() == VISIBLE && !oldChild->hasLayer()) { layer = owner->enclosingLayer(); layer->dirtyVisibleContentStatus(); Problem is we don't need the removechild call since destroy caption already calls it later. calling removechild earlier removes it from parent and hence our enclosing layer comes out null. } 405903 1 inferno 2011-05-18 11:42:29 -0700 As you can see we don't need to removchild earlier, renderobject destroy will call it at the right time. void RenderObject::destroy() { ....... remove(); 405933 2 93962 inferno 2011-05-18 12:18:19 -0700 Created attachment 93962 Patch 405935 3 93962 bdakin 2011-05-18 12:27:55 -0700 Comment on attachment 93962 Patch r=me 405938 4 inferno 2011-05-18 12:30:59 -0700 Committed r86781: <http://trac.webkit.org/changeset/86781> 406607 5 ademar 2011-05-19 13:35:25 -0700 Revision r86781 cherry-picked into qtwebkit-2.2 with commit 2907a02 <http://gitorious.org/webkit/qtwebkit/commit/2907a02> 93962 2011-05-18 12:18:19 -0700 2011-05-18 12:27:55 -0700 Patch bug-61083-20110518121818.patch text/plain 3283 inferno SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTggIEFiaGlzaGVr IEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgcmVtb3ZlQ2hpbGQgb24gdGFibGUgY2FwdGlv biBzaW5jZSBkZXN0cm95IGNhbGwKKyAgICAgICAgYWxyZWFkeSBkb2VzIHRoYXQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA4MworCisgICAgICAg IFRlc3Q6IGZhc3QvdGFibGUvdGFibGUtY2FwdGlvbnMtY2hpbGQtdmlzaWJsZS1jcmFzaC5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyVGFibGU6OnJlY2FsY0NhcHRpb24pOgorCiAyMDExLTA1LTE4ICBFdmFuIE1hcnRp biAgPGV2YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcu CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAJKHJldmlzaW9u IDg2NzcyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzAxLDEwICs3MDEsNiBAQCB2b2lkIFJlbmRlclRhYmxlOjpyZWNhbGND YXB0aW9uKFJlbmRlckJsCiAgICAgICAgIG1fY2FwdGlvbiA9IGNhcHRpb247CiAgICAgICAgIG1f Y2FwdGlvbi0+c2V0TmVlZHNMYXlvdXQodHJ1ZSk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgLy8g RGV0YWNoIHRoZSBjaGlsZCBmcm9tIHRoZSB0YWJsZS4KLSAgICAgICAgY29uc3QgUmVuZGVyQmxv Y2sqIGJsb2NrID0gc3RhdGljX2Nhc3Q8Y29uc3QgUmVuZGVyQmxvY2sqPih0aGlzKTsKLSAgICAg ICAgY29uc3RfY2FzdDxSZW5kZXJCbG9jayo+KGJsb2NrKS0+cmVtb3ZlQ2hpbGQoY2FwdGlvbik7 Ci0KICAgICAgICAgLy8gTWFrZSBzdXJlIHRvIG51bGwgb3V0IHRoZSBjaGlsZCdzIHJlbmRlcmVy LgogICAgICAgICBpZiAoTm9kZSogbm9kZSA9IGNhcHRpb24tPm5vZGUoKSkKICAgICAgICAgICAg IG5vZGUtPnNldFJlbmRlcmVyKDApOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODY3ODApCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0w NS0xOCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzIHRoYXQgd2UgZG8gbm90 IGNyYXNoIHdoZW4gcHJlbWF0dXJlbHkgY2FsbGluZyByZW1vdmVDaGlsZCwKKyAgICAgICAgZm9s bG93ZWQgYnkgZGVzdHJveSBjYWxsIG9uIHRhYmxlIGNhcHRpb24uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTA4MworCisgICAgICAgICogZmFzdC90 YWJsZS90YWJsZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC90YWJsZS90YWJsZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNy YXNoLmh0bWw6IEFkZGVkLgorCiAyMDExLTA1LTE4ICBDaGFuZyBTaHUgIDxjc2h1QHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC90YWJsZS90YWJsZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNyYXNoLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL3RhYmxlLWNh cHRpb25zLWNoaWxkLXZpc2libGUtY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC90YWJsZS90YWJsZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNyYXNo LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitUZXN0IHBhc3NlcyBp ZiBpdCBkb2VzIG5vdCBjcmFzaC4KKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS90YWJs ZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS90YWJsZS1jYXB0aW9ucy1jaGlsZC12aXNpYmxlLWNyYXNoLmh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL3RhYmxlLWNhcHRpb25zLWNo aWxkLXZpc2libGUtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNyBAQAorPGh0 bWw+DQorICAgIDxib2R5Pg0KKwkgICAgVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2gu DQorICAgICAgICA8ZGl2IHN0eWxlPSJ2aXNpYmlsaXR5OiBjb2xsYXBzZTsiPg0KKyAgICAgICAg ICAgIDx0YWJsZT4NCisgICAgICAgICAgICAgICAgPGNhcHRpb24+PC9jYXB0aW9uPg0KKyAgICAg ICAgICAgICAgICA8Y2FwdGlvbj4NCisgICAgICAgICAgICAgICAgICAgIDxzcGFuIHN0eWxlPSJ2 aXNpYmlsaXR5OiB2aXNpYmxlOyI+PC9zcGFuPg0KKyAgICAgICAgICAgICAgICA8L2NhcHRpb24+ DQorICAgICAgICAgICAgPC90YWJsZT4NCisgICAgICAgIDwvZGl2Pg0KKyAgICAgICAgPHNjcmlw dD4NCisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQ0KKyAgICAg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7DQorICAgICAgICA8 L3NjcmlwdD4NCisgICAgPC9ib2R5Pg0KKzwvaHRtbD4NCg==