61056 2011-05-18 08:28:40 -0700 Web Inspector: Non-color CSS property values can get a color-picker 2011-05-18 11:20:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 405732 0 apavlov 2011-05-18 08:28:40 -0700 Only color-enabled properties should show a color picker. Patch to follow. Upstreaming http://code.google.com/p/chromium/issues/detail?id=83051 405741 1 93921 apavlov 2011-05-18 08:39:08 -0700 Created attachment 93921 [PATCH] Suggested fix 405804 2 93921 commit-queue 2011-05-18 10:15:41 -0700 Comment on attachment 93921 [PATCH] Suggested fix Clearing flags on attachment: 93921 Committed r86774: <http://trac.webkit.org/changeset/86774> 405805 3 commit-queue 2011-05-18 10:15:46 -0700 All reviewed patches have been landed. Closing bug. 405871 4 commit-queue 2011-05-18 11:20:24 -0700 The commit-queue encountered the following flaky tests while processing attachment 93921: http/tests/websocket/tests/bad-handshake-crash.html bug 54370 (author: abarth@webkit.org) http/tests/websocket/tests/close-on-unload-reference-in-parent.html bug 54008 (authors: abarth@webkit.org and yutak@chromium.org) The commit-queue is continuing to process your patch. 93921 2011-05-18 08:39:08 -0700 2011-05-18 10:15:41 -0700 [PATCH] Suggested fix colorpicker.patch text/plain 2703 apavlov Y29tbWl0IDQ3ZTgzNjA0ZDAwMTA3MzljMDYwMmY5ZjhiNDYxNWEzMmYxZTIyMDAKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgTWF5IDE4 IDE5OjM1OjU0IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNkZGY5Ny4uZDc3 ZDdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDExLTA1LTE4ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTm9uLWNvbG9yIENTUyBwcm9w ZXJ0eSB2YWx1ZXMgY2FuIGdldCBhIGNvbG9yLXBpY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNTYKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkNTU0tleXdvcmRDb21wbGV0aW9ucy5mb3JQcm9wZXJ0eSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLmlzQ29sb3JBd2FyZVByb3BlcnR5KToKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUudXBkYXRlVGl0bGUp OgorCisyMDExLTA1LTE4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBtb2RlbC1iYXNlZCBDU1MgZWRpdGluZyBkb2VzIG5vdCB1cGRhdGUgQGltcG9ydC1l ZCBzdHlsZXNoZWV0IHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwppbmRleCBkZTIwNzJh Li41NWEyZWNmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtMzksNiArMzksMTEgQEAgV2Vi SW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucyA9IHsKICAgICAgICAgaWYgKHByb3BlcnR5 TmFtZSBpbiBXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUuSW5oZXJpdGVkUHJvcGVydGll cykKICAgICAgICAgICAgIGFjY2VwdGVkS2V5d29yZHMucHVzaCgiaW5oZXJpdCIpOwogICAgICAg ICByZXR1cm4gbmV3IFdlYkluc3BlY3Rvci5DU1NDb21wbGV0aW9ucyhhY2NlcHRlZEtleXdvcmRz LCB0cnVlKTsKKyAgICB9LAorCisgICAgaXNDb2xvckF3YXJlUHJvcGVydHk6IGZ1bmN0aW9uKHBy b3BlcnR5TmFtZSkKKyAgICB7CisgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuQ1NTS2V5d29y ZENvbXBsZXRpb25zLl9jb2xvckF3YXJlUHJvcGVydGllc1twcm9wZXJ0eU5hbWVdID09PSB0cnVl OwogICAgIH0KIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCmluZGV4IDk4ZWQ2MmQuLmViNTAxZDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRl YmFyUGFuZS5qcwpAQCAtMTQ1MSw3ICsxNDUxLDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVy dHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB2YXIgY29sb3JSZWdleCA9 IC8oKD86cmdifGhzbClhP1woW14pXStcKXwjWzAtOWEtZkEtRl17Nn18I1swLTlhLWZBLUZdezN9 fFxiXHcrXGIoPyEtKSkvZzsKICAgICAgICAgICAgIHZhciBjb2xvclByb2Nlc3NvciA9IHByb2Nl c3NWYWx1ZS5iaW5kKHdpbmRvdywgY29sb3JSZWdleCwgcHJvY2Vzc0NvbG9yLCBudWxsKTsKIAot ICAgICAgICAgICAgdmFsdWVFbGVtZW50LmFwcGVuZENoaWxkKHByb2Nlc3NWYWx1ZSgvdXJsXChc cyooW14pXHNdKylccypcKS9nLCBsaW5raWZ5VVJMLCBjb2xvclByb2Nlc3NvciwgdmFsdWUpKTsK KyAgICAgICAgICAgIHZhbHVlRWxlbWVudC5hcHBlbmRDaGlsZChwcm9jZXNzVmFsdWUoL3VybFwo XHMqKFteKVxzXSspXHMqXCkvZywgbGlua2lmeVVSTCwgV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRD b21wbGV0aW9ucy5pc0NvbG9yQXdhcmVQcm9wZXJ0eShzZWxmLm5hbWUpID8gY29sb3JQcm9jZXNz b3IgOiBudWxsLCB2YWx1ZSkpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5saXN0SXRlbUVs ZW1lbnQucmVtb3ZlQ2hpbGRyZW4oKTsK