61052 2011-05-18 07:25:35 -0700 [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix 2011-05-24 10:07:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 cshu webkit-unassigned abecsi commit-queue ossy oldest_to_newest 405699 0 cshu 2011-05-18 07:25:35 -0700 I ran the following script: Tools/Scripts/run-webkit-tests LayoutTests/fast/events --skipped=only I expected to see only the skipped tests under folder LayoutTests/fast/events to be run. However, the test log (on mac) shows "Testing 24080 test cases." Note that this is equivalent to run Tools/Scripts/run-webkit-tests --skipped=ignore Normally, running Tools/Scripts/run-webkit-tests shows "Testing 23538 test cases." However, running the script without sub-folder works as expected: Tools/Scripts/run-webkit-tests --skipped=only shows "Testing 592 test cases." 405708 1 ossy 2011-05-18 07:33:10 -0700 Unfortunately --skipped=only use too simple algorithm, it compares the parameters with skipped list entries. If you don't add LayoutTests, it works. But it would be great if it can handle LayoutTests/ prefix ... 407004 2 94201 ossy 2011-05-20 05:17:14 -0700 Created attachment 94201 proposed fix It would make --skipped=only users happier, because they can use tab completion to find the directory name. :) 407006 3 94201 abecsi 2011-05-20 05:21:44 -0700 Comment on attachment 94201 proposed fix Some more perl magic. LGTM. 407025 4 cshu 2011-05-20 06:15:03 -0700 Thanks, Ossy. 408950 5 94201 commit-queue 2011-05-24 10:07:44 -0700 Comment on attachment 94201 proposed fix Clearing flags on attachment: 94201 Committed r87162: <http://trac.webkit.org/changeset/87162> 408952 6 commit-queue 2011-05-24 10:07:48 -0700 All reviewed patches have been landed. Closing bug. 94201 2011-05-20 05:17:14 -0700 2011-05-24 10:07:43 -0700 proposed fix 1.patch text/plain 2431 ossy ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MDZj NTgzLi43ZjExNzk3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjAgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbT1JXVF1NYWtlIC0tc2tpcHBlZD1vbmx5IG9wdGlvbiB3b3JrIHdpdGggcGFy YW1ldGVycyB3aXRoIExheW91dFRlc3RzLyBwcmVmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDUyCisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1y dW4td2Via2l0LXRlc3RzOgorCiAyMDExLTA1LTIwICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0cwppbmRleCBjOTYxZjU4Li5jZmU2ZDYxIDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1 bi13ZWJraXQtdGVzdHMKQEAgLTI0MTksMTMgKzI0MTksMTUgQEAgc3ViIHJlYWRTa2lwcGVkRmls ZXMoJCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoISRjb25zdHJhaW50UGF0aCkg ewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjIEFsd2F5cyBhZGQgJHNraXBwZWQg c2luY2Ugbm8gY29uc3RyYWludCBwYXRoIHdhcyBzcGVjaWZpZWQgb24gdGhlIGNvbW1hbmQgbGlu ZS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAQVJHViwgJHNraXBwZWQp OwotICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzaWYgKCRza2lwcGVkID1+IC9eKCRj b25zdHJhaW50UGF0aCkvKSB7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSBlbHNpZiAo JHNraXBwZWQgPX4gL14oJGNvbnN0cmFpbnRQYXRoKS8gfHwgKCJMYXlvdXRUZXN0cy8iLiRza2lw cGVkKSA9fiAvXigkY29uc3RyYWludFBhdGgpLyApIHsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIyBBZGQgJHNraXBwZWQgb25seSBpZiBpdCBtYXRjaGVzIHRoZSBjdXJyZW50IHBh dGggY29uc3RyYWludCwgZS5nLiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyAi LS1za2lwcGVkPW9ubHkgZGlyMSIgd2l0aCAiZGlyMS9maWxlMS5odG1sIiBvbiB0aGUgc2tpcHBl ZCBsaXN0LgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjICItLXNraXBwZWQ9b25s eSBkaXIxIiB3aXRoICJkaXIxL2ZpbGUxLmh0bWwiIG9uIHRoZSBza2lwcGVkIGxpc3Qgb3IKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyAiLS1za2lwcGVkPW9ubHkgTGF5b3V0VGVz dHMvZGlyMSIgd2l0aCAiZGlyMS9maWxlMS5odG1sIiBvbiB0aGUgc2tpcHBlZCBsaXN0CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQEFSR1YsICRza2lwcGVkKTsKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2lmICgkY29uc3RyYWludFBhdGggPX4gL14oJHNr aXBwZWQpLykgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0gZWxzaWYgKCRjb25zdHJh aW50UGF0aCA9fiAvXigiTGF5b3V0VGVzdHNcLyIuJHNraXBwZWQpLyB8fCAkY29uc3RyYWludFBh dGggPX4gL14oJHNraXBwZWQpLykgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAj IEFkZCBjdXJyZW50IHBhdGggY29uc3RyYWludCBpZiBpdCBpcyBtb3JlIHNwZWNpZmljIHRoYW4g dGhlIHNraXAgbGlzdCBlbnRyeSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyBl LmcuLCAiLS1za2lwcGVkPW9ubHkgZGlyMS9kaXIyL2RpcjMiIHdpdGggImRpcjEiIG9uIHRoZSBz a2lwcGVkIGxpc3QuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMgZS5nLiwgIi0t c2tpcHBlZD1vbmx5IGRpcjEvZGlyMi9kaXIzIiB3aXRoICJkaXIxIiBvbiB0aGUgc2tpcHBlZCBs aXN0IG9yCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMgZS5nLiwgIi0tc2tpcHBl ZD1vbmx5IExheW91dFRlc3RzL2RpcjEvZGlyMi9kaXIzIiB3aXRoICJkaXIxIiBvbiB0aGUgc2tp cHBlZCBsaXN0LgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBBUkdWLCAk Y29uc3RyYWludFBhdGgpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICAgICAgICAgIH0gZWxzaWYgKCR2ZXJib3NlKSB7Cg==