61045 2011-05-18 05:15:03 -0700 [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest 2012-11-14 06:10:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 ossy webkit-unassigned ademar cmarcelo ossy rafael.lobo webkit.review.bot oldest_to_newest 405659 0 ossy 2011-05-18 05:15:03 -0700 FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage2, QWebSettings::LocalStorageEnabled, "localStorage", true)): 0 Expected (true): 1 Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2295)] 407043 1 94210 ossy 2011-05-20 06:35:44 -0700 Created attachment 94210 mark failing test cases as expected fail 407044 2 94210 ossy 2011-05-20 06:36:15 -0700 Comment on attachment 94210 mark failing test cases as expected fail wrong patch 407048 3 94211 ossy 2011-05-20 06:37:08 -0700 Created attachment 94211 mark failing test cases as expected fail 407052 4 webkit.review.bot 2011-05-20 06:39:52 -0700 Attachment 94211 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2342: Missing space after , [whitespace/comma] [3] Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2345: Missing space after , [whitespace/comma] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 407053 5 94211 ossy 2011-05-20 06:46:51 -0700 Comment on attachment 94211 mark failing test cases as expected fail cq-, I'll fix the style issue before landing. 407080 6 94211 ossy 2011-05-20 07:26:49 -0700 Comment on attachment 94211 mark failing test cases as expected fail Landed in http://trac.webkit.org/changeset/86951 407171 7 rafael.lobo 2011-05-20 10:15:43 -0700 I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way. 413581 8 ademar 2011-06-01 12:32:35 -0700 Revision r86951 cherry-picked into qtwebkit-2.2 with commit e34811a <http://gitorious.org/webkit/qtwebkit/commit/e34811a> 417348 9 ademar 2011-06-08 11:03:29 -0700 (In reply to comment #7) > I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way. Even with your patch, the two failures are still there, but they're different than the one originally reported on this bug. The ones currently failing are: FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1 Expected (false): 0 Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2335)] and if we continue (via XFAIL): FAIL! : tst_QWebPage::testOptionalJSObjects() Compared values are not the same Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1 Expected (false): 0 Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2338)] 420127 10 rafael.lobo 2011-06-13 18:09:22 -0700 They were failing before: https://bugs.webkit.org/show_bug.cgi?id=29867 Perhaps we should reopen that bug, and close this one as it is a duplicate. 766811 11 ossy 2012-11-14 06:10:39 -0800 Tests aren't marked as failures now, so they work fine. 94210 2011-05-20 06:35:44 -0700 2011-05-20 06:36:15 -0700 mark failing test cases as expected fail 1.patch text/plain 476 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggOGI4YzgyYi4uNTkwMDZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTYs NyArNiw3IEBACiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MTA0NQogCiAgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKLSAg ICAgICAgKHRzdF9RV2ViUGFnZTo6dGVzdE9wdGlvbmFsSlNPYmplY3RzKToKKyAgICAgICAgKHRz dF9RV2ViUGFnZTo6dGVzdE9wdGlvbmFsSlNPYmplY3RzKTogTWFyayBmYWlsaW5nIHRlc3QgY2Fz ZXMgYXMgZXhwZWN0ZWQgZmFpbHMuCiAKIDIwMTEtMDUtMjAgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAo= 94211 2011-05-20 06:37:08 -0700 2011-05-20 07:26:49 -0700 mark failing test cases as expected fail 1.patch text/plain 1702 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggYzdjZTg1Yi4uNTkwMDZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxMS0wNS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF0gRml4IHRzdF9RV2ViUGFnZTo6dGVzdE9wdGlvbmFsSlNPYmplY3RzKCkgYXV0b3Rlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQ1CisKKyAg ICAgICAgKiB0ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgorICAgICAgICAodHN0X1FX ZWJQYWdlOjp0ZXN0T3B0aW9uYWxKU09iamVjdHMpOiBNYXJrIGZhaWxpbmcgdGVzdCBjYXNlcyBh cyBleHBlY3RlZCBmYWlscy4KKworMjAxMS0wNS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEJlbmphbWluIFBvdWxhaW4uCiAK ICAgICAgICAgW1F0XUZpeCB0c3RfUVdlYkZyYW1lOjpzZXRVcmxUb0ludmFsaWQoKSBhdXRvdGVz dCBhZnRlciByODQ3NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBh Z2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0 X3F3ZWJwYWdlLmNwcAppbmRleCAxZDJjYjQ3Li41ZDBjZjY4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dl YktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0yMzM5LDggKzIzMzks MTAgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OnRlc3RPcHRpb25hbEpTT2JqZWN0cygpCiAgICAgUUNP TVBBUkUodGVzdEZsYWcod2ViUGFnZTIsIFFXZWJTZXR0aW5nczo6T2ZmbGluZVdlYkFwcGxpY2F0 aW9uQ2FjaGVFbmFibGVkLCAiYXBwbGljYXRpb25DYWNoZSIsIGZhbHNlKSwgdHJ1ZSk7CiAKICAg ICBRQ09NUEFSRSh0ZXN0RmxhZyh3ZWJQYWdlMSwgUVdlYlNldHRpbmdzOjpMb2NhbFN0b3JhZ2VF bmFibGVkLCAibG9jYWxTdG9yYWdlIiwgZmFsc2UpLCBmYWxzZSk7CisgICAgUUVYUEVDVF9GQUlM KCIiLCJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwNDUiLCBDb250 aW51ZSk7CiAgICAgUUNPTVBBUkUodGVzdEZsYWcod2ViUGFnZTIsIFFXZWJTZXR0aW5nczo6TG9j YWxTdG9yYWdlRW5hYmxlZCwgImxvY2FsU3RvcmFnZSIsIHRydWUpLCAgdHJ1ZSk7CiAgICAgUUNP TVBBUkUodGVzdEZsYWcod2ViUGFnZTEsIFFXZWJTZXR0aW5nczo6TG9jYWxTdG9yYWdlRW5hYmxl ZCwgImxvY2FsU3RvcmFnZSIsIGZhbHNlKSwgZmFsc2UpOworICAgIFFFWFBFQ1RfRkFJTCgiIiwi aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQ1IiwgQ29udGludWUp OwogICAgIFFDT01QQVJFKHRlc3RGbGFnKHdlYlBhZ2UyLCBRV2ViU2V0dGluZ3M6OkxvY2FsU3Rv cmFnZUVuYWJsZWQsICJsb2NhbFN0b3JhZ2UiLCBmYWxzZSksIHRydWUpOwogfQogCg==