61044 2011-05-18 05:12:11 -0700 [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest 2011-05-27 11:23:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 ossy menard ademar cmarcelo commit-queue menard ossy oldest_to_newest 405658 0 ossy 2011-05-18 05:12:11 -0700 Error message with r86748: FAIL! : tst_QGraphicsWebView::setPalette(inactiveBG) Compared pointers are not the same Actual (QApplication::activeWindow()): (nil) Expected (activeView): 0xfffeddd8 Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp(450)] 410493 1 menard 2011-05-26 09:10:01 -0700 Ossy got some news? Is that a flacky test? 410509 2 ossy 2011-05-26 09:18:22 -0700 Yes, it is. Feel free to check the results on the bot and pick up this bug. 410570 3 95000 menard 2011-05-26 10:18:27 -0700 Created attachment 95000 Patch 410575 4 menard 2011-05-26 10:19:57 -0700 (In reply to comment #3) > Created an attachment (id=95000) [details] > Patch Sounds like more a workaround but if it works. It's a regression on the new bots it seems all of that was working before. Ossy can you test? 411426 5 95000 ossy 2011-05-27 07:30:29 -0700 Comment on attachment 95000 Patch Unfortunately I can't reproduce this bug locally now, but it still fails on the buildbot intermittently. I hope this patch will fix this flakiness. :) So r=me. 411450 6 95000 commit-queue 2011-05-27 08:34:29 -0700 Comment on attachment 95000 Patch Clearing flags on attachment: 95000 Committed r87514: <http://trac.webkit.org/changeset/87514> 411451 7 commit-queue 2011-05-27 08:34:35 -0700 All reviewed patches have been landed. Closing bug. 411569 8 ademar 2011-05-27 11:23:07 -0700 Revision r87514 cherry-picked into qtwebkit-2.2 with commit 329d0c6 <http://gitorious.org/webkit/qtwebkit/commit/329d0c6> 95000 2011-05-26 10:18:27 -0700 2011-05-27 08:34:29 -0700 Patch bug-61044-20110526141823.patch text/plain 1885 menard SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA4NzM5OSkKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMjYgIEFs ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdHN0X1FHcmFwaGlj c1dlYlZpZXc6OnNldFBhbGV0dGUoaW5hY3RpdmVCRykgYXV0b3Rlc3QKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDQ0CisKKyAgICAgICAgTWFrZSBz dXJlIHRvIHNldCB0aGUgYWN0aXZlIHdpbmRvdyBvbiB0aGUgYXBwbGljYXRpb24gdG9vLgorCisg ICAgICAgICogdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHA6 CisgICAgICAgICh0c3RfUUdyYXBoaWNzV2ViVmlldzo6c2V0UGFsZXR0ZSk6CisKIDIwMTEtMDUt MjUgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291 cmNlL1dlYktpdC9xdC90ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3FncmFwaGljc3dlYnZp ZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwCShyZXZpc2lvbiA4NzM5OCkKKysrIFNvdXJjZS9X ZWJLaXQvcXQvdGVzdHMvcWdyYXBoaWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM4Nyw5ICszODcsMTEgQEAgdm9pZCB0c3RfUUdyYXBoaWNzV2Vi Vmlldzo6c2V0UGFsZXR0ZSgpCiAgICAgaWYgKCFhY3RpdmUpIHsKICAgICAgICAgY29udHJvbFZp ZXcuc2hvdygpOwogICAgICAgICBRVGVzdDo6cVdhaXRGb3JXaW5kb3dTaG93bigmY29udHJvbFZp ZXcpOworICAgICAgICBRQXBwbGljYXRpb246OnNldEFjdGl2ZVdpbmRvdygmY29udHJvbFZpZXcp OwogICAgICAgICBhY3RpdmVWaWV3ID0gJmNvbnRyb2xWaWV3OwogICAgICAgICBjb250cm9sVmll dy5hY3RpdmF0ZVdpbmRvdygpOwogICAgIH0gZWxzZSB7CisgICAgICAgIFFBcHBsaWNhdGlvbjo6 c2V0QWN0aXZlV2luZG93KCZ2aWV3MSk7CiAgICAgICAgIHZpZXcxLmFjdGl2YXRlV2luZG93KCk7 CiAgICAgICAgIGFjdGl2ZVZpZXcgPSAmdmlldzE7CiAgICAgfQpAQCAtNDQwLDkgKzQ0MiwxMSBA QCB2b2lkIHRzdF9RR3JhcGhpY3NXZWJWaWV3OjpzZXRQYWxldHRlKCkKICAgICBpZiAoIWFjdGl2 ZSkgewogICAgICAgICBjb250cm9sVmlldy5zaG93KCk7CiAgICAgICAgIFFUZXN0OjpxV2FpdEZv cldpbmRvd1Nob3duKCZjb250cm9sVmlldyk7CisgICAgICAgIFFBcHBsaWNhdGlvbjo6c2V0QWN0 aXZlV2luZG93KCZjb250cm9sVmlldyk7CiAgICAgICAgIGFjdGl2ZVZpZXcgPSAmY29udHJvbFZp ZXc7CiAgICAgICAgIGNvbnRyb2xWaWV3LmFjdGl2YXRlV2luZG93KCk7CiAgICAgfSBlbHNlIHsK KyAgICAgICAgUUFwcGxpY2F0aW9uOjpzZXRBY3RpdmVXaW5kb3coJnZpZXcyKTsKICAgICAgICAg dmlldzIuYWN0aXZhdGVXaW5kb3coKTsKICAgICAgICAgYWN0aXZlVmlldyA9ICZ2aWV3MjsKICAg ICB9Cg==