61026 2011-05-18 00:28:23 -0700 Don't use DEFINE_STATIC_LOCAL with an unsigned 2011-05-18 09:13:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki psolanki simon.fraser oldest_to_newest 405554 0 psolanki 2011-05-18 00:28:23 -0700 StorageTracker.cpp has DEFINE_STATIC_LOCAL(const unsigned, fileExtLength, (fileExt.length())); DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here. 405556 1 93879 psolanki 2011-05-18 00:32:33 -0700 Created attachment 93879 Patch 405716 2 simon.fraser 2011-05-18 07:55:02 -0700 I wonder if we could make it compile error to use DEFINE_STATIC_LOCAL on POD types? 405770 3 psolanki 2011-05-18 09:13:16 -0700 Committed r86772: <http://trac.webkit.org/changeset/86772> 93879 2011-05-18 00:32:33 -0700 2011-05-18 00:33:13 -0700 Patch bug-61026-20110518003232.patch text/plain 1504 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogODY3MTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmNTczZWQ3OWY2NzA5OWI5 N2I1NjEzM2Q4NGJhODk5NDMxNGU3ZWQ2Li44YzI3MGFhMGMxNDE2YmMwYTg2ZTBkMzIzYzk1NzJi M2JiNjJlOGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTggIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHVzZSBERUZJTkVfU1RBVElDX0xPQ0FMIHdp dGggYW4gdW5zaWduZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYxMDI2CisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlN0b3JhZ2VUcmFja2VyOjpzeW5jRmlsZVN5c3RlbUFuZFRyYWNrZXJE YXRhYmFzZSk6IERFRklORV9TVEFUSUNfTE9DQUwgaXMgbWVhbnQKKyAgICAgICAgZm9yIG9iamVj dHMsIG5vdCB1bnNpZ25lZCBpbnRzLiBXZSBjYW4ganVzdCB1c2Ugc3RhdGljIGhlcmUuCisKIDIw MTEtMDUtMTcgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEphbWVzIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFn ZS9TdG9yYWdlVHJhY2tlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFj a2VyLmNwcAppbmRleCA0ZTZjY2NhYTEwMGQ0ZTExMjY0Y2FlYmI3ZGRmYTdlZGI5ZDg0YjEzLi5l YThlYTg4ZjQwOWRhMWU0YzY1ZGRhZmE4ZTNmM2M3OWQ1MWFlMWNlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmNwcApAQCAtMTk1LDcgKzE5NSw3IEBAIHZvaWQgU3Rv cmFnZVRyYWNrZXI6OnN5bmNGaWxlU3lzdGVtQW5kVHJhY2tlckRhdGFiYXNlKCkKICAgICBtX2Rh dGFiYXNlR3VhcmQubG9jaygpOwogICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5n LCBmaWxlTWF0Y2hQYXR0ZXJuLCAoIioubG9jYWxzdG9yYWdlIikpOwogICAgIERFRklORV9TVEFU SUNfTE9DQUwoY29uc3QgU3RyaW5nLCBmaWxlRXh0LCAoIi5sb2NhbHN0b3JhZ2UiKSk7Ci0gICAg REVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCB1bnNpZ25lZCwgZmlsZUV4dExlbmd0aCwgKGZpbGVF eHQubGVuZ3RoKCkpKTsKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgZmlsZUV4dExlbmd0aCA9 IGZpbGVFeHQubGVuZ3RoKCk7CiAgICAgbV9kYXRhYmFzZUd1YXJkLnVubG9jaygpOwogCiAgICAg VmVjdG9yPFN0cmluZz4gcGF0aHM7Cg==