6101 2005-12-15 13:33:50 -0800 Leaks in XSLTProcessorImpl due to early exit in failure case 2005-12-29 21:32:11 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric oldest_to_newest 26020 0 eric 2005-12-15 13:33:50 -0800 Leaks in XSLTProcessorImpl due to early-exit in failure case After adding two XSLT processor failure cases to the layout tests last week it's now possible to see a leak caused in that code path. The attached patch closes the leak. 26021 1 5099 eric 2005-12-15 13:35:09 -0800 Created attachment 5099 Proposed patch 26030 2 5099 darin 2005-12-15 21:53:23 -0800 Comment on attachment 5099 Proposed patch If the sourceDoc comes back 0, should we be returning true or false? This code returns true. Otherwise, looks fine. I guess I'll say review+. 26031 3 5099 eric 2005-12-15 22:48:07 -0800 Comment on attachment 5099 Proposed patch Bah, my bad. Yeah, it's supposed to return false. I'll init success to false instead when landing. 26210 4 5099 eric 2005-12-19 14:12:54 -0800 Comment on attachment 5099 Proposed patch This is wrong. I have a new patch I'll post. 27204 5 5367 eric 2005-12-29 20:21:54 -0800 Created attachment 5367 Better fix 5099 2005-12-15 13:35:09 -0800 2005-12-29 20:21:54 -0800 Proposed patch leak.patch text/plain 1563 eric SW5kZXg6IHhzbHRfcHJvY2Vzc29yaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYkNvcmUva2h0bWwveHNsL3hzbHRfcHJvY2Vzc29yaW1wbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMTcKZGlmZiAtcCAtdSAtcjEuMTcgeHNsdF9wcm9jZXNzb3JpbXBsLmNwcAot LS0geHNsdF9wcm9jZXNzb3JpbXBsLmNwcAkxIERlYyAyMDA1IDEwOjMyOjMwIC0wMDAwCTEuMTcK KysrIHhzbHRfcHJvY2Vzc29yaW1wbC5jcHAJMTUgRGVjIDIwMDUgMjE6MzU6MzkgLTAwMDAKQEAg LTI5NiwyMiArMjk2LDIyIEBAIGJvb2wgWFNMVFByb2Nlc3NvckltcGw6OnRyYW5zZm9ybVRvU3Ry aW4KICAgICB9CiAgICAgY2FjaGVkU3R5bGVzaGVldC0+Y2xlYXJEb2N1bWVudHMoKTsKICAgICAK LSAgICB4bWxEb2NQdHIgc291cmNlRG9jID0geG1sRG9jUHRyRnJvbU5vZGUoc291cmNlTm9kZSk7 Ci0gICAgY29uc3QgY2hhciAqKnBhcmFtcyA9IHhzbHRQYXJhbUFycmF5RnJvbVFEaWN0KG1fcGFy YW1ldGVycyk7Ci0gICAgeG1sRG9jUHRyIHJlc3VsdERvYyA9IHhzbHRBcHBseVN0eWxlc2hlZXQo c2hlZXQsIHNvdXJjZURvYywgcGFyYW1zKTsKLSAgICBmcmVlWHNsdFBhcmFtQXJyYXkocGFyYW1z KTsKKyAgICBib29sIHN1Y2Nlc3MgPSB0cnVlOworICAgIGlmICh4bWxEb2NQdHIgc291cmNlRG9j ID0geG1sRG9jUHRyRnJvbU5vZGUoc291cmNlTm9kZSkpIHsKKyAgICAgICAgY29uc3QgY2hhciAq KnBhcmFtcyA9IHhzbHRQYXJhbUFycmF5RnJvbVFEaWN0KG1fcGFyYW1ldGVycyk7CisgICAgICAg IHhtbERvY1B0ciByZXN1bHREb2MgPSB4c2x0QXBwbHlTdHlsZXNoZWV0KHNoZWV0LCBzb3VyY2VE b2MsIHBhcmFtcyk7CisgICAgICAgIHhtbEZyZWVEb2Moc291cmNlRG9jKTsKKyAgICAgICAgZnJl ZVhzbHRQYXJhbUFycmF5KHBhcmFtcyk7CisgICAgICAgIAorICAgICAgICBpZiAoc3VjY2VzcyA9 IHNhdmVSZXN1bHRUb1N0cmluZyhyZXN1bHREb2MsIHNoZWV0LCByZXN1bHRTdHJpbmcpKQorICAg ICAgICAgICAgbWltZVR5cGUgPSByZXN1bHRNSU1FVHlwZShyZXN1bHREb2MsIHNoZWV0KTsKKyAg ICAgICAgeG1sRnJlZURvYyhyZXN1bHREb2MpOworICAgIH0KICAgICAKICAgICBzZXRYU0xUTG9h ZENhbGxCYWNrKDAsIDAsIDApOwotICAgIAotICAgIGlmICghc2F2ZVJlc3VsdFRvU3RyaW5nKHJl c3VsdERvYywgc2hlZXQsIHJlc3VsdFN0cmluZykpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICAKLSAgICBtaW1lVHlwZSA9IHJlc3VsdE1JTUVUeXBlKHJlc3VsdERvYywgc2hlZXQpOwotICAg IAogICAgIHhzbHRGcmVlU3R5bGVzaGVldChzaGVldCk7Ci0gICAgeG1sRnJlZURvYyhyZXN1bHRE b2MpOwogICAgIAotICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBzdWNjZXNzOwogfQogCiBS ZWZQdHI8RG9jdW1lbnRJbXBsPiBYU0xUUHJvY2Vzc29ySW1wbDo6dHJhbnNmb3JtVG9Eb2N1bWVu dChOb2RlSW1wbCAqc291cmNlTm9kZSkK 5367 2005-12-29 20:21:54 -0800 2005-12-29 21:23:17 -0800 Better fix leak.patch text/plain 3515 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTkKZGlmZiAtcCAtdSAtcjEuNTkgQ2hh bmdlTG9nCi0tLSBDaGFuZ2VMb2cJMzAgRGVjIDIwMDUgMDQ6MTE6NDcgLTAwMDAJMS41OQorKysg Q2hhbmdlTG9nCTMwIERlYyAyMDA1IDA0OjIyOjQwIC0wMDAwCkBAIC0xLDUgKzEsMTYgQEAKIDIw MDUtMTItMjkgIEVyaWMgU2VpZGVsICA8ZXNlaWRlbEBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGVha3MgaW4gWFNMVFByb2Nlc3Nv ckltcGwgZHVlIHRvIGVhcmx5IGV4aXQgaW4gZmFpbHVyZSBjYXNlCisgICAgICAgIGh0dHA6Ly9i dWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMQorCisgICAgICAgICog a2h0bWwveHNsL3hzbHRfcHJvY2Vzc29yaW1wbC5jcHA6CisgICAgICAgIChET006OnhtbERvY1B0 ckZyb21Ob2RlKTogYWRkICJzaG91bGREZWxldGUiIGFyZ3VtZW50CisgICAgICAgIChET006OlhT TFRQcm9jZXNzb3JJbXBsOjp0cmFuc2Zvcm1Ub1N0cmluZyk6IGRlbGV0ZSBuZXcnZCB4bWxEb2MK KworMjAwNS0xMi0yOSAgRXJpYyBTZWlkZWwgIDxlc2VpZGVsQGFwcGxlLmNvbT4KKwogICAgICAg ICBGaWxlIGFjY2lkZW50YWxseSBvbWl0dGVkIGZyb20gcHJldmlvdXMgY29tbWl0LgogCiAgICAg ICAgIFJlbW92ZSBRRGljdCBmcm9tIGtodG1sL2h0bWwKSW5kZXg6IGtodG1sL3hzbC94c2x0X3By b2Nlc3NvcmltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3hzbC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIw CmRpZmYgLXAgLXUgLXIxLjIwIGtodG1sL3hzbC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwCi0tLSBr aHRtbC94c2wveHNsdF9wcm9jZXNzb3JpbXBsLmNwcAkyMyBEZWMgMjAwNSAwMzo1NzoyNSAtMDAw MAkxLjIwCisrKyBraHRtbC94c2wveHNsdF9wcm9jZXNzb3JpbXBsLmNwcAkzMCBEZWMgMjAwNSAw NDoyMzowMyAtMDAwMApAQCAtMjU3LDcgKzI1Nyw3IEBAIHN0YXRpYyB4c2x0U3R5bGVzaGVldFB0 ciB4c2x0U3R5bGVzaGVldFAKICAgICByZXR1cm4gY2FjaGVkU3R5bGVzaGVldC0+Y29tcGlsZVN0 eWxlU2hlZXQoKTsKIH0KIAotc3RhdGljIGlubGluZSB4bWxEb2NQdHIgeG1sRG9jUHRyRnJvbU5v ZGUoTm9kZUltcGwgKnNvdXJjZU5vZGUpCitzdGF0aWMgaW5saW5lIHhtbERvY1B0ciB4bWxEb2NQ dHJGcm9tTm9kZShOb2RlSW1wbCAqc291cmNlTm9kZSwgYm9vbCAmc2hvdWxkRGVsZXRlKQogewog ICAgIFJlZlB0cjxEb2N1bWVudEltcGw+IG93bmVyRG9jdW1lbnQgPSBzb3VyY2VOb2RlLT5nZXRE b2N1bWVudCgpOwogICAgIGJvb2wgc291cmNlSXNEb2N1bWVudCA9IChzb3VyY2VOb2RlID09IG93 bmVyRG9jdW1lbnQuZ2V0KCkpOwpAQCAtMjY1LDggKzI2NSwxMCBAQCBzdGF0aWMgaW5saW5lIHht bERvY1B0ciB4bWxEb2NQdHJGcm9tTm9kCiAgICAgeG1sRG9jUHRyIHNvdXJjZURvYyA9IDA7CiAg ICAgaWYgKHNvdXJjZUlzRG9jdW1lbnQpCiAgICAgICAgIHNvdXJjZURvYyA9ICh4bWxEb2NQdHIp b3duZXJEb2N1bWVudC0+dHJhbnNmb3JtU291cmNlKCk7Ci0gICAgaWYgKCFzb3VyY2VEb2MpCisg ICAgaWYgKCFzb3VyY2VEb2MpIHsKICAgICAgICAgc291cmNlRG9jID0gKHhtbERvY1B0cil4bWxE b2NQdHJGb3JTdHJpbmcoY3JlYXRlTWFya3VwKHNvdXJjZU5vZGUpLCBzb3VyY2VJc0RvY3VtZW50 ID8gb3duZXJEb2N1bWVudC0+VVJMKCkgOiBRU3RyaW5nKCkpOworICAgICAgICBzaG91bGREZWxl dGUgPSAoc291cmNlRG9jICE9IDApOworICAgIH0KICAgICByZXR1cm4gc291cmNlRG9jOwogfQog CkBAIC0zMDIsMjMgKzMwNCwyNiBAQCBib29sIFhTTFRQcm9jZXNzb3JJbXBsOjp0cmFuc2Zvcm1U b1N0cmluCiAgICAgfQogICAgIGNhY2hlZFN0eWxlc2hlZXQtPmNsZWFyRG9jdW1lbnRzKCk7CiAg ICAgCi0gICAgeG1sRG9jUHRyIHNvdXJjZURvYyA9IHhtbERvY1B0ckZyb21Ob2RlKHNvdXJjZU5v ZGUpOwotICAgIGNvbnN0IGNoYXIgKipwYXJhbXMgPSB4c2x0UGFyYW1BcnJheUZyb21QYXJhbWV0 ZXJNYXAobV9wYXJhbWV0ZXJzKTsKLSAgICB4bWxEb2NQdHIgcmVzdWx0RG9jID0geHNsdEFwcGx5 U3R5bGVzaGVldChzaGVldCwgc291cmNlRG9jLCBwYXJhbXMpOwotICAgIGZyZWVYc2x0UGFyYW1B cnJheShwYXJhbXMpOworICAgIGJvb2wgc3VjY2VzcyA9IGZhbHNlOworICAgIGJvb2wgc2hvdWxk RnJlZVNvdXJjZURvYyA9IGZhbHNlOworICAgIGlmICh4bWxEb2NQdHIgc291cmNlRG9jID0geG1s RG9jUHRyRnJvbU5vZGUoc291cmNlTm9kZSwgc2hvdWxkRnJlZVNvdXJjZURvYykpIHsKKyAgICAg ICAgY29uc3QgY2hhciAqKnBhcmFtcyA9IHhzbHRQYXJhbUFycmF5RnJvbVBhcmFtZXRlck1hcCht X3BhcmFtZXRlcnMpOworICAgICAgICB4bWxEb2NQdHIgcmVzdWx0RG9jID0geHNsdEFwcGx5U3R5 bGVzaGVldChzaGVldCwgc291cmNlRG9jLCBwYXJhbXMpOworICAgICAgICBmcmVlWHNsdFBhcmFt QXJyYXkocGFyYW1zKTsKKyAgICAgICAgaWYgKHNob3VsZEZyZWVTb3VyY2VEb2MpCisgICAgICAg ICAgICB4bWxGcmVlRG9jKHNvdXJjZURvYyk7CisgICAgICAgIAorICAgICAgICBpZiAoc3VjY2Vz cyA9IHNhdmVSZXN1bHRUb1N0cmluZyhyZXN1bHREb2MsIHNoZWV0LCByZXN1bHRTdHJpbmcpKSB7 CisgICAgICAgICAgICBtaW1lVHlwZSA9IHJlc3VsdE1JTUVUeXBlKHJlc3VsdERvYywgc2hlZXQp OworICAgICAgICAgICAgcmVzdWx0RW5jb2RpbmcgPSAoY2hhciAqKXJlc3VsdERvYy0+ZW5jb2Rp bmc7CisgICAgICAgIH0KKyAgICAgICAgeG1sRnJlZURvYyhyZXN1bHREb2MpOworICAgIH0KICAg ICAKICAgICBzZXRYU0xUTG9hZENhbGxCYWNrKDAsIDAsIDApOwotICAgIAotICAgIGlmICghc2F2 ZVJlc3VsdFRvU3RyaW5nKHJlc3VsdERvYywgc2hlZXQsIHJlc3VsdFN0cmluZykpCi0gICAgICAg IHJldHVybiBmYWxzZTsKLSAgICAKLSAgICBtaW1lVHlwZSA9IHJlc3VsdE1JTUVUeXBlKHJlc3Vs dERvYywgc2hlZXQpOwotICAgIHJlc3VsdEVuY29kaW5nID0gKGNoYXIgKilyZXN1bHREb2MtPmVu Y29kaW5nOwotICAgIAogICAgIHhzbHRGcmVlU3R5bGVzaGVldChzaGVldCk7Ci0gICAgeG1sRnJl ZURvYyhyZXN1bHREb2MpOwotICAgIAotICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIHN1 Y2Nlc3M7CiB9CiAKIFJlZlB0cjxEb2N1bWVudEltcGw+IFhTTFRQcm9jZXNzb3JJbXBsOjp0cmFu c2Zvcm1Ub0RvY3VtZW50KE5vZGVJbXBsICpzb3VyY2VOb2RlKQo=