61008 2011-05-17 18:14:14 -0700 Assertion failed if text field is cleared while drag&drop 2011-11-11 12:53:14 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 honten webkit-unassigned ap dglazkov enrica kaustubh.ra mrobinson rniwa tony webkit.review.bot oldest_to_newest 405431 0 honten 2011-05-17 18:14:14 -0700 if I select and drag text and a dom event fires (e.g., ondragenter) and removes the text I'm dragging, we hit the same assertion. Attached the manual test file. 1, Run debug version 2, open drag.html 3, select "test" text in left text field and start dragging the selected text. 4, drop the test into the right text field. 5, Assertion failed as following, ASSERT(endingSelection().isNonOrphanedRange()); #0 0x0225bddd in WebCore::MoveSelectionCommand::doApply at MoveSelectionCommand.cpp:42 #1 0x0222c62b in WebCore::EditCommand::apply at EditCommand.cpp:92 #2 0x0222c6db in WebCore::applyCommand at EditCommand.cpp:229 #3 0x023ce0e3 in WebCore::DragController::concludeEditDrag at DragController.cpp:467 #4 0x023cf053 in WebCore::DragController::performDrag at DragController.cpp:206 #5 0x01a6aa35 in WebKit::WebViewImpl::dragTargetDrop at WebViewImpl.cpp:1937 #6 0x02f63aad in RenderView::OnDragTargetDrop at render_view.cc:3327 405432 1 93853 honten 2011-05-17 18:14:58 -0700 Created attachment 93853 Test html file. 488210 2 111912 kaustubh.ra 2011-10-20 23:45:57 -0700 Created attachment 111912 Patch This was issue with GtkUtilities to calculate screenPoints, gtk2 API was being used for translating window co-ordinates. 488379 3 111912 enrica 2011-10-21 07:47:50 -0700 Comment on attachment 111912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111912&action=review > Source/WebCore/platform/gtk/GtkUtilities.cpp:44 > +#endif Are xInWindow and yInWindow in and out parameters? If not, I believe it is confusing to have them initialized in the GTK_API_VERSION_2 case. 488436 4 mrobinson 2011-10-21 09:33:56 -0700 I'm having trouble understanding this change. Is the call to gtk_window_translate_coordinates unnecessary? Are the coordinates correct without it. It's unusual that this would be required for GTK+ 2, but not something similar for GTK+ 3. Furthermore, I don't understand how this leads to an assertion failure. I'm not saying the patch is wrong, I just don't grok it. 488827 5 kaustubh.ra 2011-10-21 20:00:37 -0700 (In reply to comment #4) > I'm having trouble understanding this change. Is the call to gtk_window_translate_coordinates unnecessary? Are the coordinates correct without it. It's unusual that this would be required for GTK+ 2, but not something similar for GTK+ 3. AFAIK, In case of GTK+2, when the text is being dragged there is another small window getting created to hold the text being dragged. And for that the Widget we received in this call has to be translated into its toplevel widget co-ordinates which is not the GTK+3 case. Furthermore, I don't understand how this leads to an assertion failure. > The assert is thrown in this case as the endingSelection does not find it be in Range as the Position returned by dragData created from the point in convertWidgetPointToScreenPoint is not proper. > I'm not saying the patch is wrong, I just don't grok it. 488864 6 mrobinson 2011-10-21 21:29:48 -0700 (In reply to comment #5) > (In reply to comment #4) > > I'm having trouble understanding this change. Is the call to gtk_window_translate_coordinates unnecessary? Are the coordinates correct without it. It's unusual that this would be required for GTK+ 2, but not something similar for GTK+ 3. > > AFAIK, In case of GTK+2, when the text is being dragged there is another small window getting created to hold the text being dragged. And for that the Widget we received in this call has to be translated into its toplevel widget co-ordinates which is not the GTK+3 case. This is also the case for GTK+ 3, AFAIK. The small window is the drag icon. 488867 7 kaustubh.ra 2011-10-21 21:36:21 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > I'm having trouble understanding this change. Is the call to gtk_window_translate_coordinates unnecessary? Are the coordinates correct without it. It's unusual that this would be required for GTK+ 2, but not something similar for GTK+ 3. > > > > AFAIK, In case of GTK+2, when the text is being dragged there is another small window getting created to hold the text being dragged. And for that the Widget we received in this call has to be translated into its toplevel widget co-ordinates which is not the GTK+3 case. > > This is also the case for GTK+ 3, AFAIK. The small window is the drag icon. During debug I was getting different points. So I looked around google to check and found this http://stackoverflow.com/questions/2088962/how-do-you-find-the-absolute-position-of-a-gtk-widget-in-a-window Where they suggested to use either of the APIs to find absolute position. 489053 8 kaustubh.ra 2011-10-23 12:21:34 -0700 IMHO, the call gtk_widget_translate_coordinates seems unnecessary. We can remove that. I am not able to test it somehow as I have gtk3 but will try on another machine may be tomorrow. From the suggestion on stackoverflow.com though its not very full proof, and also from Gtk API reference it seems that we should be using either of API. 496072 9 113625 kaustubh.ra 2011-11-03 23:54:28 -0700 Created attachment 113625 Patch This bug is duplicate of https://bugs.webkit.org/show_bug.cgi?id=70277 and has been fixed. Adding layout test case for text dragging. 496075 10 113625 rniwa 2011-11-04 00:05:23 -0700 Comment on attachment 113625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113625&action=review > LayoutTests/ChangeLog:7 > + Please explain what kind of test you're adding and that the assertion failure has been fixed in another changeset (including the revision) > LayoutTests/fast/events/drag-text-with-clear.html:10 > + if (window.layoutTestController) > + layoutTestController.dumpAsText(); Please don't outdent the entire script content. 496076 11 113625 rniwa 2011-11-04 00:05:47 -0700 Comment on attachment 113625 Patch r- due to missing change log entry. 496078 12 113627 kaustubh.ra 2011-11-04 00:10:24 -0700 Created attachment 113627 Updated Patch Added ChangeLog explanation for adding test case. 496079 13 113628 kaustubh.ra 2011-11-04 00:12:01 -0700 Created attachment 113628 Updated Patch 496081 14 kaustubh.ra 2011-11-04 00:22:11 -0700 Thanks Ryosuke for quick review :) 496084 15 rniwa 2011-11-04 00:26:12 -0700 (In reply to comment #14) > Thanks Ryosuke for quick review :) Thanks a lot for adding the test! 496087 16 113628 webkit.review.bot 2011-11-04 00:35:32 -0700 Comment on attachment 113628 Updated Patch Attachment 113628 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10313077 New failing tests: fast/events/drag-text-with-clear.html 496614 17 kaustubh.ra 2011-11-04 19:43:10 -0700 (In reply to comment #16) > (From update of attachment 113628 [details]) > Attachment 113628 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10313077 > > New failing tests: > fast/events/drag-text-with-clear.html Hi Ryosuke any idea why this must be failing? Do I need to add platform specific things if any ? 496617 18 rniwa 2011-11-04 19:49:52 -0700 I don't know. Maybe Tony would know? 497530 19 tony 2011-11-07 15:31:58 -0800 I tried running this on Chromium Linux, the results include the text "test". That seems correct to me (ie., the text is moved into the second input area). What platform does this test work for you? On Mac, you probably need to add a eventSender.leapForward call initiate a drag. 497778 20 kaustubh.ra 2011-11-07 23:33:11 -0800 (In reply to comment #19) > I tried running this on Chromium Linux, the results include the text "test". That seems correct to me (ie., the text is moved into the second input area). > > What platform does this test work for you? On Mac, you probably need to add a eventSender.leapForward call initiate a drag. I am working on GTK platform. Guess i might need to add platform specific result? 497782 21 114000 kaustubh.ra 2011-11-07 23:41:49 -0800 Created attachment 114000 Patch Updated test case. 498753 22 kaustubh.ra 2011-11-09 02:38:41 -0800 Ryosuke, can you review once? Thanks. 501013 23 114000 webkit.review.bot 2011-11-11 12:53:07 -0800 Comment on attachment 114000 Patch Clearing flags on attachment: 114000 Committed r100009: <http://trac.webkit.org/changeset/100009> 501014 24 webkit.review.bot 2011-11-11 12:53:14 -0800 All reviewed patches have been landed. Closing bug. 93853 2011-05-17 18:14:58 -0700 2011-05-17 18:14:58 -0700 Test html file. drag.html text/html 477 honten PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHRpdGxlPlNhbXBsZTwvdGl0bGU+ CiAgICA8c2NyaXB0PgogICAgICB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7CiAgICAgICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0T2JqIikub25kcmFnZW50ZXIgPSBmdW5jdGlv bigpIHsKICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhU TUwgPSAiRHJhZyBFbnRlciI7CiAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5w dXRPYmoiKS52YWx1ZSA9ICIiOwogICAgICAgIH0KICAgICAgfQogICAgPC9zY3JpcHQ+CiAgPC9o ZWFkPgogIDxib2R5PgogICAgPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4KICAgIDxpbnB1dCB0eXBl PSJ0ZXh0IiBpZD0iaW5wdXRPYmoiIHZhbHVlPSJ0ZXN0Ij4KICAgIDxpbnB1dCB0eXBlPSJ0ZXh0 Ij4KICA8L2JvZHk+CjwvaHRtbD4K 111912 2011-10-20 23:45:57 -0700 2011-11-03 23:54:28 -0700 Patch patch.txt text/plain 1992 kaustubh.ra SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4MDcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMjAgIEthdXN0dWJo IEF0cmF3YWxrYXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9u IGZhaWxlZCBpZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyZkcm9wCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTAwOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0 a1V0aWxpdGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb252ZXJ0V2lkZ2V0UG9pbnRUb1Nj cmVlblBvaW50KTogQWRkaW5nICNpZmRlZiBmb3IgR1RLMiBBUEkgdGhhdCBjYXVzZXMKKyAgICAg ICAgaW52YWxpZCBzY3JlZW5Qb2ludCBwb3NpdGlvbiBmb3IgZHJvcCBldmVudC4KKwogMjAxMS0x MC0yMCAgUGV0ZXIgUnliaW4gIDxwZXRlci5yeWJpbkBnbWFpbC5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogcmVpbXBsZW1lbnQgcHJvdG9jb2wgYmFja2VuZC9mcm9udGVuZCBzb3VyY2Ug Z2VuZXJhdG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0aWVz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0 aWVzLmNwcAkocmV2aXNpb24gOTgwNjUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv R3RrVXRpbGl0aWVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBD b3B5cmlnaHQgKEMpIDIwMTEsIElnYWxpYSBTLkwuCisgKiBDb3B5cmlnaHQgKGMpIDIwMTAgTW90 b3JvbGEgTW9iaWxpdHksIEluYy4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAgLTM0LDkgKzM1LDEz IEBAIEludFBvaW50IGNvbnZlcnRXaWRnZXRQb2ludFRvU2NyZWVuUG9pbnQKICAgICBpZiAoIXRv cGxldmVsV2lkZ2V0IHx8ICFndGtfd2lkZ2V0X2lzX3RvcGxldmVsKHRvcGxldmVsV2lkZ2V0KSB8 fCAhR1RLX0lTX1dJTkRPVyh0b3BsZXZlbFdpZGdldCkpCiAgICAgICAgIHJldHVybiBwb2ludDsK IAotICAgIGludCB4SW5XaW5kb3csIHlJbldpbmRvdzsKLSAgICBndGtfd2lkZ2V0X3RyYW5zbGF0 ZV9jb29yZGluYXRlcyh3aWRnZXQsIHRvcGxldmVsV2lkZ2V0LCBwb2ludC54KCksIHBvaW50Lnko KSwgJnhJbldpbmRvdywgJnlJbldpbmRvdyk7CisgICAgaW50IHhJbldpbmRvdyA9IHBvaW50Lngo KTsKKyAgICBpbnQgeUluV2luZG93ID0gcG9pbnQueSgpOwogICAgIGludCB3aW5kb3dPcmlnaW5Y LCB3aW5kb3dPcmlnaW5ZOworCisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKKyAgICBndGtfd2lk Z2V0X3RyYW5zbGF0ZV9jb29yZGluYXRlcyh3aWRnZXQsIHRvcGxldmVsV2lkZ2V0LCBwb2ludC54 KCksIHBvaW50LnkoKSwgJnhJbldpbmRvdywgJnlJbldpbmRvdyk7CisjZW5kaWYKICAgICBnZGtf d2luZG93X2dldF9vcmlnaW4oZ3RrX3dpZGdldF9nZXRfd2luZG93KHRvcGxldmVsV2lkZ2V0KSwg JndpbmRvd09yaWdpblgsICZ3aW5kb3dPcmlnaW5ZKTsKIAogICAgIHJldHVybiBJbnRQb2ludCh3 aW5kb3dPcmlnaW5YICsgeEluV2luZG93LCB3aW5kb3dPcmlnaW5ZICsgeUluV2luZG93KTsK 113625 2011-11-03 23:54:28 -0700 2011-11-04 00:10:24 -0700 Patch 61008_patch.txt text/plain 2559 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk5MjYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMDQgIEthdXN0dWJoIEF0cmF3YWxr YXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCBp ZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyZkcm9wLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2RyYWctdGV4dC13 aXRoLWNsZWFyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVudHMvZHJh Zy10ZXh0LXdpdGgtY2xlYXIuaHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMDMgIEVyaWMgQ2FybHNv biAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZm9yZ290 IHRvIHNraXAgYSBuZXcgdGVzdCBpbiByOTkyNjEuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXItZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xl YXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKK1RoaXMgdGVzdHMg dGhhdCBpZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyAtIGRyb3AgaXQgZG9lcyBu b3QgZ2l2ZSBhbnkgQXNzZXJ0cyAoQnVnIDYxMDA4KQorCitQQVNTCisgCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFyLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGJvZHk+Cis8cD4gVGhpcyB0ZXN0cyB0aGF0IGlmIHRleHQgZmllbGQgaXMgY2xlYXJlZCB3 aGlsZSBkcmFnIC0gZHJvcCBpdCBkb2VzIG5vdCBnaXZlIGFueSBBc3NlcnRzIDxhIGhyZWY9aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMDA4PihCdWcgNjEwMDgpPC9h PjwvcD4KKzxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+Cis8aW5wdXQgdHlwZT0idGV4dCIgaWQ9Imlu cHV0T2JqZWN0IiB2YWx1ZT0idGVzdCI+Cis8aW5wdXQgdHlwZT0idGV4dCIgaWQ9Im91dHB1dE9i amVjdCI+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJpbnB1dE9iamVjdCIpLm9uZHJhZ2VudGVyID0gZnVuY3Rpb24oKSB7 CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbnB1dE9iamVjdCIpLnZhbHVlID0g IiI7CisgICAgfQorCisgICAgZnVuY3Rpb24gZHJhZ1RleHQoc3JjLCBkZXN0KQorICAgIHsKKyAg ICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3JjLm9mZnNldExlZnQgKyA1LCBzcmMub2Zm c2V0VG9wICsgMik7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgICAgICBl dmVudFNlbmRlci5tb3VzZU1vdmVUbyhzcmMub2Zmc2V0TGVmdCArIDEwLCBzcmMub2Zmc2V0VG9w ICsgMik7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGRlc3Qub2Zmc2V0TGVmdCAr IDUsIGRlc3Qub2Zmc2V0VG9wICsgMik7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsK KyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVySFRNTCA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdXRwdXRPYmplY3QiKS52YWx1ZTsKKyAgICB9CisKKyAg ICB2YXIgaW5wdXRPYmplY3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXRPYmplY3Qi KTsKKyAgICB2YXIgb3V0cHV0T2JqZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm91dHB1 dE9iamVjdCIpOworICAgIGlucHV0T2JqZWN0LmZvY3VzKCk7CisgICAgZHJhZ1RleHQoaW5wdXRP YmplY3QsIG91dHB1dE9iamVjdCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 113627 2011-11-04 00:10:24 -0700 2011-11-04 00:12:01 -0700 Updated Patch 61008_patch.txt text/plain 2731 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk5MjYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDQgIEthdXN0dWJoIEF0cmF3YWxr YXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCBp ZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyZkcm9wLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRvIGRyYWctZHJvcCB0ZXh0IGZy b20gb25lIGlucHV0IGVsZW1lbnQgdG8gYW5vdGhlciBjbGVhcmluZyB0aGUgZmlyc3QgaW5wdXQK KyAgICAgICAgZWxlbWVudC4gRml4ZWQgaW4gQ2hhbmdlIHNldCAtIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0Lzk5MDg1CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcmFnLXRleHQt d2l0aC1jbGVhci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ry YWctdGV4dC13aXRoLWNsZWFyLmh0bWw6IEFkZGVkLgorCiAyMDExLTExLTAzICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZvcmdv dCB0byBza2lwIGEgbmV3IHRlc3QgaW4gcjk5MjYxLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFyLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNs ZWFyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3Rz IHRoYXQgaWYgdGV4dCBmaWVsZCBpcyBjbGVhcmVkIHdoaWxlIGRyYWcgLSBkcm9wIGl0IGRvZXMg bm90IGdpdmUgYW55IEFzc2VydHMgKEJ1ZyA2MTAwOCkKKworUEFTUworIApJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXIuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXIu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxib2R5PgorPHA+IFRoaXMgdGVzdHMgdGhhdCBpZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQg d2hpbGUgZHJhZyAtIGRyb3AgaXQgZG9lcyBub3QgZ2l2ZSBhbnkgQXNzZXJ0cyA8YSBocmVmPWh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTAwOD4oQnVnIDYxMDA4KTwv YT48L3A+Cis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorPGlucHV0IHR5cGU9InRleHQiIGlkPSJp bnB1dE9iamVjdCIgdmFsdWU9InRlc3QiPgorPGlucHV0IHR5cGU9InRleHQiIGlkPSJvdXRwdXRP YmplY3QiPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiaW5wdXRPYmplY3QiKS5vbmRyYWdlbnRlciA9IGZ1bmN0aW9uKCkg eworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXRPYmplY3QiKS52YWx1ZSA9 ICIiOworICAgIH0KKworICAgIGZ1bmN0aW9uIGRyYWdUZXh0KHNyYywgZGVzdCkKKyAgICB7Cisg ICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHNyYy5vZmZzZXRMZWZ0ICsgNSwgc3JjLm9m ZnNldFRvcCArIDIpOworICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICAgICAg ZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3JjLm9mZnNldExlZnQgKyAxMCwgc3JjLm9mZnNldFRv cCArIDIpOworICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhkZXN0Lm9mZnNldExlZnQg KyA1LCBkZXN0Lm9mZnNldFRvcCArIDIpOworICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7 CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgib3V0cHV0T2JqZWN0IikudmFsdWU7CisgICAgfQorCisg ICAgdmFyIGlucHV0T2JqZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0T2JqZWN0 Iik7CisgICAgdmFyIG91dHB1dE9iamVjdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdXRw dXRPYmplY3QiKTsKKyAgICBpbnB1dE9iamVjdC5mb2N1cygpOworICAgIGRyYWdUZXh0KGlucHV0 T2JqZWN0LCBvdXRwdXRPYmplY3QpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 113628 2011-11-04 00:12:01 -0700 2011-11-07 23:41:49 -0800 Updated Patch 61008_patch.txt text/plain 2659 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk5MjYzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDQgIEthdXN0dWJoIEF0cmF3YWxr YXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCBp ZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyZkcm9wLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRvIGRyYWctZHJvcCB0ZXh0IGZy b20gb25lIGlucHV0IGVsZW1lbnQgdG8gYW5vdGhlciBjbGVhcmluZyB0aGUgZmlyc3QgaW5wdXQK KyAgICAgICAgZWxlbWVudC4gRml4ZWQgaW4gQ2hhbmdlIHNldCAtIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0Lzk5MDg1CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcmFnLXRleHQt d2l0aC1jbGVhci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ry YWctdGV4dC13aXRoLWNsZWFyLmh0bWw6IEFkZGVkLgorCiAyMDExLTExLTAzICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZvcmdv dCB0byBza2lwIGEgbmV3IHRlc3QgaW4gcjk5MjYxLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFyLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNs ZWFyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3Rz IHRoYXQgaWYgdGV4dCBmaWVsZCBpcyBjbGVhcmVkIHdoaWxlIGRyYWcgLSBkcm9wIGl0IGRvZXMg bm90IGdpdmUgYW55IEFzc2VydHMgKEJ1ZyA2MTAwOCkKKworUEFTUworIApJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXIuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXIu aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxib2R5PgorPHA+IFRoaXMgdGVzdHMgdGhhdCBpZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQg d2hpbGUgZHJhZyAtIGRyb3AgaXQgZG9lcyBub3QgZ2l2ZSBhbnkgQXNzZXJ0cyA8YSBocmVmPWh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTAwOD4oQnVnIDYxMDA4KTwv YT48L3A+Cis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorPGlucHV0IHR5cGU9InRleHQiIGlkPSJp bnB1dE9iamVjdCIgdmFsdWU9InRlc3QiPgorPGlucHV0IHR5cGU9InRleHQiIGlkPSJvdXRwdXRP YmplY3QiPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiaW5wdXRPYmplY3QiKS5vbmRyYWdlbnRlciA9IGZ1bmN0aW9uKCkgeworICAgIGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJpbnB1dE9iamVjdCIpLnZhbHVlID0gIiI7Cit9CisKK2Z1bmN0 aW9uIGRyYWdUZXh0KHNyYywgZGVzdCkKK3sKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhz cmMub2Zmc2V0TGVmdCArIDUsIHNyYy5vZmZzZXRUb3AgKyAyKTsKKyAgICBldmVudFNlbmRlci5t b3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhzcmMub2Zmc2V0TGVmdCAr IDEwLCBzcmMub2Zmc2V0VG9wICsgMik7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oZGVz dC5vZmZzZXRMZWZ0ICsgNSwgZGVzdC5vZmZzZXRUb3AgKyAyKTsKKyAgICBldmVudFNlbmRlci5t b3VzZVVwKCk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVySFRN TCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdXRwdXRPYmplY3QiKS52YWx1ZTsKK30KKwor dmFyIGlucHV0T2JqZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlucHV0T2JqZWN0Iik7 Cit2YXIgb3V0cHV0T2JqZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm91dHB1dE9iamVj dCIpOworaW5wdXRPYmplY3QuZm9jdXMoKTsKK2RyYWdUZXh0KGlucHV0T2JqZWN0LCBvdXRwdXRP YmplY3QpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 114000 2011-11-07 23:41:49 -0800 2011-11-11 12:53:07 -0800 Patch 61008_patch.txt text/plain 2678 kaustubh.ra SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDk5NTI2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDcgIEthdXN0dWJoIEF0cmF3YWxr YXIgIDxrYXVzdHViaEBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCBp ZiB0ZXh0IGZpZWxkIGlzIGNsZWFyZWQgd2hpbGUgZHJhZyZkcm9wLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRvIGRyYWctZHJvcCB0ZXh0IGZy b20gb25lIGlucHV0IGVsZW1lbnQgdG8gYW5vdGhlciBjbGVhcmluZyB0aGUgZmlyc3QgaW5wdXQK KyAgICAgICAgZWxlbWVudC4gRml4ZWQgaW4gQ2hhbmdlIHNldCAtIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0Lzk5MDg1CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcmFnLXRleHQt d2l0aC1jbGVhci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ry YWctdGV4dC13aXRoLWNsZWFyLmh0bWw6IEFkZGVkLgorCiAyMDExLTExLTA3ICBLZW5pY2hpIElz aGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIExheW91 dCBUZXN0IHBsYXRmb3JtL2Nocm9taXVtLWNnLW1hYy9lZGl0aW5nL2lucHV0L2ltZS1jYW5kaWRh dGUtd2luZG93LXBvc2l0aW9uLmh0bWwgaXMgZmxha3kKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1jbGVhci1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcmFnLXRleHQtd2l0aC1j bGVhci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorVGhpcyB0ZXN0 cyB0aGF0IGlmIHRleHQgZmllbGQgaXMgY2xlYXJlZCB3aGlsZSBkcmFnIC0gZHJvcCBpdCBkb2Vz IG5vdCBnaXZlIGFueSBBc3NlcnRzIChCdWcgNjEwMDgpCisKK1BBU1MKKyAKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFyLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJhZy10ZXh0LXdpdGgtY2xlYXIuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2RyYWctdGV4dC13aXRoLWNsZWFy Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzIgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+Cis8Ym9keT4KKzxwPiBUaGlzIHRlc3RzIHRoYXQgaWYgdGV4dCBmaWVsZCBpcyBjbGVhcmVk IHdoaWxlIGRyYWcgLSBkcm9wIGl0IGRvZXMgbm90IGdpdmUgYW55IEFzc2VydHMgPGEgaHJlZj1o dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEwMDg+KEJ1ZyA2MTAwOCk8 L2E+PC9wPgorPGRpdiBpZD0icmVzdWx0Ij48L2Rpdj4KKzxpbnB1dCB0eXBlPSJ0ZXh0IiBpZD0i aW5wdXRPYmplY3QiIHZhbHVlPSJ0ZXN0Ij4KKzxpbnB1dCB0eXBlPSJ0ZXh0IiBpZD0ib3V0cHV0 T2JqZWN0Ij4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImlucHV0T2JqZWN0Iikub25kcmFnZW50ZXIgPSBmdW5jdGlvbigpIHsKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiaW5wdXRPYmplY3QiKS52YWx1ZSA9ICIiOworfQorCitmdW5j dGlvbiBkcmFnVGV4dChzcmMsIGRlc3QpCit7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8o c3JjLm9mZnNldExlZnQgKyA1LCBzcmMub2Zmc2V0VG9wICsgMik7CisgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3JjLm9mZnNldExlZnQg KyAxMCwgc3JjLm9mZnNldFRvcCArIDIpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGRl c3Qub2Zmc2V0TGVmdCArIDUsIGRlc3Qub2Zmc2V0VG9wICsgMik7CisgICAgZXZlbnRTZW5kZXIu bW91c2VVcCgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhU TUwgPSAiUEFTUyI7Cit9CisKK3ZhciBpbnB1dE9iamVjdCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJpbnB1dE9iamVjdCIpOwordmFyIG91dHB1dE9iamVjdCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJvdXRwdXRPYmplY3QiKTsKK2lucHV0T2JqZWN0LmZvY3VzKCk7CitkcmFnVGV4dChp bnB1dE9iamVjdCwgb3V0cHV0T2JqZWN0KTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=