60989 2011-05-17 14:39:50 -0700 Clear deprecated icon APIs from chromium port 2011-05-17 17:09:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 michaelbai webkit-unassigned commit-queue fishd oldest_to_newest 405294 0 michaelbai 2011-05-17 14:39:50 -0700 Following the previous patch https://bugs.webkit.org/show_bug.cgi?id=60247, Clear deprecated icon APIs from chromium port. 405300 1 93819 michaelbai 2011-05-17 14:49:02 -0700 Created attachment 93819 Initial implementation 405347 2 93819 fishd 2011-05-17 15:38:36 -0700 Comment on attachment 93819 Initial implementation woohoo! 405409 3 93819 commit-queue 2011-05-17 17:08:58 -0700 Comment on attachment 93819 Initial implementation Clearing flags on attachment: 93819 Committed r86721: <http://trac.webkit.org/changeset/86721> 405410 4 commit-queue 2011-05-17 17:09:03 -0700 All reviewed patches have been landed. Closing bug. 93819 2011-05-17 14:49:02 -0700 2011-05-17 17:08:58 -0700 Initial implementation patch.0 text/plain 4612 michaelbai SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4NjcwNykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDUtMTcgIFRhbyBCYWkgIDxtaWNoYWVsYmFpQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciBkZXByZWNh dGVkIGljb24gQVBJcyBmcm9tIGNocm9taXVtIHBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDk4OQorCisgICAgICAgICogcHVibGljL1dlYkZy YW1lLmg6IFJlbW92ZWQgZmF2aWNvblVSTCgpCisgICAgICAgICogcHVibGljL1dlYkZyYW1lQ2xp ZW50Lmg6IFJlbW92ZWQgZGlkQ2hhbmdlSWNvbnMoKQorICAgICAgICAqIHNyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuY3BwOgorICAgICAgICAgICAgIFJlbW92ZWQgdGhlIGNvZGUgdG8gc3VwcG9y dCBkZXByZWNhdGVkIEFQSQorICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6 OmRpc3BhdGNoRGlkQ2hhbmdlSWNvbnMpOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3Bw OiBSZW1vdmVkIGZhdmljb25VUkwoKQorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDogIFJl bW92ZWQgZmF2aWNvblVSTCgpCisKIDIwMTEtMDUtMTcgIEFuZHJldyBXaWxzb24gIDxhdHdpbHNv bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg2NjQ3 LgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCShyZXZpc2lv biA4NjcwNCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHdv cmtpbmcgY29weSkKQEAgLTEzMiwxOSArMTMyLDExIEBAIHB1YmxpYzoKICAgICAvLyBkYXRhU291 cmNlKCktPnJlcXVlc3QoKS51cmwoKS4KICAgICB2aXJ0dWFsIFdlYlVSTCB1cmwoKSBjb25zdCA9 IDA7CiAKLSAgICAvLyBERVBSRUNBVEVEOiBVc2UgaWNvbklSTHMgaW5zdGVhZC4KLSAgICB2aXJ0 dWFsIFdlYlVSTCBmYXZJY29uVVJMKCkgY29uc3QgPSAwOwotCiAgICAgLy8gVGhlIHVybHMgb2Yg dGhlIGdpdmVuIGNvbWJpbmF0aW9uIHR5cGVzIG9mIGZhdmljb24gKGlmIGFueSkgc3BlY2lmaWVk IGJ5CiAgICAgLy8gdGhlIGRvY3VtZW50IGxvYWRlZCBpbiB0aGlzIGZyYW1lLiBUaGUgaWNvblR5 cGVzIGlzIGEgYml0LW1hc2sgb2YKICAgICAvLyBXZWJJY29uVVJMOjpUeXBlIHZhbHVlcywgdXNl ZCB0byBzZWxlY3QgZnJvbSB0aGUgYXZhaWxhYmxlIHNldCBvZiBpY29uCiAgICAgLy8gVVJMcwot ICAgIHZpcnR1YWwgV2ViVmVjdG9yPFdlYkljb25VUkw+IGljb25VUkxzKGludCBpY29uVHlwZXMp IGNvbnN0Ci0gICAgewotICAgICAgICAvLyBGSVhNRSA6IFJlbW92ZSB0aGUgaW1wbGVtZW50YXRp b24sIHRoaXMgbWFrZSBidWlsZGJvdCBoYXBweSBkdXJpbmcKLSAgICAgICAgLy8gICAgICAgICB0 aGUgdHJhbnNpZW50LgotICAgICAgICByZXR1cm4gV2ViVmVjdG9yPFdlYkljb25VUkw+KCk7Ci0g ICAgfQorICAgIHZpcnR1YWwgV2ViVmVjdG9yPFdlYkljb25VUkw+IGljb25VUkxzKGludCBpY29u VHlwZXMpIGNvbnN0ID0gMDsKIAogICAgIC8vIFRoZSB1cmwgb2YgdGhlIE9wZW5TZWFyY2ggRGVz cmlwdGlvbiBEb2N1bWVudCAoaWYgYW55KSBzcGVjaWZpZWQgYnkKICAgICAvLyB0aGUgZG9jdW1l bnQgbG9hZGVkIGluIHRoaXMgZnJhbWUuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJGcmFtZUNsaWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgJKHJldmlzaW9uIDg2NzA0KQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAt MjAyLDkgKzIwMiw2IEBAIHB1YmxpYzoKICAgICAgICAgZGlkUmVjZWl2ZVRpdGxlKGZyYW1lLCB0 aXRsZSk7CiAgICAgfQogCi0gICAgLy8gREVQUkVDQVRFRDogSW1wbGVtZW50IGRpZENoYW5nZUlj b24gaW5zdGVhZC4KLSAgICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlSWNvbnMoV2ViRnJhbWUqKSB7 IH0KLQogICAgIC8vIFRoZSBpY29uIGZvciB0aGUgcGFnZSBoYXZlIGNoYW5nZWQuCiAgICAgdmly dHVhbCB2b2lkIGRpZENoYW5nZUljb24oV2ViRnJhbWUqLCBXZWJJY29uVVJMOjpUeXBlKSB7IH0K IApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA4NjcwNCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc1OSwx MiArNzU5LDggQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkUgogCiB2 b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlzcGF0Y2hEaWRDaGFuZ2VJY29ucyhXZWJDb3Jl OjpJY29uVHlwZSB0eXBlKQogewotICAgIGlmIChtX3dlYkZyYW1lLT5jbGllbnQoKSkgeworICAg IGlmIChtX3dlYkZyYW1lLT5jbGllbnQoKSkKICAgICAgICAgbV93ZWJGcmFtZS0+Y2xpZW50KCkt PmRpZENoYW5nZUljb24obV93ZWJGcmFtZSwgc3RhdGljX2Nhc3Q8V2ViSWNvblVSTDo6VHlwZT4o dHlwZSkpOwotICAgICAgICAvLyBGSVhNRSA6IEtlZXAgdGhlIEFQSSB3b3JrIGluIHRoZSB0cmFu c2llbnQuCi0gICAgICAgIGlmICh0eXBlID09IFdlYkNvcmU6OkZhdmljb24pCi0gICAgICAgICAg ICBtX3dlYkZyYW1lLT5jbGllbnQoKS0+ZGlkQ2hhbmdlSWNvbnMobV93ZWJGcmFtZSk7Ci0gICAg fQogfQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6ZGlzcGF0Y2hEaWRDb21taXRMb2Fk KCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAko cmV2aXNpb24gODY3MDQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjAsMTQgKzUyMCw2IEBAIFdlYlVSTCBXZWJGcmFt ZUltcGw6OnVybCgpIGNvbnN0CiAgICAgcmV0dXJuIGRzLT5yZXF1ZXN0KCkudXJsKCk7CiB9CiAK LVdlYlVSTCBXZWJGcmFtZUltcGw6OmZhdkljb25VUkwoKSBjb25zdAotewotICAgIFdlYlZlY3Rv cjxXZWJJY29uVVJMPiB1cmxzID0gaWNvblVSTHMoV2ViSWNvblVSTDo6VHlwZUZhdmljb24pOwot ICAgIGlmICh1cmxzLnNpemUoKSkKLSAgICAgICAgcmV0dXJuIHVybHNbMF0uaWNvblVSTCgpOwot ICAgIHJldHVybiBXZWJVUkwoKTsKLX0KLQogV2ViVmVjdG9yPFdlYkljb25VUkw+IFdlYkZyYW1l SW1wbDo6aWNvblVSTHMoaW50IGljb25UeXBlcykgY29uc3QKIHsKICAgICBGcmFtZUxvYWRlciog ZnJhbWVMb2FkZXIgPSBtX2ZyYW1lLT5sb2FkZXIoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCShyZXZpc2lvbiA4NjcwNCkKKysrIFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3 MCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0TmFtZShjb25zdCBXZWJTdHJpbmcm KTsKICAgICB2aXJ0dWFsIGxvbmcgbG9uZyBpZGVudGlmaWVyKCkgY29uc3Q7CiAgICAgdmlydHVh bCBXZWJVUkwgdXJsKCkgY29uc3Q7Ci0gICAgdmlydHVhbCBXZWJVUkwgZmF2SWNvblVSTCgpIGNv bnN0OwogICAgIHZpcnR1YWwgV2ViVmVjdG9yPFdlYkljb25VUkw+IGljb25VUkxzKGludCBpY29u VHlwZXMpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVVJMIG9wZW5TZWFyY2hEZXNjcmlwdGlvblVS TCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViU3RyaW5nIGVuY29kaW5nKCkgY29uc3Q7Cg==