60977 2011-05-17 12:12:08 -0700 [chromium] Always set layerRenderer, even on non-drawn-layers 2011-05-17 15:34:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca commit-queue jamesr nduca oldest_to_newest 405215 0 nduca 2011-05-17 12:12:08 -0700 [chromium] Always set layerRenderer, even on non-drawn-layers 405222 1 93805 nduca 2011-05-17 12:16:28 -0700 Created attachment 93805 Patch 405240 2 93805 jamesr 2011-05-17 12:38:54 -0700 Comment on attachment 93805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93805&action=review Change looks good. Is there any way to test this (even manually)? > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:353 > + renderSurfaceLayer->setLayerRenderer(this); I think this is redundant - have you checked if this helps? drawLayers() skips render surfaces with an empty layer list (see http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp#L448). I suppose it doesn't hurt to set it regardless. 405251 3 93810 nduca 2011-05-17 13:00:52 -0700 Created attachment 93810 Add some comments for posterity. 405343 4 93810 commit-queue 2011-05-17 15:34:33 -0700 Comment on attachment 93810 Add some comments for posterity. Clearing flags on attachment: 93810 Committed r86713: <http://trac.webkit.org/changeset/86713> 405344 5 commit-queue 2011-05-17 15:34:37 -0700 All reviewed patches have been landed. Closing bug. 93805 2011-05-17 12:16:28 -0700 2011-05-17 13:00:49 -0700 Patch bug-60977-20110517121627.patch text/plain 2749 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogODY2NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzk1Mzk0NDk3ZTkxZjlh NTUzMzJlZDI0ZGQ0NjlkOTk5ZGExZTJjLi5jZTMzZDQyMWM0MmVhN2FkMGJhOTBlNWNjYTRlOTEy NDE3YzM1Yzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMTcgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWx3YXlzIHNldCBsYXllclJlbmRlcmVyLCBl dmVuIG9uIG5vbi1kcmF3bi1sYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYwOTc3CisKKyAgICAgICAgVGhpcyBmaXhlcyBjcmFzaGJ1ZyBjcmJ1 Zy5jb20vODI3OTksIGluIHdoaWNoIGEgUmVuZGVyTGF5ZXIKKyAgICAgICAgY291bGQgbm90IHBy ZXBhcmUgaXRzZWxmIGJlY2F1c2UgaXRzIG93bmluZyBsYXllckltcGwgaGFkIG5vCisgICAgICAg IGFzc29jaWF0ZWQgbGF5ZXJSZW5kZXJlci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM YXllclJlbmRlcmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyk6CisKIDIwMTEtMDUtMTYg IEFuZHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjg2NjI1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAKaW5kZXggNWU1YzI3YjRmYzBjZjJjZGQ2Njc2MzIwM2I0MDBjMzQxMzg0YTNjNC4uNTc4 ZDMxMThhNjBjMTk2YjFlMWM3YTkzOTdkZTAyYWY4ZjZiNmMyZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXll clJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC0zNTAsNiArMzUwLDggQEAgdm9pZCBMYXllclJlbmRl cmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBMYXllckxpc3QmIHJlbmRlclN1 cmZhY2VMYXkKICAgICAgICAgUmVuZGVyU3VyZmFjZUNocm9taXVtKiByZW5kZXJTdXJmYWNlID0g cmVuZGVyU3VyZmFjZUxheWVyLT5yZW5kZXJTdXJmYWNlKCk7CiAgICAgICAgIEFTU0VSVChyZW5k ZXJTdXJmYWNlKTsKIAorICAgICAgICByZW5kZXJTdXJmYWNlTGF5ZXItPnNldExheWVyUmVuZGVy ZXIodGhpcyk7CisKICAgICAgICAgLy8gUmVuZGVyIHN1cmZhY2VzIHdob3NlIGRyYXdhYmxlIGFy ZWEgaGFzIHplcm8gd2lkdGggb3IgaGVpZ2h0CiAgICAgICAgIC8vIHdpbGwgaGF2ZSBubyBsYXll cnMgYXNzb2NpYXRlZCB3aXRoIHRoZW0gYW5kIHNob3VsZCBiZSBza2lwcGVkLgogICAgICAgICBp ZiAoIXJlbmRlclN1cmZhY2UtPm1fbGF5ZXJMaXN0LnNpemUoKSkKQEAgLTM2NiwxMCArMzY4LDkg QEAgdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBM YXllckxpc3QmIHJlbmRlclN1cmZhY2VMYXkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAog ICAgICAgICAgICAgTGF5ZXJDaHJvbWl1bSogbGF5ZXIgPSBjY0xheWVySW1wbC0+b3duZXIoKTsK LSAgICAgICAgICAgIGlmIChsYXllci0+Ym91bmRzKCkuaXNFbXB0eSgpKQotICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICBsYXllci0+c2V0TGF5ZXJSZW5kZXJlcih0aGlz KTsKKwogICAgICAgICAgICAgaWYgKGxheWVyLT5tYXNrTGF5ZXIoKSkKICAgICAgICAgICAgICAg ICBsYXllci0+bWFza0xheWVyKCktPnNldExheWVyUmVuZGVyZXIodGhpcyk7CiAgICAgICAgICAg ICBpZiAobGF5ZXItPnJlcGxpY2FMYXllcigpKSB7CkBAIC0zNzgsNiArMzc5LDkgQEAgdm9pZCBM YXllclJlbmRlcmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBMYXllckxpc3Qm IHJlbmRlclN1cmZhY2VMYXkKICAgICAgICAgICAgICAgICAgICAgbGF5ZXItPnJlcGxpY2FMYXll cigpLT5tYXNrTGF5ZXIoKS0+c2V0TGF5ZXJSZW5kZXJlcih0aGlzKTsKICAgICAgICAgICAgIH0K IAorICAgICAgICAgICAgaWYgKGxheWVyLT5ib3VuZHMoKS5pc0VtcHR5KCkpCisgICAgICAgICAg ICAgIGNvbnRpbnVlOworCiAgICAgICAgICAgICBJbnRSZWN0IHRhcmdldFN1cmZhY2VSZWN0ID0g Y2NMYXllckltcGwtPnRhcmdldFJlbmRlclN1cmZhY2UoKSA/IGNjTGF5ZXJJbXBsLT50YXJnZXRS ZW5kZXJTdXJmYWNlKCktPmNvbnRlbnRSZWN0KCkgOiBtX2RlZmF1bHRSZW5kZXJTdXJmYWNlLT5j b250ZW50UmVjdCgpOwogICAgICAgICAgICAgSW50UmVjdCBzY2lzc29yUmVjdCA9IGxheWVyLT5j Y0xheWVySW1wbCgpLT5zY2lzc29yUmVjdCgpOwogICAgICAgICAgICAgaWYgKCFzY2lzc29yUmVj dC5pc0VtcHR5KCkpCg== 93810 2011-05-17 13:00:52 -0700 2011-05-17 15:34:32 -0700 Add some comments for posterity. bug-60977-20110517130051.patch text/plain 3383 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogODY2NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzk1Mzk0NDk3ZTkxZjlh NTUzMzJlZDI0ZGQ0NjlkOTk5ZGExZTJjLi43ZjgwMGU3N2NkYzdkZTAwMTJmNmVlY2RkZjQxMGQz NGI3OGE1YTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMTcgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWx3YXlzIHNldCBsYXllclJlbmRlcmVyLCBl dmVuIG9uIG5vbi1kcmF3bi1sYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYwOTc3CisKKyAgICAgICAgVGhpcyBpcyBhIGRlZmVuc2l2ZSBmaXhl IGZvciBjcmJ1Zy5jb20vODI3OTksIGluIHdoaWNoCisgICAgICAgIGEgUmVuZGVyTGF5ZXIgY291 bGQgbm90IHByZXBhcmUgaXRzZWxmIGJlY2F1c2UgaXRzIG93bmluZyBsYXllckltcGwKKyAgICAg ICAgaGFkIG5vIGFzc29jaWF0ZWQgbGF5ZXJSZW5kZXJlci4gVGhlIHVuZGVybHlpbmcgaXNzdWUg aXMgdGhhdCB3ZQorICAgICAgICBzb21ldGltZXMgcHV0IHJlbmRlclN1cmZhY2VzIG9udG8gdGhl IGxpc3QgdGhhdCB3b24ndCBhY3R1YWxseSByZW5kZXIuCisgICAgICAgIEZvciBub3csIHRoZSBw cmlvcml0eSBpcyB0byByZWR1Y2UgZnJhZ2lsaXR5IHNvIHRoYXQgaW52aXNpYmxlIGxheWVycwor ICAgICAgICBkb250IGxlYWQgdG8gY3Jhc2hlcnMuIFdlIGRvIHRoaXMgYnkgYmVpbmcgbW9yZSBh Z3Jlc3NpdmUgYWJvdXQgCisgICAgICAgIGJpbmRpbmcgQ0NMYXllckltcGxzIHRvIHRoZSBMYXll clJlbmRlcmVyLCBkb2luZyBpdCBhbGwgdGhlIHRpbWUgcmF0aGVyCisgICAgICAgIHRoYW4gb25s eSB3aGVuIHdlIHRoaW5rIGl0IHdpbGwgZ2V0IHJlbmRlcmVkLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6cGFpbnRMYXllckNvbnRlbnRzKToKKwog MjAxMS0wNS0xNiAgQW5kcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByODY2MjUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAppbmRleCA1ZTVjMjdiNGZjMGNmMmNkZDY2NzYzMjAzYjQwMGMzNDEz ODRhM2M0Li41ODQyMmYxMDkxZTY3NmQwMTI3ZmYzZmFhZTFhNjI4ODA0MDdmMmM1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTM1MCw2ICszNTAsMTEgQEAgdm9p ZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBMYXllckxp c3QmIHJlbmRlclN1cmZhY2VMYXkKICAgICAgICAgUmVuZGVyU3VyZmFjZUNocm9taXVtKiByZW5k ZXJTdXJmYWNlID0gcmVuZGVyU3VyZmFjZUxheWVyLT5yZW5kZXJTdXJmYWNlKCk7CiAgICAgICAg IEFTU0VSVChyZW5kZXJTdXJmYWNlKTsKIAorICAgICAgICAvLyBNYWtlIHN1cmUgYW55IHJlbmRl clN1cmZhY2VMYXllciBpcyBhc3NvY2lhdGVkIHdpdGggdGhpcyBsYXllclJlbmRlcmVyLgorICAg ICAgICAvLyBUaGlzIGlzIGEgZGVmZW5zaXZlIGFzc2lnbm1lbnQgaW4gY2FzZSB0aGUgb3duZXIg b2YgdGhpcyBsYXllciBoYXNuJ3QKKyAgICAgICAgLy8gc2V0IHRoZSBsYXllclJlbmRlcmVyIG9u IHRoaXMgbGF5ZXIgYWxyZWFkeS4KKyAgICAgICAgcmVuZGVyU3VyZmFjZUxheWVyLT5zZXRMYXll clJlbmRlcmVyKHRoaXMpOworCiAgICAgICAgIC8vIFJlbmRlciBzdXJmYWNlcyB3aG9zZSBkcmF3 YWJsZSBhcmVhIGhhcyB6ZXJvIHdpZHRoIG9yIGhlaWdodAogICAgICAgICAvLyB3aWxsIGhhdmUg bm8gbGF5ZXJzIGFzc29jaWF0ZWQgd2l0aCB0aGVtIGFuZCBzaG91bGQgYmUgc2tpcHBlZC4KICAg ICAgICAgaWYgKCFyZW5kZXJTdXJmYWNlLT5tX2xheWVyTGlzdC5zaXplKCkpCkBAIC0zNjYsMTAg KzM3MSw5IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpwYWludExheWVyQ29udGVudHMo Y29uc3QgTGF5ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5CiAgICAgICAgICAgICAgICAgY29udGlu dWU7CiAKICAgICAgICAgICAgIExheWVyQ2hyb21pdW0qIGxheWVyID0gY2NMYXllckltcGwtPm93 bmVyKCk7Ci0gICAgICAgICAgICBpZiAobGF5ZXItPmJvdW5kcygpLmlzRW1wdHkoKSkKLSAgICAg ICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgbGF5ZXItPnNldExheWVyUmVuZGVy ZXIodGhpcyk7CisKICAgICAgICAgICAgIGlmIChsYXllci0+bWFza0xheWVyKCkpCiAgICAgICAg ICAgICAgICAgbGF5ZXItPm1hc2tMYXllcigpLT5zZXRMYXllclJlbmRlcmVyKHRoaXMpOwogICAg ICAgICAgICAgaWYgKGxheWVyLT5yZXBsaWNhTGF5ZXIoKSkgewpAQCAtMzc4LDYgKzM4Miw5IEBA IHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpwYWludExheWVyQ29udGVudHMoY29uc3QgTGF5 ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5CiAgICAgICAgICAgICAgICAgICAgIGxheWVyLT5yZXBs aWNhTGF5ZXIoKS0+bWFza0xheWVyKCktPnNldExheWVyUmVuZGVyZXIodGhpcyk7CiAgICAgICAg ICAgICB9CiAKKyAgICAgICAgICAgIGlmIChsYXllci0+Ym91bmRzKCkuaXNFbXB0eSgpKQorICAg ICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICAgICAgSW50UmVjdCB0YXJnZXRTdXJmYWNl UmVjdCA9IGNjTGF5ZXJJbXBsLT50YXJnZXRSZW5kZXJTdXJmYWNlKCkgPyBjY0xheWVySW1wbC0+ dGFyZ2V0UmVuZGVyU3VyZmFjZSgpLT5jb250ZW50UmVjdCgpIDogbV9kZWZhdWx0UmVuZGVyU3Vy ZmFjZS0+Y29udGVudFJlY3QoKTsKICAgICAgICAgICAgIEludFJlY3Qgc2Npc3NvclJlY3QgPSBs YXllci0+Y2NMYXllckltcGwoKS0+c2Npc3NvclJlY3QoKTsKICAgICAgICAgICAgIGlmICghc2Np c3NvclJlY3QuaXNFbXB0eSgpKQo=