60965 2011-05-17 09:27:31 -0700 GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color 2011-05-17 10:13:26 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 klobag klobag commit-queue kbr oldest_to_newest 405088 0 klobag 2011-05-17 09:27:31 -0700 Currently Skia version of GraphicsContext3D always uses BGRA8 format as source. It should check SK_x_SHIFT. 405092 1 93779 klobag 2011-05-17 09:32:41 -0700 Created attachment 93779 Patch 405100 2 93779 kbr 2011-05-17 09:47:18 -0700 Comment on attachment 93779 Patch Looks good. Thanks for taking care of this. 405118 3 93779 commit-queue 2011-05-17 10:13:22 -0700 Comment on attachment 93779 Patch Clearing flags on attachment: 93779 Committed r86679: <http://trac.webkit.org/changeset/86679> 405119 4 commit-queue 2011-05-17 10:13:26 -0700 All reviewed patches have been landed. Closing bug. 93779 2011-05-17 09:32:41 -0700 2011-05-17 10:13:22 -0700 Patch bug-60965-20110517093240.patch text/plain 1736 klobag SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2Njc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMTcgIEdyYWNlIEts b2JhICA8a2xvYmFnQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBHcmFwaGljc0NvbnRleHQzRFNraWEgbmVlZHMgdG8gaG9ub3Ig dGhlIHBsYXRmb3JtIFNrX3hfU0hJRlQgdmFsdWUgaW5zdGVhZCBvZiBhc3N1bWluZyBCR1JBIGNv bG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDk2 NQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNr aWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OmdldEltYWdlRGF0 YSk6CisKIDIwMTEtMDUtMTcgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHQzRFNraWEuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3Jh cGhpY3NDb250ZXh0M0RTa2lhLmNwcAkocmV2aXNpb24gODY1MjApCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dDNEU2tpYS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJJbWFnZS5oIgogI2luY2x1ZGUg IkltYWdlU291cmNlLmgiCiAjaW5jbHVkZSAiTmF0aXZlSW1hZ2VTa2lhLmgiCisjaW5jbHVkZSAi U2tDb2xvclByaXYuaCIKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bh c3NPd25QdHIuaD4KIApAQCAtODAsNyArODEsOCBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNEOjpn ZXRJbWFnZURhdGEoSW1hCiAgICAgQVNTRVJUKHNraWFJbWFnZS0+cm93Qnl0ZXMoKSA9PSBza2lh SW1hZ2UtPndpZHRoKCkgKiA0KTsKICAgICBvdXRwdXRWZWN0b3IucmVzaXplKHNraWFJbWFnZS0+ cm93Qnl0ZXMoKSAqIHNraWFJbWFnZS0+aGVpZ2h0KCkpOwogICAgIHJldHVybiBwYWNrUGl4ZWxz KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHNraWFJbWFnZS0+Z2V0UGl4ZWxzKCkp LAotICAgICAgICAgICAgICAgICAgICAgIFNvdXJjZUZvcm1hdEJHUkE4LCBza2lhSW1hZ2UtPndp ZHRoKCksIHNraWFJbWFnZS0+aGVpZ2h0KCksIDAsCisgICAgICAgICAgICAgICAgICAgICAgU0tf QjMyX1NISUZUID8gU291cmNlRm9ybWF0UkdCQTggOiBTb3VyY2VGb3JtYXRCR1JBOCwKKyAgICAg ICAgICAgICAgICAgICAgICBza2lhSW1hZ2UtPndpZHRoKCksIHNraWFJbWFnZS0+aGVpZ2h0KCks IDAsCiAgICAgICAgICAgICAgICAgICAgICAgZm9ybWF0LCB0eXBlLCBuZWVkZWRBbHBoYU9wLCBv dXRwdXRWZWN0b3IuZGF0YSgpKTsKIH0KIAo=