60937 2011-05-16 17:44:36 -0700 SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API 2011-07-02 13:57:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren mjs ap mjs psolanki oldest_to_newest 404848 0 ggaren 2011-05-16 17:44:36 -0700 Here's the code: name = makeName(6); (k%2)?email=name+"@mac.com":email=name+"(at)mac.com"; Since 'name' is undeclared, and window.name defaults to the DOM frame name API, this test spends a bunch of time getting and setting the name of the frame in the DOM. Of course we want the DOM to be fast, but testing the DOM seems contrary to the goals of SunSpider. 404952 1 ap 2011-05-16 23:18:45 -0700 This is fixed in a r-'ed patch attached to bug 17634, although with a slightly different rationale. 405403 2 ggaren 2011-05-17 16:57:24 -0700 It looks like Maciej planned to fix this, but never got around to it. I think the important issue is to pick a name that doesn't conflict with a DOM API. Whether the variable is declared as a var or not is no big deal. 431633 3 99560 mjs 2011-07-02 13:53:49 -0700 Created attachment 99560 Patch 431635 4 mjs 2011-07-02 13:57:46 -0700 Committed r90318: <http://trac.webkit.org/changeset/90318> 99560 2011-07-02 13:53:49 -0700 2011-07-02 13:55:31 -0700 Patch bug-60937-20110702135348.patch text/plain 1442 mjs SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3VuU3BpZGVyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBQZXJmb3JtYW5jZVRlc3RzL1N1blNwaWRlci9DaGFuZ2VMb2cJKHJldmlzaW9uIDkwMzE3KQor KysgUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMDIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxl LmNvbT4KKworICAgICAgICBTdW5TcGlkZXI6IHN0cmluZy12YWxpZGF0ZS1pbnB1dC5qcyB1c2Vz IGFuIHVuZGVjbGFyZWQgdmFyaWFibGUgbmFtZWQgJ25hbWUnLCB3aGljaCBpcyBhIERPTSBBUEkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwOTM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9z dW5zcGlkZXItMS4wL3N0cmluZy12YWxpZGF0ZS1pbnB1dC5qczoKKyAgICAgICAgKGRvVGVzdCk6 IFJlbmFtZSB0aGUgdmFyaWFibGUgdG8gdXNlcm5hbWUKKwogMjAxMS0wNy0wMiAgTWFjaWVqIFN0 YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvdGVzdHMvc3Vuc3BpZGVyLTEu MC9zdHJpbmctdmFsaWRhdGUtaW5wdXQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0 cy9TdW5TcGlkZXIvdGVzdHMvc3Vuc3BpZGVyLTEuMC9zdHJpbmctdmFsaWRhdGUtaW5wdXQuanMJ KHJldmlzaW9uIDkwMzE2KQorKysgUGVyZm9ybWFuY2VUZXN0cy9TdW5TcGlkZXIvdGVzdHMvc3Vu c3BpZGVyLTEuMC9zdHJpbmctdmFsaWRhdGUtaW5wdXQuanMJKHdvcmtpbmcgY29weSkKQEAgLTEx LDggKzExLDggQEAgZnVuY3Rpb24gZG9UZXN0KCkKICAgIC8vIG1ha2UgdXAgZW1haWwgYWRkcmVz cwogICAgZm9yICh2YXIgaz0wO2s8NDAwMDtrKyspCiAgICB7Ci0gICAgICBuYW1lID0gbWFrZU5h bWUoNik7Ci0gICAgICAoayUyKT9lbWFpbD1uYW1lKyJAbWFjLmNvbSI6ZW1haWw9bmFtZSsiKGF0 KW1hYy5jb20iOworICAgICAgdXNlcm5hbWUgPSBtYWtlTmFtZSg2KTsKKyAgICAgIChrJTIpP2Vt YWlsPXVzZXJuYW1lKyJAbWFjLmNvbSI6ZW1haWw9dXNlcm5hbWUrIihhdCltYWMuY29tIjsKIAog ICAgICAgLy8gdmFsaWRhdGUgdGhlIGVtYWlsIGFkZHJlc3MKICAgICAgIHZhciBwYXR0ZXJuID0g L15bYS16QS1aMC05XC1cLl9dK0BbYS16QS1aMC05XC1fXSsoXC4/W2EtekEtWjAtOVwtX10qKVwu W2EtekEtWl17MiwzfSQvOwo=