60927 2011-05-16 15:23:02 -0700 fastCheckSelector() does not inline correctly in all cases 2011-05-16 16:40:16 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned ddkilzer zwarich oldest_to_newest 404766 0 koivisto 2011-05-16 15:23:02 -0700 It should use anonymous namespace and functions as template arguments. 404769 1 93705 koivisto 2011-05-16 15:26:53 -0700 Created attachment 93705 patch 404774 2 koivisto 2011-05-16 15:31:26 -0700 <rdar://problem/9443884> 404802 3 93705 ddkilzer 2011-05-16 16:15:36 -0700 Comment on attachment 93705 patch r=me 404817 4 koivisto 2011-05-16 16:40:16 -0700 http://trac.webkit.org/changeset/86635 93705 2011-05-16 15:26:53 -0700 2011-05-16 16:15:36 -0700 patch fastcheckselector-inline.patch text/plain 5122 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NjEzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTYgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MDkyNworICAgICAgICBmYXN0Q2hlY2tTZWxlY3RvcigpIGRvZXMgbm90IGlubGluZSBjb3Jy ZWN0bHkgaW4gYWxsIGNhc2VzCisKKyAgICAgICAgVXNlIGFub255bW91cyBuYW1lc3BhY2UgaW5z dGVhZCBvZiBzdGF0aWMgcXVhbGlmaWVyIHRvIGdldCBpbnRlcm5hbCBsaW5rYWdlLgorICAgICAg ICBVc2UgZnVuY3Rpb25zIGFzIHRlbXBsYXRlIGFyZ3VtZW50cyBpbnN0ZWFkIG9mIGNsYXNzZXMu CisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NTdHlsZVNlbGVjdG9yOjpTZWxlY3RvckNoZWNrZXI6OmZhc3RDaGVja1NlbGVjdG9yKToK KwogMjAxMS0wNS0xNiAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZy4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDg2NTc0KQorKysgU291cmNl L1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDU2 LDggKzIwNTYsMTAgQEAgaW5saW5lIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6Y2hlY2tTZWxlYwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgcmV0dXJuIHRydWU7CiB9CisgICAgCituYW1lc3Bh Y2UgewogCi1zdGF0aWMgaW5saW5lIGJvb2wgc2VsZWN0b3JUYWdNYXRjaGVzKGNvbnN0IEVsZW1l bnQqIGVsZW1lbnQsIGNvbnN0IENTU1NlbGVjdG9yKiBzZWxlY3RvcikKK2lubGluZSBib29sIHNl bGVjdG9yVGFnTWF0Y2hlcyhjb25zdCBFbGVtZW50KiBlbGVtZW50LCBjb25zdCBDU1NTZWxlY3Rv ciogc2VsZWN0b3IpCiB7CiAgICAgaWYgKCFzZWxlY3Rvci0+aGFzVGFnKCkpCiAgICAgICAgIHJl dHVybiB0cnVlOwpAQCAtMjA2OCw3ICsyMDcwLDcgQEAgc3RhdGljIGlubGluZSBib29sIHNlbGVj dG9yVGFnTWF0Y2hlcyhjbwogICAgIHJldHVybiBuYW1lc3BhY2VVUkkgPT0gc3RhckF0b20gfHwg bmFtZXNwYWNlVVJJID09IGVsZW1lbnQtPm5hbWVzcGFjZVVSSSgpOwogfQogCi1zdGF0aWMgaW5s aW5lIGJvb2wgaXNGYXN0Q2hlY2thYmxlU2VsZWN0b3IoY29uc3QgQ1NTU2VsZWN0b3IqIHNlbGVj dG9yKQoraW5saW5lIGJvb2wgaXNGYXN0Q2hlY2thYmxlU2VsZWN0b3IoY29uc3QgQ1NTU2VsZWN0 b3IqIHNlbGVjdG9yKQogewogICAgIGZvciAoOyBzZWxlY3Rvcjsgc2VsZWN0b3IgPSBzZWxlY3Rv ci0+dGFnSGlzdG9yeSgpKSB7CiAgICAgICAgIGlmIChzZWxlY3Rvci0+cmVsYXRpb24oKSAhPSBD U1NTZWxlY3Rvcjo6RGVzY2VuZGFudCAmJiBzZWxlY3Rvci0+cmVsYXRpb24oKSAhPSBDU1NTZWxl Y3Rvcjo6Q2hpbGQgJiYgc2VsZWN0b3ItPnJlbGF0aW9uKCkgIT0gQ1NTU2VsZWN0b3I6OlN1YlNl bGVjdG9yKQpAQCAtMjA3OSwxMiArMjA4MSwxMiBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNGYXN0 Q2hlY2thYmxlU2VsZWN0CiAgICAgcmV0dXJuIHRydWU7CiB9CiAgICAgCi10ZW1wbGF0ZSA8Y2xh c3MgVmFsdWVDaGVja2VyPgordGVtcGxhdGUgPGJvb2wgY2hlY2tWYWx1ZShjb25zdCBFbGVtZW50 KiwgQXRvbWljU3RyaW5nSW1wbCopPgogaW5saW5lIGJvb2wgZmFzdENoZWNrU2luZ2xlU2VsZWN0 b3IoY29uc3QgQ1NTU2VsZWN0b3IqJiBzZWxlY3RvciwgY29uc3QgRWxlbWVudComIGVsZW1lbnQs IGNvbnN0IENTU1NlbGVjdG9yKiYgdG9wQ2hpbGRPclN1YnNlbGVjdG9yLCBjb25zdCBFbGVtZW50 KiYgdG9wQ2hpbGRPclN1YnNlbGVjdG9yTWF0Y2hFbGVtZW50KQogewogICAgIEF0b21pY1N0cmlu Z0ltcGwqIHZhbHVlID0gc2VsZWN0b3ItPnZhbHVlKCkuaW1wbCgpOwogICAgIGZvciAoOyBlbGVt ZW50OyBlbGVtZW50ID0gZWxlbWVudC0+cGFyZW50RWxlbWVudCgpKSB7Ci0gICAgICAgIGlmIChW YWx1ZUNoZWNrZXI6OmNoZWNrVmFsdWUoZWxlbWVudCwgdmFsdWUpICYmIHNlbGVjdG9yVGFnTWF0 Y2hlcyhlbGVtZW50LCBzZWxlY3RvcikpIHsKKyAgICAgICAgaWYgKGNoZWNrVmFsdWUoZWxlbWVu dCwgdmFsdWUpICYmIHNlbGVjdG9yVGFnTWF0Y2hlcyhlbGVtZW50LCBzZWxlY3RvcikpIHsKICAg ICAgICAgICAgIGlmIChzZWxlY3Rvci0+cmVsYXRpb24oKSA9PSBDU1NTZWxlY3Rvcjo6RGVzY2Vu ZGFudCkKICAgICAgICAgICAgICAgICB0b3BDaGlsZE9yU3Vic2VsZWN0b3IgPSAwOwogICAgICAg ICAgICAgZWxzZSBpZiAoIXRvcENoaWxkT3JTdWJzZWxlY3RvcikgewpAQCAtMjExNCwyNCArMjEx NiwyMiBAQCBpbmxpbmUgYm9vbCBmYXN0Q2hlY2tTaW5nbGVTZWxlY3Rvcihjb25zCiAgICAgcmV0 dXJuIGZhbHNlOwogfQogCi1zdHJ1Y3QgQ2xhc3NDaGVjayB7Ci0gICAgc3RhdGljIGJvb2wgY2hl Y2tWYWx1ZShjb25zdCBFbGVtZW50KiBlbGVtZW50LCBBdG9taWNTdHJpbmdJbXBsKiB2YWx1ZSkg Ci0gICAgewotICAgICAgICByZXR1cm4gZWxlbWVudC0+aGFzQ2xhc3MoKSAmJiBzdGF0aWNfY2Fz dDxjb25zdCBTdHlsZWRFbGVtZW50Kj4oZWxlbWVudCktPmNsYXNzTmFtZXMoKS5jb250YWlucyh2 YWx1ZSk7Ci0gICAgfQotfTsKLXN0cnVjdCBJZENoZWNrIHsKLSAgICBzdGF0aWMgYm9vbCBjaGVj a1ZhbHVlKGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQsIEF0b21pY1N0cmluZ0ltcGwqIHZhbHVlKSAK LSAgICB7Ci0gICAgICAgIHJldHVybiBlbGVtZW50LT5oYXNJRCgpICYmIGVsZW1lbnQtPmlkRm9y U3R5bGVSZXNvbHV0aW9uKCkuaW1wbCgpID09IHZhbHVlOwotICAgIH0KLX07Ci1zdHJ1Y3QgVGFn Q2hlY2sgewotICAgIHN0YXRpYyBib29sIGNoZWNrVmFsdWUoY29uc3QgRWxlbWVudCosIEF0b21p Y1N0cmluZ0ltcGwqKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotfTsKK2lu bGluZSBib29sIGNoZWNrQ2xhc3NWYWx1ZShjb25zdCBFbGVtZW50KiBlbGVtZW50LCBBdG9taWNT dHJpbmdJbXBsKiB2YWx1ZSkgCit7CisgICAgcmV0dXJuIGVsZW1lbnQtPmhhc0NsYXNzKCkgJiYg c3RhdGljX2Nhc3Q8Y29uc3QgU3R5bGVkRWxlbWVudCo+KGVsZW1lbnQpLT5jbGFzc05hbWVzKCku Y29udGFpbnModmFsdWUpOworfQorCitpbmxpbmUgYm9vbCBjaGVja0lEVmFsdWUoY29uc3QgRWxl bWVudCogZWxlbWVudCwgQXRvbWljU3RyaW5nSW1wbCogdmFsdWUpIAoreworICAgIHJldHVybiBl bGVtZW50LT5oYXNJRCgpICYmIGVsZW1lbnQtPmlkRm9yU3R5bGVSZXNvbHV0aW9uKCkuaW1wbCgp ID09IHZhbHVlOworfQorCitpbmxpbmUgYm9vbCBjaGVja1RhZ1ZhbHVlKGNvbnN0IEVsZW1lbnQq LCBBdG9taWNTdHJpbmdJbXBsKikKK3sKKyAgICByZXR1cm4gdHJ1ZTsKK30KKworfQogCiBib29s IENTU1N0eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6ZmFzdENoZWNrU2VsZWN0b3IoY29u c3QgQ1NTU2VsZWN0b3IqIHNlbGVjdG9yLCBjb25zdCBFbGVtZW50KiBlbGVtZW50KQogewpAQCAt MjE1NSwxNSArMjE1NSwxNSBAQCBib29sIENTU1N0eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tl cjo6CiAgICAgd2hpbGUgKHNlbGVjdG9yKSB7CiAgICAgICAgIHN3aXRjaCAoc2VsZWN0b3ItPm1f bWF0Y2gpIHsKICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6Q2xhc3M6Ci0gICAgICAgICAgICBp ZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9yPENsYXNzQ2hlY2s+KHNlbGVjdG9yLCBlbGVtZW50 LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3IsIHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNoRWxlbWVu dCkpCisgICAgICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9yPGNoZWNrQ2xhc3NW YWx1ZT4oc2VsZWN0b3IsIGVsZW1lbnQsIHRvcENoaWxkT3JTdWJzZWxlY3RvciwgdG9wQ2hpbGRP clN1YnNlbGVjdG9yTWF0Y2hFbGVtZW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6SWQ6Ci0gICAg ICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9yPElkQ2hlY2s+KHNlbGVjdG9yLCBl bGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3IsIHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNo RWxlbWVudCkpCisgICAgICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9yPGNoZWNr SURWYWx1ZT4oc2VsZWN0b3IsIGVsZW1lbnQsIHRvcENoaWxkT3JTdWJzZWxlY3RvciwgdG9wQ2hp bGRPclN1YnNlbGVjdG9yTWF0Y2hFbGVtZW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6Tm9uZToK LSAgICAgICAgICAgIGlmICghZmFzdENoZWNrU2luZ2xlU2VsZWN0b3I8VGFnQ2hlY2s+KHNlbGVj dG9yLCBlbGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3IsIHRvcENoaWxkT3JTdWJzZWxlY3Rv ck1hdGNoRWxlbWVudCkpCisgICAgICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9y PGNoZWNrVGFnVmFsdWU+KHNlbGVjdG9yLCBlbGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3Is IHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNoRWxlbWVudCkpCiAgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6Cg==