60926 2011-05-16 14:54:37 -0700 [chromium] shard V8DerivedSources into 19 files 2011-05-16 16:32:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue dglazkov yaar oldest_to_newest 404732 0 tony 2011-05-16 14:54:37 -0700 [chromium] shard V8DerivedSources into 20 files 404748 1 93701 tony 2011-05-16 15:08:18 -0700 Created attachment 93701 Patch 404752 2 tony 2011-05-16 15:10:22 -0700 I also tested 20 files and 30 files, but both had slower files than with 19. 20 files had a file take 19s and 30 files had a file take 17s. I suspect there's some benefit to using a value that's relatively prime to 8. 404767 3 93701 abarth 2011-05-16 15:24:01 -0700 Comment on attachment 93701 Patch OMG, thank you! 404807 4 commit-queue 2011-05-16 16:28:58 -0700 The commit-queue encountered the following flaky tests while processing attachment 93701: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 404809 5 93701 commit-queue 2011-05-16 16:32:49 -0700 Comment on attachment 93701 Patch Clearing flags on attachment: 93701 Committed r86631: <http://trac.webkit.org/changeset/86631> 404810 6 commit-queue 2011-05-16 16:32:54 -0700 All reviewed patches have been landed. Closing bug. 93701 2011-05-16 15:08:18 -0700 2011-05-16 16:32:49 -0700 Patch bug-60926-20110516150754.patch text/plain 4114 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODY2MDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MWNlNDc3MTgzMzM4NzQx ZWNlMjExN2RiZWRkYTUwOTFkMjk4ZDNjLi42ZDc3NTM1NzZiMjE4N2EzNGUwZjI1ODYyYzc5YTky ZDI4MWVjODE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMTYgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIHNoYXJkIFY4RGVyaXZlZFNvdXJjZXMgaW50 byAxOSBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjA5MjYKKworICAgICAgICBUaGlzIHJlZHVjZXMgdGhlIGNsb2JiZXIgYnVpbGQgdGltZSBi eSA0cyBvbiBteSBtYWNoaW5lLiAgSXQgaGVscHMKKyAgICAgICAgYnkgbWFraW5nIHRoZSBzbG93 ZXN0IHRvIGNvbXBpbGUgVjhEZXJpdmVkU291cmNlcyBmYXN0ZXIgKGFuZCB0aHVzCisgICAgICAg IG1vcmUgcGFyYWxsZWxpemFibGUpLiAgV2l0aCA4IGZpbGVzLCB0aGUgMyBzbG93ZXN0IGFyZSAy M3MsIDE4cyBhbmQKKyAgICAgICAgMTBzLiAgV2l0aCAxOSBmaWxlcywgdGhlIDMgc2xvd2VzdCBh cmUgMTZzLCAxMHMsIGFuZCAxMHMuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cDoKKyAgICAgICAgKiBzdG9yYWdlL0lEQk9iamVjdFN0b3JlLmg6IEZpeCBhIG1pc3NpbmcgaW5j bHVkZSB0aGF0IHdhcyB3b3JraW5nCisgICAgICAgICAgYmVjYXVzZSBhIGRpZmZlcmVudCAuY3Bw IGZpbGUgYmVmb3JlIGl0IHdhcyBpbmNsdWRpbmcgdGhlIGhlYWRlci4KKwogMjAxMS0wNS0xNiAg WXV6byBGdWppc2hpbWEgIDx5dXpvQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW50dGkgS29pdmlzdG8uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9X ZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4 IDcwYjgwZDFhMWJlMmUyZjk0MmMxMTM5ODM2MjZhZDMwY2Q4NTg5MTYuLjJlMGI1MWQ2ZDQyMzgw M2U4ZGVkMTJmMWU0MGQ3OTc3ZjQ3Yzk1YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwCkBAIC0yOTQsMTQgKzI5NCwyNSBAQAogICAgICAgICBdLAogICAgICAgfSx7CiAg ICAgICAgICdkZXJpdmVkX3NvdXJjZXNfYWdncmVnYXRlX2ZpbGVzJzogWwotICAgICAgICAgICc8 KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNl czEuY3BwJywKLSAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2Jp bmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXMyLmNwcCcsCi0gICAgICAgICAgJzwoU0hBUkVEX0lOVEVS TUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2ZWRTb3VyY2VzMy5jcHAnLAotICAg ICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJp dmVkU291cmNlczQuY3BwJywKLSAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikv d2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXM1LmNwcCcsCi0gICAgICAgICAgJzwoU0hB UkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2ZWRTb3VyY2VzNi5j cHAnLAotICAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGlu Z3MvVjhEZXJpdmVkU291cmNlczcuY3BwJywKLSAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJ QVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXM4LmNwcCcsCisgICAgICAg ICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2ZWRT b3VyY2VzMDEuY3BwJywKKyAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Vi a2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXMwMi5jcHAnLAorICAgICAgICAgICc8KFNIQVJF RF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNlczAzLmNw cCcsCisgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5n cy9WOERlcml2ZWRTb3VyY2VzMDQuY3BwJywKKyAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJ QVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXMwNS5jcHAnLAorICAgICAg ICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVk U291cmNlczA2LmNwcCcsCisgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dl YmtpdC9iaW5kaW5ncy9WOERlcml2ZWRTb3VyY2VzMDcuY3BwJywKKyAgICAgICAgICAnPChTSEFS RURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXMwOC5j cHAnLAorICAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGlu Z3MvVjhEZXJpdmVkU291cmNlczA5LmNwcCcsCisgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVE SUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2ZWRTb3VyY2VzMTAuY3BwJywKKyAgICAg ICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZl ZFNvdXJjZXMxMS5jcHAnLAorICAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93 ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNlczEyLmNwcCcsCisgICAgICAgICAgJzwoU0hB UkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2ZWRTb3VyY2VzMTMu Y3BwJywKKyAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRp bmdzL1Y4RGVyaXZlZFNvdXJjZXMxNC5jcHAnLAorICAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1F RElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNlczE1LmNwcCcsCisgICAg ICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5kaW5ncy9WOERlcml2 ZWRTb3VyY2VzMTYuY3BwJywKKyAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikv d2Via2l0L2JpbmRpbmdzL1Y4RGVyaXZlZFNvdXJjZXMxNy5jcHAnLAorICAgICAgICAgICc8KFNI QVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNlczE4 LmNwcCcsCisgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC9iaW5k aW5ncy9WOERlcml2ZWRTb3VyY2VzMTkuY3BwJywKICAgICAgICAgXSwKICAgICAgIH1dLAogICAg IF0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlLmgKaW5kZXggZjBjNWViZjZm MDBlMzc1YzQ0Mzc5Y2M2YzA2NDMyNzY5NmFiZTBhNi4uOGU0OTA5NzRhNWQ3MDYwMWJmOGVmY2Rk ZDdkYjIyNjNiNmMxNTc4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJP YmplY3RTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCT2JqZWN0U3RvcmUu aApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIklEQktleVJhbmdlLmgiCiAjaW5jbHVkZSAi SURCT2JqZWN0U3RvcmVCYWNrZW5kSW50ZXJmYWNlLmgiCiAjaW5jbHVkZSAiSURCUmVxdWVzdC5o IgorI2luY2x1ZGUgIklEQlRyYW5zYWN0aW9uLmgiCiAjaW5jbHVkZSAiT3B0aW9uc09iamVjdC5o IgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAiU2VyaWFsaXplZFNjcmlw dFZhbHVlLmgiCg==