60908 2011-05-16 11:05:41 -0700 JSWeakObjectMap finalisation may occur while gc is in inconsistent state 2011-05-16 12:24:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 404603 0 oliver 2011-05-16 11:05:41 -0700 JSWeakObjectMap finalisation may occur while gc is in inconsistent state 404607 1 93670 oliver 2011-05-16 11:09:15 -0700 Created attachment 93670 Patch 404625 2 93670 ggaren 2011-05-16 11:22:16 -0700 Comment on attachment 93670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93670&action=review Please file a bug to track the better long-term change we discussed, which makes weak maps reference-counted in the API, based on a linked-on-or-after check > Source/JavaScriptCore/runtime/JSGlobalObject.h:116 > + static JS_EXPORTDATA WeakMapFinalizer s_weakMapFinalizer; These names really should be plural -- "WeakMapsFinalizer, s_weakMapsFinalizer", etc. 404643 3 oliver 2011-05-16 11:54:55 -0700 Committed r86594: <http://trac.webkit.org/changeset/86594> 404654 4 93670 webkit.review.bot 2011-05-16 12:24:22 -0700 Comment on attachment 93670 Patch Attachment 93670 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8699931 93670 2011-05-16 11:09:15 -0700 2011-05-16 12:24:22 -0700 Patch bug-60908-20110516110914.patch text/plain 3935 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODY1ODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGUz YWQwNjY1MTFiMGI0YTVhMTNkMGJkMzk4YzlmZDZiMTI5NmVkOTQuLjhmMzNkNGY4MmVkZDMxOGM0 ZDM0NmE4MGY2YmI1NDUyNjg2Nzg2MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIyIEBACisyMDExLTA1LTE2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNXZWFrT2Jq ZWN0TWFwIGZpbmFsaXNhdGlvbiBtYXkgb2NjdXIgd2hpbGUgZ2MgaXMgaW4gaW5jb25zaXN0ZW50 IHN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDkwOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTQwOTQ5MT4KKworICAgICAgICBXZSBuZWVk IHRvIGVuc3VyZSB0aGF0IHdlIGhhdmUgY2FsbGVkIGFsbCB0aGUgd2VhayBtYXAgZmluYWxpemVy cyB3aGlsZQorICAgICAgICB0aGUgZ2xvYmFsIG9iamVjdCAoYW5kIGhlbmNlIGdsb2JhbCBjb250 ZXh0KSBpcyBzdGlsbCBpbiBhIGNvbnNpc3RlbnQKKyAgICAgICAgc3RhdGUuICBUaGUgYmVzdCB3 YXkgdG8gYWNoaWV2ZSB0aGlzIGlzIHRvIHNpbXBseSB1c2UgYSB3ZWFrIGhhbmRsZSBhbmQKKyAg ICAgICAgZmluYWxpemVyIG9uIHRoZSBnbG9iYWwgb2JqZWN0LgorCisgICAgICAgICogSmF2YVNj cmlwdENvcmUuZXhwOgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwOgorICAg ICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6V2Vha01hcEZpbmFsaXplcjo6ZmluYWxpemUpOgor ICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNHbG9i YWxPYmplY3Q6OnJlZ2lzdGVyV2Vha01hcCk6CisKIDIwMTEtMDUtMTYgIFNpZGRoYXJ0aCBNYXRo dXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBM YXN6bG8gR29tYm9zLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLmV4cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAKaW5k ZXggMTJiMzE1OGRkNWI5NGVlYzM3YTE4MTU4NWI5MWQyY2FmZjZhNTg5Mi4uNDkyMjgzYWVmZTJm NTJjMTg2OTgwMTY5ZTdlNjIwY2U2NGQ4NjU5OCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2 YVNjcmlwdENvcmUuZXhwCkBAIC0xNjAsNiArMTYwLDcgQEAgX19aTjNKU0MxNEpTR2xvYmFsT2Jq ZWN0MTJkZWZpbmVHZXR0ZXJFUE5TXzlFeGVjU3RhdGVFUktOU18xMElkZW50aWZpZXJFUE5TXzhK U08KIF9fWk4zSlNDMTRKU0dsb2JhbE9iamVjdDEyZGVmaW5lU2V0dGVyRVBOU185RXhlY1N0YXRl RVJLTlNfMTBJZGVudGlmaWVyRVBOU184SlNPYmplY3RFagogX19aTjNKU0MxNEpTR2xvYmFsT2Jq ZWN0MTN2aXNpdENoaWxkcmVuRVJOU185TWFya1N0YWNrRQogX19aTjNKU0MxNEpTR2xvYmFsT2Jq ZWN0MTdwdXRXaXRoQXR0cmlidXRlc0VQTlNfOUV4ZWNTdGF0ZUVSS05TXzEwSWRlbnRpZmllckVO U183SlNWYWx1ZUVqCitfX1pOM0pTQzE0SlNHbG9iYWxPYmplY3QxOHNfd2Vha01hcEZpbmFsaXpl ckUKIF9fWk4zSlNDMTRKU0dsb2JhbE9iamVjdDNwdXRFUE5TXzlFeGVjU3RhdGVFUktOU18xMElk ZW50aWZpZXJFTlNfN0pTVmFsdWVFUk5TXzE1UHV0UHJvcGVydHlTbG90RSAgCiBfX1pOM0pTQzE0 SlNHbG9iYWxPYmplY3Q0aW5pdEVQTlNfOEpTT2JqZWN0RQogX19aTjNKU0MxNEpTR2xvYmFsT2Jq ZWN0RDJFdgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9i YWxPYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmpl Y3QuY3BwCmluZGV4IDM5MWE2NTUwZGQ1NGI0MTIyMTAyMjFhNmQ0MDA1NDllYzE0NTZiNTMuLjYz NzFhMWQ1MTEyZjUyOGJkMzgwMmI0NjMzZDgxMGQxZTZiZWViYmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5jcHAKQEAgLTQ0NCw2ICs0NDQs MTIgQEAgdm9pZCogSlNHbG9iYWxPYmplY3Q6Om9wZXJhdG9yIG5ldyhzaXplX3Qgc2l6ZSwgSlNH bG9iYWxEYXRhKiBnbG9iYWxEYXRhKQogICAgIHJldHVybiBnbG9iYWxEYXRhLT5oZWFwLmFsbG9j YXRlKHNpemUpOwogfQogCit2b2lkIEpTR2xvYmFsT2JqZWN0OjpXZWFrTWFwRmluYWxpemVyOjpm aW5hbGl6ZShIYW5kbGU8VW5rbm93bj4gaGFuZGxlLCB2b2lkKikKK3sKKyAgICBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0ID0gYXNHbG9iYWxPYmplY3QoaGFuZGxlLmdldCgpKTsKKyAgICBn bG9iYWxPYmplY3QtPm1fd2Vha01hcHMuY2xlYXIoKTsKK30KKwogRHluYW1pY0dsb2JhbE9iamVj dFNjb3BlOjpEeW5hbWljR2xvYmFsT2JqZWN0U2NvcGUoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRh LCBKU0dsb2JhbE9iamVjdCogZHluYW1pY0dsb2JhbE9iamVjdCkKICAgICA6IG1fZHluYW1pY0ds b2JhbE9iamVjdFNsb3QoZ2xvYmFsRGF0YS5keW5hbWljR2xvYmFsT2JqZWN0KQogICAgICwgbV9z YXZlZER5bmFtaWNHbG9iYWxPYmplY3QobV9keW5hbWljR2xvYmFsT2JqZWN0U2xvdCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5oCmluZGV4IGUzMDZj ODdkMWZiYzBiNDg1ZjVmM2VjYjNlNGU3MWNhN2NjMmMxOTQuLmM5YzU1OTg3MDRkNTYyMWYyNTY2 MjNhMjlkYThhNDk3ZjUxYjAxNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsT2JqZWN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNHbG9iYWxPYmplY3QuaApAQCAtMTA4LDYgKzEwOCwxMyBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgRGVidWdnZXIqIG1fZGVidWdnZXI7CiAKICAgICAgICAgV2Vha01hcFNldCBtX3dl YWtNYXBzOworICAgICAgICBXZWFrPEpTR2xvYmFsT2JqZWN0PiBtX3dlYWtNYXBGaW5hbGl6ZXI7 CisgICAgICAgIGNsYXNzIFdlYWtNYXBGaW5hbGl6ZXIgOiBwdWJsaWMgV2Vha0hhbmRsZU93bmVy IHsKKyAgICAgICAgcHVibGljOgorICAgICAgICAgICAgdmlydHVhbCB2b2lkIGZpbmFsaXplKEhh bmRsZTxVbmtub3duPiwgdm9pZCogY29udGV4dCk7CisgICAgICAgIH07CisgICAgICAgIHN0YXRp YyBKU19FWFBPUlREQVRBIFdlYWtNYXBGaW5hbGl6ZXIgc193ZWFrTWFwRmluYWxpemVyOworCiAg ICAgICAgIFdlYWtSYW5kb20gbV93ZWFrUmFuZG9tOwogCiAgICAgICAgIFN5bWJvbFRhYmxlIG1f c3ltYm9sVGFibGU7CkBAIC0yNTYsNiArMjYzLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAg ICAgdm9pZCByZWdpc3RlcldlYWtNYXAoT3BhcXVlSlNXZWFrT2JqZWN0TWFwKiBtYXApCiAgICAg ICAgIHsKKyAgICAgICAgICAgIGlmICghbV93ZWFrTWFwRmluYWxpemVyKQorICAgICAgICAgICAg ICAgIG1fd2Vha01hcEZpbmFsaXplci5zZXQoZ2xvYmFsRGF0YSgpLCB0aGlzLCAmc193ZWFrTWFw RmluYWxpemVyKTsKICAgICAgICAgICAgIG1fd2Vha01hcHMuYWRkKG1hcCk7CiAgICAgICAgIH0K IAo=