60901 2011-05-16 10:04:40 -0700 [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea. 2011-05-18 08:50:04 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 61001 1 kling kling ossy webkit.review.bot oldest_to_newest 404545 0 kling 2011-05-16 10:04:40 -0700 To prepare for the eventual removal of the ChunkedUpdateDrawingArea, make QGraphicsWKView's "Simple" backing store type map to DrawingAreaImpl. 404547 1 93658 kling 2011-05-16 10:05:09 -0700 Created attachment 93658 Proposed patch 404549 2 webkit.review.bot 2011-05-16 10:06:54 -0700 Attachment 93658 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 404559 3 kling 2011-05-16 10:15:06 -0700 (In reply to comment #2) > Attachment 93658 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 > > Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] > Total errors found: 1 in 3 files Derp! Will include the bug# when landing. :) 404648 4 93658 kenneth 2011-05-16 12:04:05 -0700 Comment on attachment 93658 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=93658&action=review > Source/WebKit2/ChangeLog:5 > + [Qt][WK2] Remove usage of ChunkedUpdateDrawingArea. Where is the bug id? 405011 5 kling 2011-05-17 04:41:48 -0700 Committed r86668: <http://trac.webkit.org/changeset/86668> 405522 6 ossy 2011-05-17 22:35:08 -0700 Rolled out: http://trac.webkit.org/changeset/86719 405757 7 kling 2011-05-18 08:50:04 -0700 Committed r86767: <http://trac.webkit.org/changeset/86767> 93658 2011-05-16 10:05:09 -0700 2011-05-16 12:04:05 -0700 Proposed patch bug-60901.diff text/plain 2920 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkMDljYjNjLi5mY2UwYjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDUtMTYgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBSZW1v dmUgdXNhZ2Ugb2YgQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhLgorCisgICAgICAgIFRvIHByZXBh cmUgZm9yIHRoZSBldmVudHVhbCByZW1vdmFsIG9mIHRoZSBDaHVua2VkVXBkYXRlRHJhd2luZ0Fy ZWEsCisgICAgICAgIG1ha2UgUUdyYXBoaWNzV0tWaWV3J3MgIlNpbXBsZSIgYmFja2luZyBzdG9y ZSB0eXBlIG1hcCB0byBEcmF3aW5nQXJlYUltcGwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3FncmFwaGljc3drdmlldy5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZ3Jh cGhpY3N3a3ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwOgor ICAgICAgICAoUVdLUGFnZVByaXZhdGU6OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkpOgorCiAyMDEx LTA1LTEyICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmNwcAppbmRleCAyN2QzZGU5Li4xYzA5MzRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmll dy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3Zp ZXcuY3BwCkBAIC0yMSwxMSArMjEsOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg InFncmFwaGljc3drdmlldy5oIgogCi0jaW5jbHVkZSAiQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVh UHJveHkuaCIKICNpbmNsdWRlICJJbnRTaXplLmgiCiAjaW5jbHVkZSAiUnVuTG9vcC5oIgogI2lu Y2x1ZGUgIlRpbGVkRHJhd2luZ0FyZWFQcm94eS5oIgotI2luY2x1ZGUgIlVwZGF0ZUNodW5rLmgi CiAjaW5jbHVkZSAiV0tBUElDYXN0LmgiCiAjaW5jbHVkZSAicXdrcGFnZS5oIgogI2luY2x1ZGUg InF3a3BhZ2VfcC5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xZ3JhcGhpY3N3a3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdy YXBoaWNzd2t2aWV3LmgKaW5kZXggYjIzZWYxNi4uOTE5N2U5OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5oCkBAIC0yNiw3ICsyNiw3 IEBAIGNsYXNzIFFXRUJLSVRfRVhQT1JUIFFHcmFwaGljc1dLVmlldyA6IHB1YmxpYyBRR3JhcGhp Y3NXaWRnZXQgewogICAgIFFfUFJPUEVSVFkoUVVybCB1cmwgUkVBRCB1cmwgV1JJVEUgc2V0VXJs KQogCiBwdWJsaWM6Ci0gICAgZW51bSBCYWNraW5nU3RvcmVUeXBlIHsgU2ltcGxlLCBUaWxlZCwg SW1wbCB9OworICAgIGVudW0gQmFja2luZ1N0b3JlVHlwZSB7IFNpbXBsZSwgVGlsZWQgfTsKICAg ICBRR3JhcGhpY3NXS1ZpZXcoUVdLQ29udGV4dCogY29udGV4dCwgQmFja2luZ1N0b3JlVHlwZSBi YWNraW5nU3RvcmVUeXBlID0gU2ltcGxlLCBRR3JhcGhpY3NJdGVtKiBwYXJlbnQgPSAwKTsKIAog ICAgIHZpcnR1YWwgflFHcmFwaGljc1dLVmlldygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggM2U0Y2UzZi4uMzgwOGYyMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCkBAIC0yNCw3ICsyNCw2IEBACiAK ICNpbmNsdWRlICJxd2twcmVmZXJlbmNlc19wLmgiCiAKLSNpbmNsdWRlICJDaHVua2VkVXBkYXRl RHJhd2luZ0FyZWFQcm94eS5oIgogI2luY2x1ZGUgIkNsaWVudEltcGwuaCIKICNpbmNsdWRlICJE cmF3aW5nQXJlYVByb3h5SW1wbC5oIgogI2luY2x1ZGUgInFncmFwaGljc3drdmlldy5oIgpAQCAt MTM4LDkgKzEzNyw3IEBAIFBhc3NPd25QdHI8RHJhd2luZ0FyZWFQcm94eT4gUVdLUGFnZVByaXZh dGU6OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKQogICAgIGlmIChiYWNraW5nU3RvcmVUeXBlID09 IFFHcmFwaGljc1dLVmlldzo6VGlsZWQpCiAgICAgICAgIHJldHVybiBUaWxlZERyYXdpbmdBcmVh UHJveHk6OmNyZWF0ZSh3a1ZpZXcsIHBhZ2UuZ2V0KCkpOwogI2VuZGlmCi0gICAgaWYgKGJhY2tp bmdTdG9yZVR5cGUgPT0gUUdyYXBoaWNzV0tWaWV3OjpJbXBsKQotICAgICAgICByZXR1cm4gRHJh d2luZ0FyZWFQcm94eUltcGw6OmNyZWF0ZShwYWdlLmdldCgpKTsKLSAgICByZXR1cm4gQ2h1bmtl ZFVwZGF0ZURyYXdpbmdBcmVhUHJveHk6OmNyZWF0ZSh3a1ZpZXcsIHBhZ2UuZ2V0KCkpOworICAg IHJldHVybiBEcmF3aW5nQXJlYVByb3h5SW1wbDo6Y3JlYXRlKHBhZ2UuZ2V0KCkpOwogfQogCiB2 b2lkIFFXS1BhZ2VQcml2YXRlOjpzZXRWaWV3TmVlZHNEaXNwbGF5KGNvbnN0IFdlYkNvcmU6Oklu dFJlY3QmIHJlY3QpCg==