6090 2005-12-14 22:39:17 -0800 REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu 2005-12-18 08:14:11 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz webkit-unassigned darin oldest_to_newest 25981 0 mitz 2005-12-14 22:39:17 -0800 Summary: the following assert fails when you choose Copy from the contextual menu of a WebImageView: image (WebKit/WebKit/Misc.subproj/WebNSPasteboardExtras.m:229 -[NSPasteboard(WebExtras) _web_writeImage:URL:title:archive:types:]) To reproduce: open an image file in its own Safari window, control-click the image and choose copy. With a deployment build, you can verify that the image wasn't copied to the clipboard. This is similar to bug 6032 and I have a patch. 25982 1 5082 mitz 2005-12-14 22:56:08 -0800 Created attachment 5082 Use the correct key for the image renderer 26003 2 5082 darin 2005-12-15 06:30:31 -0800 Comment on attachment 5082 Use the correct key for the image renderer r=me 26004 3 5082 darin 2005-12-15 06:32:10 -0800 Comment on attachment 5082 Use the correct key for the image renderer Dictionary needs to include both the image renderer (for use inside WebKit) and the image (for use by other callers), so we need to add WebElementImageKey with the image as well. 26007 4 5094 mitz 2005-12-15 08:53:28 -0800 Created attachment 5094 Updated patch 26032 5 5094 darin 2005-12-16 00:05:53 -0800 Comment on attachment 5094 Updated patch r=me 5082 2005-12-14 22:56:08 -0800 2005-12-15 08:53:28 -0800 Use the correct key for the image renderer 6090_r1.patch text/plain 1878 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdC9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzQwMwpkaWZmIC1wIC11IC1y MS4zNDAzIFdlYktpdC9DaGFuZ2VMb2cKLS0tIFdlYktpdC9DaGFuZ2VMb2cJMTQgRGVjIDIwMDUg MDY6MTY6NDMgLTAwMDAJMS4zNDAzCisrKyBXZWJLaXQvQ2hhbmdlTG9nCTE1IERlYyAyMDA1IDA3 OjAxOjEwIC0wMDAwCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDUtMTItIyMgIE1pdHogUGV0dGVsICA8 b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4u b3JnL3Nob3dfYnVnLmNnaT9pZD02MDkwCisgICAgICAgICAgUkVHUkVTU0lPTjogQXNzZXJ0aW9u IGZhaWx1cmUgd2hlbiBjaG9vc2luZyBDb3B5IGZyb20gYSBXZWJJbWFnZVZpZXcncyBjb250ZXh0 dWFsIG1lbnUKKworICAgICAgICAqIFdlYlZpZXcuc3VicHJvai9XZWJJbWFnZVZpZXcubToKKyAg ICAgICAgKC1bV2ViSW1hZ2VWaWV3IGVsZW1lbnRBdFBvaW50Ol0pOiBVc2UgV2ViQ29yZUVsZW1l bnRJbWFnZVJlbmRlcmVyS2V5IGluc3RlYWQgb2YgV2ViRWxlbWVudEltYWdlS2V5CisgICAgICAg IGZvciB0aGUgaW1hZ2UgcmVuZGVyZXIuCisKIDIwMDUtMTItMTMgIE1hY2llaiBTdGFjaG93aWFr ICA8bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IFdl YktpdC9XZWJWaWV3LnN1YnByb2ovV2ViSW1hZ2VWaWV3Lm0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViSW1hZ2VWaWV3Lm0sdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNzUKZGlmZiAtcCAtdSAtcjEuNzUgV2ViS2l0L1dlYlZpZXcuc3VicHJv ai9XZWJJbWFnZVZpZXcubQotLS0gV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJJbWFnZVZpZXcu bQkyMCBTZXAgMjAwNSAwODozMzowNSAtMDAwMAkxLjc1CisrKyBXZWJLaXQvV2ViVmlldy5zdWJw cm9qL1dlYkltYWdlVmlldy5tCTE1IERlYyAyMDA1IDA3OjAyOjE0IC0wMDAwCkBAIC00Myw2ICs0 Myw3IEBACiAjaW1wb3J0IDxXZWJLaXQvV2ViVUlEZWxlZ2F0ZVByaXZhdGUuaD4KIAogI2ltcG9y dCA8V2ViQ29yZS9XZWJDb3JlSW1hZ2VSZW5kZXJlci5oPgorI2ltcG9ydCA8V2ViQ29yZS9XZWJD b3JlQnJpZGdlLmg+CiAKIEBpbXBsZW1lbnRhdGlvbiBXZWJJbWFnZVZpZXcKIApAQCAtMjM2LDcg KzIzNyw3IEBACiAgICAgQVNTRVJUKGZyYW1lKTsKICAgICAKICAgICByZXR1cm4gW05TRGljdGlv bmFyeSBkaWN0aW9uYXJ5V2l0aE9iamVjdHNBbmRLZXlzOgotICAgICAgICBbcmVwIGltYWdlXSwg ICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViRWxlbWVudEltYWdlS2V5LAorICAgICAgICBb cmVwIGltYWdlXSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgV2ViQ29yZUVsZW1lbnRJbWFn ZVJlbmRlcmVyS2V5LAogICAgICAgICBbTlNWYWx1ZSB2YWx1ZVdpdGhSZWN0OltzZWxmIGJvdW5k c11dLCAJV2ViRWxlbWVudEltYWdlUmVjdEtleSwKICAgICAgICAgW3JlcCBVUkxdLCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFdlYkVsZW1lbnRJbWFnZVVSTEtleSwKICAgICAgICAgW05T TnVtYmVyIG51bWJlcldpdGhCb29sOk5PXSwgCQlXZWJFbGVtZW50SXNTZWxlY3RlZEtleSwK 5094 2005-12-15 08:53:28 -0800 2005-12-16 00:05:53 -0800 Updated patch 6090_r2.patch text/plain 1954 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdC9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzQwMwpkaWZmIC1wIC11IC1y MS4zNDAzIFdlYktpdC9DaGFuZ2VMb2cKLS0tIFdlYktpdC9DaGFuZ2VMb2cJMTQgRGVjIDIwMDUg MDY6MTY6NDMgLTAwMDAJMS4zNDAzCisrKyBXZWJLaXQvQ2hhbmdlTG9nCTE1IERlYyAyMDA1IDA3 OjAxOjEwIC0wMDAwCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDUtMTItIyMgIE1pdHogUGV0dGVsICA8 b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4u b3JnL3Nob3dfYnVnLmNnaT9pZD02MDkwCisgICAgICAgICAgUkVHUkVTU0lPTjogQXNzZXJ0aW9u IGZhaWx1cmUgd2hlbiBjaG9vc2luZyBDb3B5IGZyb20gYSBXZWJJbWFnZVZpZXcncyBjb250ZXh0 dWFsIG1lbnUKKworICAgICAgICAqIFdlYlZpZXcuc3VicHJvai9XZWJJbWFnZVZpZXcubToKKyAg ICAgICAgKC1bV2ViSW1hZ2VWaWV3IGVsZW1lbnRBdFBvaW50Ol0pOiBVc2UgV2ViQ29yZUVsZW1l bnRJbWFnZVJlbmRlcmVyS2V5CisgICAgICAgIGZvciB0aGUgaW1hZ2UgcmVuZGVyZXIgYW5kIFdl YkVsZW1lbnRJbWFnZUtleSBmb3IgdGhlIGltYWdlLgorCiAyMDA1LTEyLTEzICBNYWNpZWogU3Rh Y2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCklu ZGV4OiBXZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkltYWdlVmlldy5tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkltYWdlVmlldy5tLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjc1CmRpZmYgLXAgLXUgLXIxLjc1IFdlYktpdC9XZWJWaWV3 LnN1YnByb2ovV2ViSW1hZ2VWaWV3Lm0KLS0tIFdlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViSW1h Z2VWaWV3Lm0JMjAgU2VwIDIwMDUgMDg6MzM6MDUgLTAwMDAJMS43NQorKysgV2ViS2l0L1dlYlZp ZXcuc3VicHJvai9XZWJJbWFnZVZpZXcubQkxNSBEZWMgMjAwNSAxNjo1NzowNCAtMDAwMApAQCAt NDMsNiArNDMsNyBAQAogI2ltcG9ydCA8V2ViS2l0L1dlYlVJRGVsZWdhdGVQcml2YXRlLmg+CiAK ICNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZUltYWdlUmVuZGVyZXIuaD4KKyNpbXBvcnQgPFdlYkNv cmUvV2ViQ29yZUJyaWRnZS5oPgogCiBAaW1wbGVtZW50YXRpb24gV2ViSW1hZ2VWaWV3CiAKQEAg LTIzNiw3ICsyMzcsOCBAQAogICAgIEFTU0VSVChmcmFtZSk7CiAgICAgCiAgICAgcmV0dXJuIFtO U0RpY3Rpb25hcnkgZGljdGlvbmFyeVdpdGhPYmplY3RzQW5kS2V5czoKLSAgICAgICAgW3JlcCBp bWFnZV0sICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYkVsZW1lbnRJbWFnZUtleSwKKyAg ICAgICAgW3JlcCBpbWFnZV0sICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdlYkNvcmVFbGVt ZW50SW1hZ2VSZW5kZXJlcktleSwKKyAgICAgICAgW1tyZXAgaW1hZ2VdIGltYWdlXSwgICAgICAg ICAgICAgICAgICAgIFdlYkVsZW1lbnRJbWFnZUtleSwKICAgICAgICAgW05TVmFsdWUgdmFsdWVX aXRoUmVjdDpbc2VsZiBib3VuZHNdXSwgCVdlYkVsZW1lbnRJbWFnZVJlY3RLZXksCiAgICAgICAg IFtyZXAgVVJMXSwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJFbGVtZW50SW1hZ2VV UkxLZXksCiAgICAgICAgIFtOU051bWJlciBudW1iZXJXaXRoQm9vbDpOT10sIAkJV2ViRWxlbWVu dElzU2VsZWN0ZWRLZXksCg==