60893 2011-05-16 09:03:37 -0700 [Qt] tst_QWebFrame::render() failing 2011-06-02 05:36:22 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 rafael.lobo rafael.lobo ademar cmarcelo commit-queue kling laszlo.gombos luiz oldest_to_newest 404512 0 rafael.lobo 2011-05-16 09:03:37 -0700 Running the test tst_qwebframe, you may find this test case render() failing. See output: ********* Start testing of tst_QWebFrame ********* Config: Using QTest library 4.7.4, Qt 4.7.4 PASS : tst_QWebFrame::initTestCase() FAIL! : tst_QWebFrame::render() Compared values are not the same Actual (size.width()): 100 Expected (picture.boundingRect().width() + frame->scrollBarGeometry(Qt::Vertical).width()): 0 Loc: [/home/rafael/git/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(2915)] PASS : tst_QWebFrame::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped ********* Finished testing of tst_QWebFrame ********* I'm using Qt 4.7.4 and Qt Mobility 1.1 on openSUSE 64 bit. 405306 1 rafael.lobo 2011-05-17 14:55:31 -0700 Qt Linux Platform's builder is not complaining about this test. As it is using Qt 4.7.3, I believe it might be a regression on Qt, so I'm waiting to know the exact commit that it is using so I can try that (as they don't have a tag for 4.7.3), and I'm still trying to figure out why I can't build Qt-Mobility's master branch with the people on #qt-mobility. So in the meantime, I was checking why this bug is happening. The problem with this test case is that at the end of the rendering stage, it seems that nothing was actually rendered inside QPicture, so the resulting boundingRect remains (0,0 0x0). After doing some few tests, I've noticed that whenever I try to paint anything inside the QPicture, using the proper pointers to it inside the inner functions, it updates its boundingRect just as expected in the end (I was doing basic stuff like painting a rect, or an ellipse). But as I get deeper on it, the code started to get really confusing, so I still couldn't figure out why, in the end, "nothing" was really rendered. So let's say it is really rendering, what could be happening here is an access to an invalid pointer deep inside, which might be related somehow to a possible regression on Qt. I didn't discard the possibility that this test was not working before and by coincidence the results matched, but I feel this is very unlikely. I'll keep this reported as I advance on it. 407035 2 94208 rafael.lobo 2011-05-20 06:30:51 -0700 Created attachment 94208 Now it waits the content to be loaded before testing and make sure QPicture will expand if its painter is used to render. As this test uses a QPicture's painter to render the frame, its bounding rect is supposed to grow as bigger the painting gets inside it. What was happening here was a very strange behavior on its expanding policy. If you render stuff without translating anything, things will work as expected. The issue works as follows: 1. Set a clipping rect on the painter. 2. Fill it with a bigger rect and check the QPicture's bounding rect (it should match the clipping rect). 3. Now set a clipping rect to be somewhere's else, so it would have to expand when filled. [ignore to make it work] 4. Translate to the top left point of this recently determined clipping rect. Your clipping rect would be changed to the follow (0,0 WxH) [/ignore] 5. Fill again with a bigger rect, and check if the QPicture's bounding rect is increased as you would expect. I don't know any other better way to explain this, so I've looked into ScrollBarThemeQt::paint and realized it would paint the place where the scrollbar should be with a background color before the actual scrollbar. So if I paint this background color before the translation, the QPicture's bounding rect would expand correctly, and the resulting painting would not change. 407073 3 rafael.lobo 2011-05-20 07:04:44 -0700 I have tested this expanding policy of QPicture on Qt 4.7.2, 4.7.3 and 4.7.4, they all work the same way. So I believe that it has passed on the buildbot because it wasn't making use of such themes, which would probably don't have any translation issue. 407403 4 94208 luiz 2011-05-20 16:47:42 -0700 Comment on attachment 94208 Now it waits the content to be loaded before testing and make sure QPicture will expand if its painter is used to render. View in context: https://bugs.webkit.org/attachment.cgi?id=94208&action=review > Source/WebCore/ChangeLog:12 > + If you use a QPicture's painter to render a themed scrollbar, > + as it does a translation to a certain point before painting, > + QPicture's bounding rect may not be expanded because the new > + clipping region may be inside its bounding rect in the original > + coordinate system (before translation). This change log is very confusing, specially after reading your comments in the bug. Is it a problem with QPicture, with the QStyle in use in your env or with QtWebKit? As the problem does not show up in all machines I would say that it is in your env. Did you try using QWindowsStyle in the test? I think that this together with the waitForSignal may solve the problem and we would be sure that the test will always use the same style in all platforms. If you see problems in QPicture or in the QStyle that you use, you should file bugs for them. Anyway, this change log needs to be improved a lot. :) 410746 5 rafael.lobo 2011-05-26 12:49:51 -0700 In this case it could be better to use the same style to every platform only for this test. The problem about this idea is that I should use a QWebView instead of a QWebPage and change its style. Then I've realized that QWebView's setStyle doesn't affect the page scrollbars (reported here: https://bugs.webkit.org/show_bug.cgi?id=61459). So for now I would have to change QApplication style, but it would affect the style theme for all tests. Is it a good idea to make this test to use the same style theme for every platform? Or maybe the current setting is also good as we could detect errors in different platform themes? The current problem of this test failing here (and not in buildbot) is actually a problem on QPicture (I've filed a bug here: http://bugreports.qt.nokia.com/browse/QTBUG-19496) as I've explained previously. A workaround for it is just to avoid to translate before painting in every theme specific way, and this would make it expand correctly to all themes. That's why I've changed the order to make it draw the background first and then translate to draw the scrollbar itself. In addition, this test is called "render" but it is not validating much of rendering. It's only checking its final geometry which is certainly not enough to say whether rendering was done correctly or not, and it is also using a non-reliable source (until now) of geometry to decide (QPicture). So there are many things wrong about it. I want to know if it is really a great idea to have the same theme style for all platforms to verify its geometry, or if I should just wait for QPicture's fix. Anyway, in the meantime, I will be looking for a fix for the bug #61459. 411503 6 luiz 2011-05-27 09:41:55 -0700 (In reply to comment #5) > In this case it could be better to use the same style to every platform only for this test. The problem about this idea is that I should use a QWebView instead of a QWebPage and change its style. Then I've realized that QWebView's setStyle doesn't affect the page scrollbars (reported here: https://bugs.webkit.org/show_bug.cgi?id=61459). So for now I would have to change QApplication style, but it would affect the style theme for all tests. > > Is it a good idea to make this test to use the same style theme for every platform? Or maybe the current setting is also good as we could detect errors in different platform themes? > > The current problem of this test failing here (and not in buildbot) is actually a problem on QPicture (I've filed a bug here: http://bugreports.qt.nokia.com/browse/QTBUG-19496) as I've explained previously. A workaround for it is just to avoid to translate before painting in every theme specific way, and this would make it expand correctly to all themes. That's why I've changed the order to make it draw the background first and then translate to draw the scrollbar itself. > > In addition, this test is called "render" but it is not validating much of rendering. It's only checking its final geometry which is certainly not enough to say whether rendering was done correctly or not, and it is also using a non-reliable source (until now) of geometry to decide (QPicture). So there are many things wrong about it. > > I want to know if it is really a great idea to have the same theme style for all platforms to verify its geometry, or if I should just wait for QPicture's fix. Anyway, in the meantime, I will be looking for a fix for the bug #61459. I suggested using a fixed style because this problem seems to be in QPicture and in a QStyle. As we are testing QtWebKit and not QPicture or a certain QStyle I think that it makes sense. But the changes that you proposed in ScrollbarThemeQt.cpp are ok. If it is a problem to use a fixed style then just provide a better change log and submit it again for review. 411714 7 95229 rafael.lobo 2011-05-27 16:50:43 -0700 Created attachment 95229 Modified Changelog to summarize changes more efficiently If it's a real consensus that this test should use the same style for every platform, then I think we could create a more efficient test in this format that could compare every pixel to check if the rendering was really correct in all plataforms. For this original test purposes, these changes are sufficient to avoid the bug on QPicture. So I've also changed the name of the test to "renderGeometry", because the previously name really didn't fit what was really tested there. 411780 8 95229 kling 2011-05-27 19:31:13 -0700 Comment on attachment 95229 Modified Changelog to summarize changes more efficiently This looks suspicious, you're moving the fillRect before the translate, and this doesn't affect anything but QPicture? o_O 411801 9 rafael.lobo 2011-05-27 21:23:12 -0700 Suppose you have a rect (X,Y) WxH. If you paint it at this moment, you'll fill points from (X,Y) to (X+W,Y+H), right? This is what I'm currently doing. So instead of painting it in the beginning, take the top left point of this rectangle - that would be (X,Y) - and then translate the painter to that point. Now your origin (0,0) is actually (X,Y). If you now get this rect and move it to point (0,0), you'll have the rect: (0,0) WxH. Now let's paint this rect inside the painter and see if we get any difference. As the points inside the painter were translated, for every point (a,b) in the rect, you'll be actually painting (a+X,b+Y) in the original coordinates, and we know the range of a is [0,W] and b is [0,H] because of our translated rect defined previously. Thus, the points painted in the original coordinate system would be (0+X,0+Y) to (W+X,H+Y), that is exactly the same as painting it before this translation. Hopes this helps to clarify. 411826 10 kling 2011-05-28 02:20:17 -0700 (In reply to comment #8) > (From update of attachment 95229 [details]) > This looks suspicious, you're moving the fillRect before the translate, and this doesn't affect anything but QPicture? o_O Never mind this, I had a few too many sheets in the wind at the time and didn't notice the QRect::moveTo() call. :) 412745 11 95453 rafael.lobo 2011-05-31 10:53:06 -0700 Created attachment 95453 Same patch as before (for additional comments, see last patch's comments) 412752 12 95453 kling 2011-05-31 11:09:02 -0700 Comment on attachment 95453 Same patch as before Curious workaround. r=me 412829 13 95474 rafael.lobo 2011-05-31 13:34:31 -0700 Created attachment 95474 Applied my changes on top of the master branch head (comments already made in the previous patch) 413069 14 95474 commit-queue 2011-05-31 18:47:35 -0700 Comment on attachment 95474 Applied my changes on top of the master branch head Clearing flags on attachment: 95474 Committed r87767: <http://trac.webkit.org/changeset/87767> 413587 15 ademar 2011-06-01 12:34:09 -0700 Revision r87767 cherry-picked into qtwebkit-2.2 with commit f3934e4 <http://gitorious.org/webkit/qtwebkit/commit/f3934e4> 414047 16 95453 laszlo.gombos 2011-06-02 05:36:15 -0700 Comment on attachment 95453 Same patch as before Clearing flags to take it our from the pending-commit queue as it appears to me that the correct version of the patch has been landed. Please reopen if this is not the case. 94208 2011-05-20 06:30:51 -0700 2011-05-27 16:50:43 -0700 Now it waits the content to be loaded before testing and make sure QPicture will expand if its painter is used to render. tst_qwebframe_render.diff text/plain 3421 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDc4YjU5Li40Yjg4ZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDUtMjAgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IHRzdF9RV2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisKKyAgICAgICAgSWYgeW91IHVzZSBhIFFQ aWN0dXJlJ3MgcGFpbnRlciB0byByZW5kZXIgYSB0aGVtZWQgc2Nyb2xsYmFyLAorICAgICAgICBh cyBpdCBkb2VzIGEgdHJhbnNsYXRpb24gdG8gYSBjZXJ0YWluIHBvaW50IGJlZm9yZSBwYWludGlu ZywKKyAgICAgICAgUVBpY3R1cmUncyBib3VuZGluZyByZWN0IG1heSBub3QgYmUgZXhwYW5kZWQg YmVjYXVzZSB0aGUgbmV3CisgICAgICAgIGNsaXBwaW5nIHJlZ2lvbiBtYXkgYmUgaW5zaWRlIGl0 cyBib3VuZGluZyByZWN0IGluIHRoZSBvcmlnaW5hbAorICAgICAgICBjb29yZGluYXRlIHN5c3Rl bSAoYmVmb3JlIHRyYW5zbGF0aW9uKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1Njcm9sbGJh clRoZW1lUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVRdDo6cGFpbnQp OgorCiAyMDExLTA1LTE2ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQuIFdpbmRvd3MgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvU2Nyb2xsYmFyVGhlbWVRdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxiYXJUaGVtZVF0LmNwcAppbmRleCAwNzljNjc2Li41Y2Rj NjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxiYXJUaGVt ZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxiYXJUaGVtZVF0 LmNwcApAQCAtMTUwLDE5ICsxNTAsMTggQEAgYm9vbCBTY3JvbGxiYXJUaGVtZVF0OjpwYWludChT Y3JvbGxiYXIqIHNjcm9sbGJhciwgR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnQKIAogICAg IHAucGFpbnRlci0+c2F2ZSgpOwogICAgIFFTdHlsZU9wdGlvblNsaWRlciogb3B0ID0gc3R5bGVP cHRpb25TbGlkZXIoc2Nyb2xsYmFyLCBwLndpZGdldCk7Ci0KLSAgICBwLnBhaW50ZXItPnNldENs aXBSZWN0KG9wdC0+cmVjdC5pbnRlcnNlY3RlZChkYW1hZ2VSZWN0KSwgUXQ6OkludGVyc2VjdENs aXApOworICAgIGNvbnN0IFFSZWN0IGludGVyc2VjdGVkUmVjdCA9IG9wdC0+cmVjdC5pbnRlcnNl Y3RlZChkYW1hZ2VSZWN0KTsKKyAgICBwLnBhaW50ZXItPnNldENsaXBSZWN0KGludGVyc2VjdGVk UmVjdCwgUXQ6OkludGVyc2VjdENsaXApOwogCiAjaWZkZWYgUV9XU19NQUMKICAgICBwLmRyYXdD b21wbGV4Q29udHJvbChRU3R5bGU6OkNDX1Njcm9sbEJhciwgKm9wdCk7CiAjZWxzZQorICAgIC8v IFRoZSBRU3R5bGUgZXhwZWN0cyB0aGUgYmFja2dyb3VuZCB0byBiZSBhbHJlYWR5IGZpbGxlZC4K KyAgICBwLnBhaW50ZXItPmZpbGxSZWN0KGludGVyc2VjdGVkUmVjdCwgb3B0LT5wYWxldHRlLmJh Y2tncm91bmQoKSk7CisKICAgICBjb25zdCBRUG9pbnQgdG9wTGVmdCA9IG9wdC0+cmVjdC50b3BM ZWZ0KCk7CiAgICAgcC5wYWludGVyLT50cmFuc2xhdGUodG9wTGVmdCk7CiAgICAgb3B0LT5yZWN0 Lm1vdmVUbyhRUG9pbnQoMCwgMCkpOwotCi0gICAgLy8gVGhlIFFTdHlsZSBleHBlY3RzIHRoZSBi YWNrZ3JvdW5kIHRvIGJlIGFscmVhZHkgZmlsbGVkCi0gICAgcC5wYWludGVyLT5maWxsUmVjdChv cHQtPnJlY3QsIG9wdC0+cGFsZXR0ZS5iYWNrZ3JvdW5kKCkpOwotCiAgICAgcC5kcmF3Q29tcGxl eENvbnRyb2woUVN0eWxlOjpDQ19TY3JvbGxCYXIsICpvcHQpOwogICAgIG9wdC0+cmVjdC5tb3Zl VG8odG9wTGVmdCk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggOGE1OWY4ZC4uNGU3NDk4NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wNS0yMCAgUmFmYWVsIEJyYW5k YW8gIDxyYWZhZWwubG9ib0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gdHN0X1FXZWJGcmFtZTo6cmVuZGVyKCkgZmFp bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4 OTMKKworICAgICAgICBUaGUgdGVzdCB3YXMgZXhwZWN0aW5nIHRoZSBmcmFtZSBjb250ZW50cyB0 byBiZSBhbHJlYWR5IGxvYWRlZAorICAgICAgICBiZWZvcmUgcmVuZGVyaW5nIGl0IGludG8gYSBR UGljdHVyZS4gSXQgYWxzbyBoYWQgYW4gaXNzdWUgd2l0aAorICAgICAgICB0aGVtZWQgc2Nyb2xs YmFycy4KKworICAgICAgICAqIHRlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwog MjAxMS0wNS0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFBh cnRpYWwgcmV2ZXJ0IG9mIHI4NjUzNy4gIEZ1bGxTY3JlZW5WaWRlb1F0LmggY2FuJ3QgZGVwZW5k IG9uIE93blB0ci5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFt ZS90c3RfcXdlYmZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3Rz dF9xd2ViZnJhbWUuY3BwCmluZGV4IDZiZmI1MGYuLjhjMzAwYmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC0yODk2LDYg KzI4OTYsNyBAQCB2b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRlcigpCiAgICAgUVdlYkZyYW1lICpm cmFtZSA9IGZyYW1lcy5hdCgwKTsKICAgICBRU3RyaW5nIGlubmVySHRtbCgiPGJvZHkgc3R5bGU9 J21hcmdpbjogMHB4Oyc+PGltZyBzcmM9J3FyYzovaW1hZ2UucG5nJy8+PC9ib2R5PiIpOwogICAg IGZyYW1lLT5zZXRIdG1sKGlubmVySHRtbCk7CisgICAgd2FpdEZvclNpZ25hbChmcmFtZSwgU0lH TkFMKGxvYWRGaW5pc2hlZChib29sKSksIDIwMCk7CiAKICAgICBRUGljdHVyZSBwaWN0dXJlOwog Cg== 95229 2011-05-27 16:50:43 -0700 2011-05-31 10:53:06 -0700 Modified Changelog to summarize changes more efficiently tst_qwebframe_render_2.diff text/plain 3602 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDc4YjU5Li5iNWFmODlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDUtMjcgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IHRzdF9RV2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisKKyAgICAgICAgRHVlIGEgcHJvYmxlbSBv biBRUGljdHVyZSAoaHR0cDovL2J1Z3JlcG9ydHMucXQubm9raWEuY29tL2Jyb3dzZS9RVEJVRy0x OTQ5NiksCisgICAgICAgIHRoaXMgdGVzdCB3YXMgY2FsY3VsYXRpbmcgdGhlIGZpbmFsIGdlb21l dHJ5IGluY29ycmVjdGx5LiBBcyB0aGUgb3JkZXIgYmV0d2VlbgorICAgICAgICBhIHRyYW5zbGF0 ZSBhbmQgYSBkcmF3IG9wZXJhdGlvbiBjb3VsZCBiZSByZWxldmFudCBmb3IgaXQsIGJ1dCBub3Qg Zm9yIHRoZQorICAgICAgICBmaW5hbCByZW5kZXJlZCByZXN1bHQsIHRoZXkgd2VyZSBjaGFuZ2Vk IG9uIFNjcm9sbGJhclRoZW1lUXQ6OnBhaW50LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2Ny b2xsYmFyVGhlbWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZVF0Ojpw YWludCk6CisKIDIwMTEtMDUtMTYgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gV2luZG93cyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxiYXJUaGVtZVF0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJhclRoZW1lUXQuY3BwCmluZGV4IDA3OWM2NzYu LjVkZTU3ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJh clRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJhclRo ZW1lUXQuY3BwCkBAIC0xNTYsMTMgKzE1NiwxMiBAQCBib29sIFNjcm9sbGJhclRoZW1lUXQ6OnBh aW50KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udAog I2lmZGVmIFFfV1NfTUFDCiAgICAgcC5kcmF3Q29tcGxleENvbnRyb2woUVN0eWxlOjpDQ19TY3Jv bGxCYXIsICpvcHQpOwogI2Vsc2UKKyAgICAvLyBUaGUgUVN0eWxlIGV4cGVjdHMgdGhlIGJhY2tn cm91bmQgdG8gYmUgYWxyZWFkeSBmaWxsZWQuCisgICAgcC5wYWludGVyLT5maWxsUmVjdChvcHQt PnJlY3QsIG9wdC0+cGFsZXR0ZS5iYWNrZ3JvdW5kKCkpOworCiAgICAgY29uc3QgUVBvaW50IHRv cExlZnQgPSBvcHQtPnJlY3QudG9wTGVmdCgpOwogICAgIHAucGFpbnRlci0+dHJhbnNsYXRlKHRv cExlZnQpOwogICAgIG9wdC0+cmVjdC5tb3ZlVG8oUVBvaW50KDAsIDApKTsKLQotICAgIC8vIFRo ZSBRU3R5bGUgZXhwZWN0cyB0aGUgYmFja2dyb3VuZCB0byBiZSBhbHJlYWR5IGZpbGxlZAotICAg IHAucGFpbnRlci0+ZmlsbFJlY3Qob3B0LT5yZWN0LCBvcHQtPnBhbGV0dGUuYmFja2dyb3VuZCgp KTsKLQogICAgIHAuZHJhd0NvbXBsZXhDb250cm9sKFFTdHlsZTo6Q0NfU2Nyb2xsQmFyLCAqb3B0 KTsKICAgICBvcHQtPnJlY3QubW92ZVRvKHRvcExlZnQpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDhhNTlmOGQuLmE4ZmIxMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTEtMDUtMjcgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIHRzdF9R V2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisKKyAgICAgICAgVGhlIHRlc3Qgd2FzIGV4cGVjdGlu ZyB0aGUgZnJhbWUgY29udGVudHMgdG8gYmUgYWxyZWFkeSBsb2FkZWQKKyAgICAgICAgYmVmb3Jl IHJlbmRlcmluZyBpdCBpbnRvIGEgUVBpY3R1cmUuIFJlbmFtZWQgdGhlIHRlc3QgdG8gZml0Cisg ICAgICAgIGl0cyByZWFsIHB1cnBvc2UgbW9yZSBhY2NvcmRpbmdseS4KKworICAgICAgICAqIHRl c3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwogMjAxMS0wNS0xNiAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFBhcnRpYWwgcmV2ZXJ0IG9mIHI4NjUz Ny4gIEZ1bGxTY3JlZW5WaWRlb1F0LmggY2FuJ3QgZGVwZW5kIG9uIE93blB0ci5oCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCmluZGV4 IDZiZmI1MGYuLjRmMGY1MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC02MzcsNyArNjM3LDcgQEAgcHJpdmF0ZSBzbG90 czoKICAgICB2b2lkIGJhc2VVcmxfZGF0YSgpOwogICAgIHZvaWQgYmFzZVVybCgpOwogICAgIHZv aWQgaGFzU2V0Rm9jdXMoKTsKLSAgICB2b2lkIHJlbmRlcigpOworICAgIHZvaWQgcmVuZGVyR2Vv bWV0cnkoKTsKICAgICB2b2lkIHJlbmRlckhpbnRzKCk7CiAgICAgdm9pZCBzY3JvbGxQb3NpdGlv bigpOwogICAgIHZvaWQgc2Nyb2xsVG9BbmNob3IoKTsKQEAgLTI4ODAsNyArMjg4MCw3IEBAIHZv aWQgdHN0X1FXZWJGcmFtZTo6aGFzU2V0Rm9jdXMoKQogICAgIFFUUllfVkVSSUZZKG1fcGFnZS0+ bWFpbkZyYW1lKCktPmhhc0ZvY3VzKCkpOwogfQogCi12b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRl cigpCit2b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRlckdlb21ldHJ5KCkKIHsKICAgICBRU3RyaW5n IGh0bWwoIjxodG1sPiIgXAogICAgICAgICAgICAgICAgICAgICAiPGhlYWQ+PHN0eWxlPiIgXApA QCAtMjg5Niw2ICsyODk2LDcgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpyZW5kZXIoKQogICAgIFFX ZWJGcmFtZSAqZnJhbWUgPSBmcmFtZXMuYXQoMCk7CiAgICAgUVN0cmluZyBpbm5lckh0bWwoIjxi b2R5IHN0eWxlPSdtYXJnaW46IDBweDsnPjxpbWcgc3JjPSdxcmM6L2ltYWdlLnBuZycvPjwvYm9k eT4iKTsKICAgICBmcmFtZS0+c2V0SHRtbChpbm5lckh0bWwpOworICAgIHdhaXRGb3JTaWduYWwo ZnJhbWUsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpLCAyMDApOwogCiAgICAgUVBpY3R1cmUg cGljdHVyZTsKIAo= 95453 2011-05-31 10:53:06 -0700 2011-06-02 05:36:15 -0700 Same patch as before tst_qwebframe_render_2.diff text/plain 3602 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMDc4YjU5Li5iNWFmODlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDUtMjcgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IHRzdF9RV2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisKKyAgICAgICAgRHVlIGEgcHJvYmxlbSBv biBRUGljdHVyZSAoaHR0cDovL2J1Z3JlcG9ydHMucXQubm9raWEuY29tL2Jyb3dzZS9RVEJVRy0x OTQ5NiksCisgICAgICAgIHRoaXMgdGVzdCB3YXMgY2FsY3VsYXRpbmcgdGhlIGZpbmFsIGdlb21l dHJ5IGluY29ycmVjdGx5LiBBcyB0aGUgb3JkZXIgYmV0d2VlbgorICAgICAgICBhIHRyYW5zbGF0 ZSBhbmQgYSBkcmF3IG9wZXJhdGlvbiBjb3VsZCBiZSByZWxldmFudCBmb3IgaXQsIGJ1dCBub3Qg Zm9yIHRoZQorICAgICAgICBmaW5hbCByZW5kZXJlZCByZXN1bHQsIHRoZXkgd2VyZSBjaGFuZ2Vk IG9uIFNjcm9sbGJhclRoZW1lUXQ6OnBhaW50LgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2Ny b2xsYmFyVGhlbWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZVF0Ojpw YWludCk6CisKIDIwMTEtMDUtMTYgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gV2luZG93cyBidWlsZCBmaXguCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxiYXJUaGVtZVF0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJhclRoZW1lUXQuY3BwCmluZGV4IDA3OWM2NzYu LjVkZTU3ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJh clRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJhclRo ZW1lUXQuY3BwCkBAIC0xNTYsMTMgKzE1NiwxMiBAQCBib29sIFNjcm9sbGJhclRoZW1lUXQ6OnBh aW50KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udAog I2lmZGVmIFFfV1NfTUFDCiAgICAgcC5kcmF3Q29tcGxleENvbnRyb2woUVN0eWxlOjpDQ19TY3Jv bGxCYXIsICpvcHQpOwogI2Vsc2UKKyAgICAvLyBUaGUgUVN0eWxlIGV4cGVjdHMgdGhlIGJhY2tn cm91bmQgdG8gYmUgYWxyZWFkeSBmaWxsZWQuCisgICAgcC5wYWludGVyLT5maWxsUmVjdChvcHQt PnJlY3QsIG9wdC0+cGFsZXR0ZS5iYWNrZ3JvdW5kKCkpOworCiAgICAgY29uc3QgUVBvaW50IHRv cExlZnQgPSBvcHQtPnJlY3QudG9wTGVmdCgpOwogICAgIHAucGFpbnRlci0+dHJhbnNsYXRlKHRv cExlZnQpOwogICAgIG9wdC0+cmVjdC5tb3ZlVG8oUVBvaW50KDAsIDApKTsKLQotICAgIC8vIFRo ZSBRU3R5bGUgZXhwZWN0cyB0aGUgYmFja2dyb3VuZCB0byBiZSBhbHJlYWR5IGZpbGxlZAotICAg IHAucGFpbnRlci0+ZmlsbFJlY3Qob3B0LT5yZWN0LCBvcHQtPnBhbGV0dGUuYmFja2dyb3VuZCgp KTsKLQogICAgIHAuZHJhd0NvbXBsZXhDb250cm9sKFFTdHlsZTo6Q0NfU2Nyb2xsQmFyLCAqb3B0 KTsKICAgICBvcHQtPnJlY3QubW92ZVRvKHRvcExlZnQpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDhhNTlmOGQuLmE4ZmIxMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTEtMDUtMjcgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIHRzdF9R V2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisKKyAgICAgICAgVGhlIHRlc3Qgd2FzIGV4cGVjdGlu ZyB0aGUgZnJhbWUgY29udGVudHMgdG8gYmUgYWxyZWFkeSBsb2FkZWQKKyAgICAgICAgYmVmb3Jl IHJlbmRlcmluZyBpdCBpbnRvIGEgUVBpY3R1cmUuIFJlbmFtZWQgdGhlIHRlc3QgdG8gZml0Cisg ICAgICAgIGl0cyByZWFsIHB1cnBvc2UgbW9yZSBhY2NvcmRpbmdseS4KKworICAgICAgICAqIHRl c3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcDoKKwogMjAxMS0wNS0xNiAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFBhcnRpYWwgcmV2ZXJ0IG9mIHI4NjUz Ny4gIEZ1bGxTY3JlZW5WaWRlb1F0LmggY2FuJ3QgZGVwZW5kIG9uIE93blB0ci5oCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCmluZGV4 IDZiZmI1MGYuLjRmMGY1MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdl YmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC02MzcsNyArNjM3LDcgQEAgcHJpdmF0ZSBzbG90 czoKICAgICB2b2lkIGJhc2VVcmxfZGF0YSgpOwogICAgIHZvaWQgYmFzZVVybCgpOwogICAgIHZv aWQgaGFzU2V0Rm9jdXMoKTsKLSAgICB2b2lkIHJlbmRlcigpOworICAgIHZvaWQgcmVuZGVyR2Vv bWV0cnkoKTsKICAgICB2b2lkIHJlbmRlckhpbnRzKCk7CiAgICAgdm9pZCBzY3JvbGxQb3NpdGlv bigpOwogICAgIHZvaWQgc2Nyb2xsVG9BbmNob3IoKTsKQEAgLTI4ODAsNyArMjg4MCw3IEBAIHZv aWQgdHN0X1FXZWJGcmFtZTo6aGFzU2V0Rm9jdXMoKQogICAgIFFUUllfVkVSSUZZKG1fcGFnZS0+ bWFpbkZyYW1lKCktPmhhc0ZvY3VzKCkpOwogfQogCi12b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRl cigpCit2b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRlckdlb21ldHJ5KCkKIHsKICAgICBRU3RyaW5n IGh0bWwoIjxodG1sPiIgXAogICAgICAgICAgICAgICAgICAgICAiPGhlYWQ+PHN0eWxlPiIgXApA QCAtMjg5Niw2ICsyODk2LDcgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpyZW5kZXIoKQogICAgIFFX ZWJGcmFtZSAqZnJhbWUgPSBmcmFtZXMuYXQoMCk7CiAgICAgUVN0cmluZyBpbm5lckh0bWwoIjxi b2R5IHN0eWxlPSdtYXJnaW46IDBweDsnPjxpbWcgc3JjPSdxcmM6L2ltYWdlLnBuZycvPjwvYm9k eT4iKTsKICAgICBmcmFtZS0+c2V0SHRtbChpbm5lckh0bWwpOworICAgIHdhaXRGb3JTaWduYWwo ZnJhbWUsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpLCAyMDApOwogCiAgICAgUVBpY3R1cmUg cGljdHVyZTsKIAo= 95474 2011-05-31 13:34:31 -0700 2011-05-31 18:47:34 -0700 Applied my changes on top of the master branch head tst_qwebframe_render_3.diff text/plain 3610 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3N2M2NmRiLi5iNTcxZTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDUtMzEgIFJhZmFlbCBCcmFuZGFvICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAgIFtRdF0g dHN0X1FXZWJGcmFtZTo6cmVuZGVyKCkgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4OTMKKworICAgICAgICBEdWUgYSBwcm9ibGVtIG9u IFFQaWN0dXJlIChodHRwOi8vYnVncmVwb3J0cy5xdC5ub2tpYS5jb20vYnJvd3NlL1FUQlVHLTE5 NDk2KSwKKyAgICAgICAgdGhpcyB0ZXN0IHdhcyBjYWxjdWxhdGluZyB0aGUgZmluYWwgZ2VvbWV0 cnkgaW5jb3JyZWN0bHkuIEFzIHRoZSBvcmRlciBiZXR3ZWVuCisgICAgICAgIGEgdHJhbnNsYXRl IGFuZCBhIGRyYXcgb3BlcmF0aW9uIGNvdWxkIGJlIHJlbGV2YW50IGZvciBpdCwgYnV0IG5vdCBm b3IgdGhlCisgICAgICAgIGZpbmFsIHJlbmRlcmVkIHJlc3VsdCwgdGhleSB3ZXJlIGNoYW5nZWQg b24gU2Nyb2xsYmFyVGhlbWVRdDo6cGFpbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9TY3Jv bGxiYXJUaGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lUXQ6OnBh aW50KToKKwogMjAxMS0wNS0zMSAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbGJhclRoZW1lUXQuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vcXQvU2Nyb2xsYmFyVGhlbWVRdC5jcHAKaW5kZXggYmM1NzRmNy4uNjc2 ZGQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvU2Nyb2xsYmFyVGhl bWVRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvU2Nyb2xsYmFyVGhlbWVR dC5jcHAKQEAgLTE2MywxMyArMTYzLDEyIEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVRdDo6cGFpbnQo U2Nyb2xsYmFyKiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpY3NDb250CiAgICAg ZWxzZQogI2VuZGlmCiAgICAgewotICAgICAgICBjb25zdCBRUG9pbnQgdG9wTGVmdCA9IG9wdC0+ cmVjdC50b3BMZWZ0KCk7Ci0gICAgICAgIHAucGFpbnRlci0+dHJhbnNsYXRlKHRvcExlZnQpOwot ICAgICAgICBvcHQtPnJlY3QubW92ZVRvKFFQb2ludCgwLCAwKSk7Ci0KICAgICAgICAgLy8gVGhl IFFTdHlsZSBleHBlY3RzIHRoZSBiYWNrZ3JvdW5kIHRvIGJlIGFscmVhZHkgZmlsbGVkLgogICAg ICAgICBwLnBhaW50ZXItPmZpbGxSZWN0KG9wdC0+cmVjdCwgb3B0LT5wYWxldHRlLmJhY2tncm91 bmQoKSk7CiAKKyAgICAgICAgY29uc3QgUVBvaW50IHRvcExlZnQgPSBvcHQtPnJlY3QudG9wTGVm dCgpOworICAgICAgICBwLnBhaW50ZXItPnRyYW5zbGF0ZSh0b3BMZWZ0KTsKKyAgICAgICAgb3B0 LT5yZWN0Lm1vdmVUbyhRUG9pbnQoMCwgMCkpOwogICAgICAgICBwLmRyYXdDb21wbGV4Q29udHJv bChRU3R5bGU6OkNDX1Njcm9sbEJhciwgKm9wdCk7CiAgICAgICAgIG9wdC0+cmVjdC5tb3ZlVG8o dG9wTGVmdCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBhYTAzODJmLi4xODQyYzMyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA1LTMxICBSYWZhZWwgQnJhbmRhbyAg PHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVh cyBLbGluZy4KKworICAgICAgICBbUXRdIHRzdF9RV2ViRnJhbWU6OnJlbmRlcigpIGZhaWxpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODkzCisg ICAgICAgIAorICAgICAgICBUaGUgdGVzdCB3YXMgZXhwZWN0aW5nIHRoZSBmcmFtZSBjb250ZW50 cyB0byBiZSBhbHJlYWR5IGxvYWRlZAorICAgICAgICBiZWZvcmUgcmVuZGVyaW5nIGl0IGludG8g YSBRUGljdHVyZS4gUmVuYW1lZCB0aGUgdGVzdCB0byBmaXQKKyAgICAgICAgaXRzIHJlYWwgcHVy cG9zZSBtb3JlIGFjY29yZGluZ2x5LgorCisgICAgICAgICogdGVzdHMvcXdlYmZyYW1lL3RzdF9x d2ViZnJhbWUuY3BwOgorICAgICAgICAodHN0X1FXZWJGcmFtZTo6cmVuZGVyR2VvbWV0cnkpOgor CiAyMDExLTA1LTMwICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZl aXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJh bWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5j cHAKaW5kZXggZTdkMzQ5MC4uZmJlMGY2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC90 ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90 ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKQEAgLTYzNyw3ICs2MzcsNyBAQCBwcml2 YXRlIHNsb3RzOgogICAgIHZvaWQgYmFzZVVybF9kYXRhKCk7CiAgICAgdm9pZCBiYXNlVXJsKCk7 CiAgICAgdm9pZCBoYXNTZXRGb2N1cygpOwotICAgIHZvaWQgcmVuZGVyKCk7CisgICAgdm9pZCBy ZW5kZXJHZW9tZXRyeSgpOwogICAgIHZvaWQgcmVuZGVySGludHMoKTsKICAgICB2b2lkIHNjcm9s bFBvc2l0aW9uKCk7CiAgICAgdm9pZCBzY3JvbGxUb0FuY2hvcigpOwpAQCAtMjg4MSw3ICsyODgx LDcgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpoYXNTZXRGb2N1cygpCiAgICAgUVRSWV9WRVJJRlko bV9wYWdlLT5tYWluRnJhbWUoKS0+aGFzRm9jdXMoKSk7CiB9CiAKLXZvaWQgdHN0X1FXZWJGcmFt ZTo6cmVuZGVyKCkKK3ZvaWQgdHN0X1FXZWJGcmFtZTo6cmVuZGVyR2VvbWV0cnkoKQogewogICAg IFFTdHJpbmcgaHRtbCgiPGh0bWw+IiBcCiAgICAgICAgICAgICAgICAgICAgICI8aGVhZD48c3R5 bGU+IiBcCkBAIC0yODk3LDYgKzI4OTcsNyBAQCB2b2lkIHRzdF9RV2ViRnJhbWU6OnJlbmRlcigp CiAgICAgUVdlYkZyYW1lICpmcmFtZSA9IGZyYW1lcy5hdCgwKTsKICAgICBRU3RyaW5nIGlubmVy SHRtbCgiPGJvZHkgc3R5bGU9J21hcmdpbjogMHB4Oyc+PGltZyBzcmM9J3FyYzovaW1hZ2UucG5n Jy8+PC9ib2R5PiIpOwogICAgIGZyYW1lLT5zZXRIdG1sKGlubmVySHRtbCk7CisgICAgd2FpdEZv clNpZ25hbChmcmFtZSwgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSksIDIwMCk7CiAKICAgICBR UGljdHVyZSBwaWN0dXJlOwogCg==