60892 2011-05-16 09:02:41 -0700 REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView 2011-05-16 14:05:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 kling kling ademar benjamin noam tonikitoo oldest_to_newest 404511 0 kling 2011-05-16 09:02:41 -0700 In r83820, an extra GraphicsLayer was added to the RenderLayerCompositor to contain all other layers, including the new scroll bar layers. The layer never gets a size set, since it's merely a container. This breaks PageClientQGraphicsWidget's assumption that the outermost layer should clip its children. This is already handled by the RenderLayerCompositor's "clip layer." 404519 1 93651 kling 2011-05-16 09:12:54 -0700 Created attachment 93651 Proposed patch 404529 2 93651 kenneth 2011-05-16 09:46:08 -0700 Comment on attachment 93651 Proposed patch Good find! :-) 404550 3 93651 kling 2011-05-16 10:10:03 -0700 Comment on attachment 93651 Proposed patch Clearing flags on attachment: 93651 Committed r86582: <http://trac.webkit.org/changeset/86582> 404551 4 kling 2011-05-16 10:10:11 -0700 All reviewed patches have been landed. Closing bug. 404593 5 tonikitoo 2011-05-16 10:50:46 -0700 Is there a way to catch such regressions? 404701 6 ademar 2011-05-16 14:05:00 -0700 Revision r86582 cherry-picked into qtwebkit-2.2 with commit 816a9ab <http://gitorious.org/webkit/qtwebkit/commit/816a9ab> 93651 2011-05-16 09:12:54 -0700 2011-05-16 10:10:03 -0700 Proposed patch bug-60892.diff text/plain 1597 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggMGMyNDYxNC4uODJiM2RiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMS0wNS0xNiAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVT U0lPTihyODM4MjApOiBbUXRdIEFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG5vIGxvbmdlciB3b3Jr cyBpbiBRR3JhcGhpY3NXZWJWaWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjA4OTIKKworICAgICAgICBEb24ndCBzZXQgdGhlIEl0ZW1DbGlwc0No aWxkcmVuVG9TaGFwZSBmbGFnIGZvciB0aGUgcm9vdCBwbGF0Zm9ybSBsYXllciwKKyAgICAgICAg c2luY2UgdGhhdCBpcyBub3cgdGhlIG92ZXJmbG93IGNvbnRyb2xzIGxheWVyLiBUaGUgY2xpcCBs YXllciwgd2hpY2ggd2FzCisgICAgICAgIHByZXZpb3VzbHkgdGhlIHJvb3QgcGxhdGZvcm0gbGF5 ZXIsIGFscmVhZHkgZ2V0cyB0aGUgZmxhZyBieSB3YXkgb2YKKyAgICAgICAgdGhlIEdyYXBoaWNz TGF5ZXIgbWFzay10by1ib3VuZHMgZmxhZy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1Bh Z2VDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ2xpZW50UUdyYXBoaWNzV2lk Z2V0OjpzZXRSb290R3JhcGhpY3NMYXllcik6CisKIDIwMTEtMDUtMTIgIFlvdW5nIEhhbiBMZWUg IDxqb3licm9AY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBS b2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVT dXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1BhZ2VDbGllbnRRdC5jcHAKaW5kZXggNWZmNDNhMC4uMmJhMDQ0OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9QYWdlQ2xpZW50UXQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcApAQCAtMjg5LDcgKzI4 OSw2IEBAIHZvaWQgUGFnZUNsaWVudFFHcmFwaGljc1dpZGdldDo6c2V0Um9vdEdyYXBoaWNzTGF5 ZXIoR3JhcGhpY3NMYXllciogbGF5ZXIpCiAgICAgcm9vdEdyYXBoaWNzTGF5ZXIgPSBsYXllciA/ IGxheWVyLT5wbGF0Zm9ybUxheWVyKCkgOiAwOwogCiAgICAgaWYgKHJvb3RHcmFwaGljc0xheWVy KSB7Ci0gICAgICAgIHJvb3RHcmFwaGljc0xheWVyLmRhdGEoKS0+c2V0RmxhZyhRR3JhcGhpY3NJ dGVtOjpJdGVtQ2xpcHNDaGlsZHJlblRvU2hhcGUsIHRydWUpOwogICAgICAgICByb290R3JhcGhp Y3NMYXllci5kYXRhKCktPnNldFBhcmVudEl0ZW0odmlldyk7CiAgICAgICAgIHJvb3RHcmFwaGlj c0xheWVyLmRhdGEoKS0+c2V0WlZhbHVlKFJvb3RHcmFwaGljc0xheWVyWlZhbHVlKTsKICAgICB9 Cg==