60888 2011-05-16 08:14:56 -0700 Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation. 2011-05-16 10:04:46 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 404483 0 podivilov 2011-05-16 08:14:56 -0700 Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation. 404484 1 93645 podivilov 2011-05-16 08:15:26 -0700 Created attachment 93645 Patch. 404486 2 93645 yurys 2011-05-16 08:23:19 -0700 Comment on attachment 93645 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=93645&action=review > Source/WebCore/inspector/InspectorController.h:-118 > - void disableDebugger(); Please make sure this doesn't break Safari. I only see Start debugging... but please double check. > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:144 > + m_inspectorState->setBoolean(DebuggerAgentState::debuggerEnabled, false); After front-end reopening debugger will be off in Safari. r- for this. 404488 3 yurys 2011-05-16 08:24:56 -0700 (In reply to comment #2) > After front-end reopening debugger will be off in Safari. r- for this. Sorry, of cause it will be restored from the local store on the front-end and pushed to the back end. 404489 4 93645 webkit.review.bot 2011-05-16 08:25:27 -0700 Comment on attachment 93645 Patch. Attachment 93645 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8699878 404493 5 93645 webkit-ews 2011-05-16 08:27:45 -0700 Comment on attachment 93645 Patch. Attachment 93645 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8704015 404546 6 podivilov 2011-05-16 10:04:46 -0700 Committed r86581: <http://trac.webkit.org/changeset/86581> 93645 2011-05-16 08:15:26 -0700 2011-05-16 08:27:45 -0700 Patch. patch text/plain 6070 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzQwYjc3Li4wNmVlZmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDUtMTYgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogZGVidWdnZXJXYXNFbmFibGVkIG5vdGlmaWNhdGlvbiBzaG91bGQgbm90IGJlIHNl bmQgdG8gZnJvbnRlbmQgb24gbmF2aWdhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODg4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuaDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjplbmFibGUpOgorICAgICAg ICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGlzYWJsZSk6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpyZXN0b3JlKToKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmNsZWFyRnJvbnRlbmQpOgorICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50Lmg6CisKIDIwMTEtMDUtMTIgIE1PUklUQSBI YWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgU2hhZG93Q29udGVudEVsZW1l bnQgc2hvdWxkIGFmZmVjdCB0aGUgb3JkZXIgb2YgcmVuZGVyZXIgY2hpbGRyZW4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCBlZTQz NTlkLi42NDg0MTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwCkBAIC00NDEsMTEgKzQ0MSw2IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJv bGxlcjo6c2hvd0FuZEVuYWJsZURlYnVnZ2VyKCkKICAgICAgICAgbV9zdGFydFVzZXJJbml0aWF0 ZWREZWJ1Z2dpbmdXaGVuRnJvbnRlZElzQ29ubmVjdGVkID0gdHJ1ZTsKIH0KIAotdm9pZCBJbnNw ZWN0b3JDb250cm9sbGVyOjpkaXNhYmxlRGVidWdnZXIoKQotewotICAgIG1fZGVidWdnZXJBZ2Vu dC0+ZGlzYWJsZSgpOwotfQotCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnN0YXJ0VXNlcklu aXRpYXRlZFByb2ZpbGluZygpCiB7CiAgICAgbV9wcm9maWxlckFnZW50LT5zdGFydFVzZXJJbml0 aWF0ZWRQcm9maWxpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q29udHJvbGxlci5oCmluZGV4IDY3MjI0MTguLmMyYjQ4OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaApAQCAtMTE1LDcgKzExNSw2IEBAIHB1 YmxpYzoKICAgICB2b2lkIGRpc2FibGVQcm9maWxlcigpOwogICAgIHZvaWQgc2hvd0FuZEVuYWJs ZURlYnVnZ2VyKCk7CiAgICAgYm9vbCBkZWJ1Z2dlckVuYWJsZWQoKTsKLSAgICB2b2lkIGRpc2Fi bGVEZWJ1Z2dlcigpOwogICAgIHZvaWQgcmVzdW1lKCk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCmluZGV4IGRl NTUwYTIuLjA4OGRkMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKQEAgLTY1LDM3ICs2NSwyNyBAQCBJbnNwZWN0b3JEZWJ1 Z2dlckFnZW50Ojp+SW5zcGVjdG9yRGVidWdnZXJBZ2VudCgpCiAgICAgQVNTRVJUKCFtX2luc3Ry dW1lbnRpbmdBZ2VudHMtPmluc3BlY3RvckRlYnVnZ2VyQWdlbnQoKSk7CiB9CiAKLXZvaWQgSW5z cGVjdG9yRGVidWdnZXJBZ2VudDo6ZW5hYmxlKGJvb2wgcmVzdG9yaW5nRnJvbVN0YXRlKQordm9p ZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjplbmFibGUoKQogewotICAgIEFTU0VSVChtX2Zyb250 ZW5kKTsKLSAgICBpZiAoIXJlc3RvcmluZ0Zyb21TdGF0ZSAmJiBlbmFibGVkKCkpCi0gICAgICAg IHJldHVybjsKLSAgICBtX2luc3BlY3RvclN0YXRlLT5zZXRCb29sZWFuKERlYnVnZ2VyQWdlbnRT dGF0ZTo6ZGVidWdnZXJFbmFibGVkLCB0cnVlKTsKICAgICBtX2luc3RydW1lbnRpbmdBZ2VudHMt PnNldEluc3BlY3RvckRlYnVnZ2VyQWdlbnQodGhpcyk7CiAKLSAgICBzY3JpcHREZWJ1Z1NlcnZl cigpLmNsZWFyQnJlYWtwb2ludHMoKTsKICAgICAvLyBGSVhNRShXSzQ0NTEzKTogYnJlYWtwb2lu dHMgYWN0aXZhdGVkIGZsYWcgc2hvdWxkIGJlIHN5bmNocm9uaXplZCBiZXR3ZWVuIGFsbCBmcm9u dC1lbmRzCiAgICAgc2NyaXB0RGVidWdTZXJ2ZXIoKS5zZXRCcmVha3BvaW50c0FjdGl2YXRlZCh0 cnVlKTsKICAgICBzdGFydExpc3RlbmluZ1NjcmlwdERlYnVnU2VydmVyKCk7CiAKLSAgICBtX2Zy b250ZW5kLT5kZWJ1Z2dlcldhc0VuYWJsZWQoKTsKICAgICBpZiAobV9saXN0ZW5lcikKICAgICAg ICAgbV9saXN0ZW5lci0+ZGVidWdnZXJXYXNFbmFibGVkKCk7CiB9CiAKIHZvaWQgSW5zcGVjdG9y RGVidWdnZXJBZ2VudDo6ZGlzYWJsZSgpCiB7Ci0gICAgaWYgKCFlbmFibGVkKCkpCi0gICAgICAg IHJldHVybjsKLSAgICBtX2luc3BlY3RvclN0YXRlLT5zZXRCb29sZWFuKERlYnVnZ2VyQWdlbnRT dGF0ZTo6ZGVidWdnZXJFbmFibGVkLCBmYWxzZSk7CiAgICAgbV9pbnNwZWN0b3JTdGF0ZS0+c2V0 T2JqZWN0KERlYnVnZ2VyQWdlbnRTdGF0ZTo6amF2YVNjcmlwdEJyZWFrcG9pbnRzLCBJbnNwZWN0 b3JPYmplY3Q6OmNyZWF0ZSgpKTsKICAgICBtX2luc3RydW1lbnRpbmdBZ2VudHMtPnNldEluc3Bl Y3RvckRlYnVnZ2VyQWdlbnQoMCk7CiAKICAgICBzdG9wTGlzdGVuaW5nU2NyaXB0RGVidWdTZXJ2 ZXIoKTsKKyAgICBzY3JpcHREZWJ1Z1NlcnZlcigpLmNsZWFyQnJlYWtwb2ludHMoKTsKICAgICBj bGVhcigpOwogCi0gICAgaWYgKG1fZnJvbnRlbmQpCi0gICAgICAgIG1fZnJvbnRlbmQtPmRlYnVn Z2VyV2FzRGlzYWJsZWQoKTsKICAgICBpZiAobV9saXN0ZW5lcikKICAgICAgICAgbV9saXN0ZW5l ci0+ZGVidWdnZXJXYXNEaXNhYmxlZCgpOwogfQpAQCAtMTA1LDEwICs5NSwzNCBAQCBib29sIElu c3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmVuYWJsZWQoKQogICAgIHJldHVybiBtX2luc3BlY3RvclN0 YXRlLT5nZXRCb29sZWFuKERlYnVnZ2VyQWdlbnRTdGF0ZTo6ZGVidWdnZXJFbmFibGVkKTsKIH0K IAordm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjplbmFibGUoRXJyb3JTdHJpbmcqKQorewor ICAgIGlmIChlbmFibGVkKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGVuYWJsZSgpOworICAg IG1faW5zcGVjdG9yU3RhdGUtPnNldEJvb2xlYW4oRGVidWdnZXJBZ2VudFN0YXRlOjpkZWJ1Z2dl ckVuYWJsZWQsIHRydWUpOworCisgICAgQVNTRVJUKG1fZnJvbnRlbmQpOworICAgIG1fZnJvbnRl bmQtPmRlYnVnZ2VyV2FzRW5hYmxlZCgpOworfQorCit2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdl bnQ6OmRpc2FibGUoRXJyb3JTdHJpbmcqKQoreworICAgIGlmICghZW5hYmxlZCgpKQorICAgICAg ICByZXR1cm47CisKKyAgICBkaXNhYmxlKCk7CisgICAgbV9pbnNwZWN0b3JTdGF0ZS0+c2V0Qm9v bGVhbihEZWJ1Z2dlckFnZW50U3RhdGU6OmRlYnVnZ2VyRW5hYmxlZCwgZmFsc2UpOworCisgICAg aWYgKG1fZnJvbnRlbmQpCisgICAgICAgIG1fZnJvbnRlbmQtPmRlYnVnZ2VyV2FzRGlzYWJsZWQo KTsKK30KKwogdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpyZXN0b3JlKCkKIHsKLSAgICBp ZiAobV9pbnNwZWN0b3JTdGF0ZS0+Z2V0Qm9vbGVhbihEZWJ1Z2dlckFnZW50U3RhdGU6OmRlYnVn Z2VyRW5hYmxlZCkpCi0gICAgICAgIGVuYWJsZSh0cnVlKTsKKyAgICBpZiAoZW5hYmxlZCgpKQor ICAgICAgICBlbmFibGUoKTsKIH0KIAogdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpzZXRG cm9udGVuZChJbnNwZWN0b3JGcm9udGVuZCogZnJvbnRlbmQpCkBAIC0xMjIsMTAgKzEzNiwxMiBA QCB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmNsZWFyRnJvbnRlbmQoKQogCiAgICAgaWYg KCFlbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICAvLyBJZiB0aGUgd2luZG93IGlzIGJl aW5nIGNsb3NlZCB3aXRoIHRoZSBkZWJ1Z2dlciBlbmFibGVkLAotICAgIC8vIHJlbWVtYmVyIHRo aXMgc3RhdGUgdG8gcmUtZW5hYmxlIGRlYnVnZ2VyIG9uIHRoZSBuZXh0IHdpbmRvdwotICAgIC8v IG9wZW5pbmcuCisKICAgICBkaXNhYmxlKCk7CisKKyAgICAvLyBGSVhNRTogZGVidWdnZXJFbmFi bGVkIGlzIGFjdHVhbGx5IHNldCB0byBmYWxzZSBvbmx5IHdoZW4gZnJvbnRlbmQgaXMgY2xvc2Vk LgorICAgIC8vIE9uIG5hdmlnYXRpb24sIGRlYnVnZ2VyRW5hYmxlZCB2YWx1ZSBpcyBwcmVzZXJ2 ZWQgZHVlIHRvIG1fc3RhdGUtPm11dGUoKSBoYWNrIGluIEluc3BlY3RvckNvbnRyb2xsZXIuCisg ICAgbV9pbnNwZWN0b3JTdGF0ZS0+c2V0Qm9vbGVhbihEZWJ1Z2dlckFnZW50U3RhdGU6OmRlYnVn Z2VyRW5hYmxlZCwgZmFsc2UpOwogfQogCiB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OnNl dEJyZWFrcG9pbnRzQWN0aXZlKEVycm9yU3RyaW5nKiwgYm9vbCBhY3RpdmUpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaAppbmRleCAyNzUz MTEwLi4xOGUwOTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yRGVidWdnZXJBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JEZWJ1Z2dlckFnZW50LmgKQEAgLTY4LDkgKzY4LDggQEAgY2xhc3MgSW5zcGVjdG9yRGVidWdn ZXJBZ2VudCA6IHB1YmxpYyBTY3JpcHREZWJ1Z0xpc3RlbmVyIHsKIHB1YmxpYzoKICAgICB2aXJ0 dWFsIH5JbnNwZWN0b3JEZWJ1Z2dlckFnZW50KCk7CiAKLSAgICB2b2lkIGVuYWJsZShFcnJvclN0 cmluZyopIHsgZW5hYmxlKGZhbHNlKTsgfQotICAgIHZvaWQgZGlzYWJsZShFcnJvclN0cmluZyop IHsgZGlzYWJsZSgpOyB9Ci0gICAgdm9pZCBkaXNhYmxlKCk7CisgICAgdm9pZCBlbmFibGUoRXJy b3JTdHJpbmcqKTsKKyAgICB2b2lkIGRpc2FibGUoRXJyb3JTdHJpbmcqKTsKICAgICBib29sIGVu YWJsZWQoKTsKICAgICB2b2lkIHJlc3RvcmUoKTsKICAgICB2b2lkIHNldEZyb250ZW5kKEluc3Bl Y3RvckZyb250ZW5kKik7CkBAIC0xMTYsNyArMTE1LDggQEAgcHJvdGVjdGVkOgogICAgIHZpcnR1 YWwgdm9pZCBzdG9wTGlzdGVuaW5nU2NyaXB0RGVidWdTZXJ2ZXIoKSA9IDA7CiAKIHByaXZhdGU6 Ci0gICAgdm9pZCBlbmFibGUoYm9vbCByZXN0b3JpbmdGcm9tU3RhdGUpOworICAgIHZvaWQgZW5h YmxlKCk7CisgICAgdm9pZCBkaXNhYmxlKCk7CiAKICAgICBQYXNzUmVmUHRyPEluc3BlY3RvckFy cmF5PiBjdXJyZW50Q2FsbEZyYW1lcygpOwogCg==