60887 2011-05-16 08:09:09 -0700 [Qt][Wk2][Symbian] Fix build after r86560 2011-05-16 10:27:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 s.mathur s.mathur ossy oldest_to_newest 404478 0 s.mathur 2011-05-16 08:09:09 -0700 In Bug 55875, we started using USE(UNIX_DOMAIN_SOCKETS) to guard Qt-Unix and Gtk code which uses code dependent on Unix domain socket IPC. r86560 (http://trac.webkit.org/changeset/86560) should have guarded ArgumentDecoder.cpp and ArgumentEncoder.cpp too, otherwise Qt-Symbian build breaks. 404480 1 93644 s.mathur 2011-05-16 08:11:38 -0700 Created attachment 93644 build fix for Symbian buildbot Fixes build failure: http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1044/steps/compile%20Source/logs/stdio 404485 2 93644 ossy 2011-05-16 08:19:42 -0700 Comment on attachment 93644 build fix for Symbian buildbot View in context: https://bugs.webkit.org/attachment.cgi?id=93644&action=review > Source/WebKit2/ChangeLog:10 > + (CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with HAVE(UNIX_DOMAIN_SOCKETS) > + * Platform/CoreIPC/ArgumentEncoder.cpp: r=me with change HAVE to USE. Please fix it before landing. 404491 3 ossy 2011-05-16 08:26:50 -0700 Landed in http://trac.webkit.org/changeset/86574 404556 4 s.mathur 2011-05-16 10:13:13 -0700 Build still busted, re-opening 404564 5 93663 s.mathur 2011-05-16 10:17:55 -0700 Created attachment 93663 try 2: build fix for Symbian buildbot Balazs had moved some of key QT||GTK defines to UNIX_DOMAIN_SOCKET guards, so I was caught off guard. My bad. My intention was to land Symbian parts in separate Bug 55875 (Shared Memory) and Bug 55877 (Core IPC and Process launching) In any case, here is a somewhat hacky middle ground to keep Symbian bot green until I re-baseline the Core IPC patch in Bug 55877 and get it landed. 404568 6 93663 ossy 2011-05-16 10:23:21 -0700 Comment on attachment 93663 try 2: build fix for Symbian buildbot It is a little bit ugly workaround, but rs=me until the real fix landed. 404575 7 ossy 2011-05-16 10:27:49 -0700 I landed it manually after I removed the unnecessarz trailing whitespaces: http://trac.webkit.org/changeset/86585 93644 2011-05-16 08:11:38 -0700 2011-05-16 08:27:01 -0700 build fix for Symbian buildbot 60887_v1.patch text/plain 1960 s.mathur SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NTcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMTYgIFNpZGRoYXJ0 aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdW1drMl1bU3ltYmlhbl0gRml4IGJ1 aWxkIGFmdGVyIHI4NjU2MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA4ODcKKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnREZWNv ZGVyLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkFyZ3VtZW50RGVjb2Rlcjo6fkFyZ3VtZW50RGVj b2Rlcik6IGd1YXJkIFVuaXggYW5kIEd0ayBjb2RlIHdpdGggSEFWRShVTklYX0RPTUFJTl9TT0NL RVRTKQorICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcDoKKyAg ICAgICAgKENvcmVJUEM6OkFyZ3VtZW50RW5jb2Rlcjo6fkFyZ3VtZW50RW5jb2Rlcik6IGRpdHRv CisKIDIwMTEtMDUtMTYgIFNpZGRoYXJ0aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9zLgpJbmRleDogU291cmNl L1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudERlY29kZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJndW1lbnREZWNvZGVyLmNwcAko cmV2aXNpb24gODY1NjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3Vt ZW50RGVjb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDcgKzQ3LDcgQEAgQXJndW1lbnRE ZWNvZGVyOjp+QXJndW1lbnREZWNvZGVyKCkKIHsKICAgICBBU1NFUlQobV9hbGxvY2F0ZWRCYXNl KTsKICAgICBmYXN0RnJlZShtX2FsbG9jYXRlZEJhc2UpOwotI2lmICFQTEFURk9STShRVCkgJiYg IVBMQVRGT1JNKEdUSykKKyNpZiAhVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCiAgICAgLy8gRklY TUU6IFdlIG5lZWQgdG8gZGlzcG9zZSBvZiB0aGUgbWFjaCBwb3J0cyBpbiBjYXNlcyBvZiBmYWls dXJlLgogI2Vsc2UKICAgICBEZXF1ZTxBdHRhY2htZW50Pjo6aXRlcmF0b3IgZW5kID0gbV9hdHRh Y2htZW50cy5lbmQoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJn dW1lbnRFbmNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9D b3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHAJKHJldmlzaW9uIDg2NTY2KQorKysgU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01MCw3ICs1MCw3IEBAIEFyZ3VtZW50RW5jb2Rlcjo6fkFyZ3VtZW50RW5jb2RlcigpCiB7 CiAgICAgaWYgKG1fYnVmZmVyKQogICAgICAgICBmYXN0RnJlZShtX2J1ZmZlcik7Ci0jaWYgIVBM QVRGT1JNKFFUKSAmJiAhUExBVEZPUk0oR1RLKQorI2lmICFVU0UoVU5JWF9ET01BSU5fU09DS0VU UykKICAgICAvLyBGSVhNRTogV2UgbmVlZCB0byBkaXNwb3NlIG9mIHRoZSBhdHRhY2htZW50cyBp biBjYXNlcyBvZiBmYWlsdXJlLgogI2Vsc2UKICAgICBmb3IgKGludCBpID0gMDsgaSA8IG1fYXR0 YWNobWVudHMuc2l6ZSgpOyArK2kpCg== 93663 2011-05-16 10:17:55 -0700 2011-05-16 10:27:58 -0700 try 2: build fix for Symbian buildbot 60887_v6.patch text/plain 5106 s.mathur SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NTgxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMTYgIFNpZGRoYXJ0 aCBNYXRodXIgIDxzaWRkaGFydGgubWF0aHVyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdW1drMl1bU3ltYmlhbl0gRml4IGJ1 aWxkIGFmdGVyIHI4NjU2MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA4ODcKKworICAgICAgICBUZW1wb3JhcmlseSBmaXggU3ltYmlhbiBidWlsZCBi eSByZS1lbmFibGluZyBjb21waWxhdGlvbiAKKyAgICAgICAgb2YgUXQvR3RrIGNvbW1vbiBjb2Rl IChhcyB3YXMgdGhlIGNhc2UgZm9yIFN5bWJpYW4gYmVmb3JlIHI1NTg3NSkuIAorICAgICAgICBU aGlzIGlzIGEgc3RvcCBnYXAgdW50aWwgdGhlIHB1cmUgU3ltYmlhbiBDb3JlIElQQyBhbmQgcHJv Y2VzcyBsYXVuY2hpbmcgYml0cyBsYW5kIGluIEJ1ZyA1NTg3NQorICAgICAgICBBcyBvZiB0aGlz IHJldmlzaW9uLCBvbmx5IHRoZSBuYXRpdmUgU2hhcmVkTWVtb3J5IGltcGxlbWVudGF0aW9uIGlz IGluIHRydW5rLgorCisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9BdHRhY2htZW50Lmg6IENv bXBpbGUgUXQvR3RrIGNvbW1vbiBjb2RlIGZvciBRdC1TeW1iaWFuIHRvbworICAgICAgICAqIFBs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oOiBkaXR0bworICAgICAgICAqIFBsYXRmb3JtL1No YXJlZE1lbW9yeS5oOiAgICAgICBkaXR0bworICAgICAgICAqIFBsYXRmb3JtL3F0L1NoYXJlZE1l bW9yeVN5bWJpYW4uY3BwOiBzdHViIGltcGxlbWVudGF0aW9ucyBvZiBhdHRhY2htZW50IGhhbmRs aW5nCisgICAgICAgIChXZWJLaXQ6OlNoYXJlZE1lbW9yeTo6SGFuZGxlOjpyZWxlYXNlVG9BdHRh Y2htZW50KToKKyAgICAgICAgKFdlYktpdDo6U2hhcmVkTWVtb3J5OjpIYW5kbGU6OmFkb3B0RnJv bUF0dGFjaG1lbnQpOgorCiAyMDExLTA1LTE2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaAkocmV2aXNpb24gODY1NzQpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9TaGFyZWRNZW1vcnkuaAkod29ya2luZyBjb3B5KQpAQCAtNjAs NyArNjAsNyBAQCBwdWJsaWM6CiAgICAgICAgIHZvaWQgZW5jb2RlKENvcmVJUEM6OkFyZ3VtZW50 RW5jb2RlciopIGNvbnN0OwogICAgICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQ29yZUlQQzo6QXJn dW1lbnREZWNvZGVyKiwgSGFuZGxlJik7CiAKLSNpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykK KyNpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykgfHwgT1MoU1lNQklBTikgCiAgICAgICAgIENv cmVJUEM6OkF0dGFjaG1lbnQgcmVsZWFzZVRvQXR0YWNobWVudCgpIGNvbnN0OwogICAgICAgICB2 b2lkIGFkb3B0RnJvbUF0dGFjaG1lbnQoaW50IGZpbGVEZXNjcmlwdG9yLCBzaXplX3QpOwogI2Vu ZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0F0dGFjaG1lbnQuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0F0dGFjaG1lbnQu aAkocmV2aXNpb24gODY1NzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0F0 dGFjaG1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDAsNyArNDAsNyBAQCBwdWJsaWM6CiAjaWYg UExBVEZPUk0oTUFDKQogICAgICAgICBNYWNoUG9ydFR5cGUsCiAgICAgICAgIE1hY2hPT0xNZW1v cnlUeXBlLAotI2VsaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCisjZWxpZiBVU0UoVU5JWF9E T01BSU5fU09DS0VUUykgfHwgT1MoU1lNQklBTikKICAgICAgICAgTWFwcGVkTWVtb3J5CiAjZW5k aWYKICAgICB9OwpAQCAtNDgsNyArNDgsNyBAQCBwdWJsaWM6CiAjaWYgUExBVEZPUk0oTUFDKQog ICAgIEF0dGFjaG1lbnQobWFjaF9wb3J0X25hbWVfdCBwb3J0LCBtYWNoX21zZ190eXBlX25hbWVf dCBkaXNwb3NpdGlvbik7CiAgICAgQXR0YWNobWVudCh2b2lkKiBhZGRyZXNzLCBtYWNoX21zZ19z aXplX3Qgc2l6ZSwgbWFjaF9tc2dfY29weV9vcHRpb25zX3QgY29weU9wdGlvbnMsIGJvb2wgZGVh bGxvY2F0ZSk7Ci0jZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykKKyNlbGlmIFVTRShVTklY X0RPTUFJTl9TT0NLRVRTKSB8fCBPUyhTWU1CSUFOKQogICAgIEF0dGFjaG1lbnQoaW50IGZpbGVE ZXNjcmlwdG9yLCBzaXplX3QpOwogI2VuZGlmCiAKQEAgLTY2LDcgKzY2LDcgQEAgcHVibGljOgog ICAgIG1hY2hfbXNnX3NpemVfdCBzaXplKCkgY29uc3QgeyBBU1NFUlQobV90eXBlID09IE1hY2hP T0xNZW1vcnlUeXBlKTsgcmV0dXJuIG1fb29sTWVtb3J5LnNpemU7IH0KICAgICBtYWNoX21zZ19j b3B5X29wdGlvbnNfdCBjb3B5T3B0aW9ucygpIGNvbnN0IHsgQVNTRVJUKG1fdHlwZSA9PSBNYWNo T09MTWVtb3J5VHlwZSk7IHJldHVybiBtX29vbE1lbW9yeS5jb3B5T3B0aW9uczsgfQogICAgIGJv b2wgZGVhbGxvY2F0ZSgpIGNvbnN0IHsgQVNTRVJUKG1fdHlwZSA9PSBNYWNoT09MTWVtb3J5VHlw ZSk7IHJldHVybiBtX29vbE1lbW9yeS5kZWFsbG9jYXRlOyB9Ci0jZWxpZiBVU0UoVU5JWF9ET01B SU5fU09DS0VUUykKKyNlbGlmIFVTRShVTklYX0RPTUFJTl9TT0NLRVRTKSB8fCBPUyhTWU1CSUFO KQogICAgIHNpemVfdCBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9zaXplOyB9CiAKICAgICBpbnQg cmVsZWFzZUZpbGVEZXNjcmlwdG9yKCkgeyBpbnQgdGVtcCA9IG1fZmlsZURlc2NyaXB0b3I7IG1f ZmlsZURlc2NyaXB0b3IgPSAtMTsgcmV0dXJuIHRlbXA7IH0KQEAgLTk0LDcgKzk0LDcgQEAgcHJp dmF0ZToKICAgICAgICAgICAgIGJvb2wgZGVhbGxvY2F0ZTsKICAgICAgICAgfSBtX29vbE1lbW9y eTsKICAgICB9OwotI2VsaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCisjZWxpZiBVU0UoVU5J WF9ET01BSU5fU09DS0VUUykgfHwgT1MoU1lNQklBTikKICAgICBpbnQgbV9maWxlRGVzY3JpcHRv cjsKICAgICBzaXplX3QgbV9zaXplOwogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAkocmV2aXNpb24gODY1NzQpCisrKyBTb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAkod29ya2luZyBjb3B5KQpAQCAt MTEzLDcgKzExMyw3IEBAIHB1YmxpYzoKICNlbGlmIFBMQVRGT1JNKFdJTikKICAgICB0eXBlZGVm IEhBTkRMRSBJZGVudGlmaWVyOwogICAgIHN0YXRpYyBib29sIGNyZWF0ZVNlcnZlckFuZENsaWVu dElkZW50aWZpZXJzKElkZW50aWZpZXImIHNlcnZlcklkZW50aWZpZXIsIElkZW50aWZpZXImIGNs aWVudElkZW50aWZpZXIpOwotI2VsaWYgVVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCisjZWxpZiBV U0UoVU5JWF9ET01BSU5fU09DS0VUUykgfHwgT1MoU1lNQklBTikKICAgICB0eXBlZGVmIGludCBJ ZGVudGlmaWVyOwogI2VuZGlmCiAKQEAgLTMzOSw3ICszMzksNyBAQCBwcml2YXRlOgogICAgIE93 blB0cjxBcmd1bWVudEVuY29kZXI+IG1fcGVuZGluZ1dyaXRlQXJndW1lbnRzOwogICAgIE9WRVJM QVBQRUQgbV93cml0ZVN0YXRlOwogICAgIEhBTkRMRSBtX2Nvbm5lY3Rpb25QaXBlOwotI2VsaWYg VVNFKFVOSVhfRE9NQUlOX1NPQ0tFVFMpCisjZWxpZiBVU0UoVU5JWF9ET01BSU5fU09DS0VUUykg fHwgT1MoU1lNQklBTikKICAgICAvLyBDYWxsZWQgb24gdGhlIGNvbm5lY3Rpb24gcXVldWUuCiAg ICAgdm9pZCByZWFkeVJlYWRIYW5kbGVyKCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL3F0L1NoYXJlZE1lbW9yeVN5bWJpYW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVN5bWJpYW4uY3BwCShyZXZpc2lvbiA4NjU3NCkK KysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL3F0L1NoYXJlZE1lbW9yeVN5bWJpYW4uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02OSw2ICs2OSwxNyBAQCBib29sIFNoYXJlZE1lbW9yeTo6SGFuZGxl OjpkZWNvZGUoQ29yZUlQCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKKy8vIEZJWE1FOiBUbyBiZSBy ZW1vdmVkIGFzIHBhcnQgb2YgQnVnIDU1ODc3IAorQ29yZUlQQzo6QXR0YWNobWVudCBTaGFyZWRN ZW1vcnk6OkhhbmRsZTo6cmVsZWFzZVRvQXR0YWNobWVudCgpIGNvbnN0Cit7CisgICAgcmV0dXJu IENvcmVJUEM6OkF0dGFjaG1lbnQoLTEsIDApOworfQorCisvLyBGSVhNRTogVG8gYmUgcmVtb3Zl ZCBhcyBwYXJ0IG9mIEJ1ZyA1NTg3NyAKK3ZvaWQgU2hhcmVkTWVtb3J5OjpIYW5kbGU6OmFkb3B0 RnJvbUF0dGFjaG1lbnQoaW50LCBzaXplX3QpCit7Cit9CisKIFBhc3NSZWZQdHI8U2hhcmVkTWVt b3J5PiBTaGFyZWRNZW1vcnk6OmNyZWF0ZShzaXplX3Qgc2l6ZSkKIHsKICAgICAvLyBPbiBTeW1i aWFuLCBnbG9iYWwgY2h1bmtzIChzaGFyZWQgbWVtb3J5IHNlZ21lbnRzKSBoYXZlIHN5c3RlbS11 bmlxdWUgbmFtZXMsIHNvIHdlIHBpY2sgYSByYW5kb20K