60864 2011-05-15 17:55:57 -0700 Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl 2011-05-16 10:48:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff aroben oldest_to_newest 404238 0 msaboff 2011-05-15 17:55:57 -0700 BackingStore objects can be reused in DrawingAreaProxyImpl::didUpdateBackingStoreState as per a FIXME: comment. This is likely to be more efficient. 404276 1 93604 msaboff 2011-05-15 22:02:54 -0700 Created attachment 93604 Patch to reuse backing stores and reduce timeout to 2 seconds 404280 2 93604 ggaren 2011-05-15 22:08:28 -0700 Comment on attachment 93604 Patch to reuse backing stores and reduce timeout to 2 seconds View in context: https://bugs.webkit.org/attachment.cgi?id=93604&action=review r=me > Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:212 > + // If we have a backing store the right size, reuse it. "backing store that is the right size" would make for a more grammatically correct comment. 404290 3 msaboff 2011-05-15 22:31:36 -0700 Committed r86524: <http://trac.webkit.org/changeset/86524> 404438 4 aroben 2011-05-16 06:05:58 -0700 Was any (non-memory) performance testing done of the 5 second -> 2 second change? See bug 51262 comment 5 and bug 51262 comment 6 (and other comments, too) for how the 5-second interval was arrived at. 404587 5 msaboff 2011-05-16 10:48:07 -0700 (In reply to comment #4) I did some bench testing looking for white flash problems. This included running with little free memory and a large number of tabs / windows (40-50). I didn't notice any white flashing or unreasonable delays. With instrumentation, I noticed that the number of backing stores would grow as needed. 93604 2011-05-15 22:02:54 -0700 2011-05-15 22:08:28 -0700 Patch to reuse backing stores and reduce timeout to 2 seconds 60864.patch text/plain 2222 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NTE5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMTUgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3Vib3B0aW1hbCBsaWZldGltZSBvZiBCYWNraW5nU3RvcmUg b2JqZWN0cyBpbiBEcmF3aW5nQXJlYVByb3h5SW1wbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4NjQKKworICAgICAgICBJbXBsZW1lbnRlZCByZXVz ZSBvZiBCYWNraW5nU3RvcmUncyBpbiAKKyAgICAgICAgRHJhd2luZ0FyZWFQcm94eUltcGw6OmRp ZFVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlIHdoZW4gdGhlIHNpemUgbmVlZGVkCisgICAgICAgIG1h dGNoZXMgdGhlIHNpemUgb2YgdGhlIGV4aXN0aW5nIEJhY2tpbmdTdG9yZS4KKyAgICAgICAgQWxz byByZWR1Y2VkIHRoZSBkaXNjYXJkQmFja2luZ1N0b3JlVGltZXIgZnJvbSA1IHRvIDIgc2Vjb25k cy4KKyAgICAgICAgVGhlc2UgY2hhbmdlcyByZWR1Y2VzIG1lbW9yeSB1c2FnZSB1cCB0byAxME1C IG9uIG1lbW9yeSB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5 SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHlJbXBsOjpkaWRVcGRh dGVCYWNraW5nU3RvcmVTdGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHlJ bXBsOjpkaXNjYXJkQmFja2luZ1N0b3JlU29vbik6CisKIDIwMTEtMDUtMTUgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJl eSBHYXJlbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5 SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdB cmVhUHJveHlJbXBsLmNwcAkocmV2aXNpb24gODY0NzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDksOSAr MjA5LDkgQEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5SW1wbDo6ZGlkVXBkYXRlQmFjawogICAgIH0K ICNlbmRpZgogCi0gICAgLy8gRklYTUU6IFdlIGNvdWxkIGp1c3QgcmV1c2Ugb3VyIGV4aXN0aW5n IGJhY2tpbmcgc3RvcmUgaWYgaXQncyB0aGUgc2FtZSBzaXplIGFzCi0gICAgLy8gdXBkYXRlSW5m by52aWV3U2l6ZS4KLSAgICBtX2JhY2tpbmdTdG9yZSA9IG51bGxwdHI7CisgICAgLy8gSWYgd2Ug aGF2ZSBhIGJhY2tpbmcgc3RvcmUgdGhlIHJpZ2h0IHNpemUsIHJldXNlIGl0LgorICAgIGlmICht X2JhY2tpbmdTdG9yZSAmJiBtX2JhY2tpbmdTdG9yZS0+c2l6ZSgpICE9IHVwZGF0ZUluZm8udmll d1NpemUpCisgICAgICAgIG1fYmFja2luZ1N0b3JlID0gbnVsbHB0cjsKICAgICBpbmNvcnBvcmF0 ZVVwZGF0ZSh1cGRhdGVJbmZvKTsKIH0KIApAQCAtMzUyLDcgKzM1Miw3IEBAIHZvaWQgRHJhd2lu Z0FyZWFQcm94eUltcGw6OmRpc2NhcmRCYWNraW4KIAogICAgIC8vIFdlJ2xsIHdhaXQgdGhpcyBt YW55IHNlY29uZHMgYWZ0ZXIgdGhlIGxhc3QgcGFpbnQgYmVmb3JlIHRocm93aW5nIGF3YXkgb3Vy IGJhY2tpbmcgc3RvcmUgdG8gc2F2ZSBtZW1vcnkuCiAgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJl IHNtYXJ0ZXIgdG8gbWFrZSB0aGlzIGRlbGF5IGJhc2VkIG9uIGhvdyBleHBlbnNpdmUgcGFpbnRp bmcgaXMuIFNlZSA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTczMz4uCi0gICAgc3RhdGljIGNvbnN0 IGRvdWJsZSBkaXNjYXJkQmFja2luZ1N0b3JlRGVsYXkgPSA1OworICAgIHN0YXRpYyBjb25zdCBk b3VibGUgZGlzY2FyZEJhY2tpbmdTdG9yZURlbGF5ID0gMjsKIAogICAgIG1fZGlzY2FyZEJhY2tp bmdTdG9yZVRpbWVyLnN0YXJ0T25lU2hvdChkaXNjYXJkQmFja2luZ1N0b3JlRGVsYXkpOwogfQo=