60858 2011-05-15 13:14:10 -0700 [Qt] Fix crash in inspector/console/console-long-eval-crash.html 2011-05-16 02:51:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 robert robert loislo pfeldman yurys oldest_to_newest 404198 0 robert 2011-05-15 13:14:10 -0700 [Qt] Fix crash in inspector/console/console-long-eval-crash.html 404200 1 93589 robert 2011-05-15 13:25:20 -0700 Created attachment 93589 Patch 404201 2 robert 2011-05-15 13:27:54 -0700 Hi Ilya, Does this look right to you? Or maybe there was a good reason for not protecting the call to m_client in sendMessageToBackend() ? 404205 3 loislo 2011-05-15 14:12:29 -0700 looks good to me 404326 4 93589 yurys 2011-05-16 00:12:41 -0700 Comment on attachment 93589 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93589&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:246 > + m_client->sendMessageToBackend(message); style: wrong alignment, not sure why style-check did fail. 404388 5 loislo 2011-05-16 02:51:23 -0700 manually Committed r86551 93589 2011-05-15 13:25:20 -0700 2011-05-16 02:51:52 -0700 Patch bug-60858-20110515212518.patch text/plain 2580 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODY1MDkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwZGIwNDBjYWJiYjk1ODM4ODMxODY3 ZWMyMmNmMTgxNWJkMTJhNDAwLi43NTlmNjY5NWM4ZGY3OGUyNmQyZjU4ZjBhNDAyYjRhNGQ3NTdk NDkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMTUgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gRml4IGNyYXNoIGluIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbG9u Zy1ldmFsLWNyYXNoLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYwODU4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEx LTA1LTE1ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLiBKdXN0IHNraXBwaW5nIGEgdGVzdC4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CmluZGV4IGRjNTNhYWE1YzhhYTYxYjNjZjk4ZTRkMzg2MWE4ZWUzN2U2ODk1ZDUuLmYyNjAxYmNk M2Y5Y2Q5MjFiNGQ3NGZmMDU2ZTcxZTZhMThiYmE1YzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZApAQCAtMTA3LDkgKzEwNyw2IEBAIGluc3BlY3Rvci9kZWJ1Z2dlci9kb20tYnJlYWtwb2ludHMu aHRtbAogaW5zcGVjdG9yL2RlYnVnZ2VyL2V2ZW50LWxpc3RlbmVyLWJyZWFrcG9pbnRzLmh0bWwK IGluc3BlY3Rvci9kZWJ1Z2dlci94aHItYnJlYWtwb2ludHMuaHRtbAogCi0jIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDYxNgotaW5zcGVjdG9yL2NvbnNvbG8vY29u c29sZS1sb25nLWV2YWwtY3Jhc2guaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MDMwMAogaW5zcGVjdG9yL2RlYnVnZ2VyL2xpdmUtZWRpdC5odG1sCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZWRkNDE0MzY4OTMxZjE1Y2FhODllMDBiMDNmMTU3NWM2MmM3MTEyLi4y ZTU3NzdhYzRmYzU2NjVlYWI0YWM2MGJlMWIyNWMyYWQxMTA5OGQ0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMDUtMTUgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g Rml4IGNyYXNoIGluIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbG9uZy1ldmFsLWNyYXNoLmh0 bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwODU4 CisKKyAgICAgICAgVGhlIGNsaWVudCBtYXkgYmUgZ29uZSB3aGVuIHNlbmRNZXNzYWdlVG9CYWNr ZW5kKCkgaXMgY2FsbGVkLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5k SG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnNlbmRN ZXNzYWdlVG9CYWNrZW5kKToKKwogMjAxMS0wNS0xNSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNs b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhv c3QuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5j cHAKaW5kZXggZDdmMTZhOTc2Y2NiYWMwZjIxODRkOTFmNDA4YzEwMTJjMTFmOWVkMi4uOWNmNmZm M2Q0ZDE2ZmI5NDUyOWQ5N2UwYzQ1ZDgzZTgzODgyMTI2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKQEAgLTI0Miw3ICsyNDIs OCBAQCBTdHJpbmcgSW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojpsb2FkU2Vzc2lvblNldHRpbmcoY29u c3QgU3RyaW5nJiBrZXkpCiAKIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpzZW5kTWVzc2Fn ZVRvQmFja2VuZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCiB7Ci0gICAgbV9jbGllbnQtPnNlbmRN ZXNzYWdlVG9CYWNrZW5kKG1lc3NhZ2UpOworICAgIGlmIChtX2NsaWVudCkKKyAgICAgICAgICBt X2NsaWVudC0+c2VuZE1lc3NhZ2VUb0JhY2tlbmQobWVzc2FnZSk7CiB9CiAKICNpZiBFTkFCTEUo Q09OVEVYVF9NRU5VUykK