60840 2011-05-14 11:30:59 -0700 WebKit2: Smart cut&paste is broken 2011-05-14 14:23:41 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 ap ap andersca commit-queue oldest_to_newest 404082 0 ap 2011-05-14 11:30:59 -0700 Steps to reproduce: 1. Open e.g. http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea 2. Double click a word 3. Cmd+X Expected results: the word is cut, only one space of the two that were surrounding it remains. Actual results: both spaces remain. All we likely need to do is to set a preference. I'm not sure, but we may not be using "Mac editing behavior" at all in WK2, losing a lot of other important features. 404084 1 ap 2011-05-14 11:31:26 -0700 <rdar://problem/9439927> 404087 2 93559 ap 2011-05-14 12:00:58 -0700 Created attachment 93559 proposed fix No, this doesn't affect editing behavior, only this one feature. 404088 3 93559 andersca 2011-05-14 12:07:17 -0700 Comment on attachment 93559 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=93559&action=review > Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:183 > + smartInsertDeleteEnabled = ![[NSUserDefaults standardUserDefaults] objectForKey:WebSmartInsertDeleteEnabled] || [[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled]; I don't understand the first part here. smartInsertDelete is enabled when [[NSUserDefaults standardUserDefaults] objectForKey:WebSmartInsertDeleteEnabled] returns nil? 404089 4 ap 2011-05-14 12:28:51 -0700 > I don't understand the first part here. smartInsertDelete is enabled when [[NSUserDefaults standardUserDefaults] objectForKey:WebSmartInsertDeleteEnabled] returns nil? Yes. It should be enabled for users who never touched this preference in context menu. Here is what WebKit1 does in -[WebViewPrivate init]: smartInsertDeleteEnabled = ![[NSUserDefaults standardUserDefaults] objectForKey:WebSmartInsertDeleteEnabled] || [[NSUserDefaults standardUserDefaults] boolForKey:WebSmartInsertDeleteEnabled]; 404119 5 93559 commit-queue 2011-05-14 14:23:36 -0700 Comment on attachment 93559 proposed fix Clearing flags on attachment: 93559 Committed r86497: <http://trac.webkit.org/changeset/86497> 404120 6 commit-queue 2011-05-14 14:23:41 -0700 All reviewed patches have been landed. Closing bug. 93559 2011-05-14 12:00:58 -0700 2011-05-14 14:23:36 -0700 proposed fix SmartCutPaste.txt text/plain 1482 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDkzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTQgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogU21hcnQgY3V0JnBhc3RlIGlzIGJyb2tlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA4NDAKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk0Mzk5Mjc+CisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFj L1RleHRDaGVja2VyTWFjLm1tOiAoV2ViS2l0OjpUZXh0Q2hlY2tlcjo6aXNTbWFydEluc2VydERl bGV0ZUVuYWJsZWQpOgorICAgICAgICBNYXRjaCBXSzEgLSB0aGlzIGRlZmF1bHQgZGVmYXVsdHMg dG8gWUVTIGlmIG5vdCBwcmVzZW50LgorCiAyMDExLTA1LTE0ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVGV4dENoZWNrZXJNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9UZXh0Q2hlY2tlck1hYy5tbQko cmV2aXNpb24gODY0MTApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1RleHRDaGVj a2VyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xODAsNyArMTgwLDcgQEAgYm9vbCBUZXh0Q2hl Y2tlcjo6aXNTbWFydEluc2VydERlbGV0ZUVuYQogICAgIHN0YXRpYyBib29sIHJlYWRTbWFydElu c2VydERlbGV0ZUVuYWJsZWREZWZhdWx0OwogCiAgICAgaWYgKCFyZWFkU21hcnRJbnNlcnREZWxl dGVFbmFibGVkRGVmYXVsdCkgewotICAgICAgICBzbWFydEluc2VydERlbGV0ZUVuYWJsZWQgPSBb W05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OldlYlNtYXJ0 SW5zZXJ0RGVsZXRlRW5hYmxlZF07CisgICAgICAgIHNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZCA9 ICFbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBvYmplY3RGb3JLZXk6V2Vi U21hcnRJbnNlcnREZWxldGVFbmFibGVkXSB8fCBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNl ckRlZmF1bHRzXSBib29sRm9yS2V5OldlYlNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZF07CiAKICAg ICAgICAgcmVhZFNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZERlZmF1bHQgPSB0cnVlOwogICAgIH0K