60835 2011-05-14 02:04:17 -0700 initializeMainThread in jsc executable 2011-05-14 22:02:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 59762 P2 Normal --- 1 paroga paroga abarth ap barraclough levin oldest_to_newest 404045 0 paroga 2011-05-14 02:04:17 -0700 initializeMainThread in jsc executable 404046 1 93551 paroga 2011-05-14 02:07:08 -0700 Created attachment 93551 Patch 404079 2 ap 2011-05-14 11:13:20 -0700 *** This bug has been marked as a duplicate of bug 59762 *** 404090 3 paroga 2011-05-14 12:41:32 -0700 Can you please explain the r-? What's wrong with this change? Isn't the knowledge about the MainThread allowed in JSC? Why is it part of WTF in that case? At the moment we get an assertion at http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp?rev=84466#L146 when not using ENABLE(WTF_MULTIPLE_THREADS). I don't think that removing the assertion will be the right way??? 404104 4 ap 2011-05-14 13:20:56 -0700 Sorry, I thought that the explanation in the bug I duped this to was sufficient. A JavaScriptCore API client can use any thread - there is no requirement that the first call to JavaScriptCore is from main thread, or that the client initializes main thread explicitly. So, jsc is testing a common and perfectly normal scenario. > At the moment we get an assertion at http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp?rev=84466#L146 when not using ENABLE(WTF_MULTIPLE_THREADS). It would be cleanest to open a new bug for the symptom that you observe, and discuss solutions there. Please post a stack trace for the assertion in that bug. 404114 5 paroga 2011-05-14 13:50:41 -0700 (In reply to comment #4) > Sorry, I thought that the explanation in the bug I duped this to was sufficient. I didn't find the info i wanted. :-( > A JavaScriptCore API client can use any thread - there is no requirement that the first call to JavaScriptCore is from main thread, or that the client initializes main thread explicitly. So, jsc is testing a common and perfectly normal scenario. IMHO then every isMainThread call is wrong in WTF/JSC and we should move MainThread to WebCore. > > At the moment we get an assertion at http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp?rev=84466#L146 when not using ENABLE(WTF_MULTIPLE_THREADS). > > It would be cleanest to open a new bug for the symptom that you observe, and discuss solutions there. Please post a stack trace for the assertion in that bug. Created bug 60846. 404143 6 ap 2011-05-14 22:02:06 -0700 > IMHO then every isMainThread call is wrong in WTF/JSC and we should move MainThread to WebCore. There are only two uses outside MainThread.* files - in AtomicString::init() and in CryptographicallyRandomNumber.cpp. This does seem confusing and misplaced to me. 93551 2011-05-14 02:07:08 -0700 2011-05-14 11:13:29 -0700 Patch bug-60835-20110514110706.patch text/plain 1246 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODY0NjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQw YzhhMzE1ZjQ2MjcxMTgzNWUyYzZiZGZjY2U2N2UyODA2NzYzNTIuLjkzOGQ4MzllNmJlMWMwNGI2 MGUxY2ZkMmMwMTExOGQ0ZGNmNTY2NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDExLTA1LTE0ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGlu aXRpYWxpemVNYWluVGhyZWFkIGluIGpzYyBleGVjdXRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDgzNQorCisgICAgICAgIEFkZGVkIFdURjo6 aW5pdGlhbGl6ZU1haW5UaHJlYWQoKSB0byBmaXggQVNTRVJUKGlzTWFpblRocmVhZCgpKS4KKwor ICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgIChtYWluKToKKwogMjAxMS0wNS0wMSAgSG9sZ2Vy IEhhbnMgUGV0ZXIgRnJleXRoZXIgIDxob2xnZXJAbW9pamktbW9iaWxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggNzI5ZGNl OTk4NmIwMGNkNWZhMmYwMGZkODEyNDk5MThkZDFjNDIwZi4uMDY4ZWFkMWNkYTJiZjg2OTZmYzA1 MTQxNmQxOTljMDI0ZWQ0MDI2YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKQEAgLTM1MCw2ICszNTAs NyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAKICAgICAvLyBJbml0aWFsaXpl IEpTQyBiZWZvcmUgZ2V0dGluZyBKU0dsb2JhbERhdGEuCiAgICAgSlNDOjppbml0aWFsaXplVGhy ZWFkaW5nKCk7CisgICAgV1RGOjppbml0aWFsaXplTWFpblRocmVhZCgpOwogCiAgICAgLy8gV2Ug Y2FuJ3QgdXNlIGRlc3RydWN0b3JzIGluIHRoZSBmb2xsb3dpbmcgY29kZSBiZWNhdXNlIGl0IHVz ZXMgV2luZG93cwogICAgIC8vIFN0cnVjdHVyZWQgRXhjZXB0aW9uIEhhbmRsaW5nCg==