<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60824</bug_id>
          
          <creation_ts>2011-05-13 17:42:50 -0700</creation_ts>
          <short_desc>[Qt] Turn on CONFIG(production) for production branches</short_desc>
          <delta_ts>2012-03-02 00:59:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>32653</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>hausmann</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>menard</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>403995</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-05-13 17:42:50 -0700</bug_when>
    <thetext>This bug is a place-holder to remind us to turn on production bit for all QtWebKit production branches. The idea has been introduced in http://trac.webkit.org/changeset/65690 and has been used first in QtWebKit 2.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403997</commentid>
    <comment_count>1</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-05-13 17:47:44 -0700</bug_when>
    <thetext>The following gitorious commits needs to be merged (from QtWebKit 2.1) into QtWebKit 2.2:

1./ b88b478535791adff59008398454c026ce20f301

To merge this commit, please add the &quot;CONFIG += production&quot; line into common.pri instead of WebKit.pri otherwise the build will not succeed. 

2./ a00c8841274f813983a581b86b919be4e645dd80
3./ 4172d67496e94e457a4daf45c808e5db4757c74e

4./ Merging these 3 commits (the first commit really) will make some LayoutTests fail as this will disable WebTiming, which requires adjusting the LayoutTest results and the Skipped list. I can help fixing these failures if needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404527</commentid>
    <comment_count>2</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-05-16 09:41:58 -0700</bug_when>
    <thetext>Done on 2.2.

I also disabled the web timing tests I could find, but I&apos;m not sure if there are others failing, we&apos;ll have to see the results from the bot (unfortunately I still don&apos;t have a VM/machine here to run these tests reliably).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404727</commentid>
    <comment_count>3</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-05-16 14:47:26 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Done on 2.2.
&gt; 
&gt; I also disabled the web timing tests I could find, but I&apos;m not sure if there are others failing, we&apos;ll have to see the results from the bot (unfortunately I still don&apos;t have a VM/machine here to run these tests reliably).

Update: managed to fix/skip all failing tests, the 2.2 bots are green now. :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419509</commentid>
    <comment_count>4</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-06-13 05:35:01 -0700</bug_when>
    <thetext>Can we close that bug or what?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>419543</commentid>
    <comment_count>5</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2011-06-13 07:16:43 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Can we close that bug or what?

That&apos;s one of these bugs which don&apos;t fit well into bugzilla: it&apos;s a reminder for something we have to do on our productization branches, but not on trunk.

Let&apos;s keep it open until I document on the wiki the procedure for opening a new stable branch, then we can close it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>569397</commentid>
    <comment_count>6</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-03-02 00:59:09 -0800</bug_when>
    <thetext>We&apos;re likely going to use a different mechanism for the &quot;production&quot; builds (if at all). Closing this for now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>