<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>60820</bug_id>
          
          <creation_ts>2011-05-13 16:59:37 -0700</creation_ts>
          <short_desc>Handle WTF_FEATURE defined to nothing</short_desc>
          <delta_ts>2011-06-08 06:19:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lucas De Marchi">lucas.de.marchi</reporter>
          <assigned_to name="Lucas De Marchi">lucas.de.marchi</assigned_to>
          <cc>leandro</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>paroga</cc>
    
    <cc>steveblock</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>zecke</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>403958</commentid>
    <comment_count>0</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-13 16:59:37 -0700</bug_when>
    <thetext>Handle WTF_FEATURE defined to nothing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403967</commentid>
    <comment_count>1</comment_count>
      <attachid>93535</attachid>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-13 17:07:01 -0700</bug_when>
    <thetext>Created attachment 93535
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>403972</commentid>
    <comment_count>2</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-13 17:12:11 -0700</bug_when>
    <thetext>Simple source code to test the result. BLA and BLO are considered to be disabled, so the output will be &quot;bli\n&quot;

---
#include &lt;stdio.h&gt;

#define ENABLE_BLA 0
#define ENABLE_BLI 1
#define ENABLE_BLO

#define ENABLE(WTF_FEATURE) (defined ENABLE_##WTF_FEATURE &amp;&amp; ENABLE_##WTF_FEATURE +0)


int main(void)
{
#if ENABLE(BLA)
    printf(&quot;bla\n&quot;);
#endif
#if ENABLE(BLI)
    printf(&quot;bli\n&quot;);
#endif
#if ENABLE(BLO)
    printf(&quot;blo\n&quot;);
#endif

    return 0;
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404025</commentid>
    <comment_count>3</comment_count>
      <attachid>93535</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-05-13 22:23:07 -0700</bug_when>
    <thetext>Comment on attachment 93535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93535&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:17
&gt; +        * wtf/Platform.h: ditto.

ditto what??

&gt; Source/JavaScriptCore/wtf/Platform.h:55
&gt; +#define ENABLE(WTF_FEATURE) (defined ENABLE_##WTF_FEATURE  &amp;&amp; ENABLE_##WTF_FEATURE +0)

I don&apos;t like this patch. IMHO its a failure if a ENABLE_XXX is not defined. The buildsystem must take care of the defines.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404137</commentid>
    <comment_count>4</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-14 19:44:29 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 93535 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=93535&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/ChangeLog:17
&gt; &gt; +        * wtf/Platform.h: ditto.
&gt; 
&gt; ditto what??

I explained what I did above of this. This is the only file modified, so it directly applies to what I said before.


&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/Platform.h:55
&gt; &gt; +#define ENABLE(WTF_FEATURE) (defined ENABLE_##WTF_FEATURE  &amp;&amp; ENABLE_##WTF_FEATURE +0)
&gt; 
&gt; I don&apos;t like this patch. IMHO its a failure if a ENABLE_XXX is not defined. The buildsystem must take care of the defines.

I think you misread the issue. Please see the discussion on mailing list about adding other ports to CMake like GTK and Android.

ENABLE(WTF_FEATURE) checks if the the feature is defined *and* TRUE. This check is currently failing in case the feature is defined but without any value. What this patch does is to fix this.

It looks very hackish, but I don&apos;t think there&apos;s a fix more elegant than this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404427</commentid>
    <comment_count>5</comment_count>
      <attachid>93535</attachid>
    <who name="Steve Block">steveblock</who>
    <bug_when>2011-05-16 05:34:54 -0700</bug_when>
    <thetext>Comment on attachment 93535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93535&amp;action=review

&gt;&gt;&gt; Source/JavaScriptCore/wtf/Platform.h:55
&gt;&gt;&gt; +#define ENABLE(WTF_FEATURE) (defined ENABLE_##WTF_FEATURE  &amp;&amp; ENABLE_##WTF_FEATURE +0)
&gt;&gt; 
&gt;&gt; I don&apos;t like this patch. IMHO its a failure if a ENABLE_XXX is not defined. The buildsystem must take care of the defines.
&gt; 
&gt; I think you misread the issue. Please see the discussion on mailing list about adding other ports to CMake like GTK and Android.
&gt; 
&gt; ENABLE(WTF_FEATURE) checks if the the feature is defined *and* TRUE. This check is currently failing in case the feature is defined but without any value. What this patch does is to fix this.
&gt; 
&gt; It looks very hackish, but I don&apos;t think there&apos;s a fix more elegant than this.

I didn&apos;t follow all of the details of your webkit-dev discussion about cmake, but this patch looks wrong to me. The code is written expecting these flags to be either undefined, or set to TRUE/FALSE. Surely this should be solved by fixing cmake to set the flags correctly, not modifying the code to compensate.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>404441</commentid>
    <comment_count>6</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-05-16 06:19:05 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; I didn&apos;t follow all of the details of your webkit-dev discussion about cmake, but this patch looks wrong to me. The code is written expecting these flags to be either undefined, or set to TRUE/FALSE. Surely this should be solved by fixing cmake to set the flags correctly, not modifying the code to compensate.

Ok. So the only way to have this working right in CMake for all ports is to define a default value (0 ?) for every feature. It&apos;s not my preferred solution (it seems much cleaner to do what I did here) but it sure can be made.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>415397</commentid>
    <comment_count>7</comment_count>
      <attachid>96008</attachid>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-06-03 22:03:03 -0700</bug_when>
    <thetext>Created attachment 96008
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>416494</commentid>
    <comment_count>8</comment_count>
    <who name="Leandro Pereira">leandro</who>
    <bug_when>2011-06-07 07:43:18 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Created an attachment (id=96008) [details]
&gt; Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>417197</commentid>
    <comment_count>9</comment_count>
      <attachid>96008</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2011-06-08 06:04:25 -0700</bug_when>
    <thetext>Comment on attachment 96008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96008&amp;action=review

&gt; ChangeLog:18
&gt; +        with another variable. This way the feature will be always 0 or 1 and

will always be</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>417206</commentid>
    <comment_count>10</comment_count>
    <who name="Lucas De Marchi">lucas.de.marchi</who>
    <bug_when>2011-06-08 06:19:58 -0700</bug_when>
    <thetext>Committed r88342: &lt;http://trac.webkit.org/changeset/88342&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>93535</attachid>
            <date>2011-05-13 17:07:01 -0700</date>
            <delta_ts>2011-06-03 22:02:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60820-20110513210727.patch</filename>
            <type>text/plain</type>
            <size>1803</size>
            <attacher name="Lucas De Marchi">lucas.de.marchi</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODY0NzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGYz
ZTgxNGRmY2I1YTNjMTIxNjgzZDQyYWRhZGZmZTZiMmZmNGU3NGMuLjZlNTcwNjlhM2RlYzI3YWFk
NTFmNzc5YWJiMDQ0MzVkZDViOTEzZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDIxIEBACisyMDExLTA1LTEzICBMdWNhcyBEZSBNYXJjaGkgIDxsdWNhcy5kZW1hcmNoaUBw
cm9mdXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBIYW5kbGUgV1RGX0ZFQVRVUkUgZGVmaW5lZCB0byBub3RoaW5nCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDgyMAorCisgICAgICAgIElu
IEVOQUJMRShXVEZfRkVBVFVSRSkgbWFjcm8gd2UgY2hlY2sgZm9yIHRoZSBmZWF0dXJlIGJlZW4g
ZGVmaW5lZCBhbmQKKyAgICAgICAgZGlmZmVyZW50IGZyb20gemVyby4gSG93ZXZlciBpZiB0aGUg
ZmVhdHVyZSBpcyBkZWZpbmVkIHRvIG5vdGhpbmcKKyAgICAgICAgKCNkZWZpbmUgRU5BQkxFX01Z
X0ZFQVRVUkUpLCB0aGUgcHJlcHJvY2Vzc29yIHdpbGwgZmFpbCB0byBoYW5kbGUgdGhlCisgICAg
ICAgIHNvdXJjZSBjb2RlLCBjb21wbGFpbmluZyB0aGVyZSdzIG5vIHJpZ2h0IG9wZXJhbmQgdG8g
JyYmJyBvcGVyYXRvci4KKworICAgICAgICBJbiBvcmRlciB0byBoYW5kbGUgdGhpcyBjYXNlLCB3
ZSBhZGQgYSAiKzAiIGF0IHRoZSBlbmQgb2YgdGhlIG1hY3JvCisgICAgICAgIGRlZmluaXRpb24u
IEl0IHdpbGwgYmUgdGhlIHJpZ2h0IG9wZXJhbmQgaW4gY2FzZSBmZWF0dXJlIGlzIGRlZmluZWQK
KyAgICAgICAgdG8gbm90aGluZywgcmV0dXJuaW5nIDAgaW4gdGhhdCBjYXNlLgorCisgICAgICAg
ICogd3RmL1BsYXRmb3JtLmg6IGRpdHRvLgorCiAyMDExLTA1LTEzICBPbGl2ZXIgSHVudCAgPG9s
aXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0
Zi9QbGF0Zm9ybS5oCmluZGV4IDQ2YWY1NDczNDlmNWI2NTkyMDEwOGJmZjY3N2U2MGNjMjk3YzE1
MDMuLjNiNmMyNGM1NTUyZDExY2EzOGY5ZjE3MDI3YTA2MjU3OTgzOThiNzcgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTUyLDcgKzUyLDcgQEAKIC8qIFVTRSgpIC0gdXNl
IGEgcGFydGljdWxhciB0aGlyZC1wYXJ0eSBsaWJyYXJ5IG9yIG9wdGlvbmFsIE9TIHNlcnZpY2Ug
Ki8KICNkZWZpbmUgVVNFKFdURl9GRUFUVVJFKSAoZGVmaW5lZCBXVEZfVVNFXyMjV1RGX0ZFQVRV
UkUgICYmIFdURl9VU0VfIyNXVEZfRkVBVFVSRSkKIC8qIEVOQUJMRSgpIC0gdHVybiBvbiBhIHNw
ZWNpZmljIGZlYXR1cmUgb2YgV2ViS2l0ICovCi0jZGVmaW5lIEVOQUJMRShXVEZfRkVBVFVSRSkg
KGRlZmluZWQgRU5BQkxFXyMjV1RGX0ZFQVRVUkUgICYmIEVOQUJMRV8jI1dURl9GRUFUVVJFKQor
I2RlZmluZSBFTkFCTEUoV1RGX0ZFQVRVUkUpIChkZWZpbmVkIEVOQUJMRV8jI1dURl9GRUFUVVJF
ICAmJiBFTkFCTEVfIyNXVEZfRkVBVFVSRSArMCkKIAogCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>96008</attachid>
            <date>2011-06-03 22:03:03 -0700</date>
            <delta_ts>2011-06-08 06:04:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-60820-20110604020337.patch</filename>
            <type>text/plain</type>
            <size>5673</size>
            <attacher name="Lucas De Marchi">lucas.de.marchi</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODgwOTAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n
ZUxvZwppbmRleCAxYzA2ODVjZmZmNmRiZjc4NmJjMTljZjIwMzc1YTc4OGFmM2UxZGIwLi44NDVk
ZTc1ZDY3ODFlMWI4NDgzMTY1MjU0MDNiNzY4YWI1OTczYTlkIDEwMDY0NAotLS0gYS9DaGFuZ2VM
b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDYtMDMgIEx1Y2FzIERl
IE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gTmV2ZXIgbGV0IGEgV1RG
X0ZFQVRVUkUgZGVmaW5lZCB0byBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu
b3JnL3Nob3dfYnVnLmNnaT9pZD02MDgyMAorCisgICAgICAgIElmIGEgcG9ydCBkb2Vzbid0IHdh
bnQgdG8gZ2l2ZSB0aGUgdXNlciBzb21lIGNvbmZpZ3VyZSBvcHRpb25zLAorICAgICAgICBuZXZl
cnRoZWxlc3MgaXQgd291bGQgaGF2ZSB0byBkZWZpbmUgdGhpcyBmZWF0dXJlIGFzIE9GRi4gT3Ro
ZXJ3aXNlCisgICAgICAgIHRoZXJlJ3MgYSBidWlsZCBlcnJvciBiZWNhdXNlIHRoZSBnZW5lcmF0
ZWQgY21ha2Vjb25maWcuaCBpcyBub3QKKyAgICAgICAgcGFyc2VkIGNvcnJlY3RseSBieSBFTkFC
TEUgbWFjcm8sIHdoaWNoIGV4cGVjdHMgZWFjaCBmZWF0dXJlIHRvIGJlCisgICAgICAgIGVpdGhl
ciB1bmRlZmluZWQgb3IgZGVmaW5lZCB0byBUUlVFL0ZBTFNFLgorCisgICAgICAgICogU291cmNl
L2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOiBVc2UgYSB2YXJpYWJsZSB3aXRoIHRoZSBzYW1l
IG5hbWUKKyAgICAgICAgb2YgdGhlIGZlYXR1cmUsIHdoaWNoIGFsbG93cyBDT05GSUdVUkVfRklM
RSgpIHRvIHJlcGxhY2UgaXQgaW4gdGhlIG5ldworICAgICAgICBjbWFrZWNvbmZpZy5oLmNtYWtl
LgorICAgICAgICAqIFNvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlOiB1c2UgI2NtYWtlZGVmaW5l
MDEgaW5zdGVhZCBvZiAjZGVmaW5lCisgICAgICAgIHdpdGggYW5vdGhlciB2YXJpYWJsZS4gVGhp
cyB3YXkgdGhlIGZlYXR1cmUgd2lsbCBiZSBhbHdheXMgMCBvciAxIGFuZAorICAgICAgICBpdCB3
aWxsIG5ldmVyIGJlIGxlZnQgdW5kZWZpbmVkLgorCiAyMDExLTA2LTAzICBNYXJ0aW4gUm9iaW5z
b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp
IEdsYXprb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2Ug
Yi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5kZXggNzEzYjFhNzZhNWNmM2Nh
YjAwOThjZGZiODEwZGYxYjUyM2ExMzQ1ZC4uNGNhYjVhMzhmY2NjOTY3NjFmZWE5NmVkNjJkZjdm
M2YzNjMxNDdhYyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtl
CisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQpAQCAtNDQsMTEgKzQ0LDEx
IEBAIE1BQ1JPKFdFQktJVF9GRUFUVVJFIF9mZWF0dXJlIF9kZXNjcmlwdGlvbiBfdHlwZSBfYXJn
cykKIAlMSVNUKEFQUEVORCBXRUJLSVRfRkVBVFVSRVMgJHtfZmVhdHVyZX0pCiAKIAlJRiAoJHtf
ZmVhdHVyZX0pCi0JCVNFVCgke19mZWF0dXJlfV9WQUxVRSAxKQorCQlTRVQoJHtfZmVhdHVyZX0g
MSkKIAkJV0VCS0lUX1NFUEFSQVRFX0ZFQVRVUkVTKCR7X2ZlYXR1cmV9IDEgJHtBUkdOfSkKIAkJ
TElTVChBUFBFTkQgRkVBVFVSRV9ERUZJTkVTICR7X2ZlYXR1cmV9KQogCUVMU0UgKCkKLQkJU0VU
KCR7X2ZlYXR1cmV9X1ZBTFVFIDApCisJCVNFVCgke19mZWF0dXJlfSAwKQogCQlXRUJLSVRfU0VQ
QVJBVEVfRkVBVFVSRVMoJHtfZmVhdHVyZX0gMCAke0FSR059KQogCUVORElGICgpCiBFTkRNQUNS
TygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFr
ZWNvbmZpZy5oLmNtYWtlCmluZGV4IDE3ZDZjODVhNmNjMDIzMzNmODA2YmVjNTFhZGZjYTQ0MzFj
MjhjNjUuLjQwMmMwZTg3OWFkZjExMDg4OTY0M2EwZWFhN2IxMzkwNTIyMjk2N2MgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZWNvbmZpZy5o
LmNtYWtlCkBAIC00LDQyICs0LDQzIEBACiAjZGVmaW5lIFdFQktJVF9VU0VSX0FHRU5UX01BSk9S
X1ZFUlNJT04gQFVTRVJfQUdFTlRfVkVSU0lPTl9NQUpPUkAKICNkZWZpbmUgV0VCS0lUX1VTRVJf
QUdFTlRfTUlOT1JfVkVSU0lPTiBAVVNFUl9BR0VOVF9WRVJTSU9OX01JTk9SQAogCi0jZGVmaW5l
IEVOQUJMRV9BU19JTUFHRSBARU5BQkxFX0FTX0lNQUdFX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVf
QkxPQiBARU5BQkxFX0JMT0JfVkFMVUVACi0jZGVmaW5lIEVOQUJMRV9DSEFOTkVMX01FU1NBR0lO
RyBARU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfREFUQUJB
U0UgQEVOQUJMRV9EQVRBQkFTRV9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0RBVEFHUklEIEBFTkFC
TEVfREFUQUdSSURfVkFMVUVACi0jZGVmaW5lIEVOQUJMRV9EQVRBTElTVCBARU5BQkxFX0RBVEFM
SVNUX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVNUyBARU5BQkxFX0RB
VEFfVFJBTlNGRVJfSVRFTVNfVkFMVUVACi0jZGVmaW5lIEVOQUJMRV9ET01fU1RPUkFHRSBARU5B
QkxFX0RPTV9TVE9SQUdFX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfRVZFTlRTT1VSQ0UgQEVOQUJM
RV9FVkVOVFNPVVJDRV9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0ZBU1RfTU9CSUxFX1NDUk9MTElO
RyBARU5BQkxFX0ZBU1RfTU9CSUxFX1NDUk9MTElOR19WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0ZJ
TFRFUlMgQEVOQUJMRV9GSUxURVJTX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfRlRQRElSIEBFTkFC
TEVfRlRQRElSX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfR0VPTE9DQVRJT04gQEVOQUJMRV9HRU9M
T0NBVElPTl9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0dMSUJfU1VQUE9SVCBARU5BQkxFX0dMSUJf
U1VQUE9SVF9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0lDT05EQVRBQkFTRSBARU5BQkxFX0lDT05E
QVRBQkFTRV9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0lOU1BFQ1RPUiBARU5BQkxFX0lOU1BFQ1RP
Ul9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIgQEVOQUJMRV9KQVZB
U0NSSVBUX0RFQlVHR0VSX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfSklUIEBFTkFCTEVfSklUX1ZB
TFVFQAotI2RlZmluZSBFTkFCTEVfTUFUSE1MIEBFTkFCTEVfTUFUSE1MX1ZBTFVFQAotI2RlZmlu
ZSBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSBARU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUElf
VkFMVUVACi0jZGVmaW5lIEVOQUJMRV9OT1RJRklDQVRJT05TIEBFTkFCTEVfTk9USUZJQ0FUSU9O
U19WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUyBARU5BQkxF
X09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OU19WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX09SSUVOVEFU
SU9OX0VWRU5UUyBARU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UU19WQUxVRUAKLSNkZWZpbmUgRU5B
QkxFX1BST0dSRVNTX1RBRyBARU5BQkxFX1BST0dSRVNTX1RBR19WQUxVRUAKLSNkZWZpbmUgRU5B
QkxFX1NIQVJFRF9XT1JLRVJTIEBFTkFCTEVfU0hBUkVEX1dPUktFUlNfVkFMVUVACi0jZGVmaW5l
IEVOQUJMRV9TVkcgQEVOQUJMRV9TVkdfVkFMVUVACi0jZGVmaW5lIEVOQUJMRV9TVkdfQU5JTUFU
SU9OIEBFTkFCTEVfU1ZHX0FOSU1BVElPTl9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX1NWR19GT05U
UyBARU5BQkxFX1NWR19GT05UU19WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX1NWR19GT1JFSUdOX09C
SkVDVCBARU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVF9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX1NW
R19VU0UgQEVOQUJMRV9TVkdfVVNFX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfVE9VQ0hfRVZFTlRT
IEBFTkFCTEVfVE9VQ0hfRVZFTlRTX1ZBTFVFQAotI2RlZmluZSBFTkFCTEVfVklERU8gQEVOQUJM
RV9WSURFT19WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX1dFQl9TT0NLRVRTIEBFTkFCTEVfV0VCX1NP
Q0tFVFNfVkFMVUVACi0jZGVmaW5lIEVOQUJMRV9XT1JLRVJTIEBFTkFCTEVfV09SS0VSU19WQUxV
RUAKLSNkZWZpbmUgRU5BQkxFX1hIVE1MTVAgQEVOQUJMRV9YSFRNTE1QX1ZBTFVFQAotI2RlZmlu
ZSBFTkFCTEVfWFBBVEggQEVOQUJMRV9YUEFUSF9WQUxVRUAKLSNkZWZpbmUgRU5BQkxFX1hTTFQg
QEVOQUJMRV9YU0xUX1ZBTFVFQAorCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfQVNfSU1BR0UKKyNj
bWFrZWRlZmluZTAxIEVOQUJMRV9CTE9CCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfQ0hBTk5FTF9N
RVNTQUdJTkcKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9EQVRBQkFTRQorI2NtYWtlZGVmaW5lMDEg
RU5BQkxFX0RBVEFHUklECisjY21ha2VkZWZpbmUwMSBFTkFCTEVfREFUQUxJU1QKKyNjbWFrZWRl
ZmluZTAxIEVOQUJMRV9EQVRBX1RSQU5TRkVSX0lURU1TCisjY21ha2VkZWZpbmUwMSBFTkFCTEVf
RE9NX1NUT1JBR0UKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9FVkVOVFNPVVJDRQorI2NtYWtlZGVm
aW5lMDEgRU5BQkxFX0ZBU1RfTU9CSUxFX1NDUk9MTElORworI2NtYWtlZGVmaW5lMDEgRU5BQkxF
X0ZJTFRFUlMKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9GVFBESVIKKyNjbWFrZWRlZmluZTAxIEVO
QUJMRV9HRU9MT0NBVElPTgorI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0dMSUJfU1VQUE9SVAorI2Nt
YWtlZGVmaW5lMDEgRU5BQkxFX0lDT05EQVRBQkFTRQorI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0lO
U1BFQ1RPUgorI2NtYWtlZGVmaW5lMDEgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIKKyNjbWFr
ZWRlZmluZTAxIEVOQUJMRV9KSVQKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9NQVRITUwKKyNjbWFr
ZWRlZmluZTAxIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJCisjY21ha2VkZWZpbmUwMSBFTkFC
TEVfTk9USUZJQ0FUSU9OUworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX09GRkxJTkVfV0VCX0FQUExJ
Q0FUSU9OUworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUworI2NtYWtl
ZGVmaW5lMDEgRU5BQkxFX1BST0dSRVNTX1RBRworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NIQVJF
RF9XT1JLRVJTCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfU1ZHCisjY21ha2VkZWZpbmUwMSBFTkFC
TEVfU1ZHX0FOSU1BVElPTgorI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1NWR19GT05UUworI2NtYWtl
ZGVmaW5lMDEgRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVAorI2NtYWtlZGVmaW5lMDEgRU5BQkxF
X1NWR19VU0UKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9UT1VDSF9FVkVOVFMKKyNjbWFrZWRlZmlu
ZTAxIEVOQUJMRV9WSURFTworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1dFQl9TT0NLRVRTCisjY21h
a2VkZWZpbmUwMSBFTkFCTEVfV09SS0VSUworI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1hIVE1MTVAK
KyNjbWFrZWRlZmluZTAxIEVOQUJMRV9YUEFUSAorI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1hTTFQK
IAogI2VuZGlmIC8qIENNQUtFQ09ORklHX0ggKi8K
</data>
<flag name="review"
          id="89623"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="89624"
          type_id="3"
          status="-"
          setter="kenneth"
    />
          </attachment>
      

    </bug>

</bugzilla>