60816 2011-05-13 16:33:42 -0700 Backing store may not get discarded due to stopped timer 2011-05-13 17:03:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff ggaren oldest_to_newest 403943 0 msaboff 2011-05-13 16:33:42 -0700 The backing store timer (m_discardBackingStoreTimer) can get stopped and never restarted when a window is made the active window. This causes a minor memory regression. 403951 1 93532 msaboff 2011-05-13 16:50:57 -0700 Created attachment 93532 Patch to restart timer when view state change allows the backing store to be deleted. 403954 2 ggaren 2011-05-13 16:52:08 -0700 r=me 403963 3 msaboff 2011-05-13 17:03:33 -0700 Committed r86473: <http://trac.webkit.org/changeset/86473> 93532 2011-05-13 16:50:57 -0700 2011-05-13 16:51:49 -0700 Patch to restart timer when view state change allows the backing store to be deleted. 60816.patch text/plain 2105 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDcyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMTMgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQmFja2luZyBzdG9yZSBtYXkgbm90IGdldCBkaXNjYXJkZWQg ZHVlIHRvIHN0b3BwZWQgdGltZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYwODE2CisKKyAgICAgICAgQ2hhbmdlZCB0aGUgYmFja2luZyBzdG9yZSB0 aW1lciB0byByZXN0YXJ0IGlmIGl0IGhhcyBiZWVuIHN0b3BwZWQuCisgICAgICAgIFRoZSBldmFs dWF0aW9uIGlzIGRvbmUgd2hlbiB0aGUgdmlldydzIHN0YXRlIGlzIGNoYW5nZWQuCisgICAgICAg IFRoaXMgY2hhbmdlIGFwcGVhcnMgdG8gYmUgd29ydGggfjNNQiAob25lIGJhY2tpbmcgc3RvcmUg d29ydGgpCisgICAgICAgIGR1cmluZyBtZW1vcnkgdGVzdHMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvRHJhd2luZ0FyZWFQcm94eUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJl YVByb3h5SW1wbDo6ZGlzY2FyZEJhY2tpbmdTdG9yZVNvb24pOgorICAgICAgICAqIFVJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnZpZXdT dGF0ZURpZENoYW5nZSk6CisKIDIwMTEtMDUtMTMgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9EcmF3aW5nQXJlYVByb3h5SW1wbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0RyYXdpbmdBcmVhUHJveHlJbXBsLmNwcAkocmV2 aXNpb24gODY0NjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvRHJhd2luZ0FyZWFQcm94 eUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDcsNyArMzQ3LDcgQEAgdm9pZCBEcmF3aW5n QXJlYVByb3h5SW1wbDo6ZXhpdEFjY2VsZXJhdAogCiB2b2lkIERyYXdpbmdBcmVhUHJveHlJbXBs OjpkaXNjYXJkQmFja2luZ1N0b3JlU29vbigpCiB7Ci0gICAgaWYgKCFtX2lzQmFja2luZ1N0b3Jl RGlzY2FyZGFibGUpCisgICAgaWYgKCFtX2lzQmFja2luZ1N0b3JlRGlzY2FyZGFibGUgfHwgbV9k aXNjYXJkQmFja2luZ1N0b3JlVGltZXIuaXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgLy8gV2UnbGwgd2FpdCB0aGlzIG1hbnkgc2Vjb25kcyBhZnRlciB0aGUgbGFzdCBwYWludCBi ZWZvcmUgdGhyb3dpbmcgYXdheSBvdXIgYmFja2luZyBzdG9yZSB0byBzYXZlIG1lbW9yeS4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA4 NjQ2MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MzMsOCArNjMzLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnZpZXdTdGF0 ZURpZENoYW5nZShWaQogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKGZsYWdzICYgKFZpZXdX aW5kb3dJc0FjdGl2ZSB8IFZpZXdJc1Zpc2libGUpKQotICAgICAgICB1cGRhdGVCYWNraW5nU3Rv cmVEaXNjYXJkYWJsZVN0YXRlKCk7CisgICAgdXBkYXRlQmFja2luZ1N0b3JlRGlzY2FyZGFibGVT dGF0ZSgpOwogfQogCiBJbnRTaXplIFdlYlBhZ2VQcm94eTo6dmlld1NpemUoKSBjb25zdAo=