60799 2011-05-13 13:50:43 -0700 Hide appcache status bar items 2011-05-17 11:11:40 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap ademar ddkilzer joepeck michaeln pfeldman yurys oldest_to_newest 403828 0 ap 2011-05-13 13:50:43 -0700 Data that this displayed in Web Inspector's Resources->Application Cache status bar is very misleading. I think that it is more likely to confuse developers than help them. See: http://webkit.org/b/41637 Web Inspector: Give Semantics to "Refresh" and "Delete" Buttons in ApplicationCache DataGrid http://webkit.org/b/60590 Application cache status always displayed as UNCACHED at first http://webkit.org/b/60793 Application cache status indicator gets stuck at DOWNLOADING after a failure Fixing these is not trivial, so I suggest just hiding the items for now. It seems that removing essentially dead code would not be helpful in this case. Thoughts? 403831 1 93504 ap 2011-05-13 13:53:38 -0700 Created attachment 93504 proposed patch 403834 2 93504 joepeck 2011-05-13 13:55:50 -0700 Comment on attachment 93504 proposed patch Sorry, I originally added this and never had time to implement more of it. I am fine with hiding it. 403837 3 ap 2011-05-13 14:01:30 -0700 Thanks! We'll need to actually remove the code if it begins to rot before we can fix it. Committed <http://trac.webkit.org/changeset/86460>. 405182 4 ademar 2011-05-17 11:11:40 -0700 Revision r86460 cherry-picked into qtwebkit-2.2 with commit fcd06b7 <http://gitorious.org/webkit/qtwebkit/commit/fcd06b7> 93504 2011-05-13 13:53:38 -0700 2011-05-13 13:55:50 -0700 proposed patch HideBadness.txt text/plain 3028 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMTMgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSGlkZSBhcHBjYWNoZSBzdGF0dXMgYmFyIGl0ZW1zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDc5OQorCisgICAg ICAgIFdlIGhhdmUgYSBudW1iZXIgb2Ygbm9uLXRyaXZpYWwgYnVncyB0aGF0IG1ha2UgdGhlc2Ug bW9yZSBtaXNsZWFkaW5nIHRoYW4gaGVscGZ1bCB0byBkZXZlbG9wZXJzLgorCisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9BcHBsaWNhdGlvbkNhY2hlSXRlbXNWaWV3LmpzOiAoV2ViSW5z cGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVJdGVtc1ZpZXcpOgorICAgICAgICBKdXN0IGhpZGUgdGhl IGl0ZW1zIGZvciBub3cuIFJlbW92aW5nIGFsbCBzdXBwb3J0IGNvZGUgd291bGQgYmUgY29tcGxp Y2F0ZWQsIGFuZCBub3QgaGVscGZ1bC4KKwogMjAxMS0wNS0xMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDog U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BcHBsaWNhdGlvbkNhY2hlSXRlbXNW aWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv QXBwbGljYXRpb25DYWNoZUl0ZW1zVmlldy5qcwkocmV2aXNpb24gODY0NDMpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FwcGxpY2F0aW9uQ2FjaGVJdGVtc1ZpZXcuanMJ KHdvcmtpbmcgY29weSkKQEAgLTMwLDEzICszMCwxMSBAQCBXZWJJbnNwZWN0b3IuQXBwbGljYXRp b25DYWNoZUl0ZW1zVmlldyA9CiAgICAgdGhpcy5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoInN0b3Jh Z2UtdmlldyIpOwogICAgIHRoaXMuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ0YWJsZSIpOwogCi0g ICAgLy8gRklYTUU6IERlbGV0ZSBCdXR0b24gc2VtYW50aWNzIGFyZSBub3QgeWV0IGRlZmluZWQu CiAgICAgLy8gRklYTUU6IE5lZWRzIGJldHRlciB0b29sdGlwLiAoTG9jYWxpemVkKQogICAgIHRo aXMuZGVsZXRlQnV0dG9uID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJEZWxldGUiKSwgImRlbGV0ZS1zdG9yYWdlLXN0YXR1cy1iYXItaXRl bSIpOwogICAgIHRoaXMuZGVsZXRlQnV0dG9uLnZpc2libGUgPSBmYWxzZTsKICAgICB0aGlzLmRl bGV0ZUJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX2RlbGV0ZUJ1dHRvbkNs aWNrZWQuYmluZCh0aGlzKSwgZmFsc2UpOwogCi0gICAgLy8gRklYTUU6IFJlZnJlc2ggQnV0dG9u IHNlbWFudGljcyBhcmUgbm90IHlldCBkZWZpbmVkLgogICAgIC8vIEZJWE1FOiBOZWVkcyBiZXR0 ZXIgdG9vbHRpcC4gKExvY2FsaXplZCkKICAgICB0aGlzLnJlZnJlc2hCdXR0b24gPSBuZXcgV2Vi SW5zcGVjdG9yLlN0YXR1c0JhckJ1dHRvbihXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlJlZnJlc2gi KSwgInJlZnJlc2gtc3RvcmFnZS1zdGF0dXMtYmFyLWl0ZW0iKTsKICAgICB0aGlzLnJlZnJlc2hC dXR0b24uYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9yZWZyZXNoQnV0dG9uQ2xpY2tl ZC5iaW5kKHRoaXMpLCBmYWxzZSk7CkBAIC02OSw2ICs2NywyMSBAQCBXZWJJbnNwZWN0b3IuQXBw bGljYXRpb25DYWNoZUl0ZW1zVmlldyA9CiAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRo aXMuX2VtcHR5TXNnRWxlbWVudCk7CiAKICAgICB0aGlzLnVwZGF0ZVN0YXR1cyhhcHBsaWNhdGlv bkNhY2hlLlVOQ0FDSEVEKTsKKworICAgIC8vIEZJWE1FOiBTdGF0dXMgYmFyIGl0ZW1zIGRvbid0 IHdvcmsgd2VsbCBlbm91Z2ggeWV0LCBzbyB0aGV5IGFyZSBiZWluZyBoaWRkZW4uCisgICAgLy8g aHR0cDovL3dlYmtpdC5vcmcvYi80MTYzNyBXZWIgSW5zcGVjdG9yOiBHaXZlIFNlbWFudGljcyB0 byAiUmVmcmVzaCIgYW5kICJEZWxldGUiIEJ1dHRvbnMgaW4gQXBwbGljYXRpb25DYWNoZSBEYXRh R3JpZAorICAgIC8vIGh0dHA6Ly93ZWJraXQub3JnL2IvNjA1OTAgQXBwbGljYXRpb24gY2FjaGUg c3RhdHVzIGFsd2F5cyBkaXNwbGF5ZWQgYXMgVU5DQUNIRUQgYXQgZmlyc3QKKyAgICAvLyBodHRw Oi8vd2Via2l0Lm9yZy9iLzYwNzkzIEFwcGxpY2F0aW9uIGNhY2hlIHN0YXR1cyBpbmRpY2F0b3Ig Z2V0cyBzdHVjayBhdCBET1dOTE9BRElORyBhZnRlciBhIGZhaWx1cmUKKyAgICB0aGlzLmRlbGV0 ZUJ1dHRvbi5lbGVtZW50LnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7CisgICAgdGhpcy5yZWZyZXNo QnV0dG9uLmVsZW1lbnQuc3R5bGUuZGlzcGxheSA9ICJub25lIjsKKyAgICBpZiAoUHJlZmVyZW5j ZXMub25saW5lRGV0ZWN0aW9uRW5hYmxlZCkgeworICAgICAgICB0aGlzLmNvbm5lY3Rpdml0eUlj b24uc3R5bGUuZGlzcGxheSA9ICJub25lIjsKKyAgICAgICAgdGhpcy5jb25uZWN0aXZpdHlNZXNz YWdlLnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7CisgICAgfQorICAgIHRoaXMuZGl2aWRlci5zdHls ZS5kaXNwbGF5ID0gIm5vbmUiOworICAgIHRoaXMuc3RhdHVzSWNvbi5zdHlsZS5kaXNwbGF5ID0g Im5vbmUiOworICAgIHRoaXMuc3RhdHVzTWVzc2FnZS5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOwor ICAgIAogfQogCiBXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25DYWNoZUl0ZW1zVmlldy5wcm90b3R5 cGUgPSB7Cg==