60794 2011-05-13 13:24:31 -0700 Make some page() member functions const 2011-05-13 13:46:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 403793 0 jeffm 2011-05-13 13:24:31 -0700 Make some page() member functions const 403794 1 93498 jeffm 2011-05-13 13:25:58 -0700 Created attachment 93498 Patch 403808 2 93498 webkit-ews 2011-05-13 13:37:46 -0700 Comment on attachment 93498 Patch Attachment 93498 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8699129 403811 3 jeffm 2011-05-13 13:40:44 -0700 I'll fix the qt build before landing the patch. 403817 4 jeffm 2011-05-13 13:46:22 -0700 Committed r86459: <http://trac.webkit.org/changeset/86459> 93498 2011-05-13 13:25:58 -0700 2011-05-13 13:37:46 -0700 Patch bug-60794-20110513132556.patch text/plain 3730 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDU3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMTMgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2Ugc29tZSBwYWdlKCkgbWVtYmVyIGZ1bmN0aW9ucyBjb25zdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA3OTQKKwor ICAgICAgICAqIFVJUHJvY2Vzcy9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eS5oOiBNYWtl IHBhZ2UoKSBjb25zdC4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5oOgorICAg ICAgICAoV2ViS2l0OjpXZWJGcmFtZVByb3h5OjpwYWdlKTogTWFrZSBwYWdlKCkgY29uc3QuCisg ICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6 OldlYkluc3BlY3RvclByb3h5OjpwYWdlKTogTWFrZSBwYWdlKCkgY29uc3QuCisgICAgICAgICog VUlQcm9jZXNzL21hYy9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eU1hYy5tbToKKyAgICAg ICAgKFdlYktpdDo6Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHk6OnBhZ2UpOiBNYWtlIHBh Z2UoKSBjb25zdC4KKyAgICAgICAgKiBVSVByb2Nlc3Mvd2luL0NodW5rZWRVcGRhdGVEcmF3aW5n QXJlYVByb3h5V2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2h1bmtlZFVwZGF0ZURyYXdpbmdB cmVhUHJveHk6OnBhZ2UpOiBNYWtlIHBhZ2UoKSBjb25zdC4KKwogMjAxMS0wNS0xMyAgQWRhbSBS b2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTG9hZCBwbHVnaW5zIGluIHRoZSBv cmRlciB0aGV5J3JlIGZvdW5kCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ2h1bmtl ZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkuaAkocmV2aXNpb24gODY0MzYp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJv eHkuaAkod29ya2luZyBjb3B5KQpAQCAtNjksNyArNjksNyBAQCBwdWJsaWM6CiBwcml2YXRlOgog ICAgIENodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5KFBsYXRmb3JtV2ViVmlldyosIFdlYlBh Z2VQcm94eSopOwogCi0gICAgV2ViUGFnZVByb3h5KiBwYWdlKCk7CisgICAgV2ViUGFnZVByb3h5 KiBwYWdlKCkgY29uc3Q7CiAKICAgICAvLyBEcmF3aW5nQXJlYVByb3h5CiAgICAgdmlydHVhbCB2 b2lkIGRpZFJlY2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNz YWdlSUQsIENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciopOwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViRnJhbWVQcm94eS5oCShyZXZpc2lvbiA4NjQzNikKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcw LDcgQEAgcHVibGljOgogICAgIH07CiAKICAgICB1aW50NjRfdCBmcmFtZUlEKCkgY29uc3QgeyBy ZXR1cm4gbV9mcmFtZUlEOyB9Ci0gICAgV2ViUGFnZVByb3h5KiBwYWdlKCkgeyByZXR1cm4gbV9w YWdlOyB9CisgICAgV2ViUGFnZVByb3h5KiBwYWdlKCkgY29uc3QgeyByZXR1cm4gbV9wYWdlOyB9 CiAKICAgICBXZWJGcmFtZVByb3h5KiBwYXJlbnRGcmFtZSgpIHsgcmV0dXJuIG1fcGFyZW50RnJh bWU7IH0KICAgICBXZWJGcmFtZVByb3h5KiBuZXh0U2libGluZygpIHsgcmV0dXJuIG1fbmV4dFNp Ymxpbmc7IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94 eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQ cm94eS5oCShyZXZpc2lvbiA4NjQzNikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJ bnNwZWN0b3JQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC03NCw3ICs3NCw3IEBAIHB1YmxpYzoK ICAgICB2b2lkIGludmFsaWRhdGUoKTsKIAogICAgIC8vIFB1YmxpYyBBUElzCi0gICAgV2ViUGFn ZVByb3h5KiBwYWdlKCkgeyByZXR1cm4gbV9wYWdlOyB9CisgICAgV2ViUGFnZVByb3h5KiBwYWdl KCkgY29uc3QgeyByZXR1cm4gbV9wYWdlOyB9CiAKICAgICBib29sIGlzVmlzaWJsZSgpIGNvbnN0 IHsgcmV0dXJuIG1faXNWaXNpYmxlOyB9CiAgICAgdm9pZCBzaG93KCk7CkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5TWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvQ2h1bmtlZFVwZGF0 ZURyYXdpbmdBcmVhUHJveHlNYWMubW0JKHJldmlzaW9uIDg2NDM2KQorKysgU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAog bmFtZXNwYWNlIFdlYktpdCB7CiAKLVdlYlBhZ2VQcm94eSogQ2h1bmtlZFVwZGF0ZURyYXdpbmdB cmVhUHJveHk6OnBhZ2UoKQorV2ViUGFnZVByb3h5KiBDaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQ cm94eTo6cGFnZSgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIHRvSW1wbChbbV93ZWJWaWV3IHBhZ2VS ZWZdKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vQ2h1bmtlZFVwZGF0 ZURyYXdpbmdBcmVhUHJveHlXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy93aW4vQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHlXaW4uY3BwCShyZXZpc2lv biA4NjQzNikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vQ2h1bmtlZFVwZGF0ZURy YXdpbmdBcmVhUHJveHlXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotV2ViUGFnZVBy b3h5KiBDaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eTo6cGFnZSgpCitXZWJQYWdlUHJveHkq IENodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5OjpwYWdlKCkgY29uc3QKIHsKICAgICByZXR1 cm4gbV93ZWJWaWV3LT5wYWdlKCk7CiB9Cg==