60784 2011-05-13 12:08:55 -0700 iframe sandbox doesn't properly block popups 2011-05-13 14:44:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric sam oldest_to_newest 403729 0 abarth 2011-05-13 12:08:55 -0700 iframe sandbox doesn't properly block popups 403731 1 93489 abarth 2011-05-13 12:10:35 -0700 Created attachment 93489 Patch 403732 2 93489 eric 2011-05-13 12:12:17 -0700 Comment on attachment 93489 Patch OK. 403877 3 commit-queue 2011-05-13 14:43:04 -0700 The commit-queue encountered the following flaky tests while processing attachment 93489: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 403879 4 93489 commit-queue 2011-05-13 14:44:22 -0700 Comment on attachment 93489 Patch Clearing flags on attachment: 93489 Committed r86462: <http://trac.webkit.org/changeset/86462> 403880 5 commit-queue 2011-05-13 14:44:28 -0700 All reviewed patches have been landed. Closing bug. 93489 2011-05-13 12:10:35 -0700 2011-05-13 14:44:22 -0700 Patch bug-60784-20110513121033.patch text/plain 5264 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDUtMTMgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBpZnJhbWUgc2FuZGJveCBkb2Vzbid0IHByb3Blcmx5IGJsb2NrIHBv cHVwcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjA3 ODQKKworICAgICAgICBQcmV2aW91c2x5LCB3ZSB3ZXJlbid0IGltcGxlbWVudGluZyB0aGlzIHJl cXVpcmVtZW50IGZyb20gdGhlIHNwZWM6CisKKyAgICAgICAgIlRoaXMgZmxhZyBhbHNvIHByZXZl bnRzIGNvbnRlbnQgZnJvbSBjcmVhdGluZyBuZXcgYXV4aWxpYXJ5IGJyb3dzaW5nCisgICAgICAg IGNvbnRleHRzLCBlLmcuIHVzaW5nIHRoZSB0YXJnZXQgYXR0cmlidXRlIG9yIHRoZSB3aW5kb3cu b3BlbigpIG1ldGhvZC4iCisKKyAgICAgICAgVGVzdHM6IGh0dHAvdGVzdHMvc2VjdXJpdHkvbm8t cG9wdXAtZnJvbS1zYW5kYm94LXRvcC5odG1sCisgICAgICAgICAgICAgICBodHRwL3Rlc3RzL3Nl Y3VyaXR5L25vLXBvcHVwLWZyb20tc2FuZGJveC5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvUG9s aWN5Q2hlY2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb2xpY3lDaGVja2VyOjpjaGVja05l d1dpbmRvd1BvbGljeSk6CisKIDIwMTEtMDUtMTMgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogU291 cmNlL1dlYkNvcmUvbG9hZGVyL1BvbGljeUNoZWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9Qb2xpY3lDaGVja2VyLmNwcAkocmV2aXNpb24gODY0NDcpCisrKyBT b3VyY2UvV2ViQ29yZS9sb2FkZXIvUG9saWN5Q2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM3LDYgKzM3LDcgQEAKICNpbmNsdWRlICJGcmFtZUxvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1l TG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAiSFRNTEZvcm1FbGVtZW50LmgiCisjaW5jbHVkZSAi U2VjdXJpdHlPcmlnaW4uaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC05Miw2ICs5Myw5 IEBAIHZvaWQgUG9saWN5Q2hlY2tlcjo6Y2hlY2tOYXZpZ2F0aW9uUG9saWMKIHZvaWQgUG9saWN5 Q2hlY2tlcjo6Y2hlY2tOZXdXaW5kb3dQb2xpY3koY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYgYWN0 aW9uLCBOZXdXaW5kb3dQb2xpY3lEZWNpc2lvbkZ1bmN0aW9uIGZ1bmN0aW9uLAogICAgIGNvbnN0 IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgUGFzc1JlZlB0cjxGb3JtU3RhdGU+IGZvcm1TdGF0 ZSwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUsIHZvaWQqIGFyZ3VtZW50KQogeworICAgIGlmICht X2ZyYW1lLT5kb2N1bWVudCgpICYmIG1fZnJhbWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2lu KCktPmlzU2FuZGJveGVkKFNhbmRib3hOYXZpZ2F0aW9uKSkKKyAgICAgICAgcmV0dXJuIGNvbnRp bnVlQWZ0ZXJOYXZpZ2F0aW9uUG9saWN5KFBvbGljeUlnbm9yZSk7CisKICAgICBtX2NhbGxiYWNr LnNldChyZXF1ZXN0LCBmb3JtU3RhdGUsIGZyYW1lTmFtZSwgYWN0aW9uLCBmdW5jdGlvbiwgYXJn dW1lbnQpOwogICAgIG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKS0+ZGlzcGF0Y2hEZWNpZGVQ b2xpY3lGb3JOZXdXaW5kb3dBY3Rpb24oJlBvbGljeUNoZWNrZXI6OmNvbnRpbnVlQWZ0ZXJOZXdX aW5kb3dQb2xpY3ksCiAgICAgICAgIGFjdGlvbiwgcmVxdWVzdCwgZm9ybVN0YXRlLCBmcmFtZU5h bWUpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODY0NTApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNS0xMyAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGlmcmFtZSBzYW5kYm94IGRvZXNuJ3QgcHJvcGVybHkgYmxvY2sgcG9wdXBz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDc4NAor CisgICAgICAgIFRlc3QgdGhhdCB3ZSBibG9jayBwb3B1cCB3aW5kb3dzIGZyb20gaW5zaWRlIHNh bmRib3guCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L25vLXBvcHVwLWZyb20tc2Fu ZGJveC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkv bm8tcG9wdXAtZnJvbS1zYW5kYm94LXRvcC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvdGVzdHMvc2VjdXJpdHkvbm8tcG9wdXAtZnJvbS1zYW5kYm94LXRvcC5odG1sOiBBZGRl ZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L25vLXBvcHVwLWZyb20tc2FuZGJveC5o dG1sOiBBZGRlZC4KKwogMjAxMS0wNS0xMyAgQW5kcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBTdXBwcmVzcyBjcmFzaGVyIGluIGNocm9taXVtLiBVbnJldmll d2VkLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9uby1wb3B1cC1mcm9t LXNhbmRib3gtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVz dHMvc2VjdXJpdHkvbm8tcG9wdXAtZnJvbS1zYW5kYm94LWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvbm8tcG9wdXAtZnJvbS1zYW5k Ym94LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitBTEVSVDogUEFT UworVG8gcnVuIHRoaXMgdGVzdCBvdXRzaWRlIG9mIER1bXBSZW5kZXJUcmVlLCBwbGVhc2UgZGlz YWJsZSB5b3VyIHBvcHVwIGJsb2NrZXIhCisKKwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9uby1wb3B1cC1mcm9tLXNhbmRib3gtdG9wLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L25vLXBvcHVwLWZyb20tc2Fu ZGJveC10b3AtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9zZWN1cml0eS9uby1wb3B1cC1mcm9tLXNhbmRib3gtdG9wLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitBTEVSVDogUEFTUworVG8gcnVuIHRoaXMgdGVzdCBv dXRzaWRlIG9mIER1bXBSZW5kZXJUcmVlLCBwbGVhc2UgZGlzYWJsZSB5b3VyIHBvcHVwIGJsb2Nr ZXIhCisKKwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9uby1wb3B1cC1m cm9tLXNhbmRib3gtdG9wLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9uby1wb3B1cC1mcm9tLXNhbmRib3gtdG9wLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L25vLXBvcHVwLWZyb20tc2FuZGJveC10 b3AuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNCBAQAorPHNjcmlwdD4KK2lmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1w QXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2FuT3BlbldpbmRvd3ModHJ1 ZSk7Cit9Cis8L3NjcmlwdD4KKzxwPlRvIHJ1biB0aGlzIHRlc3Qgb3V0c2lkZSBvZiBEdW1wUmVu ZGVyVHJlZSwgcGxlYXNlIGRpc2FibGUgeW91ciBwb3B1cCBibG9ja2VyITwvcD4KKzxpZnJhbWUg c2FuZGJveD0iYWxsb3ctc2NyaXB0cyIKKyAgc3JjPSJkYXRhOnRleHQvaHRtbCwKKyAgICAgICA8 c2NyaXB0PgorICAgICAgIHZhciB3aW4gPSB3aW5kb3cub3BlbignYWJvdXQ6YmxhbmsnLCAnX3Rv cCcpOworICAgICAgIGFsZXJ0KHdpbiA/ICdGQUlMJyA6ICdQQVNTJyk7CisgICAgICAgPC9zY3Jp cHQ+IgorICA+PC9pZnJhbWU+CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5 L25vLXBvcHVwLWZyb20tc2FuZGJveC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvc2VjdXJpdHkvbm8tcG9wdXAtZnJvbS1zYW5kYm94Lmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L25vLXBvcHVwLWZyb20tc2FuZGJv eC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACis8c2NyaXB0PgoraWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRDYW5PcGVuV2luZG93cyh0cnVl KTsKK30KKzwvc2NyaXB0PgorPHA+VG8gcnVuIHRoaXMgdGVzdCBvdXRzaWRlIG9mIER1bXBSZW5k ZXJUcmVlLCBwbGVhc2UgZGlzYWJsZSB5b3VyIHBvcHVwIGJsb2NrZXIhPC9wPgorPGlmcmFtZSBz YW5kYm94PSJhbGxvdy1zY3JpcHRzIgorICBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgIDxz Y3JpcHQ+CisgICAgICAgdmFyIHdpbiA9IHdpbmRvdy5vcGVuKCdhYm91dDpibGFuaycsICdfYmxh bmsnKTsKKyAgICAgICBhbGVydCh3aW4gPyAnRkFJTCcgOiAnUEFTUycpOworICAgICAgIDwvc2Ny aXB0PiIKKyAgPjwvaWZyYW1lPgo=