60775 2011-05-13 09:10:20 -0700 Source/WebCore/html/HTMLFrameElementBase.cpp contains unecessary includes 2011-05-15 04:40:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 a.renevier webkit-unassigned commit-queue dglazkov gustavo webkit.review.bot xan.lopez oldest_to_newest 403583 0 a.renevier 2011-05-13 09:10:20 -0700 Hi, in HTMLFrameElementBase.cpp, there are some includes wich seem to be not needed in that file (for example RenderEmbeddedObject.h or HTMLFrameSetElement.h) 403598 1 93465 a.renevier 2011-05-13 09:31:43 -0700 Created attachment 93465 patch v1 I checked included files, and removed those who looked unused. In order to build webkit, I had to include back SubFrameLoader.h and RenderPart.h. They were probably included by some of the removed includes 403605 2 93465 webkit-ews 2011-05-13 09:41:09 -0700 Comment on attachment 93465 patch v1 Attachment 93465 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8693220 403624 3 93465 webkit.review.bot 2011-05-13 10:05:22 -0700 Comment on attachment 93465 patch v1 Attachment 93465 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8695153 403639 4 93465 gustavo 2011-05-13 10:24:51 -0700 Comment on attachment 93465 patch v1 Attachment 93465 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8693230 403648 5 93477 a.renevier 2011-05-13 10:29:50 -0700 Created attachment 93477 patch v1.1 I probably need to let FrameLoader.h 404124 6 93477 commit-queue 2011-05-14 14:56:17 -0700 Comment on attachment 93477 patch v1.1 Rejecting attachment 93477 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2 Last 500 characters of output: .org/WebKit ff67c13..aa00ad0 master -> origin/master M Source/WebKit2/ChangeLog M Source/WebKit2/UIProcess/mac/TextCheckerMac.mm r86497 = 3e84409c598e09da7b74f2e08d0a2685f245c2f5 (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/bridge/qt/qt_runtime.cpp M Source/WebCore/bridge/qt/qt_runtime.h r86498 = aa00ad0c35bfe0bda94a6e7700e12142fcb99ae7 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded new_master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8698438 404130 7 93477 abarth 2011-05-14 15:28:38 -0700 Comment on attachment 93477 patch v1.1 View in context: https://bugs.webkit.org/attachment.cgi?id=93477&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This line is preventing the patch from landing. You should replace this line with a sentence about how you're not changing functionality. 404150 8 93576 a.renevier 2011-05-15 00:42:07 -0700 Created attachment 93576 patch v1.2 404154 9 93576 eric 2011-05-15 01:23:28 -0700 Comment on attachment 93576 patch v1.2 OK. 404157 10 93576 commit-queue 2011-05-15 04:40:10 -0700 Comment on attachment 93576 patch v1.2 Clearing flags on attachment: 93576 Committed r86503: <http://trac.webkit.org/changeset/86503> 404158 11 commit-queue 2011-05-15 04:40:16 -0700 All reviewed patches have been landed. Closing bug. 93465 2011-05-13 09:31:43 -0700 2011-05-13 10:29:43 -0700 patch v1 bug-60775-20110513183142.patch text/plain 1463 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogODYzMTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMDBkM2M2NjQyMzU4MDI4 M2MyYzAzMjFlZmEzYTcyYjA1ODlkMzQ5Li41NDE2NzU2NDcwOGRlZTkwMzJiODFiYjVkY2VhNTc2 ODJmZTBhZTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTMgIEFybm8g UmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICByZW1vdmUgdW5lY2Vzc2FyeSBpbmNsdWRlcyBmcm9tIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDc3NQorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5j cHA6CisKIDIwMTEtMDUtMTIgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCmluZGV4IDY5YmUyNmE1NDI0YTNlZDgwNmMxMmQ5ODc1 M2Q1NDgyMmU4ZWFkOTMuLjNjY2E4ZDI0Nzc4MjRiZmRmMzRkM2RiNDY2ZjQzZTMxZDczYzc4Mzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCkBAIC0y OSwxNiArMjksMTMgQEAKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCiAjaW5jbHVkZSAiRm9jdXND b250cm9sbGVyLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKLSNpbmNsdWRlICJGcmFtZUxvYWRlci5o IgotI2luY2x1ZGUgIkZyYW1lVHJlZS5oIgorI2luY2x1ZGUgIlN1YkZyYW1lTG9hZGVyLmgiCiAj aW5jbHVkZSAiRnJhbWVWaWV3LmgiCi0jaW5jbHVkZSAiSFRNTEZyYW1lU2V0RWxlbWVudC5oIgog I2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIKICNp bmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgotI2luY2x1ZGUgIlJlbmRlckVtYmVk ZGVkT2JqZWN0LmgiCi0jaW5jbHVkZSAiUmVuZGVyRnJhbWUuaCIKKyNpbmNsdWRlICJSZW5kZXJQ YXJ0LmgiCiAjaW5jbHVkZSAiU2NyaXB0Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIlNjcmlwdEV2 ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgo= 93477 2011-05-13 10:29:50 -0700 2011-05-15 00:35:57 -0700 patch v1.1 bug-60775-20110513192949.patch text/plain 1409 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogODYzMTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMDBkM2M2NjQyMzU4MDI4 M2MyYzAzMjFlZmEzYTcyYjA1ODlkMzQ5Li41NDE2NzU2NDcwOGRlZTkwMzJiODFiYjVkY2VhNTc2 ODJmZTBhZTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTMgIEFybm8g UmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICByZW1vdmUgdW5lY2Vzc2FyeSBpbmNsdWRlcyBmcm9tIFNv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDc3NQorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5j cHA6CisKIDIwMTEtMDUtMTIgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCmluZGV4IDY5YmUyNmE1NDI0YTNlZDgwNmMxMmQ5ODc1 M2Q1NDgyMmU4ZWFkOTMuLjk0MGNjMDgxYjc2ZDBlZjVhNzQwM2M5NjM2NmIyYmQyMjZlZWJhMGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCkBAIC0z MCwxNSArMzAsMTIgQEAKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJG cmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyLmgiCi0jaW5jbHVkZSAiRnJhbWVUcmVlLmgi CiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCi0jaW5jbHVkZSAiSFRNTEZyYW1lU2V0RWxlbWVudC5o IgogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIK ICNpbmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgotI2luY2x1ZGUgIlJlbmRlckVt YmVkZGVkT2JqZWN0LmgiCi0jaW5jbHVkZSAiUmVuZGVyRnJhbWUuaCIKKyNpbmNsdWRlICJSZW5k ZXJQYXJ0LmgiCiAjaW5jbHVkZSAiU2NyaXB0Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIlNjcmlw dEV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5oIgo= 93576 2011-05-15 00:42:07 -0700 2011-05-15 04:40:10 -0700 patch v1.2 bug-60775-20110515094205.patch text/plain 1453 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogODY1MDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1Mjc2ODk1YzI1NDdhYTZi Y2FiNDNmODlhMDY3NGE0M2Y2YTIyNDg3Li42MDk5MWU2MDU4YWU2NWRiMTZiYmI0Y2Q1OGU1NGIw OWYzZDkzOTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTUgIEFybm8g UmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KKworICAgICAgICByZW1vdmUgdW5lY2Vzc2FyeSBpbmNsdWRlcyBmcm9tIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDc3NQorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gVGhpcyBjaGFuZ2Ugb25seSBpbXBhY3RzIGNvbXBpbGF0aW9uLgorCisgICAgICAgICog aHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHA6CisKIDIwMTEtMDUtMTQgIE1hbGNvbG0gTWFj TGVvZCAgPG1hbGNvbG0ubWFjbGVvZEB0c2h3YW5lZGplLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZXZpbiBPbGxpdmllci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEZyYW1lRWxlbWVudEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVt ZW50QmFzZS5jcHAKaW5kZXggNjliZTI2YTU0MjRhM2VkODA2YzEyZDk4NzUzZDU0ODIyZThlYWQ5 My4uOTQwY2MwODFiNzZkMGVmNWE3NDAzYzk2MzY2YjJiZDIyNmVlYmEwYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKQEAgLTMwLDE1ICszMCwxMiBA QAogI2luY2x1ZGUgIkZvY3VzQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5j bHVkZSAiRnJhbWVMb2FkZXIuaCIKLSNpbmNsdWRlICJGcmFtZVRyZWUuaCIKICNpbmNsdWRlICJG cmFtZVZpZXcuaCIKLSNpbmNsdWRlICJIVE1MRnJhbWVTZXRFbGVtZW50LmgiCiAjaW5jbHVkZSAi SFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiSFRNTFBhcnNlcklkaW9tcy5oIgogI2luY2x1ZGUgIktV UkwuaCIKICNpbmNsdWRlICJQYWdlLmgiCi0jaW5jbHVkZSAiUmVuZGVyRW1iZWRkZWRPYmplY3Qu aCIKLSNpbmNsdWRlICJSZW5kZXJGcmFtZS5oIgorI2luY2x1ZGUgIlJlbmRlclBhcnQuaCIKICNp bmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0RXZlbnRMaXN0ZW5l ci5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCg==