60753 2011-05-13 00:24:26 -0700 [EFL] Move ewk_view_dpi_get() to ewk_util.cpp 2011-05-13 02:56:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim antognolli+webkit commit-queue kenneth lucas.de.marchi tonikitoo oldest_to_newest 403419 0 gyuyoung.kim 2011-05-13 00:24:26 -0700 I made a ewk_view_dpi_get() in order to get dpi value of device. However, I think it is better that this api is located on ewk_util.cpp. 403420 1 93412 gyuyoung.kim 2011-05-13 00:26:56 -0700 Created attachment 93412 Proposed Patch 403448 2 commit-queue 2011-05-13 02:55:28 -0700 The commit-queue encountered the following flaky tests while processing attachment 93412: http/tests/xmlhttprequest/remember-bad-password.html bug 51733 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 403450 3 93412 commit-queue 2011-05-13 02:56:28 -0700 Comment on attachment 93412 Proposed Patch Clearing flags on attachment: 93412 Committed r86421: <http://trac.webkit.org/changeset/86421> 403451 4 commit-queue 2011-05-13 02:56:33 -0700 All reviewed patches have been landed. Closing bug. 93412 2011-05-13 00:26:56 -0700 2011-05-13 02:56:28 -0700 Proposed Patch patch-dpi_get.patch text/plain 3189 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAzYjMxNTU4Li5jYWVkMjlhIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMTMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbRUZMXSBNb3ZlIGV3a192aWV3X2RwaV9nZXQoKSB0byBld2tfdXRpbC5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzUzCisKKyAgICAg ICAgTW92ZSBld2tfdmlld19kcGlfZ2V0KCkgdG8gZXdrX3V0aWwuY3BwCisKKyAgICAgICAgKiBl d2svZXdrX3ByaXZhdGUuaDoKKyAgICAgICAgKiBld2svZXdrX3V0aWwuY3BwOgorICAgICAgICAo ZXdrX3V0aWxfZHBpX2dldCk6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAg KF9ld2tfdmlld192aWV3cG9ydF9hdHRyaWJ1dGVzX2NvbXB1dGUpOgorCiAyMDExLTA1LTExICBH eXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXgg YzNkZTk4YS4uMTFmMGQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19w cml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTEx MSw3ICsxMTEsNyBAQCB2b2lkIGV3a192aWV3X3ZpZXdwb3J0X2F0dHJpYnV0ZXNfc2V0KEV2YXNf T2JqZWN0ICpvLCBjb25zdCBXZWJDb3JlOjpWaWV3cG9ydEFyZwogCiB2b2lkIGV3a192aWV3X2Rv d25sb2FkX3JlcXVlc3QoRXZhc19PYmplY3QgKm8sIEV3a19Eb3dubG9hZCAqZG93bmxvYWQpOwog Ci1pbnQgZXdrX3ZpZXdfZHBpX2dldCh2b2lkKTsKK2ludCBld2tfdXRpbF9kcGlfZ2V0KHZvaWQp OwogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKIHZvaWQgZXdrX3ZpZXdfbmVlZF90b3VjaF9l dmVudHNfc2V0KEV2YXNfT2JqZWN0KiwgYm9vbCBuZWVkZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a191dGlsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dXRpbC5jcHAKaW5kZXggYjAxYmU3Mi4uYmJlYzE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9lZmwvZXdrL2V3a191dGlsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3V0 aWwuY3BwCkBAIC0yNCw2ICsyNCwxMCBAQAogI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5j bHVkZSA8ZWluYV9zYWZldHlfY2hlY2tzLmg+CiAKKyNpZmRlZiBIQVZFX0VDT1JFX1gKKyNpbmNs dWRlIDxFY29yZV9YLmg+CisjZW5kaWYKKwogLyoqCiAgKiBDb252ZXJ0cyBhbiBpbWFnZSBmcm9t IGNhaXJvX3N1cmZhY2UgdG8gdGhlIEV2YXNfT2JqZWN0LgogICoKQEAgLTEwMywzICsxMDcsMTkg QEAgRXZhc19PYmplY3QqIGV3a191dGlsX2ltYWdlX2Zyb21fY2Fpcm9fc3VyZmFjZV9hZGQoRXZh cyogY2FudmFzLCBjYWlyb19zdXJmYWNlX3QKIAogICAgIHJldHVybiBpbWFnZTsKIH0KKworLyoq CisgKiBAaW50ZXJuYWwKKyAqIEdldHMgZHBpIHZhbHVlLgorICoKKyAqIEByZXR1cm4gZGV2aWNl J3MgZHBpIHZhbHVlLgorICovCitpbnQgZXdrX3V0aWxfZHBpX2dldCh2b2lkKQoreworI2lmZGVm IEhBVkVfRUNPUkVfWAorICAgICByZXR1cm4gZWNvcmVfeF9kcGlfZ2V0KCk7CisjZWxzZQorICAg ICByZXR1cm4gMTYwOworI2VuZGlmCit9CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmlu ZGV4IDZhNDI3ZGYuLmI5YWUzNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAt NTIsMTAgKzUyLDYgQEAKICNpbmNsdWRlIDxpbnR0eXBlcy5oPgogI2luY2x1ZGUgPHN5cy90aW1l Lmg+CiAKLSNpZmRlZiBIQVZFX0VDT1JFX1gKLSNpbmNsdWRlIDxFY29yZV9YLmg+Ci0jZW5kaWYK LQogI2RlZmluZSBaT09NX01JTiAoMC4wNSkKICNkZWZpbmUgWk9PTV9NQVggKDQuMCkKIApAQCAt MTAxNCw3ICsxMDEwLDcgQEAgc3RhdGljIFdlYkNvcmU6OlZpZXdwb3J0QXR0cmlidXRlcyBfZXdr X3ZpZXdfdmlld3BvcnRfYXR0cmlidXRlc19jb21wdXRlKEV2YXNfT2IKICAgICBFV0tfVklFV19Q UklWX0dFVChzZCwgcHJpdik7CiAKICAgICBpbnQgZGVza3RvcF93aWR0aCA9IDk4MDsKLSAgICBp bnQgZGV2aWNlX2RwaSA9IGV3a192aWV3X2RwaV9nZXQoKTsKKyAgICBpbnQgZGV2aWNlX2RwaSA9 IGV3a191dGlsX2RwaV9nZXQoKTsKIAogICAgIGludCBhdmFpbGFibGVfd2lkdGggPSAoaW50KSBw cml2LT5wYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPnBhZ2VSZWN0KCkud2lkdGgoKTsKICAgICBp bnQgYXZhaWxhYmxlX2hlaWdodCA9IChpbnQpIHByaXYtPnBhZ2UtPmNocm9tZSgpLT5jbGllbnQo KS0+cGFnZVJlY3QoKS5oZWlnaHQoKTsKQEAgLTQ0NDUsMjEgKzQ0NDEsNiBAQCBXZWJDb3JlOjpG bG9hdFJlY3QgZXdrX3ZpZXdfcGFnZV9yZWN0X2dldChFdmFzX09iamVjdCAqbykKICAgICByZXR1 cm4gbWFpbl9mcmFtZS0+dmlldygpLT5mcmFtZVJlY3QoKTsKIH0gCiAKLS8qKgotICogQGludGVy bmFsCi0gKiBHZXRzIGRwaSB2YWx1ZS4KLSAqCi0gKiBAcmV0dXJuIGRldmljZSdzIGRwaSB2YWx1 ZS4KLSAqLwotaW50IGV3a192aWV3X2RwaV9nZXQodm9pZCkKLXsKLSNpZmRlZiBIQVZFX0VDT1JF X1gKLSAgICAgcmV0dXJuIGVjb3JlX3hfZHBpX2dldCgpOwotI2Vsc2UKLSAgICAgcmV0dXJuIDE2 MDsKLSNlbmRpZgotfQotCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKIHZvaWQgZXdrX3ZpZXdf bmVlZF90b3VjaF9ldmVudHNfc2V0KEV2YXNfT2JqZWN0KiBvLCBib29sIG5lZWRlZCkKIHsK