60740 2011-05-12 17:34:00 -0700 [Qt] GraphicsContext3DQt.cpp fails to compile 2011-05-13 05:09:16 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 0 rectalogic webkit-unassigned benjamin commit-queue oldest_to_newest 403280 0 rectalogic 2011-05-12 17:34:00 -0700 GraphicsContext3DQt.cpp is failing to compile, patch coming: ../../../Source/WebCore/platform/graphics/GraphicsContext3D.h: In constructor ' WebCore::GraphicsContext3D::GraphicsContext3D(WebCore::GraphicsContext3D::Attributes, WebCore::HostWindow*, bool)': ../../../Source/WebCore/platform/graphics/GraphicsContext3D.h:935: error: 'WebCore::GraphicsContext3D::m_internal' will be initialized after ../../../Source/WebCore/platform/graphics/GraphicsContext3D.h:889: error: 'bool WebCore::GraphicsContext3D::m_isResourceSafe' ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:688: error : when initialized heremake[1]: *** [obj/debug/GraphicsContext3DQt.o] Error 1 403281 1 93375 rectalogic 2011-05-12 17:37:50 -0700 Created attachment 93375 fix compilation 403482 2 93375 commit-queue 2011-05-13 05:09:11 -0700 Comment on attachment 93375 fix compilation Clearing flags on attachment: 93375 Committed r86424: <http://trac.webkit.org/changeset/86424> 403483 3 commit-queue 2011-05-13 05:09:16 -0700 All reviewed patches have been landed. Closing bug. 93375 2011-05-12 17:37:50 -0700 2011-05-13 05:09:11 -0700 fix compilation qtgraphics.patch text/plain 1443 rectalogic SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2NDA1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMTIgIEFuZHJldyBX YXNvbiAgPHJlY3RhbG9naWNAcmVjdGFsb2dpYy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAgZmFpbHMg dG8gY29tcGlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjA3NDAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNz Q29udGV4dDNEKToKKyAgICAgICAgIENoYW5nZSBvcmRlciBvZiBpbml0aWFsaXplcnMuCisKIDIw MTEtMDUtMTIgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIEF0dGVt cHQgdG8gZml4IHRoZSBidWlsZCBhZnRlciBjaGFuZ2VzZXQgODYzOTEgPGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0Lzg2MzkxPgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAJKHJl dmlzaW9uIDg2Mzk4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NDb250ZXh0M0RRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4Niw3ICs2ODYsNyBAQCBQ YXNzUmVmUHRyPEdyYXBoaWNzQ29udGV4dDNEPiBHcmFwaGljc0NvCiB9CiAKIEdyYXBoaWNzQ29u dGV4dDNEOjpHcmFwaGljc0NvbnRleHQzRChHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBh dHRycywgSG9zdFdpbmRvdyogaG9zdFdpbmRvdywgYm9vbCkKLSAgICA6IG1faW50ZXJuYWwoYWRv cHRQdHIobmV3IEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWwoYXR0cnMsIGhvc3RXaW5kb3cpKSks IG1faXNSZXNvdXJjZVNhZmUoZmFsc2UpCisgICAgOiBtX2lzUmVzb3VyY2VTYWZlKGZhbHNlKSwg bV9pbnRlcm5hbChhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbChhdHRycywg aG9zdFdpbmRvdykpKQogewogICAgIGlmICghbV9pbnRlcm5hbC0+aXNWYWxpZCgpKQogICAgICAg ICBtX2ludGVybmFsID0gMDsK