60735 2011-05-12 16:05:52 -0700 Crash when a plug-in tries to load a resource from the application cache 2011-06-15 06:11:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca danilo yong.li.webkit oldest_to_newest 403224 0 andersca 2011-05-12 16:05:52 -0700 Crash when a plug-in tries to load a resource from the application cache 403240 1 93364 andersca 2011-05-12 16:40:36 -0700 Created attachment 93364 Patch 403243 2 93364 mitz 2011-05-12 16:44:28 -0700 Comment on attachment 93364 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93364&action=review > Source/WebCore/ChangeLog:11 > + This lead to the plug-in stream loader canceling the load, something which the application typo: lead > Source/WebCore/loader/DocumentLoader.cpp:601 > + > + // Calling ResourceLoader::didReceiveResponse can end up cancelling the load, > + // so we need to check if the loader has reached its terminal state. > + if (loader->reachedTerminalState()) > + return; > + > + // Calling ResourceLoader::didReceiveData can end up cancelling the load, > + // so we need to check if the loader has reached its terminal state. > loader->didReceiveData(data->data(), data->size(), data->size(), true); > + if (loader->reachedTerminalState()) The inconsistent way you order the comments is weird and inconsistent. 403244 3 andersca 2011-05-12 16:45:41 -0700 Committed r86397: <http://trac.webkit.org/changeset/86397> 418138 4 yong.li.webkit 2011-06-09 11:37:13 -0700 Can we assume the http status code is always 200 when resource is loaded from app cache? A status code other than 200 may cause unexpected problems 93364 2011-05-12 16:40:36 -0700 2011-05-12 16:44:28 -0700 Patch bug-60735-20110512164034.patch text/plain 5564 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2Mzk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDUtMTIgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCB3aGVuIGEgcGx1Zy1pbiB0cmllcyB0byBsb2Fk IGEgcmVzb3VyY2UgZnJvbSB0aGUgYXBwbGljYXRpb24gY2FjaGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzM1CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS84MjE2MTQyPgorCisgICAgICAgIFdoZW4gbG9hZGluZyBhcHBsaWNhdGlvbiBjYWNoZSBy ZXNvdXJjZXMgZnJvbSBkaXNrLCB3ZSB3b3VsZCBuZXZlciByZXN0b3JlIHRoZQorICAgICAgICBI VFRQIHN0YXR1cyBjb2RlLCB3aGljaCBtZWFucyB0aGF0IHJlc291cmNlcyB3b3VsZCBhbHdheXMg aGF2ZSBhIDAgc3RhdHVzIGNvZGUuCisgICAgICAgIFRoaXMgbGVhZCB0byB0aGUgcGx1Zy1pbiBz dHJlYW0gbG9hZGVyIGNhbmNlbGluZyB0aGUgbG9hZCwgc29tZXRoaW5nIHdoaWNoIHRoZSBhcHBs aWNhdGlvbgorICAgICAgICBjYWNoZSBsb2FkaW5nIG1hY2hpbmVyeSBjb3VsZG4ndCBkZWFsIGFu ZCB0aHVzIHdvdWxkIGNyYXNoLgorCisgICAgICAgIEZpeCBib3RoIHRoZSByZWFkaW5nIG9mIHRo ZSBIVFRQIHN0YXR1cyBjb2RlLCBhbmQgbWFrZSB0aGUgbG9hZGVyIG1vcmUgcm9idXN0IGFnYWlu c3QKKyAgICAgICAgYXBwbGljYXRpb24gY2FjaGUgbG9hZHMgYmVpbmcgY2FuY2VsZWQuCisKKyAg ICAgICAgVW5mb3J0dW5hdGVseSwgSSBjb3VsZG4ndCBjb21lIHVwIHdpdGggYSB0ZXN0IGZvciB0 aGlzIGJlY2F1c2UgSSBjb3VsZG4ndCBmaW5kIGEgcmVsaWFibGUgd2F5CisgICAgICAgIHRvIGZv cmNlIHRoZSBhcHBsaWNhdGlvbiBjYWNoZSB0byBiZSByZWFkIGZyb20gZGlzaywgc28gYWxsIHJl c291cmNlcyB3b3VsZCBoYXZlIHZhbGlkIHZhbHVlcy4KKworICAgICAgICAqIGxvYWRlci9Eb2N1 bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c3Vic3Rp dHV0ZVJlc291cmNlRGVsaXZlcnlUaW1lckZpcmVkKToKKyAgICAgICAgKiBsb2FkZXIvYXBwY2Fj aGUvQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbGlj YXRpb25DYWNoZVN0b3JhZ2U6OmxvYWRDYWNoZSk6CisKIDIwMTEtMDUtMTIgIEVtaWwgQSBFa2x1 bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCShyZXZpc2lv biA4NjM0NCkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU4OSw3ICs1ODksMTggQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6c3Vi c3RpdHV0ZVJlc291cmNlRAogICAgICAgICAgICAgU2hhcmVkQnVmZmVyKiBkYXRhID0gcmVzb3Vy Y2UtPmRhdGEoKTsKICAgICAgICAgCiAgICAgICAgICAgICBsb2FkZXItPmRpZFJlY2VpdmVSZXNw b25zZShyZXNvdXJjZS0+cmVzcG9uc2UoKSk7CisKKyAgICAgICAgICAgIC8vIENhbGxpbmcgUmVz b3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSBjYW4gZW5kIHVwIGNhbmNlbGxpbmcgdGhl IGxvYWQsCisgICAgICAgICAgICAvLyBzbyB3ZSBuZWVkIHRvIGNoZWNrIGlmIHRoZSBsb2FkZXIg aGFzIHJlYWNoZWQgaXRzIHRlcm1pbmFsIHN0YXRlLgorICAgICAgICAgICAgaWYgKGxvYWRlci0+ cmVhY2hlZFRlcm1pbmFsU3RhdGUoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAg ICAgICAgIC8vIENhbGxpbmcgUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhIGNhbiBlbmQg dXAgY2FuY2VsbGluZyB0aGUgbG9hZCwKKyAgICAgICAgICAgIC8vIHNvIHdlIG5lZWQgdG8gY2hl Y2sgaWYgdGhlIGxvYWRlciBoYXMgcmVhY2hlZCBpdHMgdGVybWluYWwgc3RhdGUuCiAgICAgICAg ICAgICBsb2FkZXItPmRpZFJlY2VpdmVEYXRhKGRhdGEtPmRhdGEoKSwgZGF0YS0+c2l6ZSgpLCBk YXRhLT5zaXplKCksIHRydWUpOworICAgICAgICAgICAgaWYgKGxvYWRlci0+cmVhY2hlZFRlcm1p bmFsU3RhdGUoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgICAgIGxvYWRl ci0+ZGlkRmluaXNoTG9hZGluZygwKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIC8v IEEgbnVsbCByZXNvdXJjZSBtZWFucyB0aGF0IHdlIHNob3VsZCBmYWlsIHRoZSBsb2FkLgpJbmRl eDogU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGlj YXRpb25DYWNoZVN0b3JhZ2UuY3BwCShyZXZpc2lvbiA4NjM0NCkKKysrIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlU3RvcmFnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTEwNTUsNyArMTA1NSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwYXJzZUhlYWRlcnMo Y29uc3QgU3QKIFBhc3NSZWZQdHI8QXBwbGljYXRpb25DYWNoZT4gQXBwbGljYXRpb25DYWNoZVN0 b3JhZ2U6OmxvYWRDYWNoZSh1bnNpZ25lZCBzdG9yYWdlSUQpCiB7CiAgICAgU1FMaXRlU3RhdGVt ZW50IGNhY2hlU3RhdGVtZW50KG1fZGF0YWJhc2UsIAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiU0VMRUNUIHVybCwgdHlwZSwgbWltZVR5cGUsIHRleHRFbmNvZGluZ05hbWUs IGhlYWRlcnMsIENhY2hlUmVzb3VyY2VEYXRhLmRhdGEsIENhY2hlUmVzb3VyY2VEYXRhLnBhdGgg RlJPTSBDYWNoZUVudHJpZXMgSU5ORVIgSk9JTiBDYWNoZVJlc291cmNlcyBPTiBDYWNoZUVudHJp ZXMucmVzb3VyY2U9Q2FjaGVSZXNvdXJjZXMuaWQgIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiU0VMRUNUIHVybCwgc3RhdHVzQ29kZSwgdHlwZSwgbWltZVR5cGUsIHRleHRF bmNvZGluZ05hbWUsIGhlYWRlcnMsIENhY2hlUmVzb3VyY2VEYXRhLmRhdGEsIENhY2hlUmVzb3Vy Y2VEYXRhLnBhdGggRlJPTSBDYWNoZUVudHJpZXMgSU5ORVIgSk9JTiBDYWNoZVJlc291cmNlcyBP TiBDYWNoZUVudHJpZXMucmVzb3VyY2U9Q2FjaGVSZXNvdXJjZXMuaWQgIgogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiSU5ORVIgSk9JTiBDYWNoZVJlc291cmNlRGF0YSBPTiBD YWNoZVJlc291cmNlRGF0YS5pZD1DYWNoZVJlc291cmNlcy5kYXRhIFdIRVJFIENhY2hlRW50cmll cy5jYWNoZT0/Iik7CiAgICAgaWYgKGNhY2hlU3RhdGVtZW50LnByZXBhcmUoKSAhPSBTUUxSZXN1 bHRPaykgewogICAgICAgICBMT0dfRVJST1IoIkNvdWxkIG5vdCBwcmVwYXJlIGNhY2hlIHN0YXRl bWVudCwgZXJyb3IgXCIlc1wiIiwgbV9kYXRhYmFzZS5sYXN0RXJyb3JNc2coKSk7CkBAIC0xMDcy LDE0ICsxMDcyLDE2IEBAIFBhc3NSZWZQdHI8QXBwbGljYXRpb25DYWNoZT4gQXBwbGljYXRpb24K ICAgICB3aGlsZSAoKHJlc3VsdCA9IGNhY2hlU3RhdGVtZW50LnN0ZXAoKSkgPT0gU1FMUmVzdWx0 Um93KSB7CiAgICAgICAgIEtVUkwgdXJsKFBhcnNlZFVSTFN0cmluZywgY2FjaGVTdGF0ZW1lbnQu Z2V0Q29sdW1uVGV4dCgwKSk7CiAgICAgICAgIAotICAgICAgICB1bnNpZ25lZCB0eXBlID0gc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KGNhY2hlU3RhdGVtZW50LmdldENvbHVtbkludDY0KDEpKTsKKyAg ICAgICAgaW50IGh0dHBTdGF0dXNDb2RlID0gY2FjaGVTdGF0ZW1lbnQuZ2V0Q29sdW1uSW50KDEp OworCisgICAgICAgIHVuc2lnbmVkIHR5cGUgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oY2FjaGVT dGF0ZW1lbnQuZ2V0Q29sdW1uSW50NjQoMikpOwogCiAgICAgICAgIFZlY3RvcjxjaGFyPiBibG9i OwotICAgICAgICBjYWNoZVN0YXRlbWVudC5nZXRDb2x1bW5CbG9iQXNWZWN0b3IoNSwgYmxvYik7 CisgICAgICAgIGNhY2hlU3RhdGVtZW50LmdldENvbHVtbkJsb2JBc1ZlY3Rvcig2LCBibG9iKTsK ICAgICAgICAgCiAgICAgICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGRhdGEgPSBTaGFyZWRCdWZm ZXI6OmFkb3B0VmVjdG9yKGJsb2IpOwogICAgICAgICAKLSAgICAgICAgU3RyaW5nIHBhdGggPSBj YWNoZVN0YXRlbWVudC5nZXRDb2x1bW5UZXh0KDYpOworICAgICAgICBTdHJpbmcgcGF0aCA9IGNh Y2hlU3RhdGVtZW50LmdldENvbHVtblRleHQoNyk7CiAgICAgICAgIGxvbmcgbG9uZyBzaXplID0g MDsKICAgICAgICAgaWYgKHBhdGguaXNFbXB0eSgpKQogICAgICAgICAgICAgc2l6ZSA9IGRhdGEt PnNpemUoKTsKQEAgLTEwODgsMTIgKzEwOTAsMTMgQEAgUGFzc1JlZlB0cjxBcHBsaWNhdGlvbkNh Y2hlPiBBcHBsaWNhdGlvbgogICAgICAgICAgICAgZ2V0RmlsZVNpemUocGF0aCwgc2l6ZSk7CiAg ICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIFN0cmluZyBtaW1lVHlwZSA9IGNhY2hlU3RhdGVt ZW50LmdldENvbHVtblRleHQoMik7Ci0gICAgICAgIFN0cmluZyB0ZXh0RW5jb2RpbmdOYW1lID0g Y2FjaGVTdGF0ZW1lbnQuZ2V0Q29sdW1uVGV4dCgzKTsKKyAgICAgICAgU3RyaW5nIG1pbWVUeXBl ID0gY2FjaGVTdGF0ZW1lbnQuZ2V0Q29sdW1uVGV4dCgzKTsKKyAgICAgICAgU3RyaW5nIHRleHRF bmNvZGluZ05hbWUgPSBjYWNoZVN0YXRlbWVudC5nZXRDb2x1bW5UZXh0KDQpOwogICAgICAgICAK ICAgICAgICAgUmVzb3VyY2VSZXNwb25zZSByZXNwb25zZSh1cmwsIG1pbWVUeXBlLCBzaXplLCB0 ZXh0RW5jb2RpbmdOYW1lLCAiIik7CisgICAgICAgIHJlc3BvbnNlLnNldEhUVFBTdGF0dXNDb2Rl KGh0dHBTdGF0dXNDb2RlKTsKIAotICAgICAgICBTdHJpbmcgaGVhZGVycyA9IGNhY2hlU3RhdGVt ZW50LmdldENvbHVtblRleHQoNCk7CisgICAgICAgIFN0cmluZyBoZWFkZXJzID0gY2FjaGVTdGF0 ZW1lbnQuZ2V0Q29sdW1uVGV4dCg1KTsKICAgICAgICAgcGFyc2VIZWFkZXJzKGhlYWRlcnMsIHJl c3BvbnNlKTsKICAgICAgICAgCiAgICAgICAgIFJlZlB0cjxBcHBsaWNhdGlvbkNhY2hlUmVzb3Vy Y2U+IHJlc291cmNlID0gQXBwbGljYXRpb25DYWNoZVJlc291cmNlOjpjcmVhdGUodXJsLCByZXNw b25zZSwgdHlwZSwgZGF0YS5yZWxlYXNlKCksIHBhdGgpOwo=